Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6386)

Unified Diff: chrome/browser/ui/views/ash/balloon_view_ash.cc

Issue 10765021: Make the id used in IconMsg_DownloadFavicon unique (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/ash/balloon_view_ash.cc
diff --git a/chrome/browser/ui/views/ash/balloon_view_ash.cc b/chrome/browser/ui/views/ash/balloon_view_ash.cc
index 3b8b4be96513113625445b1b05bb7473a1050277..0975e9c5519306f5eeea28693ed80646ce53e3db 100644
--- a/chrome/browser/ui/views/ash/balloon_view_ash.cc
+++ b/chrome/browser/ui/views/ash/balloon_view_ash.cc
@@ -8,6 +8,7 @@
#include "ash/system/status_area_widget.h"
#include "ash/system/web_notification/web_notification_tray.h"
#include "base/logging.h"
+#include "chrome/browser/favicon/favicon_util.h"
#include "chrome/browser/extensions/extension_service.h"
#include "chrome/browser/notifications/balloon_collection.h"
#include "chrome/browser/notifications/notification.h"
@@ -46,10 +47,9 @@ class BalloonViewAsh::IconFetcher : public content::WebContentsObserver {
icon_url_(icon_url) {
Observe(web_contents);
content::RenderViewHost* host = web_contents->GetRenderViewHost();
- host->Send(new IconMsg_DownloadFavicon(host->GetRoutingID(),
- ++request_id_,
- icon_url,
- kNotificationIconImageSize));
+ request_id_ = FaviconUtil::DownloadFavicon(host,
+ icon_url,
+ kNotificationIconImageSize);
}
// content::WebContentsObserver override.

Powered by Google App Engine
This is Rietveld 408576698