Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(773)

Unified Diff: chrome/browser/ui/views/ash/launcher/launcher_favicon_loader.cc

Issue 10765021: Make the id used in IconMsg_DownloadFavicon unique (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/views/ash/balloon_view_ash.cc ('k') | chrome/chrome_browser.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/views/ash/launcher/launcher_favicon_loader.cc
diff --git a/chrome/browser/ui/views/ash/launcher/launcher_favicon_loader.cc b/chrome/browser/ui/views/ash/launcher/launcher_favicon_loader.cc
index f15884e3dc940cc53e87facc6265134394ff4cc9..33a08df67b54f38f6813e8be753650c4cbc6e8d4 100644
--- a/chrome/browser/ui/views/ash/launcher/launcher_favicon_loader.cc
+++ b/chrome/browser/ui/views/ash/launcher/launcher_favicon_loader.cc
@@ -5,6 +5,7 @@
#include "chrome/browser/ui/views/ash/launcher/launcher_favicon_loader.h"
#include "base/logging.h"
+#include "chrome/browser/favicon/favicon_util.h"
#include "chrome/browser/ui/views/ash/launcher/browser_launcher_item_controller.h"
#include "chrome/common/favicon_url.h"
#include "chrome/common/icon_messages.h"
@@ -106,12 +107,9 @@ void FaviconBitmapHandler::OnUpdateFaviconURL(
void FaviconBitmapHandler::DownloadFavicon(const GURL& image_url) {
int image_size = 0; // Request the full sized image.
- static int next_id = 1;
- int id = next_id++;
pending_requests_.insert(image_url);
content::RenderViewHost* host = web_contents_->GetRenderViewHost();
- host->Send(new IconMsg_DownloadFavicon(
- host->GetRoutingID(), id, image_url, image_size));
+ FaviconUtil::DownloadFavicon(host, image_url, image_size);
}
void FaviconBitmapHandler::OnDidDownloadFavicon(int id,
« no previous file with comments | « chrome/browser/ui/views/ash/balloon_view_ash.cc ('k') | chrome/chrome_browser.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698