Stub out not yet implemented controller methods, so we don't have to wait for timeouts but fail imm…

Stub out not yet implemented controller methods, so we don't have to wait for timeouts but fail immediately

BUG=111316
TEST="webkit/tools/layout_tests/run_webkit_tests.py --debug --driver-name=content_shell --additional-drt-flag=--dump-render-tree --no-retry-failures svg/dynamic-updates/SVGAElement-dom-href-attr.html" fails within milliseconds instead of 30s


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=145782

[jochen (gone - plz use gerrit), 2012-07-09 15:08:56]

plz review

Andreas, fyi

[rossberg, 2012-07-09 15:54:29]

FYI.

https://chromiumcodereview.appspot.com/10740002/diff/1/content/shell/layout_t...
File content/shell/layout_test_controller.js (right):

https://chromiumcodereview.appspot.com/10740002/diff/1/content/shell/layout_t...
content/shell/layout_test_controller.js:34: Object.defineProperty(obj, name, {
get: function() { return callback; },
Tip:  {value: callback}  should be good enough here - you don't need a getter,
and configurable is false by default.

[jam, 2012-07-09 16:39:47]

lgtm

http://codereview.chromium.org/10740002/diff/1/content/shell/layout_test_cont...
File content/shell/layout_test_controller_bindings.cc (right):

http://codereview.chromium.org/10740002/diff/1/content/shell/layout_test_cont...
content/shell/layout_test_controller_bindings.cc:111: view->GetRoutingID(),
nit: 4 space indenting

http://codereview.chromium.org/10740002/diff/1/content/shell/shell_messages.h
File content/shell/shell_messages.h (right):

http://codereview.chromium.org/10740002/diff/1/content/shell/shell_messages.h...
content/shell/shell_messages.h:49: std::string /* object name */,
nit object_name, and property_name

[jochen (gone - plz use gerrit), 2012-07-09 19:25:51]

https://chromiumcodereview.appspot.com/10740002/diff/1/content/shell/layout_t...
File content/shell/layout_test_controller.js (right):

https://chromiumcodereview.appspot.com/10740002/diff/1/content/shell/layout_t...
content/shell/layout_test_controller.js:34: Object.defineProperty(obj, name, {
get: function() { return callback; },
On 2012/07/09 15:54:29, rossberg wrote:
> Tip:  {value: callback}  should be good enough here - you don't need a getter,
> and configurable is false by default.

Done.

https://chromiumcodereview.appspot.com/10740002/diff/1/content/shell/layout_t...
File content/shell/layout_test_controller_bindings.cc (right):

https://chromiumcodereview.appspot.com/10740002/diff/1/content/shell/layout_t...
content/shell/layout_test_controller_bindings.cc:111: view->GetRoutingID(),
On 2012/07/09 16:39:47, John Abd-El-Malek wrote:
> nit: 4 space indenting

Done.

https://chromiumcodereview.appspot.com/10740002/diff/1/content/shell/shell_me...
File content/shell/shell_messages.h (right):

https://chromiumcodereview.appspot.com/10740002/diff/1/content/shell/shell_me...
content/shell/shell_messages.h:49: std::string /* object name */,
On 2012/07/09 16:39:47, John Abd-El-Malek wrote:
> nit object_name, and property_name

Done.

[commit-bot: I haz the power, 2012-07-09 19:26:04]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jochen@chromium.org/10740002/7002

[commit-bot: I haz the power, 2012-07-09 19:52:01]

Try job failure for 10740002-7002 (retry) on android for steps "compile, build"
(clobber build).
It's a second try, previously, steps "compile, build" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android&nu...

[commit-bot: I haz the power, 2012-07-09 21:46:00]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jochen@chromium.org/10740002/14001

[commit-bot: I haz the power, 2012-07-09 23:26:28]

Change committed as 145782