Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2031)

Unified Diff: content/shell/layout_test_controller_host.cc

Issue 10740002: Stub out not yet implemented controller methods, so we don't have to wait for timeouts but fail imm… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: patch for landing Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/shell/layout_test_controller_host.h ('k') | content/shell/shell_messages.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/shell/layout_test_controller_host.cc
diff --git a/content/shell/layout_test_controller_host.cc b/content/shell/layout_test_controller_host.cc
index b1b8563c12dbf9640c33a0211e2431e555ff4cc4..eeb6063c1bd6dd24ee366c78daf9746213f90201 100644
--- a/content/shell/layout_test_controller_host.cc
+++ b/content/shell/layout_test_controller_host.cc
@@ -91,6 +91,7 @@ bool LayoutTestControllerHost::OnMessageReceived(
ShellViewHostMsg_SetShouldStayOnPageAfterHandlingBeforeUnload,
OnSetShouldStayOnPageAfterHandlingBeforeUnload)
IPC_MESSAGE_HANDLER(ShellViewHostMsg_WaitUntilDone, OnWaitUntilDone)
+ IPC_MESSAGE_HANDLER(ShellViewHostMsg_NotImplemented, OnNotImplemented)
IPC_MESSAGE_UNHANDLED(handled = false)
IPC_END_MESSAGE_MAP()
@@ -192,4 +193,17 @@ void LayoutTestControllerHost::OnWaitUntilDone() {
wait_until_done_ = true;
}
+void LayoutTestControllerHost::OnNotImplemented(
+ const std::string& object_name,
+ const std::string& property_name) {
+ if (captured_dump_)
+ return;
+ printf("FAIL: NOT IMPLEMENTED: %s.%s\n",
+ object_name.c_str(), property_name.c_str());
+ fprintf(stderr, "FAIL: NOT IMPLEMENTED: %s.%s\n",
+ object_name.c_str(), property_name.c_str());
+ watchdog_.Cancel();
+ CaptureDump();
+}
+
} // namespace content
« no previous file with comments | « content/shell/layout_test_controller_host.h ('k') | content/shell/shell_messages.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698