Issue 10735024: Output the correct line number in the error message for compilation failures during bootstrapping

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10735024: Output the correct line number in the error message for compilation failures during bootstrapping (Closed)

Created:
8 years, 5 months ago by jochen (gone - plz use gerrit)

Modified:
8 years, 5 months ago

Reviewers:
Michael Starzinger, rossberg

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Output the correct line number in the error message for compilation failures during bootstrapping BUG=none TEST=none Committed: https://code.google.com/p/v8/source/detail?r=12026

Patch Set 1 #

Total comments: 1

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	src/handles.h	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	src/isolate.cc	View		1 chunk	+1 line, -1 line	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Michael Starzinger

8 years, 5 months ago (2012-07-10 10:57:48 UTC) #3

LGTM (with one nit). I'll address the nit while landing.

https://chromiumcodereview.appspot.com/10735024/diff/1/src/isolate.cc
File src/isolate.cc (right):

https://chromiumcodereview.appspot.com/10735024/diff/1/src/isolate.cc#newcode...
src/isolate.cc:1133: location->start_pos()) + 1;
For consistency I would prefer to have the "+1" in the printing because all our
"line_number" local variables are zero based.

Expand Messages | Collapse Messages