Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(462)

Unified Diff: src/isolate.cc

Issue 10735024: Output the correct line number in the error message for compilation failures during bootstrapping (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/handles.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/isolate.cc
diff --git a/src/isolate.cc b/src/isolate.cc
index 30c60b691e8bade00baf2643b329707ef1936796..dea6be4d3f917d4975585491c0c5cac0b82535ea 100644
--- a/src/isolate.cc
+++ b/src/isolate.cc
@@ -1130,7 +1130,7 @@ void Isolate::DoThrow(Object* exception, MessageLocation* location) {
// somewhere) and we print out the line number at which the error occured
// to the console for easier debugging.
int line_number = GetScriptLineNumberSafe(location->script(),
- location->start_pos());
+ location->start_pos()) + 1;
Michael Starzinger 2012/07/10 10:57:48 For consistency I would prefer to have the "+1" in
if (exception->IsString()) {
OS::PrintError(
"Extension or internal compilation error: %s in %s at line %d.\n",
« no previous file with comments | « src/handles.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698