Issue 10704229: Fix loop-invariant code motion.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10704229: Fix loop-invariant code motion. (Closed)

Created:
8 years, 5 months ago by floitsch

Modified:
8 years, 5 months ago

Reviewers:
Johnni Winther, kasperl

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Fix loop-invariant code motion. We did not take the changes-flags of the instructions in the current block into account. Fixes issue 4075. Committed: https://code.google.com/p/dart/source/detail?r=9695

Patch Set 1 #

Patch Set 2 : rebase #

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+37 lines, -2 lines)			Patch
M	lib/compiler/implementation/ssa/nodes.dart	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	lib/compiler/implementation/ssa/optimize.dart	View	1 chunk	+5 lines, -0 lines	0 comments	Download
A	tests/language/loop_hoist_test.dart	View	1 chunk	+30 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

lgtm

Expand Messages | Collapse Messages