Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(497)

Unified Diff: tests/language/loop_hoist_test.dart

Issue 10704229: Fix loop-invariant code motion. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: rebase Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « lib/compiler/implementation/ssa/optimize.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/language/loop_hoist_test.dart
diff --git a/tests/language/loop_hoist_test.dart b/tests/language/loop_hoist_test.dart
new file mode 100644
index 0000000000000000000000000000000000000000..a4024af0597f0da07fd7c80d07f48dab01545bf5
--- /dev/null
+++ b/tests/language/loop_hoist_test.dart
@@ -0,0 +1,30 @@
+// Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
+// for details. All rights reserved. Use of this source code is governed by a
+// BSD-style license that can be found in the LICENSE file.
+
+class A {
+ num x;
+ A() : this.x = 0;
+
+ void bar(){
+ // dart2js hoisted the this.x out of the loop, and missed that setX would
+ // change the value.
+ for (int i = 1; i < 3; i++) {
+ setX(499);
+ foo(x);
+ break;
+ }
+ }
+ setX(x) => this.x = x;
+}
+
+var saved;
+foo(x) => saved = x;
+
+main() {
+ A a = new A();
+ for (int i = 0; i < 1; i++) {
+ a.bar();
+ }
+ Expect.equals(499, saved);
+}
« no previous file with comments | « lib/compiler/implementation/ssa/optimize.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698