Send an webNavigation event for navigations triggered by window.history

Send an webNavigation event for navigations triggered by window.history

Otherwise, we'd just see stray onCommitted events.

BUG=136090
TEST=ExtensionApiTest.WebNavigationHistory


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=146961

[jochen (gone - plz use gerrit), 2012-07-16 12:36:29]

plz review

[Matt Perry, 2012-07-16 20:42:50]

https://chromiumcodereview.appspot.com/10704225/diff/1/chrome/browser/extensi...
File chrome/browser/extensions/api/web_navigation/web_navigation_apitest.cc
(right):

https://chromiumcodereview.appspot.com/10704225/diff/1/chrome/browser/extensi...
chrome/browser/extensions/api/web_navigation/web_navigation_apitest.cc:34:
#define MAYBE_WebNavigationHistory DISABLED_WebNavigationHistory
Disabling a test before it's even checked in? That must be a new record :)

https://chromiumcodereview.appspot.com/10704225/diff/1/chrome/browser/extensi...
chrome/browser/extensions/api/web_navigation/web_navigation_apitest.cc:341:
switches::kAllowLegacyExtensionManifests);
How hard is it to just fix the manifest?

https://chromiumcodereview.appspot.com/10704225/diff/1/chrome/common/extensio...
File chrome/common/extensions/api/web_navigation.json (right):

https://chromiumcodereview.appspot.com/10704225/diff/1/chrome/common/extensio...
chrome/common/extensions/api/web_navigation.json:274: "description": "Fired when
the frame's history was updated to a new URL. All future events for that frame
will use the updated URL.",
I don't understand this description. At first I thought this event was fired
when the user navigated back/forward, or when the page used history.goBack() or
history.goForward(). This description makes it sound like the event fires when
the page changes a previous history entry somehow. Which is the correct
interpretation?

[jochen (gone - plz use gerrit), 2012-07-16 20:53:36]

https://chromiumcodereview.appspot.com/10704225/diff/1/chrome/browser/extensi...
File chrome/browser/extensions/api/web_navigation/web_navigation_apitest.cc
(right):

https://chromiumcodereview.appspot.com/10704225/diff/1/chrome/browser/extensi...
chrome/browser/extensions/api/web_navigation/web_navigation_apitest.cc:34:
#define MAYBE_WebNavigationHistory DISABLED_WebNavigationHistory
On 2012/07/16 20:42:50, Matt Perry wrote:
> Disabling a test before it's even checked in? That must be a new record :)

Well, it's an almost exact copy of the ReferenceFragment test. I'm currently
preparing another CL to fix this.

https://chromiumcodereview.appspot.com/10704225/diff/1/chrome/browser/extensi...
chrome/browser/extensions/api/web_navigation/web_navigation_apitest.cc:341:
switches::kAllowLegacyExtensionManifests);
On 2012/07/16 20:42:50, Matt Perry wrote:
> How hard is it to just fix the manifest?

I'll prepare a CL for that

https://chromiumcodereview.appspot.com/10704225/diff/1/chrome/common/extensio...
File chrome/common/extensions/api/web_navigation.json (right):

https://chromiumcodereview.appspot.com/10704225/diff/1/chrome/common/extensio...
chrome/common/extensions/api/web_navigation.json:274: "description": "Fired when
the frame's history was updated to a new URL. All future events for that frame
will use the updated URL.",
On 2012/07/16 20:42:50, Matt Perry wrote:
> I don't understand this description. At first I thought this event was fired
> when the user navigated back/forward, or when the page used history.goBack()
or
> history.goForward(). This description makes it sound like the event fires when
> the page changes a previous history entry somehow. Which is the correct
> interpretation?

It's fired when a page changes it's history. Somehow is using
history.replaceState or history.pushState (see the test).

[Matt Perry, 2012-07-16 21:15:23]

lgtm

https://chromiumcodereview.appspot.com/10704225/diff/1/chrome/common/extensio...
File chrome/common/extensions/api/web_navigation.json (right):

https://chromiumcodereview.appspot.com/10704225/diff/1/chrome/common/extensio...
chrome/common/extensions/api/web_navigation.json:274: "description": "Fired when
the frame's history was updated to a new URL. All future events for that frame
will use the updated URL.",
On 2012/07/16 20:53:36, jochen wrote:
> On 2012/07/16 20:42:50, Matt Perry wrote:
> > I don't understand this description. At first I thought this event was fired
> > when the user navigated back/forward, or when the page used history.goBack()
> or
> > history.goForward(). This description makes it sound like the event fires
when
> > the page changes a previous history entry somehow. Which is the correct
> > interpretation?
> 
> It's fired when a page changes it's history. Somehow is using
> history.replaceState or history.pushState (see the test).

OK, I'm probably confused because I don't really understand those methods.

[commit-bot: I haz the power, 2012-07-17 06:48:02]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jochen@chromium.org/10704225/1

[commit-bot: I haz the power, 2012-07-17 08:07:16]

Change committed as 146961