Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1515)

Unified Diff: chrome/browser/extensions/api/web_navigation/web_navigation_apitest.cc

Issue 10704225: Send an webNavigation event for navigations triggered by window.history (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/web_navigation/web_navigation_apitest.cc
diff --git a/chrome/browser/extensions/api/web_navigation/web_navigation_apitest.cc b/chrome/browser/extensions/api/web_navigation/web_navigation_apitest.cc
index 1f265bf7fbb5e6c7241405f4f64a2f99a9194da0..e79b20047cad05cf8600a68cac70effbe4c9d35a 100644
--- a/chrome/browser/extensions/api/web_navigation/web_navigation_apitest.cc
+++ b/chrome/browser/extensions/api/web_navigation/web_navigation_apitest.cc
@@ -31,6 +31,7 @@ using content::WebContents;
#define MAYBE_WebNavigationSimpleLoad DISABLED_WebNavigationSimpleLoad
#define MAYBE_WebNavigationReferenceFragment \
DISABLED_WebNavigationReferenceFragment
+#define MAYBE_WebNavigationHistory DISABLED_WebNavigationHistory
Matt Perry 2012/07/16 20:42:50 Disabling a test before it's even checked in? That
jochen (gone - plz use gerrit) 2012/07/16 20:53:36 Well, it's an almost exact copy of the ReferenceFr
#define MAYBE_WebNavigationOpenTab DISABLED_WebNavigationOpenTab
#define MAYBE_WebNavigationFilteredTest DISABLED_WebNavigationFilteredTest
#else
@@ -41,6 +42,7 @@ using content::WebContents;
#define MAYBE_WebNavigationGetFrame WebNavigationGetFrame
#define MAYBE_WebNavigationSimpleLoad WebNavigationSimpleLoad
#define MAYBE_WebNavigationReferenceFragment WebNavigationReferenceFragment
+#define MAYBE_WebNavigationHistory WebNavigationHistory
#define MAYBE_WebNavigationOpenTab WebNavigationOpenTab
#define MAYBE_WebNavigationFilteredTest WebNavigationFilteredTest
#endif
@@ -332,4 +334,15 @@ IN_PROC_BROWSER_TEST_F(ExtensionApiTest, WebNavigationTargetBlankIncognito) {
ASSERT_TRUE(catcher.GetNextResult()) << catcher.message();
}
+IN_PROC_BROWSER_TEST_F(ExtensionApiTest, MAYBE_WebNavigationHistory) {
+ FrameNavigationState::set_allow_extension_scheme(true);
+
+ CommandLine::ForCurrentProcess()->AppendSwitch(
+ switches::kAllowLegacyExtensionManifests);
Matt Perry 2012/07/16 20:42:50 How hard is it to just fix the manifest?
jochen (gone - plz use gerrit) 2012/07/16 20:53:36 I'll prepare a CL for that
+
+ ASSERT_TRUE(
+ RunExtensionSubtest("webnavigation", "test_history.html"))
+ << message_;
+}
+
} // namespace extensions

Powered by Google App Engine
This is Rietveld 408576698