Send an webNavigation event for navigations triggered by window.history

chrome/browser/extensions/api/web_navigation/web_navigation_apitest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/app/chrome_command_ids.h"
 #include "chrome/browser/extensions/api/web_navigation/web_navigation_api.h"
 #include "chrome/browser/extensions/extension_apitest.h"
 #include "chrome/browser/extensions/extension_service.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/tab_contents/render_view_context_menu.h"
@@ skipping 13 matching lines @@
 #if defined(OS_WIN)
 // http://crbug.com/118478
 #define MAYBE_WebNavigationIFrame DISABLED_WebNavigationIFrame
 #define MAYBE_WebNavigationFailures DISABLED_WebNavigationFailures
 #define MAYBE_WebNavigationForwardBack DISABLED_WebNavigationForwardBack
 #define MAYBE_WebNavigationClientRedirect DISABLED_WebNavigationClientRedirect
 #define MAYBE_WebNavigationGetFrame DISABLED_WebNavigationGetFrame
 #define MAYBE_WebNavigationSimpleLoad DISABLED_WebNavigationSimpleLoad
 #define MAYBE_WebNavigationReferenceFragment \
     DISABLED_WebNavigationReferenceFragment
+#define MAYBE_WebNavigationHistory DISABLED_WebNavigationHistory

[Matt Perry, 2012/07/16 20:42:50]

Disabling a test before it's even checked in? That must be a new record :)

[jochen (gone - plz use gerrit), 2012/07/16 20:53:36]

Well, it's an almost exact copy of the ReferenceFragment test. I'm currently
preparing another CL to fix this.

 #define MAYBE_WebNavigationOpenTab DISABLED_WebNavigationOpenTab
 #define MAYBE_WebNavigationFilteredTest DISABLED_WebNavigationFilteredTest
 #else
 #define MAYBE_WebNavigationIFrame WebNavigationIFrame
 #define MAYBE_WebNavigationFailures WebNavigationFailures
 #define MAYBE_WebNavigationForwardBack WebNavigationForwardBack
 #define MAYBE_WebNavigationClientRedirect WebNavigationClientRedirect
 #define MAYBE_WebNavigationGetFrame WebNavigationGetFrame
 #define MAYBE_WebNavigationSimpleLoad WebNavigationSimpleLoad
 #define MAYBE_WebNavigationReferenceFragment WebNavigationReferenceFragment
+#define MAYBE_WebNavigationHistory WebNavigationHistory
 #define MAYBE_WebNavigationOpenTab WebNavigationOpenTab
 #define MAYBE_WebNavigationFilteredTest WebNavigationFilteredTest
 #endif
 
 namespace extensions {
 
 namespace {
 
 class TestRenderViewContextMenu : public RenderViewContextMenu {
  public:
@@ skipping 271 matching lines @@
   mouse_event.x = 7;
   mouse_event.y = 7;
   mouse_event.clickCount = 1;
   tab->GetRenderViewHost()->ForwardMouseEvent(mouse_event);
   mouse_event.type = WebKit::WebInputEvent::MouseUp;
   tab->GetRenderViewHost()->ForwardMouseEvent(mouse_event);
 
   ASSERT_TRUE(catcher.GetNextResult()) << catcher.message();
 }
 
+IN_PROC_BROWSER_TEST_F(ExtensionApiTest, MAYBE_WebNavigationHistory) {
+  FrameNavigationState::set_allow_extension_scheme(true);
+
+  CommandLine::ForCurrentProcess()->AppendSwitch(
+      switches::kAllowLegacyExtensionManifests);

[Matt Perry, 2012/07/16 20:42:50]

How hard is it to just fix the manifest?

[jochen (gone - plz use gerrit), 2012/07/16 20:53:36]

I'll prepare a CL for that

+
+  ASSERT_TRUE(
+      RunExtensionSubtest("webnavigation", "test_history.html"))
+          << message_;
+}
+
 }  // namespace extensions