Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(173)

Issue 10704135: Use #pragma comment(lib, "userenv.lib") rather than AdditionalDependencies. It's better. (Closed)

Created:
8 years, 5 months ago by grt (UTC plus 2)
Modified:
8 years, 5 months ago
Reviewers:
Ryan Sleevi
CC:
chromium-reviews
Visibility:
Public.

Description

Use #pragma comment(lib, "userenv.lib") rather than AdditionalDependencies. It's better. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=145961

Patch Set 1 #

Total comments: 2

Patch Set 2 : relocated pragma #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -6 lines) Patch
M chrome/app/breakpad_win.cc View 1 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/chrome_exe.gypi View 2 chunks +0 lines, -6 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
grt (UTC plus 2)
8 years, 5 months ago (2012-07-10 18:17:34 UTC) #1
Ryan Sleevi
lgtm https://chromiumcodereview.appspot.com/10704135/diff/1/chrome/app/breakpad_win.cc File chrome/app/breakpad_win.cc (right): https://chromiumcodereview.appspot.com/10704135/diff/1/chrome/app/breakpad_win.cc#newcode13 chrome/app/breakpad_win.cc:13: #pragma comment(lib, "userenv.lib") nit: Place this after the ...
8 years, 5 months ago (2012-07-10 18:20:13 UTC) #2
grt (UTC plus 2)
ptal https://chromiumcodereview.appspot.com/10704135/diff/1/chrome/app/breakpad_win.cc File chrome/app/breakpad_win.cc (right): https://chromiumcodereview.appspot.com/10704135/diff/1/chrome/app/breakpad_win.cc#newcode13 chrome/app/breakpad_win.cc:13: #pragma comment(lib, "userenv.lib") On 2012/07/10 18:20:13, Ryan Sleevi ...
8 years, 5 months ago (2012-07-10 18:28:25 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/grt@chromium.org/10704135/7001
8 years, 5 months ago (2012-07-10 19:04:14 UTC) #4
commit-bot: I haz the power
8 years, 5 months ago (2012-07-10 21:34:31 UTC) #5
Change committed as 145961

Powered by Google App Engine
This is Rietveld 408576698