Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(446)

Side by Side Diff: chrome/app/breakpad_win.cc

Issue 10704135: Use #pragma comment(lib, "userenv.lib") rather than AdditionalDependencies. It's better. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | chrome/chrome_exe.gypi » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/app/breakpad_win.h" 5 #include "chrome/app/breakpad_win.h"
6 6
7 #include <windows.h> 7 #include <windows.h>
8 #include <shellapi.h> 8 #include <shellapi.h>
9 #include <tchar.h> 9 #include <tchar.h>
10 #include <userenv.h> 10 #include <userenv.h>
11 11
12 // userenv.dll is required for GetProfileType().
13 #pragma comment(lib, "userenv.lib")
Ryan Sleevi 2012/07/10 18:20:13 nit: Place this after the #include headers (line 4
grt (UTC plus 2) 2012/07/10 18:28:25 Done. It figures I'd copy the pattern from the le
14
12 #include <algorithm> 15 #include <algorithm>
13 #include <vector> 16 #include <vector>
14 17
15 #include "base/base_switches.h" 18 #include "base/base_switches.h"
16 #include "base/command_line.h" 19 #include "base/command_line.h"
17 #include "base/environment.h" 20 #include "base/environment.h"
18 #include "base/file_util.h" 21 #include "base/file_util.h"
19 #include "base/file_version_info.h" 22 #include "base/file_version_info.h"
20 #include "base/memory/scoped_ptr.h" 23 #include "base/memory/scoped_ptr.h"
21 #include "base/string_split.h" 24 #include "base/string_split.h"
(...skipping 859 matching lines...) Expand 10 before | Expand all | Expand 10 after
881 previous_filter = SetUnhandledExceptionFilter(filter); 884 previous_filter = SetUnhandledExceptionFilter(filter);
882 } 885 }
883 886
884 void StringVectorToCStringVector(const std::vector<std::wstring>& wstrings, 887 void StringVectorToCStringVector(const std::vector<std::wstring>& wstrings,
885 std::vector<const wchar_t*>* cstrings) { 888 std::vector<const wchar_t*>* cstrings) {
886 cstrings->clear(); 889 cstrings->clear();
887 cstrings->reserve(wstrings.size()); 890 cstrings->reserve(wstrings.size());
888 for (size_t i = 0; i < wstrings.size(); ++i) 891 for (size_t i = 0; i < wstrings.size(); ++i)
889 cstrings->push_back(wstrings[i].c_str()); 892 cstrings->push_back(wstrings[i].c_str());
890 } 893 }
OLDNEW
« no previous file with comments | « no previous file | chrome/chrome_exe.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698