Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(152)

Side by Side Diff: chrome/app/breakpad_win.cc

Issue 10704135: Use #pragma comment(lib, "userenv.lib") rather than AdditionalDependencies. It's better. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: relocated pragma Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | chrome/chrome_exe.gypi » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/app/breakpad_win.h" 5 #include "chrome/app/breakpad_win.h"
6 6
7 #include <windows.h> 7 #include <windows.h>
8 #include <shellapi.h> 8 #include <shellapi.h>
9 #include <tchar.h> 9 #include <tchar.h>
10 #include <userenv.h> 10 #include <userenv.h>
(...skipping 19 matching lines...) Expand all
30 #include "chrome/app/hard_error_handler_win.h" 30 #include "chrome/app/hard_error_handler_win.h"
31 #include "chrome/common/child_process_logging.h" 31 #include "chrome/common/child_process_logging.h"
32 #include "chrome/common/chrome_result_codes.h" 32 #include "chrome/common/chrome_result_codes.h"
33 #include "chrome/common/chrome_switches.h" 33 #include "chrome/common/chrome_switches.h"
34 #include "chrome/common/env_vars.h" 34 #include "chrome/common/env_vars.h"
35 #include "chrome/installer/util/google_chrome_sxs_distribution.h" 35 #include "chrome/installer/util/google_chrome_sxs_distribution.h"
36 #include "chrome/installer/util/google_update_settings.h" 36 #include "chrome/installer/util/google_update_settings.h"
37 #include "chrome/installer/util/install_util.h" 37 #include "chrome/installer/util/install_util.h"
38 #include "policy/policy_constants.h" 38 #include "policy/policy_constants.h"
39 39
40 // userenv.dll is required for GetProfileType().
41 #pragma comment(lib, "userenv.lib")
42
40 namespace breakpad_win { 43 namespace breakpad_win {
41 44
42 std::vector<google_breakpad::CustomInfoEntry>* g_custom_entries = NULL; 45 std::vector<google_breakpad::CustomInfoEntry>* g_custom_entries = NULL;
43 size_t g_num_of_experiments_offset = 0; 46 size_t g_num_of_experiments_offset = 0;
44 size_t g_experiment_chunks_offset = 0; 47 size_t g_experiment_chunks_offset = 0;
45 48
46 } // namespace breakpad_win 49 } // namespace breakpad_win
47 50
48 using breakpad_win::g_custom_entries; 51 using breakpad_win::g_custom_entries;
49 using breakpad_win::g_experiment_chunks_offset; 52 using breakpad_win::g_experiment_chunks_offset;
(...skipping 831 matching lines...) Expand 10 before | Expand all | Expand 10 after
881 previous_filter = SetUnhandledExceptionFilter(filter); 884 previous_filter = SetUnhandledExceptionFilter(filter);
882 } 885 }
883 886
884 void StringVectorToCStringVector(const std::vector<std::wstring>& wstrings, 887 void StringVectorToCStringVector(const std::vector<std::wstring>& wstrings,
885 std::vector<const wchar_t*>* cstrings) { 888 std::vector<const wchar_t*>* cstrings) {
886 cstrings->clear(); 889 cstrings->clear();
887 cstrings->reserve(wstrings.size()); 890 cstrings->reserve(wstrings.size());
888 for (size_t i = 0; i < wstrings.size(); ++i) 891 for (size_t i = 0; i < wstrings.size(); ++i)
889 cstrings->push_back(wstrings[i].c_str()); 892 cstrings->push_back(wstrings[i].c_str());
890 } 893 }
OLDNEW
« no previous file with comments | « no previous file | chrome/chrome_exe.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698