"Paste and go" state was being calculated wrong on views (at least). Fix by making this calculatio…

"Paste and go" state was being calculated wrong on views (at least).  Fix by making this calculation stateless.

BUG=135202
TEST=Start Chrome, navigate to a URL, copy some non-URL text, right-click the omnibox, and verify "paste and search" is shown.  Copy a URL and right-click and verify "paste and go" is shown.
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=145931

[Peter Kasting, 2012-07-03 02:58:52]

sky: all
erg: Is the state variable solution I've adopted for GTK correct, or should
there be some sort of GetClipboardText() function as there is on Mac/Win?

[Elliot Glaysher, 2012-07-09 16:29:07]

https://chromiumcodereview.appspot.com/10704074/diff/9001/chrome/browser/ui/g...
File chrome/browser/ui/gtk/omnibox/omnibox_view_gtk.cc (right):

https://chromiumcodereview.appspot.com/10704074/diff/9001/chrome/browser/ui/g...
chrome/browser/ui/gtk/omnibox/omnibox_view_gtk.cc:1345: string16
sanitized_text_for_paste_and_go_(text ?
Is this supposed to be a member variable? It's declared locally, but ends in
"_".

[Peter Kasting, 2012-07-09 17:17:21]

https://chromiumcodereview.appspot.com/10704074/diff/9001/chrome/browser/ui/g...
File chrome/browser/ui/gtk/omnibox/omnibox_view_gtk.cc (right):

https://chromiumcodereview.appspot.com/10704074/diff/9001/chrome/browser/ui/g...
chrome/browser/ui/gtk/omnibox/omnibox_view_gtk.cc:1345: string16
sanitized_text_for_paste_and_go_(text ?
On 2012/07/09 16:29:08, Elliot Glaysher wrote:
> Is this supposed to be a member variable?

Yes.  Fixed.

[Elliot Glaysher, 2012-07-09 17:28:40]

https://chromiumcodereview.appspot.com/10704074/diff/15001/chrome/browser/ui/...
File chrome/browser/ui/gtk/omnibox/omnibox_view_gtk.cc (right):

https://chromiumcodereview.appspot.com/10704074/diff/15001/chrome/browser/ui/...
chrome/browser/ui/gtk/omnibox/omnibox_view_gtk.cc:1345:
sanitized_text_for_paste_and_go_(text ?
I suspect that this will not compile, though I may be wrong if there's really an
implementation of std::string::operator(std::string);

[Peter Kasting, 2012-07-09 17:32:59]

Yeah, fixing... in the meantime just review what the code is supposed to be
doing :)

[Elliot Glaysher, 2012-07-09 17:38:57]

gtk lgtm

[Peter Kasting, 2012-07-10 19:20:11]

Since sky is out I'm just going to TBR this.  Scott, let me know after you
return if you see anything that needs changing.

[sky, 2012-07-16 22:36:42]

LGTM