"Paste and go" state was being calculated wrong on views (at least). Fix by making this calculatio…

chrome/browser/ui/omnibox/omnibox_edit_model.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_UI_OMNIBOX_OMNIBOX_EDIT_MODEL_H_
 #define CHROME_BROWSER_UI_OMNIBOX_OMNIBOX_EDIT_MODEL_H_
 #pragma once
 
 #include "base/basictypes.h"
 #include "base/compiler_specific.h"
@@ skipping 150 matching lines @@
   void Revert();
 
   // Directs the popup to start autocomplete.
   void StartAutocomplete(bool has_selected_text,
                          bool prevent_inline_autocomplete) const;
 
   // Closes the popup and cancels any pending asynchronous queries.
   void StopAutocomplete();
 
   // Determines whether the user can "paste and go", given the specified text.
-  // This also updates the internal paste-and-go-related state variables as
-  // appropriate so that the controller doesn't need to be repeatedly queried
-  // for the same text in every clipboard-related function.
   bool CanPasteAndGo(const string16& text) const;
 
   // Navigates to the destination last supplied to CanPasteAndGo.
-  void PasteAndGo();
+  void PasteAndGo(const string16& text);
 
   // Returns true if this is a paste-and-search rather than paste-and-go (or
   // nothing).
-  bool is_paste_and_search() const {
-    return (paste_and_go_match_.transition != content::PAGE_TRANSITION_TYPED);
-  }
+  bool IsPasteAndSearch(const string16& text) const;
 
   // Asks the browser to load the popup's currently selected item, using the
   // supplied disposition.  This may close the popup. If |for_drop| is true,
   // it indicates the input is being accepted as part of a drop operation and
   // the transition should be treated as LINK (so that it won't trigger the
   // URL to be autocompleted).
   void AcceptInput(WindowOpenDisposition disposition,
                    bool for_drop);
 
   // Asks the browser to load the item at |index|, with the given properties.
@@ skipping 199 matching lines @@
   // keyword.
   static bool IsSpaceCharForAcceptingKeyword(wchar_t c);
 
   // Classify the current page being viewed as, for example, the new tab
   // page or a normal web page.  Used for logging omnibox events for
   // UMA opted-in users.  Examines the user's profile to determine if the
   // current page is the user's home page.
   metrics::OmniboxEventProto::PageClassification ClassifyPage(
       const GURL& gurl) const;
 
+  // Sets |match| and |alternate_nav_url| based on classifying |text|.
+  // |alternate_nav_url| may be NULL.
+  void ClassifyStringForPasteAndGo(const string16& text,
+                                   AutocompleteMatch* match,
+                                   GURL* alternate_nav_url) const;
+
   scoped_ptr<AutocompleteController> autocomplete_controller_;
 
   OmniboxView* view_;
 
   OmniboxPopupModel* popup_;
 
   OmniboxEditController* controller_;
 
   // Whether the edit has focus.
   bool has_focus_;
@@ skipping 74 matching lines @@
   // selected keyword, or just some input text that looks like a keyword (so we
   // can show a hint to press <tab>).  This is the keyword in either case;
   // is_keyword_hint_ (below) distinguishes the two cases.
   string16 keyword_;
 
   // True if the keyword associated with this match is merely a hint, i.e. the
   // user hasn't actually selected a keyword yet.  When this is true, we can use
   // keyword_ to show a "Press <tab> to search" sort of hint.
   bool is_keyword_hint_;
 
-  // Paste And Go-related state.  See CanPasteAndGo().
-  mutable AutocompleteMatch paste_and_go_match_;
-  mutable GURL paste_and_go_alternate_nav_url_;
-
   Profile* profile_;
 
   // This is needed as prior to accepting the current text the model is
   // reverted, which triggers resetting instant. We don't want to update instant
   // in this case, so we use the flag to determine if this is happening.
   bool in_revert_;
 
   // Indicates if the upcoming autocomplete search is allowed to be treated as
   // an exact keyword match.  If this is true then keyword mode will be
   // triggered automatically if the input is "<keyword> <search string>".  We
   // allow this when CreatedKeywordSearchByInsertingSpaceInMiddle() is true.
   // This has no effect if we're already in keyword mode.
   bool allow_exact_keyword_match_;
 
   // Last value of InstantCompleteBehavior supplied to |SetSuggestedText|.
   InstantCompleteBehavior instant_complete_behavior_;
 
   DISALLOW_COPY_AND_ASSIGN(OmniboxEditModel);
 };
 
 #endif  // CHROME_BROWSER_UI_OMNIBOX_OMNIBOX_EDIT_MODEL_H_