Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Side by Side Diff: chrome/browser/ui/gtk/omnibox/omnibox_view_gtk.h

Issue 10704074: "Paste and go" state was being calculated wrong on views (at least). Fix by making this calculatio… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_UI_GTK_OMNIBOX_OMNIBOX_VIEW_GTK_H_ 5 #ifndef CHROME_BROWSER_UI_GTK_OMNIBOX_OMNIBOX_VIEW_GTK_H_
6 #define CHROME_BROWSER_UI_GTK_OMNIBOX_OMNIBOX_VIEW_GTK_H_ 6 #define CHROME_BROWSER_UI_GTK_OMNIBOX_OMNIBOX_VIEW_GTK_H_
7 #pragma once 7 #pragma once
8 8
9 #include <gtk/gtk.h> 9 #include <gtk/gtk.h>
10 10
(...skipping 421 matching lines...) Expand 10 before | Expand all | Expand 10 after
432 // Indicates if Shift key was pressed. 432 // Indicates if Shift key was pressed.
433 // Used in conjunction with the Tab key to determine if either traversal 433 // Used in conjunction with the Tab key to determine if either traversal
434 // needs to move up the results or if the keyword needs to be cleared. 434 // needs to move up the results or if the keyword needs to be cleared.
435 bool shift_was_pressed_; 435 bool shift_was_pressed_;
436 436
437 // Indicates that user requested to paste clipboard. 437 // Indicates that user requested to paste clipboard.
438 // The actual paste clipboard action might be performed later if the 438 // The actual paste clipboard action might be performed later if the
439 // clipboard is not empty. 439 // clipboard is not empty.
440 bool paste_clipboard_requested_; 440 bool paste_clipboard_requested_;
441 441
442 // Text to "Paste and go"; set by HandlePopulatePopup() and consumed by
443 // HandlePasteAndGo().
444 string16 sanitized_text_for_paste_and_go_;
445
442 // Indicates if an Enter key press is inserted as text. 446 // Indicates if an Enter key press is inserted as text.
443 // It's used in the key press handler to determine if an Enter key event is 447 // It's used in the key press handler to determine if an Enter key event is
444 // handled by IME or not. 448 // handled by IME or not.
445 bool enter_was_inserted_; 449 bool enter_was_inserted_;
446 450
447 // Indicates whether the IME changed the text. It's possible for the IME to 451 // Indicates whether the IME changed the text. It's possible for the IME to
448 // handle a key event but not change the text contents (e.g., when pressing 452 // handle a key event but not change the text contents (e.g., when pressing
449 // shift+del with no selection). 453 // shift+del with no selection).
450 bool text_changed_; 454 bool text_changed_;
451 455
(...skipping 41 matching lines...) Expand 10 before | Expand all | Expand 10 after
493 // The view that is going to be focused next. Only valid while handling 497 // The view that is going to be focused next. Only valid while handling
494 // "focus-out" events. 498 // "focus-out" events.
495 GtkWidget* going_to_focus_; 499 GtkWidget* going_to_focus_;
496 500
497 ui::GtkSignalRegistrar signals_; 501 ui::GtkSignalRegistrar signals_;
498 502
499 DISALLOW_COPY_AND_ASSIGN(OmniboxViewGtk); 503 DISALLOW_COPY_AND_ASSIGN(OmniboxViewGtk);
500 }; 504 };
501 505
502 #endif // CHROME_BROWSER_UI_GTK_OMNIBOX_OMNIBOX_VIEW_GTK_H_ 506 #endif // CHROME_BROWSER_UI_GTK_OMNIBOX_OMNIBOX_VIEW_GTK_H_
OLDNEW
« no previous file with comments | « chrome/browser/ui/cocoa/omnibox/omnibox_view_mac.mm ('k') | chrome/browser/ui/gtk/omnibox/omnibox_view_gtk.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698