Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 10700194: Represent BINARY properties using std::string instead of BinaryValue, (Closed)

Created:
8 years, 5 months ago by Jeffrey Yasskin
Modified:
8 years, 5 months ago
CC:
chromium-reviews, erikwright (departed), Aaron Boodman, mihaip-chromium-reviews_chromium.org, pam+watch_chromium.org, brettw-cc_chromium.org, Garret Kelly, not at google - send to devlin
Visibility:
Public.

Description

Represent BINARY properties using std::string instead of BinaryValue, for easier use by C++. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=147591

Patch Set 1 #

Total comments: 2

Patch Set 2 : Undo values.h change. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -19 lines) Patch
M chrome/browser/extensions/api/serial/serial_api.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/usb/usb_device_resource.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M tools/json_schema_compiler/cc_generator.py View 1 2 chunks +18 lines, -8 lines 0 comments Download
M tools/json_schema_compiler/cpp_type_generator.py View 2 chunks +2 lines, -7 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Jeffrey Yasskin
Brett, please review the small change to let BinaryValue take a StringPiece. The extra code ...
8 years, 5 months ago (2012-07-13 00:13:33 UTC) #1
brettw
https://chromiumcodereview.appspot.com/10700194/diff/1/base/values.h File base/values.h (right): https://chromiumcodereview.appspot.com/10700194/diff/1/base/values.h#newcode33 base/values.h:33: #include "base/string_piece.h" I don't actually know the answer but ...
8 years, 5 months ago (2012-07-13 16:46:46 UTC) #2
Jeffrey Yasskin
Thanks for looking at the base/values.h change, Brett. Now that it's reverted, you don't need ...
8 years, 5 months ago (2012-07-15 04:07:23 UTC) #3
Jeffrey Yasskin
I'm not sure who's best to review json_schema_compiler changes, but "ping".
8 years, 5 months ago (2012-07-19 22:09:17 UTC) #4
Matt Perry
LGTM. +cc kalman since I think he knows about json_schema_compiler
8 years, 5 months ago (2012-07-19 22:33:48 UTC) #5
not at google - send to devlin
lgtm
8 years, 5 months ago (2012-07-20 00:12:45 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jyasskin@chromium.org/10700194/4001
8 years, 5 months ago (2012-07-20 00:16:08 UTC) #7
commit-bot: I haz the power
8 years, 5 months ago (2012-07-20 01:27:36 UTC) #8
Change committed as 147591

Powered by Google App Engine
This is Rietveld 408576698