Represent BINARY properties using std::string instead of BinaryValue,

base/values.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // This file specifies a recursive data storage class called Value intended for
 // storing setting and other persistable data.  It includes the ability to
 // specify (recursive) lists and dictionaries, so it's fairly expressive.
 // However, the API is optimized for the common case, namely storing a
 // hierarchical tree of simple values.  Given a DictionaryValue root, you can
 // easily do things like:
@@ skipping 12 matching lines @@
 
 #include <iterator>
 #include <map>
 #include <string>
 #include <vector>
 
 #include "base/base_export.h"
 #include "base/basictypes.h"
 #include "base/compiler_specific.h"
 #include "base/string16.h"
+#include "base/string_piece.h"

[brettw, 2012/07/13 16:46:46]

I don't actually know the answer but I wonder if we made the right tradeoff
here. base/value is used in a lot of places and string_piece.h isn't a simple
header file. Given that this is generated code and the the end result will be
the same, do you think it would be better to just have the generator emit the
(data(), size()) calls?

[Jeffrey Yasskin, 2012/07/15 04:07:24]

I tend to think that StringPiece should be used everywhere we pass const
character data around, but it's not an important part of this particular change.
Reverted.

 
 // This file declares "using base::Value", etc. at the bottom, so that
 // current code can use these classes without the base namespace. In
 // new code, please always use base::Value, etc. or add your own
 // "using" declaration.
 // http://crbug.com/88666
 namespace base {
 
 class BinaryValue;
 class DictionaryValue;
@@ skipping 138 matching lines @@
   // Creates a Value to represent a binary buffer.  The new object takes
   // ownership of the pointer passed in, if successful.
   // Returns NULL if buffer is NULL.
   static BinaryValue* Create(char* buffer, size_t size);
 
   // For situations where you want to keep ownership of your buffer, this
   // factory method creates a new BinaryValue by copying the contents of the
   // buffer that's passed in.
   // Returns NULL if buffer is NULL.
   static BinaryValue* CreateWithCopiedBuffer(const char* buffer, size_t size);
+  static BinaryValue* CreateWithCopiedBuffer(StringPiece buffer) {
+    return CreateWithCopiedBuffer(buffer.data(), buffer.size());
+  }
 
   size_t GetSize() const { return size_; }
   char* GetBuffer() { return buffer_; }
   const char* GetBuffer() const { return buffer_; }
 
   // Overridden from Value:
   virtual BinaryValue* DeepCopy() const OVERRIDE;
   virtual bool Equals(const Value* other) const OVERRIDE;
 
  private:
@@ skipping 291 matching lines @@
 
 }  // namespace base
 
 // http://crbug.com/88666
 using base::DictionaryValue;
 using base::ListValue;
 using base::StringValue;
 using base::Value;
 
 #endif  // BASE_VALUES_H_