Rename aura_shell_unittests to ash_unittests, part 1

Rename aura_shell_unittests to ash_unittests, part 1

* Rename aura_shell_unittests target to ash_unittests
* Add a target for aura_shell_unittests that makes a copy of ash_unittests

We need the old copy until we can switch the build bots to using the new copy.

cp.py needs to change slightly to preserve the executable bit of the test binary.

BUG=110107
TEST=Run build/gyp_chromium, inspected build.ninja files to verify rules existed for both ash_unittests and aura_shell_unittests, built and ran both targets
TBR=thestig@chromium.org for trivial rename in tools/valgrind/chrome_test.py


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=146654

[James Cook, 2012-07-11 17:30:02]

Greg, PTAL.

[Greg Spencer (Chromium), 2012-07-12 19:58:54]

http://codereview.chromium.org/10700163/diff/7002/ash/ash.gyp
File ash/ash.gyp (right):

http://codereview.chromium.org/10700163/diff/7002/ash/ash.gyp#newcode397
ash/ash.gyp:397: 'launcher/launcher_tooltip_manager_unittest.cc',
Looks like some tab characters snuck in here.

http://codereview.chromium.org/10700163/diff/7002/ash/ash.gyp#newcode472
ash/ash.gyp:472: ['exclude',
'accelerators/nested_dispatcher_controller_unittest.cc'],
Same here (tabs).

http://codereview.chromium.org/10700163/diff/7002/build/all.gyp
File build/all.gyp (right):

http://codereview.chromium.org/10700163/diff/7002/build/all.gyp#newcode650
build/all.gyp:650: '../ash/ash.gyp:ash_unittests',
So, do the build bots explicitly build aura_shell_unittests, then?  Because I
don't see how ash_unittests causes aura_shell_unittests to be built as well.

[James Cook, 2012-07-12 20:53:11]

Greg, good catch!  Please have another look.  (There's a rebase here, sorry.)

http://codereview.chromium.org/10700163/diff/7002/ash/ash.gyp
File ash/ash.gyp (right):

http://codereview.chromium.org/10700163/diff/7002/ash/ash.gyp#newcode397
ash/ash.gyp:397: 'launcher/launcher_tooltip_manager_unittest.cc',
On 2012/07/12 19:58:54, Greg Spencer (Chromium) wrote:
> Looks like some tab characters snuck in here.

Done.

http://codereview.chromium.org/10700163/diff/7002/ash/ash.gyp#newcode472
ash/ash.gyp:472: ['exclude',
'accelerators/nested_dispatcher_controller_unittest.cc'],
On 2012/07/12 19:58:54, Greg Spencer (Chromium) wrote:
> Same here (tabs).

Done.

http://codereview.chromium.org/10700163/diff/7002/build/all.gyp
File build/all.gyp (right):

http://codereview.chromium.org/10700163/diff/7002/build/all.gyp#newcode650
build/all.gyp:650: '../ash/ash.gyp:ash_unittests',
On 2012/07/12 19:58:54, Greg Spencer (Chromium) wrote:
> So, do the build bots explicitly build aura_shell_unittests, then?  Because I
> don't see how ash_unittests causes aura_shell_unittests to be built as well.

Oh, good catch.  I'm not sure what they build, but the safest thing to do is
build aura_shell_unittests, since that will get us both ash_ and aura_shell_. 
Once we know the bots want to run the new one we can switch to ash_.  I'll
revert this line.

[Greg Spencer (Chromium), 2012-07-13 17:36:58]

lgtm

[James Cook, 2012-07-13 17:53:01]

Ben, I need OWNERS approval for this.  I'm working with petermayo@ to get the
bot configs changed, then we can remove the old aura_shell_unittests target.

[Ben Goodger (Google), 2012-07-13 17:54:40]

lgtm

[commit-bot: I haz the power, 2012-07-13 18:01:17]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jamescook@chromium.org/10700163/11001

[commit-bot: I haz the power, 2012-07-13 19:09:41]

Try job failure for 10700163-11001 (retry) on mac_rel for step "browser_tests".
It's a second try, previously, step "browser_tests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&nu...

[commit-bot: I haz the power, 2012-07-13 19:58:58]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jamescook@chromium.org/10700163/11001

[commit-bot: I haz the power, 2012-07-13 21:27:04]

Change committed as 146654

[Lei Zhang, 2012-07-16 18:16:33]

LGTM too, but please add me to the reviewers list next time.