Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(173)

Issue 10700087: Merge 119548 - Special layout handler should be done on top frame being printed. (Closed)

Created:
8 years, 5 months ago by Nico
Modified:
8 years, 5 months ago
Reviewers:
darin
CC:
chromium-reviews
Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/1132/
Visibility:
Public.

Description

Merge 119548 - Special layout handler should be done on top frame being printed. https://bugs.webkit.org/show_bug.cgi?id=88201 Merge approved at http://crbug.com/109412. See also http://crbug.com/135563 Patch by Vitaly Buka <vitalybuka@chromium.org>; on 2012-06-05 Reviewed by Brady Eidson. No new tests. Root case is already covered by tests. Case described in the issue can be reproduced only by direct call to Frame::setPrinting of subframe. Probably it's not possible with layout tests. * page/Frame.cpp: (WebCore::Frame::setPrinting): Use shouldUsePrintingLayout to choose proper version of forceLayout(). (WebCore::Frame::shouldUsePrintingLayout): Checks if current frame is the top frame being printed. * rendering/RenderView.cpp: (WebCore::RenderView::shouldUsePrintingLayout): Forward to Frame. TBR=darin@apple.com Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=121786

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -12867 lines) Patch
M Source/WebCore/ChangeLog View 1 chunk +0 lines, -12863 lines 0 comments Download
M Source/WebCore/page/Frame.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/WebCore/page/Frame.cpp View 2 chunks +8 lines, -2 lines 0 comments Download
M Source/WebCore/rendering/RenderView.cpp View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
Nico
8 years, 5 months ago (2012-07-03 17:30:17 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698