Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(405)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: Source/WebCore/ChangeLog

Side-by-side diff isn't available for this file because of its large size.
Issue 10700087: Merge 119548 - Special layout handler should be done on top frame being printed. (Closed) Base URL: http://svn.webkit.org/repository/webkit/branches/chromium/1132/
Patch Set: Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
Download patch
« no previous file with comments | « no previous file | Source/WebCore/page/Frame.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/WebCore/ChangeLog
===================================================================
--- Source/WebCore/ChangeLog (revision 121785)
+++ Source/WebCore/ChangeLog (working copy)
@@ -1,12866 +1,3 @@
-2012-06-18 Nico Weber <thakis@chromium.org>
-
- [chromium/mac] Unbreak smooth scrolling.
- https://bugs.webkit.org/show_bug.cgi?id=89327
-
- Reviewed by Dimitri Glazkov.
-
- Broken by Sam in r115589 / r115591.
-
- * platform/mac/ScrollAnimatorMac.mm:
- (WebCore::scrollAnimationEnabledForSystem):
-
-2012-06-18 Sheriff Bot <webkit.review.bot@gmail.com>
-
- Unreviewed, rolling out r120541, r120547, and r120548.
- http://trac.webkit.org/changeset/120541
- http://trac.webkit.org/changeset/120547
- http://trac.webkit.org/changeset/120548
- https://bugs.webkit.org/show_bug.cgi?id=89383
-
- This approach doesn't work for WebKit2 (Requested by abarth on
- #webkit).
-
- * testing/InternalSettings.cpp:
- (WebCore::InternalSettings::InternalSettings):
- (WebCore::InternalSettings::restoreTo):
- * testing/InternalSettings.h:
- (InternalSettings):
-
-2012-06-18 Yong Li <yoli@rim.com>
-
- [BlackBerry] NetworkJob::startNewJobWithRequest() should check the frame pointer
- https://bugs.webkit.org/show_bug.cgi?id=89369
-
- Reviewed by Antonio Gomes.
-
- NetworkJob::startNewJobWithRequest() should stop proceeding if the frame is null,
- which means it is a PingLoader job and should just finish now.
-
- * platform/network/blackberry/NetworkJob.cpp:
- (WebCore::NetworkJob::startNewJobWithRequest):
-
-2012-06-18 Dan Bernstein <mitz@apple.com>
-
- Ideographic comma and full-stops are mishandled in linebreak
- https://bugs.webkit.org/show_bug.cgi?id=87041
-
- Reviewed by Alexey Proskuryakov.
-
- Test: fast/text/line-breaks-after-ideographic-comma-or-full-stop-2.html
-
- Specifically, line breaks were always allowed after an ideographic comma or full stop, even
- before a closing bracket.
-
- * rendering/break_lines.cpp:
- (WebCore::shouldBreakAfter): Removed code that unconditionally allowed line breaks after
- ideographic commas and full stops, which was added for <http://webkit.org/b/17411> to work
- around an issue in Unicode 5.0. Current line break iterator implementations are based on
- newer versions of Unicode, which do not have that issue, so we can use them instead of the
- hardcoded approximate rule.
-
-2012-06-18 Martin Robinson <mrobinson@igalia.com>
-
- [TextureMapper] Rename shader variables to match the naming scheme of the newer filter shaders
- https://bugs.webkit.org/show_bug.cgi?id=89324
-
- Reviewed by Noam Rosenthal.
-
- Rename shader variables to align them with those in the new filter shaders.
-
- No new tests. This is just a simple refactor.
-
- * platform/graphics/texmap/TextureMapperShaderManager.cpp:
- Rename shader variables so that uniforms are prefixed by "u_", attributes by "a_",
- and texture samplers by "s_".
-
-2012-06-18 Alexei Filippov <alexeif@chromium.org>
-
- Web Inspector: Implement native memory bar diagram
- https://bugs.webkit.org/show_bug.cgi?id=89106
-
- Reviewed by Pavel Feldman.
-
- * inspector/front-end/NativeMemorySnapshotView.js:
- (WebInspector.NativeMemoryBarChart):
- (WebInspector.NativeMemoryBarChart.prototype._updateStats):
- (WebInspector.NativeMemoryBarChart.prototype.willHide):
- (WebInspector.NativeMemoryBarChart.prototype.wasShown):
- (WebInspector.NativeMemoryBarChart.prototype._updateView):
- * inspector/front-end/ProfileLauncherView.js:
- (WebInspector.ProfileLauncherView):
- * inspector/front-end/nativeMemoryProfiler.css:
- (.memory-bar-chart-name):
- (.memory-bar-chart-bar):
- (.memory-bar-chart-size):
- (.memory-bar-chart-total):
-
-2012-06-18 Mike West <mkwst@chromium.org>
-
- Crash in CSPSource::parseSource
- https://bugs.webkit.org/show_bug.cgi?id=89353
-
- Reviewed by Adam Barth.
-
- Test: http/tests/security/contentSecurityPolicy/source-list-parsing-malformed-meta.html
-
- * page/ContentSecurityPolicy.cpp:
- (WebCore::CSPSourceList::parseSource):
- Checking that we're not past the end of the string before deref.
-
-2012-06-18 Robert Hogan <robert@webkit.org>
-
- CSS 2.1 failure: table-height-algorithm-012 fails
- https://bugs.webkit.org/show_bug.cgi?id=85652
-
- Reviewed by Julien Chaffraix.
-
- Test: css2.1/20110323/table-height-algorithm-012.htm
- fast/css/vertical-align-baseline-rowspan-001.htm
- fast/css/vertical-align-baseline-rowspan-002.htm
- fast/css/vertical-align-baseline-rowspan-003.htm
- fast/css/vertical-align-baseline-rowspan-004.htm
- fast/css/vertical-align-baseline-rowspan-005.htm
- fast/css/vertical-align-baseline-rowspan-006.htm
- fast/css/vertical-align-baseline-rowspan-007.htm
- fast/css/vertical-align-baseline-rowspan-008.htm
- fast/css/vertical-align-baseline-rowspan-009.htm
-
- A spanning cell with Vertical-align set to 'baseline' should align the cell's content baseline
- (which is the bottom of the first line of text or in-flow content) with the baseline of the first of the rows it spans.
-
- * rendering/RenderTableSection.cpp:
- (WebCore::RenderTableSection::calcRowLogicalHeight): Only calculate the baseline for the first row in a rowspan. This
- ensures that any height added to the rowspan from the baseline is only added to the first row in the span rather than
- to each of them.
- (WebCore::RenderTableSection::layoutRows): Rather than get the baseline for each row in a rowspan (with the result that
- only the baseline for the last row actually sticks), calculate it for the first row in the rowspan only. This function is
- inefficient when handling rowspans so this doesn't fix the fact that redundant calculations are performed on each subsequent
- row in the span - that should be done separately.
-
-2012-06-18 Hayato Ito <hayato@chromium.org>
-
- Event dispatcher should use InsertionPoint::hasDistribution instead of InsertinPoint::isActive in re-targeting.
- https://bugs.webkit.org/show_bug.cgi?id=89180
-
- Reviewed by Dimitri Glazkov.
-
- If an event is fired on a fallback element within a insertion
- point which does not select any nodes, the result of event's
- re-targeting will be wrong since it uses
- InsertionPoint::isActive() to judge an existence of a lower boundary.
- That must use InsertionPoint::hasDistribution().
-
- Test: fast/dom/shadow/shadow-dom-event-dispatching.html
-
- * dom/EventDispatcher.cpp:
- (WebCore::EventDispatcher::ensureEventAncestors):
-
-2012-06-18 Tony Payne <tpayne@chromium.org>
-
- [chromium] Add iccjpeg and qcms to chromium port
- https://bugs.webkit.org/show_bug.cgi?id=81974
-
- Reviewed by Adam Barth.
-
- Covered by existing layout tests which will be rebaselined.
-
- * WebCore.gyp/WebCore.gyp: Add qcms to the build.
- * platform/image-decoders/ImageDecoder.h:
- (WebCore::ImageDecoder::qcmsOutputDeviceProfile): Return an sRGB profile.
- On OSX, return the default RGB profile. Add FIXME to use the user's
- monitor profile and verify that profile for other platforms.
-
- * platform/image-decoders/jpeg/JPEGImageDecoder.cpp:
- (turboSwizzled): For libjpeg-turbo, JCS_EXT_BGRA and JCS_EXT_RGBA are the
- two known output color spaces for which the decoder uses a data swizzle.
- (colorSpaceHasAlpha): JPEG's have no alpha in the output color space. For
- libjpeg-turbo, alpha may be present in the swizzled output color space.
-
- (WebCore::JPEGImageReader::JPEGImageReader):
- (WebCore::JPEGImageReader::close):
- (WebCore::JPEGImageReader::decode): For QCMSLIB, create the color transform
- to use during decoding, and ensure we switch to inputing RGBA data to qcms
- even if the desired output data is BGRA: outputScanlines() sends BGRA data
- to the frame buffer following color correction if needed.
- (JPEGImageReader):
- (WebCore::JPEGImageReader::colorTransform): qcms color transform getter.
- (WebCore::JPEGImageReader::createColorTransform): Create color transform.
- Release the existing transform (if any) and assign to the color transform
- created from the color profile data.
- (WebCore::JPEGImageDecoder::outputScanlines): Minor style fix. Apply color
- transform to each decoded image row.
-
- * platform/image-decoders/png/PNGImageDecoder.cpp:
- (WebCore::PNGImageReader::PNGImageReader):
- (WebCore::PNGImageReader::close):
- (WebCore::PNGImageReader::currentBufferSize): Move this adjacent to other
- setters and getters.
- (WebCore::PNGImageReader::decodingSizeOnly): Ditto.
- (WebCore::PNGImageReader::setHasAlpha): Ditto.
- (WebCore::PNGImageReader::hasAlpha): Ditto.
- (WebCore::PNGImageReader::interlaceBuffer): Ditto.
- (WebCore::PNGImageReader::createRowBuffer): Creates a temporary row buffer,
- used when a color transform is applied to the decoded image pixels.
- (WebCore::PNGImageReader::rowBuffer): Return the temporary row buffer.
- (WebCore::PNGImageReader::colorTransform): qcms color transform getter.
- (WebCore::PNGImageReader::createColorTransform): Create color transform.
- Release the existing transform (if any) and assign to the color transform
- created from the color profile data.
- (WebCore::PNGImageDecoder::headerAvailable): For QCMSLIB, create the color
- transform to use for decoding. Clear m_colorProfile (not used anymore).
- (WebCore::PNGImageDecoder::rowAvailable): Create temporary row buffer if
- a color transform is needed for decoding. Apply color transform to each
- decoded image row.
-
- * platform/image-decoders/skia/ImageDecoderSkia.cpp:
- (WebCore::ImageFrame::setColorProfile): Old method of colorProfiles is no
- longer used. Add a FIXME to remove the old implementation.
- (WebCore::ImageFrame::setStatus): Remove old color correction code.
-
-2012-06-18 Dan Bernstein <mitz@apple.com>
-
- Column progression direction cannot be set independently of writing direction
- https://bugs.webkit.org/show_bug.cgi?id=89315
-
- Added a column-progression property, which can have the values 'normal' and 'reverse'. When
- set to 'reverse', the first column is positioned at the end side of the block, and
- subsequent columns go from the in the start direction (in the inline column axis case; in
- the block column axis case, the first column coincides with the block and subsequent columns
- go before the block).
-
- Reviewed by Darin Adler.
-
- Test: fast/multicol/progression-reverse.html
-
- * css/CSSComputedStyleDeclaration.cpp:
- (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): Added handling of the new
- property.
-
- * css/CSSParser.cpp:
- (WebCore::CSSParser::parseValue): Added validity check for the new property. The valid
- values are the identifiers 'normal' and 'reverse'.
- * css/CSSPrimitiveValueMappings.h:
- (WebCore::CSSPrimitiveValue::CSSPrimitiveValue): Added this mapping from ColumnProgression
- enum values to the identifiers 'normal and 'reverse'.
- (WebCore::CSSPrimitiveValue::operator ColumnProgression): Added this mapping from the
- identifiers 'normal' and 'reverse' to ColumnProgression enum values.
- * css/CSSProperty.cpp:
- (WebCore::CSSProperty::isInheritedProperty): Added the new property to the set of
- non-inherited properties.
- * css/CSSPropertyNames.in: Added -webkit-column-progression.
- * css/StyleBuilder.cpp:
- (WebCore::StyleBuilder::StyleBuilder): Added a handler for the new property.
- * rendering/ColumnInfo.h:
- (WebCore::ColumnInfo::ColumnInfo): Added an initializer for the m_progressionIsReversed
- member variable.
- (WebCore::ColumnInfo::progressionIsReversed): Added this accessor.
- (WebCore::ColumnInfo::setProgressionIsReversed): Ditto.
- (ColumnInfo): Added a m_progressionIsReversed member variable.
- * rendering/RenderBlock.cpp:
- (WebCore::RenderBlock::paintColumnRules): Changed to advance in the reverse direction if
- needed.
- (WebCore::RenderBlock::setDesiredColumnCountAndWidth): Added call to
- ColumnInfo::setProgressionIsReversed(), based on the new property.
- (WebCore::RenderBlock::columnRectAt): Changed to take the progression direction into
- account.
- * rendering/style/RenderStyle.h: Added accessors and initial value for column progression.
- * rendering/style/RenderStyleConstants.h: Added ColumnProgression enum.
- * rendering/style/StyleMultiColData.cpp:
- (WebCore::StyleMultiColData::StyleMultiColData): Added initializer for the m_progression
- member variable.
- (WebCore::StyleMultiColData::operator==): Added equality check for m_progression.
- * rendering/style/StyleMultiColData.h:
- (StyleMultiColData): Added m_progression member variable.
-
-2012-06-18 Martin Robinson <mrobinson@igalia.com>
-
- [TextureMapper] Replace the source transform with a flip uniform
- https://bugs.webkit.org/show_bug.cgi?id=89317
-
- Reviewed by Noam Rosenthal.
-
- No new tests. This should not change any observable behavior.
-
- * platform/graphics/texmap/TextureMapperGL.cpp: Instead of building and passing
- the m4src matrix to the shader, just pass a single uniform that says whether or
- not the texture should be flipped.
- * platform/graphics/texmap/TextureMapperShaderManager.cpp: Change the shader programs
- to deal with a flip variable rather than a source matrix.
- (WebCore::TextureMapperShaderProgram::TextureMapperShaderProgram): Instead of getting the location
- of the source matrix, get the location of the flip uniform.
- (WebCore::TextureMapperShaderProgramSimple::TextureMapperShaderProgramSimple): Ditto.
- (WebCore::TextureMapperShaderProgramRectSimple::TextureMapperShaderProgramRectSimple): Ditto.
- (WebCore::TextureMapperShaderProgramOpacityAndMask::TextureMapperShaderProgramOpacityAndMask): Ditto.
- (WebCore::TextureMapperShaderProgramRectOpacityAndMask::TextureMapperShaderProgramRectOpacityAndMask): Ditto.
- * platform/graphics/texmap/TextureMapperShaderManager.h:
- (WebCore::TextureMapperShaderProgram::flipLocation): Added this getter.
- (TextureMapperShaderProgram): Rename the source matrix location member to reflect above changes.
-
-2012-06-18 Sheriff Bot <webkit.review.bot@gmail.com>
-
- Unreviewed, rolling out r120598.
- http://trac.webkit.org/changeset/120598
- https://bugs.webkit.org/show_bug.cgi?id=89359
-
- Patch causes crashes on EFL and GTK release builds (Requested
- by zdobersek on #webkit).
-
- * platform/graphics/Pattern.h:
- (Pattern):
- * platform/graphics/cairo/PlatformContextCairo.cpp:
- (WebCore::PlatformContextCairo::prepareForFilling):
- * platform/graphics/cairo/PlatformContextCairo.h:
-
-2012-06-18 Sheriff Bot <webkit.review.bot@gmail.com>
-
- Unreviewed, rolling out r120592.
- http://trac.webkit.org/changeset/120592
- https://bugs.webkit.org/show_bug.cgi?id=89357
-
- Broke v8 bindings on windows. (Requested by atwilson__ on
- #webkit).
-
- * bindings/js/JSJavaScriptCallFrameCustom.cpp:
- * bindings/js/ScriptDebugServer.cpp:
- * bindings/js/ScriptDebugServer.h:
- (ScriptDebugServer):
- * bindings/v8/DebuggerScript.js:
- (.):
- * bindings/v8/JavaScriptCallFrame.cpp:
- * bindings/v8/JavaScriptCallFrame.h:
- (JavaScriptCallFrame):
- * bindings/v8/ScriptDebugServer.cpp:
- * bindings/v8/ScriptDebugServer.h:
- * bindings/v8/ScriptFunctionCall.cpp:
- (WebCore::ScriptFunctionCall::call):
- * bindings/v8/custom/V8JavaScriptCallFrameCustom.cpp:
- * inspector/InjectedScript.cpp:
- * inspector/InjectedScript.h:
- (InjectedScript):
- * inspector/InjectedScriptSource.js:
- * inspector/Inspector.json:
- * inspector/InspectorDebuggerAgent.cpp:
- (WebCore::InspectorDebuggerAgent::setScriptSource):
- * inspector/InspectorDebuggerAgent.h:
- (InspectorDebuggerAgent):
- * inspector/JavaScriptCallFrame.idl:
-
-2012-06-18 Julien Chaffraix <jchaffraix@webkit.org>
-
- RenderTableSection wastes vector capacity
- https://bugs.webkit.org/show_bug.cgi?id=86561
-
- Reviewed by Antti Koivisto.
-
- Memory optimization, covered by existing tests.
-
- The issue is that addChild calls Vector::grow() which can over-allocate our row grid (especially
- for small tables as we allocate at least 16 entries). As we don't know if addChild is called
- in a loop (e.g. during parsing), we postpone the shrinkToFit call at layout time.
-
- (WebCore::RenderTableSection::layout):
- Added a shrinkToFit call with some explanation as to why it's good trade-off to do it now.
-
-2012-06-18 Takashi Sakamoto <tasak@google.com>
-
- webkit fails IETC border-radius-clip-002
- https://bugs.webkit.org/show_bug.cgi?id=83205
-
- Added addRoundedRectClip instead of just clip when clipToBorderRadius
- is true and bgLayer->clip() == ContentFillBox.
-
- Reviewed by Simon Fraser.
-
- This change is covered by the existing test: ietestcenter/css3/bordersbackgrounds/border-radius-clip-002.
- However expected images should be updated. I updated chromium-linux
- and chromium-mac's expected images and removed chromium-win,
- chromium-mac-leopard and chromium-mac-snowleopard's expected images.
-
- * rendering/RenderBoxModelObject.cpp:
- (WebCore::RenderBoxModelObject::paintFillLayerExtended):
- As the code for "clipping to content boxes as necessary" doesn't
- consider border-radius or not, added the code for checking
- clipToBorderRadius or not, and if so, modified to use
- getBackgroundRoundedRect for obtaining rounded rect and to use
- addRoundedRectClip by using the obtained rounded rect.
-
-2012-06-18 Iain Merrick <husky@google.com>
-
- Allow updateFixedElementsAfterScrolling() to run during layout.
- https://bugs.webkit.org/show_bug.cgi?id=84965
-
- This is needed because HistoryController restores the previous scroll
- position during layout (because we don't want an ugly flash of wrongly-
- scrolled content).
-
- Reviewed by Simon Fraser.
-
- Test: compositing/fixed-position-scroll-offset-history-restore.html
-
- * page/FrameView.cpp:
- (WebCore::FrameView::updateFixedElementsAfterScrolling):
-
-2012-06-18 Alexander Pavlov <apavlov@chromium.org>
-
- CSSOM wrappers are not built for rules in the per-document and page group user stylesheets
- https://bugs.webkit.org/show_bug.cgi?id=89221
-
- Reviewed by Antti Koivisto.
-
- The issue manifested itself by not displaying injected page group stylesheet data in the Styles pane.
-
- Test: inspector/styles/inject-stylesheet.html
-
- * css/StyleResolver.cpp:
- (WebCore::StyleResolver::collectMatchingRulesForList):
-
-2012-06-18 Dominik Röttsches <dominik.rottsches@intel.com>
-
- [cairo] Fix LayoutTests/fast/canvas/patternfill-repeat.html
- https://bugs.webkit.org/show_bug.cgi?id=53085
-
- Reviewed by Martin Robinson.
-
- Clipping previously unlimited vertical and horizontal pattern repeats with
- a clip rectangle similar to the Qt Graphics Context.
-
- No new tests, this patch fixes
- canvas/philip/tests/2d.pattern.paint.repeat* tests.
-
- * platform/graphics/Pattern.h:
- (WebCore::Pattern::getPatternSpaceTransform): Adding constant getter method to be able to map to pattern space externally, needed by PlatformContextCairo::clipForPatternFilling.
- * platform/graphics/cairo/PlatformContextCairo.cpp:
- (WebCore::PlatformContextCairo::prepareForFilling):
- (WebCore::PlatformContextCairo::clipForPatternFilling): Clip pattern repeats if needed.
- * platform/graphics/cairo/PlatformContextCairo.h:
-
-2012-06-18 Robert Kroeger <rjkroege@chromium.org>
-
- Touch events with default actions should be handled.
- https://bugs.webkit.org/show_bug.cgi?id=89304.
-
- Reviewed by Kent Tamura.
-
- Covered by existing tests and tests in blocked bug
- https://bugs.webkit.org/show_bug.cgi?id=88807
-
- * page/EventHandler.cpp:
- (WebCore::EventHandler::handleTouchEvent): Return true that the touch event
- was handled for either preventDefault or defaultHandled.
-
-2012-06-18 Silvia Pfeiffer <silviapf@chromium.org>
-
- REGRESSION introduced in bug 88623: new shadowPseudoId elements need to get default styling.
- https://bugs.webkit.org/show_bug.cgi?id=89280
-
- Reviewed by Eric Carlson.
-
- No new tests; existing tests found this bug.
-
- * css/html.css:
- (input[type="range"]::-webkit-slider-container, input[type="range"]::-webkit-media-slider-container):
- Add -webkit-media-slider-container to the default styling.
- (input[type="range"]::-webkit-slider-thumb, input[type="range"]::-webkit-media-slider-thumb):
- Add -webkit-media-slider-thumb to the default styling.
-
-2012-06-12 Kinuko Yasuda <kinuko@chromium.org>
-
- Support File/DirectoryEntry access for <input type=file> if FileSystem API is enabled
- https://bugs.webkit.org/show_bug.cgi?id=88293
-
- Reviewed by Tony Chang.
-
- Proposal email on whatwg: http://lists.whatwg.org/pipermail/whatwg-whatwg.org/2011-November/033814.html
- Proposal draft: http://wiki.whatwg.org/wiki/DragAndDropEntries
-
- Test: fast/forms/file/input-file-entries.html
-
- * Modules/filesystem/HTMLInputElementFileSystem.cpp: Added.
- * Modules/filesystem/HTMLInputElementFileSystem.h: Added.
- * Modules/filesystem/HTMLInputElementFileSystem.idl: Added.
- * WebCore.gypi:
- * html/FileInputType.cpp:
- (WebCore::FileInputType::receiveDroppedFiles): Retrieves dropped file
- system Id if the given DragData has it.
- (WebCore::FileInputType::droppedFileSystemId): Added. This returns
- dropped file system Id retrieved in receiveDroppedFiles, or an empty
- string if the platform does not support isolated file system for
- dropped files.
- * html/FileInputType.h:
- * html/HTMLInputElement.cpp:
- (WebCore::HTMLInputElement::droppedFileSystemId): Added.
- * html/HTMLInputElement.h:
- * html/InputType.cpp:
- (WebCore::InputType::droppedFileSystemId): Added.
- * html/InputType.h:
- * platform/DragData.cpp:
- * platform/DragData.h:
- * platform/chromium/DragDataChromium.cpp:
- (WebCore::DragData::droppedFileSystemId): Added.
-
-2012-06-18 Peter Rybin <peter.rybin@gmail.com>
-
- Web Inspector: Support 'Restart frame' in protocol and backend
- https://bugs.webkit.org/show_bug.cgi?id=89147
-
- Reviewed by Yury Semikhatsky.
-
- Inspector.json got new command in Debugger domain.
- A call path from InspectorDebuggerAgent to V8 Debug.LiveEdit.RestartFrame API
- is built.
- JSC implementation is a stub with fix me (40300).
-
- * bindings/js/JSJavaScriptCallFrameCustom.cpp:
- (WebCore::JSJavaScriptCallFrame::restart):
- (WebCore):
- * bindings/js/JavaScriptCallFrame.h:
- (JavaScriptCallFrame):
- * bindings/js/ScriptDebugServer.cpp:
- (WebCore):
- (WebCore::ScriptDebugServer::updateCallStack):
- * bindings/js/ScriptDebugServer.h:
- (ScriptDebugServer):
- * bindings/v8/DebuggerScript.js:
- (.):
- * bindings/v8/JavaScriptCallFrame.cpp:
- (WebCore::JavaScriptCallFrame::restart):
- (WebCore):
- * bindings/v8/JavaScriptCallFrame.h:
- (JavaScriptCallFrame):
- * bindings/v8/ScriptDebugServer.cpp:
- (WebCore):
- (WebCore::ScriptDebugServer::updateCallStack):
- * bindings/v8/ScriptDebugServer.h:
- * bindings/v8/ScriptFunctionCall.cpp:
- (WebCore::ScriptFunctionCall::call):
- * bindings/v8/custom/V8JavaScriptCallFrameCustom.cpp:
- (WebCore::V8JavaScriptCallFrame::restartCallback):
- (WebCore):
- * inspector/InjectedScript.cpp:
- (WebCore::InjectedScript::restartFrame):
- (WebCore):
- * inspector/InjectedScript.h:
- (InjectedScript):
- * inspector/InjectedScriptSource.js:
- (.):
- * inspector/Inspector.json:
- * inspector/InspectorDebuggerAgent.cpp:
- (WebCore::InspectorDebuggerAgent::restartFrame):
- * inspector/InspectorDebuggerAgent.h:
- (InspectorDebuggerAgent):
- * inspector/JavaScriptCallFrame.idl:
-
-2012-06-18 Sheriff Bot <webkit.review.bot@gmail.com>
-
- Unreviewed, rolling out r120485 and r120582.
- http://trac.webkit.org/changeset/120485
- http://trac.webkit.org/changeset/120582
- https://bugs.webkit.org/show_bug.cgi?id=89345
-
- chromeos tree breakage (Requested by morrita on #webkit).
-
- * WebCore.gyp/WebCore.gyp:
- * platform/image-decoders/ImageDecoder.h:
- (ImageFrame):
- (ImageDecoder):
- * platform/image-decoders/jpeg/JPEGImageDecoder.cpp:
- (turboSwizzled):
- (WebCore::JPEGImageReader::JPEGImageReader):
- (WebCore::JPEGImageReader::close):
- (WebCore::JPEGImageReader::decode):
- (JPEGImageReader):
- (WebCore::JPEGImageDecoder::outputScanlines):
- * platform/image-decoders/png/PNGImageDecoder.cpp:
- (WebCore::PNGImageReader::PNGImageReader):
- (WebCore::PNGImageReader::close):
- (WebCore::PNGImageReader::currentBufferSize):
- (PNGImageReader):
- (WebCore::PNGImageReader::decodingSizeOnly):
- (WebCore::PNGImageReader::interlaceBuffer):
- (WebCore::PNGImageReader::hasAlpha):
- (WebCore::PNGImageReader::setHasAlpha):
- (WebCore::PNGImageDecoder::headerAvailable):
- (WebCore::PNGImageDecoder::rowAvailable):
- * platform/image-decoders/skia/ImageDecoderSkia.cpp:
- (WebCore):
- (WebCore::resolveColorSpace):
- (WebCore::createColorSpace):
- (WebCore::ImageFrame::setColorProfile):
- (WebCore::ImageFrame::setStatus):
-
-2012-06-18 Alexei Filippov <alexeif@chromium.org>
-
- Web Inspector: Add heap profiler owned memory to the pie chart
- https://bugs.webkit.org/show_bug.cgi?id=89203
-
- Heap profiler may consume considerable amount of memory
- which is currently falls into Unknown category.
- Give it a separate sector on the pie chart.
-
- Reviewed by Yury Semikhatsky.
-
- * bindings/js/ScriptProfiler.h:
- (WebCore::ScriptProfiler::profilerSnapshotsSize):
- * bindings/v8/ScriptProfiler.cpp:
- (WebCore::ScriptProfiler::profilerSnapshotsSize):
- (WebCore):
- * bindings/v8/ScriptProfiler.h:
- (ScriptProfiler):
- * inspector/InspectorMemoryAgent.cpp:
- (MemoryBlockName):
- (WebCore):
- (WebCore::inspectorData):
- (WebCore::InspectorMemoryAgent::getProcessMemoryDistribution):
- * inspector/front-end/NativeMemorySnapshotView.js:
- (WebInspector.MemoryBlockViewProperties._initialize):
-
-2012-06-18 Mario Sanchez Prada <msanchez@igalia.com>
-
- [GTK] Get rid of DumpRenderTreeSupportGtk::{in|de}crementAccessibilityValue
- https://bugs.webkit.org/show_bug.cgi?id=89226
-
- Reviewed by Martin Robinson.
-
- Implement webkitAccessibleValueGetMinimumIncrement() properly,
- doing something similar to what is done in AccessibilityObject's
- increment() and decrement() functions.
-
- Also, added missing bits to webkitAccessibleValueSetCurrentValue
- to make sure we check the new value against range limits.
-
- * accessibility/gtk/WebKitAccessibleInterfaceValue.cpp:
- (webkitAccessibleValueGetCurrentValue):
- (webkitAccessibleValueGetMaximumValue):
- (webkitAccessibleValueGetMinimumValue):
- (webkitAccessibleValueSetCurrentValue):
- (webkitAccessibleValueGetMinimumIncrement):
-
-2012-06-14 Kinuko Yasuda <kinuko@chromium.org>
-
- [chromium] Cleanup: remove PlatformSupport::createAsyncFileSystem as it's no longer used
- https://bugs.webkit.org/show_bug.cgi?id=89083
-
- Reviewed by Kentaro Hara.
-
- No new tests as this has no functional changes.
-
- * platform/chromium/PlatformSupport.h:
- (PlatformSupport):
-
-2012-06-18 Taiju Tsuiki <tzik@chromium.org>
-
- Fix syntax of FileReader::readAsDataURL result
- https://bugs.webkit.org/show_bug.cgi?id=89330
-
- When readAsDataURL generates data URL without media type, it used to omit semicolon before
- "base64" keyword. But this semicolor is required in this case, according to RFC2397.
-
- Reviewed by Kent Tamura.
-
- Test: fast/files/read-blob-async.html
- fast/files/workers/worker-read-blob-async.html:
- fast/files/workers/worker-read-blob-sync.html:
-
- * fileapi/FileReaderLoader.cpp:
- (WebCore::FileReaderLoader::convertToDataURL):
-
-2012-06-18 MORITA Hajime <morrita@google.com>
-
- Unreviewed chormium crash fix. This should be revisited.
-
- * platform/image-decoders/ImageDecoder.h:
- (WebCore::ImageDecoder::qcmsOutputDeviceProfile):
-
-2012-06-18 Christophe Dumez <christophe.dumez@intel.com>
-
- [EFL] fast/files/xhr-response-blob.html is crashing
- https://bugs.webkit.org/show_bug.cgi?id=89334
-
- Reviewed by Kentaro Hara.
-
- Call wrap() instead of createWrapper() in JSBlob's toJS()
- to avoid hitting the !getCachedWrapper ASSERT in
- createWrapper() because we fail to use the cached wrapper.
-
- Test: fast/files/xhr-response-blob.html
-
- * bindings/js/JSBlobCustom.cpp:
- (WebCore::toJS):
-
-2012-06-18 Ilya Tikhonovsky <loislo@chromium.org>
-
- Web Inspector: rename Unknown to Other in Native heap snapshot.
- https://bugs.webkit.org/show_bug.cgi?id=89306
-
- Cosmetic change.
-
- Reviewed by Yury Semikhatsky.
-
- * inspector/front-end/NativeMemorySnapshotView.js:
- (WebInspector.NativeMemoryProfileType.prototype.buttonClicked.didReceiveMemorySnapshot):
- (WebInspector.NativeMemoryProfileType.prototype.buttonClicked):
- (WebInspector.MemoryBlockViewProperties._initialize):
-
-2012-06-18 Sergio Villar Senin <svillar@igalia.com>
-
- TextureMapperLayer: invisible layers do not let their children to be painted
- https://bugs.webkit.org/show_bug.cgi?id=88786
-
- Reviewed by Noam Rosenthal.
-
- Do not early discard recursively painting children layers if the
- current layer is not visible.
-
- Changes already covered by compositing tests. This fixes both
- compositing/backface-visibility/backface-visibility-3d.html and
- compositing/backface-visibility/backface-visibility-non3d.html.
-
- * platform/graphics/texmap/TextureMapperLayer.cpp:
- (WebCore::TextureMapperLayer::computeTransformsRecursive):
- (WebCore::TextureMapperLayer::paintSelf):
- (WebCore::TextureMapperLayer::isVisible):
-
-2012-06-15 Kinuko Yasuda <kinuko@chromium.org>
-
- XHR_RESPONSE_BLOB is not enabled on some platforms
- https://bugs.webkit.org/show_bug.cgi?id=88859
-
- Reviewed by Adam Barth.
-
- Removing XHR_RESPONSE_BLOB since the current implementation has
- no platform-specific part.
-
- Test: http/tests/xmlhttprequest/blob-response-size.html
-
- * bindings/generic/RuntimeEnabledFeatures.cpp:
- (WebCore):
- * bindings/generic/RuntimeEnabledFeatures.h:
- (RuntimeEnabledFeatures):
- * bindings/js/JSXMLHttpRequestCustom.cpp:
- (WebCore::JSXMLHttpRequest::visitChildren):
- (WebCore::JSXMLHttpRequest::response):
- * bindings/v8/custom/V8XMLHttpRequestCustom.cpp:
- (WebCore::V8XMLHttpRequest::responseAccessorGetter):
- * platform/chromium/PlatformSupport.h:
- (PlatformSupport):
- * xml/XMLHttpRequest.cpp:
- (WebCore::XMLHttpRequest::responseBlob):
- (WebCore::XMLHttpRequest::setResponseType):
- (WebCore::XMLHttpRequest::clearResponseBuffers):
- (WebCore::XMLHttpRequest::didReceiveData):
- * xml/XMLHttpRequest.h:
- (XMLHttpRequest):
- * xml/XMLHttpRequest.idl:
-
-2012-06-17 Martin Robinson <mrobinson@igalia.com>
-
- [TextureMapper] Reduce boilerplate code in the TextureMapperShaderManager
- https://bugs.webkit.org/show_bug.cgi?id=89293
-
- Reviewed by Noam Rosenthal.
-
- Refactor TextureMapperShaderManager to reduce boilerplate code, by:
- 1. Making fragment and shader source arguments to the superclass constructor.
- 2. Removing virtual methods (which should not be called in constructors) with
- constructor implementations. This exchanges a small amount of code duplication
- for a lot less boilerplate.
- 3. Standardizing on the fooLocation name instead of fooVariable.
- 4. Removing the ::prepare() series of methods for non-filter shaders. It's betters to
- have all the uniform and attribute binding in the same place.
-
- No new tests. This is just a refactor and shouldn't change any functionality.
-
- * platform/graphics/texmap/TextureMapperGL.cpp:
- Handle binding the mask texture and opacity at both of the previous ::prepare callsites. Also
- rename "shaderInfo" to "program".
- * platform/graphics/texmap/TextureMapperShaderManager.cpp: Perform the refactoring described above.
- * platform/graphics/texmap/TextureMapperShaderManager.h: Ditto.
-
-2012-06-17 Gregg Tavares <gman@google.com>
-
- Fix Framebuffer restrictions
- https://bugs.webkit.org/show_bug.cgi?id=89320
-
- Reviewed by Kenneth Russell.
-
- No new tests, just fixing old ones
-
- * html/canvas/WebGLFramebuffer.cpp:
- (WebCore::WebGLFramebuffer::checkStatus):
-
-2012-06-17 Yoshifumi Inoue <yosin@chromium.org>
-
- [Forms] Move search field related code to RenderSearchField from RenderTextControlSingleLine
- https://bugs.webkit.org/show_bug.cgi?id=88980
-
- Reviewed by Kent Tamura.
-
- This patch moves search field related methods in RenderTextControlSingleLine
- to new class RenderSearchField and changes related classes to use
- RenderSearchField.
-
- No new tests. This patch doesn't change behavior.
-
- * CMakeLists.txt: Added new file RenderSearchField.cpp
- * GNUmakefile.list.am: Added new file RenderSearchField.cpp and RenderSearchField.h
- * Target.pri: ditto
- * WebCore.gypi: ditto
- * WebCore.vcproj/WebCore.vcproj: ditto
- * WebCore.xcodeproj/project.pbxproj: ditto
- * html/HTMLInputElement.cpp:
- (WebCore::HTMLInputElement::subtreeHasChanged): Call RenderSearchField::updateCancelButtonVisibility
- (WebCore::HTMLInputElement::addSearchResult): Changed to call InputType::addSearchResult.
- * html/InputType.cpp:
- (WebCore::InputType::addSearchResult): Added.
- * html/InputType.h:
- * html/SearchInputType.cpp:
- (WebCore::SearchInputType::addSearchResult): Moved from HTMLInputElement.
- (WebCore::SearchInputType::createRenderer): Added to create RenderSearchField.
- (WebCore::SearchInputType::searchEventsShouldBeDispatched): Moved from HTMLInputElement.
- (WebCore::SearchInputType::subtreeHasChanged) Moved search related code from HTMLInputElement.
- * html/SearchInputType.h:
- * html/shadow/TextControlInnerElements.cpp:
- (WebCore::SearchFieldResultsButtonElement::defaultEventHandler): Use RenderSearchField instead of RenderTextControlSingleLine.
- * loader/FormSubmission.cpp:
- (WebCore::FormSubmission::create): Got rid isSearchField() guard for addSearchResult().
- * rendering/RenderSearchField.cpp:
- (WebCore::RenderSearchField::RenderSearchField): Renamed to RenderSearchField.
- (WebCore::RenderSearchField::~RenderSearchField): ditto
- (WebCore::RenderSearchField::resultsButtonElement): ditto
- (WebCore::RenderSearchField::cancelButtonElement): ditto
- (WebCore::RenderSearchField::addSearchResult): ditto
- (WebCore::RenderSearchField::showPopup): ditto
- (WebCore::RenderSearchField::hidePopup): ditto
- (WebCore::RenderSearchField::computeControlHeight): Added.
- (WebCore::RenderSearchField::updateFromElement): Moved search field related code from RenderTextControlSingleLine.
- (WebCore::RenderSearchField::updateCancelButtonVisibility): Renamed to RenderSearchField.
- (WebCore::RenderSearchField::visibilityForCancelButton): ditto
- (WebCore::RenderSearchField::autosaveName): ditto
- (WebCore::RenderSearchField::valueChanged): ditto
- (WebCore::RenderSearchField::itemText): ditto
- (WebCore::RenderSearchField::itemLabel): ditto
- (WebCore::RenderSearchField::itemIcon): ditto
- (WebCore::RenderSearchField::itemIsEnabled): ditto
- (WebCore::RenderSearchField::itemStyle): ditto
- (WebCore::RenderSearchField::menuStyle): ditto
- (WebCore::RenderSearchField::clientInsetLeft): ditto
- (WebCore::RenderSearchField::clientInsetRight): ditto
- (WebCore::RenderSearchField::clientPaddingLeft): ditto
- (WebCore::RenderSearchField::clientPaddingRight): ditto
- (WebCore::RenderSearchField::listSize): ditto
- (WebCore::RenderSearchField::selectedIndex): ditto
- (WebCore::RenderSearchField::popupDidHide): ditto
- (WebCore::RenderSearchField::itemIsSeparator): ditto
- (WebCore::RenderSearchField::itemIsLabel): ditto
- (WebCore::RenderSearchField::itemIsSelected): ditto
- (WebCore::RenderSearchField::setTextFromItem): ditto
- (WebCore::RenderSearchField::fontSelector): ditto
- (WebCore::RenderSearchField::hostWindow): ditto
- (WebCore::RenderSearchField::createScrollbar): ditto
- (WebCore::RenderSearchField::computeHeightLimit): Added.
- (WebCore::RenderSearchField::centerContainerIfNeeded): Added.
- * rendering/RenderSearchField.h:
- (WebCore::toRenderSearchField): Added.
- * rendering/RenderTextControlSingleLine.cpp:
- (WebCore::RenderTextControlSingleLine::RenderTextControlSingleLine): Remove search field related code.
- (WebCore::RenderTextControlSingleLine::~RenderTextControlSingleLine): ditto.
- (WebCore::RenderTextControlSingleLine::computeHeightLimit): Added.
- (WebCore::RenderTextControlSingleLine::layout): Use new methods for removing isSearchField.
- (WebCore::RenderTextControlSingleLine::computeControlHeight): Added.
- (WebCore::RenderTextControlSingleLine::updateFromElement): Remove search field related code.
- * rendering/RenderTextControlSingleLine.h:
- (RenderTextControlSingleLine):
- (WebCore::RenderTextControlSingleLine::centerContainerIfNeeded): Added.
- (WebCore::RenderTextControlSingleLine::containerElement): Exposed for RenderSearchField.
- (WebCore::RenderTextControlSingleLine::innerBlockElement): Exposed for RenderSearchField.
- * rendering/RenderingAllInOne.cpp: Added RenderSearchField.cpp
-
-2012-06-17 Yoshifumi Inoue <yosin@chromium.org>
-
- [Forms] Copy RenderTextControlSingleLine.{cpp,h} to RenderSearchFiled.{cpp,h}
- https://bugs.webkit.org/show_bug.cgi?id=89155
-
- This patch copies RenderTextControlSingleLine.cpp and .h into RenderSearchField.cpp
- and .h with just "cp" code. New files aren't compiled until bug 88980.
-
- No new tests. This patch doesn't change behavior.
-
- * rendering/RenderSearchField.cpp: Added.
- (WebCore):
- (WebCore::RenderTextControlInnerBlock::positionForPoint):
- (WebCore::RenderTextControlSingleLine::RenderTextControlSingleLine):
- (WebCore::RenderTextControlSingleLine::~RenderTextControlSingleLine):
- (WebCore::RenderTextControlSingleLine::containerElement):
- (WebCore::RenderTextControlSingleLine::innerBlockElement):
- (WebCore::RenderTextControlSingleLine::innerSpinButtonElement):
- (WebCore::RenderTextControlSingleLine::resultsButtonElement):
- (WebCore::RenderTextControlSingleLine::cancelButtonElement):
- (WebCore::RenderTextControlSingleLine::textBaseStyle):
- (WebCore::RenderTextControlSingleLine::addSearchResult):
- (WebCore::RenderTextControlSingleLine::showPopup):
- (WebCore::RenderTextControlSingleLine::hidePopup):
- (WebCore::RenderTextControlSingleLine::paint):
- (WebCore::RenderTextControlSingleLine::layout):
- (WebCore::RenderTextControlSingleLine::nodeAtPoint):
- (WebCore::RenderTextControlSingleLine::styleDidChange):
- (WebCore::RenderTextControlSingleLine::capsLockStateMayHaveChanged):
- (WebCore::RenderTextControlSingleLine::hasControlClip):
- (WebCore::RenderTextControlSingleLine::controlClipRect):
- (WebCore::RenderTextControlSingleLine::getAvgCharWidth):
- (WebCore::RenderTextControlSingleLine::preferredContentWidth):
- (WebCore::RenderTextControlSingleLine::computeControlHeight):
- (WebCore::RenderTextControlSingleLine::updateFromElement):
- (WebCore::RenderTextControlSingleLine::createInnerTextStyle):
- (WebCore::RenderTextControlSingleLine::createInnerBlockStyle):
- (WebCore::RenderTextControlSingleLine::updateCancelButtonVisibility):
- (WebCore::RenderTextControlSingleLine::visibilityForCancelButton):
- (WebCore::RenderTextControlSingleLine::textShouldBeTruncated):
- (WebCore::RenderTextControlSingleLine::autosaveName):
- (WebCore::RenderTextControlSingleLine::valueChanged):
- (WebCore::RenderTextControlSingleLine::itemText):
- (WebCore::RenderTextControlSingleLine::itemLabel):
- (WebCore::RenderTextControlSingleLine::itemIcon):
- (WebCore::RenderTextControlSingleLine::itemIsEnabled):
- (WebCore::RenderTextControlSingleLine::itemStyle):
- (WebCore::RenderTextControlSingleLine::menuStyle):
- (WebCore::RenderTextControlSingleLine::clientInsetLeft):
- (WebCore::RenderTextControlSingleLine::clientInsetRight):
- (WebCore::RenderTextControlSingleLine::clientPaddingLeft):
- (WebCore::RenderTextControlSingleLine::clientPaddingRight):
- (WebCore::RenderTextControlSingleLine::listSize):
- (WebCore::RenderTextControlSingleLine::selectedIndex):
- (WebCore::RenderTextControlSingleLine::popupDidHide):
- (WebCore::RenderTextControlSingleLine::itemIsSeparator):
- (WebCore::RenderTextControlSingleLine::itemIsLabel):
- (WebCore::RenderTextControlSingleLine::itemIsSelected):
- (WebCore::RenderTextControlSingleLine::setTextFromItem):
- (WebCore::RenderTextControlSingleLine::fontSelector):
- (WebCore::RenderTextControlSingleLine::hostWindow):
- (WebCore::RenderTextControlSingleLine::autoscroll):
- (WebCore::RenderTextControlSingleLine::scrollWidth):
- (WebCore::RenderTextControlSingleLine::scrollHeight):
- (WebCore::RenderTextControlSingleLine::scrollLeft):
- (WebCore::RenderTextControlSingleLine::scrollTop):
- (WebCore::RenderTextControlSingleLine::setScrollLeft):
- (WebCore::RenderTextControlSingleLine::setScrollTop):
- (WebCore::RenderTextControlSingleLine::scroll):
- (WebCore::RenderTextControlSingleLine::logicalScroll):
- (WebCore::RenderTextControlSingleLine::createScrollbar):
- (WebCore::RenderTextControlSingleLine::inputElement):
- * rendering/RenderSearchField.h: Added.
- (WebCore):
- (RenderTextControlSingleLine):
- (WebCore::RenderTextControlSingleLine::popupIsVisible):
- (WebCore::RenderTextControlSingleLine::isTextField):
- (WebCore::toRenderTextControlSingleLine):
- (RenderTextControlInnerBlock):
- (WebCore::RenderTextControlInnerBlock::RenderTextControlInnerBlock):
- (WebCore::RenderTextControlInnerBlock::hasLineIfEmpty):
-
-2012-06-17 Yoshifumi Inoue <yosin@chromium.org>
-
- Unreviewed, rolling out r120565.
- http://trac.webkit.org/changeset/120565
- https://bugs.webkit.org/show_bug.cgi?id=89155
-
- Bad commit message
-
- * rendering/RenderSearchField.cpp: Removed.
- * rendering/RenderSearchField.h: Removed.
-
-2012-06-17 Yoshifumi Inoue <yosin@chromium.org>
-
- [Forms] Copy RenderTextControlSingleLine.{cpp,h} to RenderSearchFiled.{cpp,h}
- https://bugs.webkit.org/show_bug.cgi?id=89155
-
- This patch copies RenderTextControlSingleLine.cpp and .h into RenderSearchField.cpp
- and .h with just "cp" code. New files aren't compiled until bug 88980.
-
- No new tests. This patch doesn't change behavior.
-
- * rendering/RenderSearchField.cpp: Added.
- (WebCore):
- (WebCore::RenderTextControlInnerBlock::positionForPoint):
- (WebCore::RenderTextControlSingleLine::RenderTextControlSingleLine):
- (WebCore::RenderTextControlSingleLine::~RenderTextControlSingleLine):
- (WebCore::RenderTextControlSingleLine::containerElement):
- (WebCore::RenderTextControlSingleLine::innerBlockElement):
- (WebCore::RenderTextControlSingleLine::innerSpinButtonElement):
- (WebCore::RenderTextControlSingleLine::resultsButtonElement):
- (WebCore::RenderTextControlSingleLine::cancelButtonElement):
- (WebCore::RenderTextControlSingleLine::textBaseStyle):
- (WebCore::RenderTextControlSingleLine::addSearchResult):
- (WebCore::RenderTextControlSingleLine::showPopup):
- (WebCore::RenderTextControlSingleLine::hidePopup):
- (WebCore::RenderTextControlSingleLine::paint):
- (WebCore::RenderTextControlSingleLine::layout):
- (WebCore::RenderTextControlSingleLine::nodeAtPoint):
- (WebCore::RenderTextControlSingleLine::styleDidChange):
- (WebCore::RenderTextControlSingleLine::capsLockStateMayHaveChanged):
- (WebCore::RenderTextControlSingleLine::hasControlClip):
- (WebCore::RenderTextControlSingleLine::controlClipRect):
- (WebCore::RenderTextControlSingleLine::getAvgCharWidth):
- (WebCore::RenderTextControlSingleLine::preferredContentWidth):
- (WebCore::RenderTextControlSingleLine::computeControlHeight):
- (WebCore::RenderTextControlSingleLine::updateFromElement):
- (WebCore::RenderTextControlSingleLine::createInnerTextStyle):
- (WebCore::RenderTextControlSingleLine::createInnerBlockStyle):
- (WebCore::RenderTextControlSingleLine::updateCancelButtonVisibility):
- (WebCore::RenderTextControlSingleLine::visibilityForCancelButton):
- (WebCore::RenderTextControlSingleLine::textShouldBeTruncated):
- (WebCore::RenderTextControlSingleLine::autosaveName):
- (WebCore::RenderTextControlSingleLine::valueChanged):
- (WebCore::RenderTextControlSingleLine::itemText):
- (WebCore::RenderTextControlSingleLine::itemLabel):
- (WebCore::RenderTextControlSingleLine::itemIcon):
- (WebCore::RenderTextControlSingleLine::itemIsEnabled):
- (WebCore::RenderTextControlSingleLine::itemStyle):
- (WebCore::RenderTextControlSingleLine::menuStyle):
- (WebCore::RenderTextControlSingleLine::clientInsetLeft):
- (WebCore::RenderTextControlSingleLine::clientInsetRight):
- (WebCore::RenderTextControlSingleLine::clientPaddingLeft):
- (WebCore::RenderTextControlSingleLine::clientPaddingRight):
- (WebCore::RenderTextControlSingleLine::listSize):
- (WebCore::RenderTextControlSingleLine::selectedIndex):
- (WebCore::RenderTextControlSingleLine::popupDidHide):
- (WebCore::RenderTextControlSingleLine::itemIsSeparator):
- (WebCore::RenderTextControlSingleLine::itemIsLabel):
- (WebCore::RenderTextControlSingleLine::itemIsSelected):
- (WebCore::RenderTextControlSingleLine::setTextFromItem):
- (WebCore::RenderTextControlSingleLine::fontSelector):
- (WebCore::RenderTextControlSingleLine::hostWindow):
- (WebCore::RenderTextControlSingleLine::autoscroll):
- (WebCore::RenderTextControlSingleLine::scrollWidth):
- (WebCore::RenderTextControlSingleLine::scrollHeight):
- (WebCore::RenderTextControlSingleLine::scrollLeft):
- (WebCore::RenderTextControlSingleLine::scrollTop):
- (WebCore::RenderTextControlSingleLine::setScrollLeft):
- (WebCore::RenderTextControlSingleLine::setScrollTop):
- (WebCore::RenderTextControlSingleLine::scroll):
- (WebCore::RenderTextControlSingleLine::logicalScroll):
- (WebCore::RenderTextControlSingleLine::createScrollbar):
- (WebCore::RenderTextControlSingleLine::inputElement):
- * rendering/RenderSearchField.h: Added.
- (WebCore):
- (RenderTextControlSingleLine):
- (WebCore::RenderTextControlSingleLine::popupIsVisible):
- (WebCore::RenderTextControlSingleLine::isTextField):
- (WebCore::toRenderTextControlSingleLine):
- (RenderTextControlInnerBlock):
- (WebCore::RenderTextControlInnerBlock::RenderTextControlInnerBlock):
- (WebCore::RenderTextControlInnerBlock::hasLineIfEmpty):
-
-2012-06-17 MORITA Hajime <morrita@google.com>
-
- Unreviewed build fix.
-
- * platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
- (WebCore::CCLayerTreeHostImpl::removePassesWithCachedTextures):
-
-2012-06-17 Philippe Normand <pnormand@igalia.com>
-
- [GStreamer] optimize ::naturalSize()
- https://bugs.webkit.org/show_bug.cgi?id=89314
-
- Reviewed by Martin Robinson.
-
- Keep track of the video-sink sinkpad in the MediaPlayerPrivate and
- adapt the webkitGstGetPadCaps API accordingly. The benefit of this
- change is to reduce the number of calls to
- gst_element_get_static_pad() and the corresponding gst_pad_unref().
-
- * platform/graphics/gstreamer/GStreamerVersioning.cpp:
- (webkitGstGetPadCaps):
- * platform/graphics/gstreamer/GStreamerVersioning.h:
- * platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
- (WebCore::MediaPlayerPrivateGStreamer::naturalSize):
- * platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:
- (MediaPlayerPrivateGStreamer):
-
-2012-06-17 Arvid Nilsson <anilsson@rim.com>
-
- Don't mark main frame layer opaque if the frame view is transparent
- https://bugs.webkit.org/show_bug.cgi?id=88234
-
- Reviewed by Simon Fraser.
-
- * rendering/RenderLayerBacking.cpp:
- (WebCore::RenderLayerBacking::createPrimaryGraphicsLayer):
-
-2012-06-17 Philip Rogers <pdr@google.com>
-
- Prevent crash in SVGDocumentExtensions::removeAllElementReferencesForTarget.
- https://bugs.webkit.org/show_bug.cgi?id=88144
-
- Reviewed by Abhishek Arya.
-
- When iterating over referencing elements to rebuild after a reference change in
- SVGDocumentExtensions::removeAllElementReferencesForTarget, we can
- modify the underlying toBeNotified vector, invalidating it. This change checks
- that a vector element is valid before rebuilding, preventing a crash.
-
- Some definitions from SVGDocumentExtensions that may put this patch in context:
- An example of a "referenced elements" is a <path>.
- An example of a "referencing element" is a <textPath href='some_path_id'>.
- m_elementDependencies is a map from referenced elements (e.g., paths) to
- a set of referencing elements (e.g., textPaths).
-
- The check that the vector element is valid relies on checking if the referencing
- element is in m_elementDependencies. This check is allowed because in the
- destructor of SVGTextPathElement (and SVGFeImageElement),
- removeAllTargetReferencesForElement() is called, removing the referencing element
- from m_elementDependencies.
-
- Simply checking if the referencing element is anywhere in m_elementDependencies
- is enough to show it is valid, but that requires iterating over all referenced
- elements to see if the given referencing element is present. This change
- only checks if the textPath is still in the elements referencing the
- path being removed, and only removes the referenced element from
- m_elementDependencies after forcing the referencing elements to be rebuilt.
-
- Test: svg/text/textpath-reference-crash.html
-
- * svg/SVGDocumentExtensions.cpp:
- (WebCore::SVGDocumentExtensions::removeAllElementReferencesForTarget):
-
-2012-06-17 Yoshifumi Inoue <yosin@chromium.org>
-
- Unreviewed, rolling out r120390.
- http://trac.webkit.org/changeset/120390
- https://bugs.webkit.org/show_bug.cgi?id=89155
-
- Failed to copy merge history to RenderSerachField.{cpp,h}
-
- * rendering/RenderSearchField.cpp: Removed.
- * rendering/RenderSearchField.h: Removed.
-
-2012-06-17 Yoshifumi Inoue <yosin@chromium.org>
-
- Unreviewed, rolling out r120432.
- http://trac.webkit.org/changeset/120432
- https://bugs.webkit.org/show_bug.cgi?id=88980
-
- Failed to copy merge history to RenderSerachField.{cpp,h}
-
- * CMakeLists.txt:
- * GNUmakefile.list.am:
- * Target.pri:
- * WebCore.gypi:
- * WebCore.vcproj/WebCore.vcproj:
- * WebCore.xcodeproj/project.pbxproj:
- * html/HTMLInputElement.cpp:
- (WebCore::HTMLInputElement::subtreeHasChanged):
- (WebCore::HTMLInputElement::searchEventsShouldBeDispatched):
- (WebCore):
- (WebCore::HTMLInputElement::addSearchResult):
- * html/HTMLInputElement.h:
- (HTMLInputElement):
- * html/InputType.cpp:
- * html/InputType.h:
- (InputType):
- * html/SearchInputType.cpp:
- * html/SearchInputType.h:
- (SearchInputType):
- * html/shadow/TextControlInnerElements.cpp:
- (WebCore::SearchFieldResultsButtonElement::defaultEventHandler):
- * loader/FormSubmission.cpp:
- (WebCore::FormSubmission::create):
- * rendering/RenderSearchField.cpp:
- (WebCore::RenderTextControlInnerBlock::positionForPoint):
- (WebCore):
- (WebCore::RenderTextControlSingleLine::RenderTextControlSingleLine):
- (WebCore::RenderTextControlSingleLine::~RenderTextControlSingleLine):
- (WebCore::RenderTextControlSingleLine::containerElement):
- (WebCore::RenderTextControlSingleLine::innerBlockElement):
- (WebCore::RenderTextControlSingleLine::innerSpinButtonElement):
- (WebCore::RenderTextControlSingleLine::resultsButtonElement):
- (WebCore::RenderTextControlSingleLine::cancelButtonElement):
- (WebCore::RenderTextControlSingleLine::textBaseStyle):
- (WebCore::RenderTextControlSingleLine::addSearchResult):
- (WebCore::RenderTextControlSingleLine::showPopup):
- (WebCore::RenderTextControlSingleLine::hidePopup):
- (WebCore::RenderTextControlSingleLine::paint):
- (WebCore::RenderTextControlSingleLine::layout):
- (WebCore::RenderTextControlSingleLine::nodeAtPoint):
- (WebCore::RenderTextControlSingleLine::styleDidChange):
- (WebCore::RenderTextControlSingleLine::capsLockStateMayHaveChanged):
- (WebCore::RenderTextControlSingleLine::hasControlClip):
- (WebCore::RenderTextControlSingleLine::controlClipRect):
- (WebCore::RenderTextControlSingleLine::getAvgCharWidth):
- (WebCore::RenderTextControlSingleLine::preferredContentWidth):
- (WebCore::RenderTextControlSingleLine::computeControlHeight):
- (WebCore::RenderTextControlSingleLine::updateFromElement):
- (WebCore::RenderTextControlSingleLine::createInnerTextStyle):
- (WebCore::RenderTextControlSingleLine::createInnerBlockStyle):
- (WebCore::RenderTextControlSingleLine::updateCancelButtonVisibility):
- (WebCore::RenderTextControlSingleLine::visibilityForCancelButton):
- (WebCore::RenderTextControlSingleLine::textShouldBeTruncated):
- (WebCore::RenderTextControlSingleLine::autosaveName):
- (WebCore::RenderTextControlSingleLine::valueChanged):
- (WebCore::RenderTextControlSingleLine::itemText):
- (WebCore::RenderTextControlSingleLine::itemLabel):
- (WebCore::RenderTextControlSingleLine::itemIcon):
- (WebCore::RenderTextControlSingleLine::itemIsEnabled):
- (WebCore::RenderTextControlSingleLine::itemStyle):
- (WebCore::RenderTextControlSingleLine::menuStyle):
- (WebCore::RenderTextControlSingleLine::clientInsetLeft):
- (WebCore::RenderTextControlSingleLine::clientInsetRight):
- (WebCore::RenderTextControlSingleLine::clientPaddingLeft):
- (WebCore::RenderTextControlSingleLine::clientPaddingRight):
- (WebCore::RenderTextControlSingleLine::listSize):
- (WebCore::RenderTextControlSingleLine::selectedIndex):
- (WebCore::RenderTextControlSingleLine::popupDidHide):
- (WebCore::RenderTextControlSingleLine::itemIsSeparator):
- (WebCore::RenderTextControlSingleLine::itemIsLabel):
- (WebCore::RenderTextControlSingleLine::itemIsSelected):
- (WebCore::RenderTextControlSingleLine::setTextFromItem):
- (WebCore::RenderTextControlSingleLine::fontSelector):
- (WebCore::RenderTextControlSingleLine::hostWindow):
- (WebCore::RenderTextControlSingleLine::autoscroll):
- (WebCore::RenderTextControlSingleLine::scrollWidth):
- (WebCore::RenderTextControlSingleLine::scrollHeight):
- (WebCore::RenderTextControlSingleLine::scrollLeft):
- (WebCore::RenderTextControlSingleLine::scrollTop):
- (WebCore::RenderTextControlSingleLine::setScrollLeft):
- (WebCore::RenderTextControlSingleLine::setScrollTop):
- (WebCore::RenderTextControlSingleLine::scroll):
- (WebCore::RenderTextControlSingleLine::logicalScroll):
- (WebCore::RenderTextControlSingleLine::createScrollbar):
- (WebCore::RenderTextControlSingleLine::inputElement):
- * rendering/RenderSearchField.h:
- (RenderTextControlSingleLine):
- (WebCore::RenderTextControlSingleLine::isTextField):
- (WebCore::toRenderTextControlSingleLine):
- (WebCore):
- (RenderTextControlInnerBlock):
- (WebCore::RenderTextControlInnerBlock::RenderTextControlInnerBlock):
- (WebCore::RenderTextControlInnerBlock::hasLineIfEmpty):
- * rendering/RenderTextControlSingleLine.cpp:
- (WebCore::RenderTextControlSingleLine::RenderTextControlSingleLine):
- (WebCore::RenderTextControlSingleLine::~RenderTextControlSingleLine):
- (WebCore):
- (WebCore::RenderTextControlSingleLine::containerElement):
- (WebCore::RenderTextControlSingleLine::innerBlockElement):
- (WebCore::RenderTextControlSingleLine::resultsButtonElement):
- (WebCore::RenderTextControlSingleLine::cancelButtonElement):
- (WebCore::RenderTextControlSingleLine::addSearchResult):
- (WebCore::RenderTextControlSingleLine::showPopup):
- (WebCore::RenderTextControlSingleLine::hidePopup):
- (WebCore::RenderTextControlSingleLine::layout):
- (WebCore::RenderTextControlSingleLine::computeControlHeight):
- (WebCore::RenderTextControlSingleLine::updateFromElement):
- (WebCore::RenderTextControlSingleLine::updateCancelButtonVisibility):
- (WebCore::RenderTextControlSingleLine::visibilityForCancelButton):
- (WebCore::RenderTextControlSingleLine::autosaveName):
- (WebCore::RenderTextControlSingleLine::valueChanged):
- (WebCore::RenderTextControlSingleLine::itemText):
- (WebCore::RenderTextControlSingleLine::itemLabel):
- (WebCore::RenderTextControlSingleLine::itemIcon):
- (WebCore::RenderTextControlSingleLine::itemIsEnabled):
- (WebCore::RenderTextControlSingleLine::itemStyle):
- (WebCore::RenderTextControlSingleLine::menuStyle):
- (WebCore::RenderTextControlSingleLine::clientInsetLeft):
- (WebCore::RenderTextControlSingleLine::clientInsetRight):
- (WebCore::RenderTextControlSingleLine::clientPaddingLeft):
- (WebCore::RenderTextControlSingleLine::clientPaddingRight):
- (WebCore::RenderTextControlSingleLine::listSize):
- (WebCore::RenderTextControlSingleLine::selectedIndex):
- (WebCore::RenderTextControlSingleLine::popupDidHide):
- (WebCore::RenderTextControlSingleLine::itemIsSeparator):
- (WebCore::RenderTextControlSingleLine::itemIsLabel):
- (WebCore::RenderTextControlSingleLine::itemIsSelected):
- (WebCore::RenderTextControlSingleLine::setTextFromItem):
- (WebCore::RenderTextControlSingleLine::fontSelector):
- (WebCore::RenderTextControlSingleLine::hostWindow):
- (WebCore::RenderTextControlSingleLine::createScrollbar):
- * rendering/RenderTextControlSingleLine.h:
- (WebCore):
- (RenderTextControlSingleLine):
- (WebCore::RenderTextControlSingleLine::popupIsVisible):
- * rendering/RenderingAllInOne.cpp:
-
-2012-06-15 Darin Adler <darin@apple.com>
-
- REGRESSION (r111041): Missing element type check in RenderThemeMac::paintMediaFullscreenButton
- https://bugs.webkit.org/show_bug.cgi?id=89270
-
- Reviewed by Oliver Hunt.
-
- * rendering/RenderThemeMac.mm:
- (WebCore::RenderThemeMac::paintMediaFullscreenButton): Use the proper idiom for getting
- a media control element's type.
-
-2012-06-17 Zeev Lieber <zlieber@chromium.org>
-
- [Chromium] Compositor should avoid drawing quads when cached textures are available and contents unchanged
- https://bugs.webkit.org/show_bug.cgi?id=88482
-
- Reviewed by Adrienne Walker.
-
- Post-processing CCRenderPassList after it's been generated and
- removing all render surface quads for which there are
- cached textures, and whose content didn't change. Added a new
- flag to CCLayerImpl to differentiate surface property change and
- layer property change.
-
- The changes are covered by new unit tests that check that
- the removal algorithm functions propertly. No rendering
- behaviour change, so no new layout tests.
-
- * platform/graphics/chromium/cc/CCDamageTracker.cpp:
- (WebCore::layerNeedsToRedrawOntoItsTargetSurface):
- (WebCore):
- (WebCore::CCDamageTracker::extendDamageForLayer):
- (WebCore::CCDamageTracker::extendDamageForRenderSurface):
- * platform/graphics/chromium/cc/CCLayerImpl.cpp:
- (WebCore::CCLayerImpl::CCLayerImpl):
- (WebCore::CCLayerImpl::layerSurfacePropertyChanged):
- (WebCore):
- (WebCore::CCLayerImpl::resetAllChangeTrackingForSubtree):
- (WebCore::CCLayerImpl::setOpacity):
- (WebCore::CCLayerImpl::setTransform):
- * platform/graphics/chromium/cc/CCLayerImpl.h:
- (CCLayerImpl):
- * platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
- (WebCore::CCLayerTreeHostImpl::calculateRenderPasses):
- (WebCore::CCLayerTreeHostImpl::removeRenderPassesRecursive):
- (WebCore):
- (WebCore::CCLayerTreeHostImpl::removePassesWithCachedTextures):
- (WebCore::CCLayerTreeHostImpl::prepareToDraw):
- * platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:
- (FrameData):
- (CCLayerTreeHostImpl):
- * platform/graphics/chromium/cc/CCRenderPass.h:
- (CCRenderPass):
- * platform/graphics/chromium/cc/CCRenderSurface.cpp:
- (WebCore::CCRenderSurface::prepareContentsTexture):
- (WebCore::CCRenderSurface::hasCachedContentsTexture):
- (WebCore):
- (WebCore::CCRenderSurface::contentsChanged):
- * platform/graphics/chromium/cc/CCRenderSurface.h:
- (CCRenderSurface):
-
-2012-06-17 Adam Barth <abarth@webkit.org>
-
- Attempt to fix a large number of tests I broke with http://trac.webkit.org/changeset/120547
-
- We need to reset the device scale facter after each test.
-
- * testing/InternalSettings.cpp:
- (WebCore::InternalSettings::InternalSettings):
- (WebCore::InternalSettings::restoreTo):
- * testing/InternalSettings.h:
- (InternalSettings):
-
-2012-06-16 Huang Dongsung <luxtella@company100.net>
-
- [Texmap] Share gaussian formula between shaders in TextureMapperShaderManager.
- https://bugs.webkit.org/show_bug.cgi?id=89277
-
- This patch makes blur and drop shadow shader share gaussian formula.
-
- On the other hand, blur and drop shadow filter computed a gaussian weight in
- pixel shader. However, a gaussian kernal has always same values, so this patch
- computes the gaussian kernel only one time using CPU.
- It is more accurate and faster.
-
- Reviewed by Noam Rosenthal.
-
- Covered by existing tests, particularly css3/filters/.
-
- * platform/graphics/texmap/TextureMapperShaderManager.cpp:
- (WebCore):
- (WebCore::StandardFilterProgram::StandardFilterProgram):
- (WebCore::gauss):
- (WebCore::gaussianKernel):
- (WebCore::StandardFilterProgram::prepare):
- * platform/graphics/texmap/TextureMapperShaderManager.h:
-
-2012-06-16 Robert Kroeger <rjkroege@chromium.org>
-
- [chromium] Make the deviceScaleFactor dynamically adjustable.
- https://bugs.webkit.org/show_bug.cgi?id=88916
-
- Reviewed by James Robinson.
-
- * platform/graphics/chromium/cc/CCLayerTreeHost.cpp: Removed use of static
- deviceScaleFactor from settings with dyanmic m_deviceScaleFactor
- (WebCore::CCLayerTreeHost::CCLayerTreeHost):
- (WebCore::CCLayerTreeHost::finishCommitOnImplThread):
- (WebCore::CCLayerTreeHost::setViewportSize):
- (WebCore::CCLayerTreeHost::updateLayers):
- (WebCore::CCLayerTreeHost::setDeviceScaleFactor): Added function to
- set deviceScaleFactor.
- (WebCore):
- * platform/graphics/chromium/cc/CCLayerTreeHost.h:
- (WebCore::CCSettings::CCSettings): Removed static deviceScaleFactor
- (CCSettings):
- (CCLayerTreeHost): Added dynamic m_deviceScaleFactor in its place.
- (WebCore::CCLayerTreeHost::deviceScaleFactor):
- * platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp: Same as above.
- (WebCore::CCLayerTreeHostImpl::CCLayerTreeHostImpl):
- (WebCore::CCLayerTreeHostImpl::calculateRenderSurfaceLayerList):
- (WebCore::CCLayerTreeHostImpl::setViewportSize):
- (WebCore::CCLayerTreeHostImpl::setDeviceScaleFactor): Added function to
- set deviceScaleFactor.
- (WebCore):
- (WebCore::CCLayerTreeHostImpl::updateMaxScrollPosition):
- (WebCore::CCLayerTreeHostImpl::scrollBegin):
- (WebCore::CCLayerTreeHostImpl::computePinchZoomDeltas):
- * platform/graphics/chromium/cc/CCLayerTreeHostImpl.h: Added dynamic
- m_deviceScaleFactor instance variable.
- (WebCore::CCLayerTreeHostImpl::deviceScaleFactor):
- (CCLayerTreeHostImpl):
-
-2012-06-16 Sheriff Bot <webkit.review.bot@gmail.com>
-
- Unreviewed, rolling out r120536.
- http://trac.webkit.org/changeset/120536
- https://bugs.webkit.org/show_bug.cgi?id=89296
-
- Does not compile on chromium-linux (Requested by abarth on
- #webkit).
-
- * platform/graphics/harfbuzz/FontPlatformDataHarfBuzz.cpp:
- (WebCore):
- (WebCore::FontPlatformData::setHinting):
- (WebCore::FontPlatformData::setAutoHint):
- (WebCore::FontPlatformData::setUseBitmaps):
- (WebCore::FontPlatformData::setAntiAlias):
- (WebCore::FontPlatformData::setSubpixelRendering):
- (WebCore::FontPlatformData::setSubpixelPositioning):
- (WebCore::FontPlatformData::setupPaint):
- * platform/graphics/harfbuzz/FontPlatformDataHarfBuzz.h:
- (FontPlatformData):
-
-2012-06-16 Sheriff Bot <webkit.review.bot@gmail.com>
-
- Unreviewed, rolling out r120539.
- http://trac.webkit.org/changeset/120539
- https://bugs.webkit.org/show_bug.cgi?id=89295
-
- Does not compile on chromium-mac (Requested by abarth on
- #webkit).
-
- * platform/graphics/chromium/cc/CCDamageTracker.cpp:
- (WebCore::CCDamageTracker::extendDamageForLayer):
- (WebCore::CCDamageTracker::extendDamageForRenderSurface):
- * platform/graphics/chromium/cc/CCLayerImpl.cpp:
- (WebCore::CCLayerImpl::CCLayerImpl):
- (WebCore::CCLayerImpl::resetAllChangeTrackingForSubtree):
- (WebCore::CCLayerImpl::setOpacity):
- (WebCore::CCLayerImpl::setTransform):
- * platform/graphics/chromium/cc/CCLayerImpl.h:
- (CCLayerImpl):
- * platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
- (WebCore::CCLayerTreeHostImpl::calculateRenderPasses):
- (WebCore::CCLayerTreeHostImpl::prepareToDraw):
- * platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:
- (CCLayerTreeHostImpl):
- * platform/graphics/chromium/cc/CCRenderPass.h:
- (CCRenderPass):
- * platform/graphics/chromium/cc/CCRenderSurface.cpp:
- (WebCore::CCRenderSurface::prepareContentsTexture):
- * platform/graphics/chromium/cc/CCRenderSurface.h:
- (CCRenderSurface):
-
-2012-06-16 Mike West <mkwst@chromium.org>
-
- Ignore paths in Content Security Policy sources rather than failing to parse them.
- https://bugs.webkit.org/show_bug.cgi?id=89281
-
- Reviewed by Adam Barth.
-
- In short: `script-src http://example.com/` should allow scripts from
- http://example.com. Currently, it allows no scripts at all, as the
- terminal `/` isn't accepted as part of a hostname.
-
- This patch adjusts CSPSourceList::parseSource to accept paths (and
- discard them). Once this lands, the next step will be to keep the
- path, and use it when comparing source origins in the various
- allowXXXFromSource methods.
-
- Tests: http/tests/security/contentSecurityPolicy/source-list-parsing-05.html
- http/tests/security/contentSecurityPolicy/source-list-parsing-06.html
-
- * page/ContentSecurityPolicy.cpp:
- (CSPSourceList):
- (WebCore):
- (WebCore::CSPSourceList::parseSource):
- Reworked this method entirely to support paths.
- (WebCore::CSPSourceList::parsePath):
- More or less a no-op at the moment.
- (WebCore::CSPSourceList::parsePort):
- Moved the `:` assertion here from parseSource.
-
-2012-06-16 Zeev Lieber <zlieber@chromium.org>
-
- [Chromium] Compositor should avoid drawing quads when cached textures are available and contents unchanged
- https://bugs.webkit.org/show_bug.cgi?id=88482
-
- Reviewed by Adrienne Walker.
-
- Post-processing CCRenderPassList after it's been generated and
- removing all render surface quads for which there are
- cached textures, and whose content didn't change. Added a new
- flag to CCLayerImpl to differentiate surface property change and
- layer property change.
-
- The changes are covered by new unit tests that check that
- the removal algorithm functions propertly. No rendering
- behaviour change, so no new layout tests.
-
- * platform/graphics/chromium/cc/CCDamageTracker.cpp:
- (WebCore::layerNeedsToRedrawOntoItsTargetSurface):
- (WebCore):
- (WebCore::CCDamageTracker::extendDamageForLayer):
- (WebCore::CCDamageTracker::extendDamageForRenderSurface):
- * platform/graphics/chromium/cc/CCLayerImpl.cpp:
- (WebCore::CCLayerImpl::CCLayerImpl):
- (WebCore::CCLayerImpl::layerSurfacePropertyChanged):
- (WebCore):
- (WebCore::CCLayerImpl::resetAllChangeTrackingForSubtree):
- (WebCore::CCLayerImpl::setOpacity):
- (WebCore::CCLayerImpl::setTransform):
- * platform/graphics/chromium/cc/CCLayerImpl.h:
- (CCLayerImpl):
- * platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
- (WebCore::CCLayerTreeHostImpl::calculateRenderPasses):
- (WebCore::CCLayerTreeHostImpl::removeRenderPassesRecursive):
- (WebCore):
- (WebCore::CCLayerTreeHostImpl::removePassesWithCachedTextures):
- (WebCore::CCLayerTreeHostImpl::prepareToDraw):
- * platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:
- (FrameData):
- (CCLayerTreeHostImpl):
- * platform/graphics/chromium/cc/CCRenderPass.h:
- (CCRenderPass):
- * platform/graphics/chromium/cc/CCRenderSurface.cpp:
- (WebCore::CCRenderSurface::prepareContentsTexture):
- (WebCore::CCRenderSurface::hasCachedContentsTexture):
- (WebCore):
- (WebCore::CCRenderSurface::contentsChanged):
- * platform/graphics/chromium/cc/CCRenderSurface.h:
- (CCRenderSurface):
-
-2012-06-16 Xianzhu Wang <wangxianzhu@chromium.org>
-
- [Chromium] Move chromium/public/linuxish/WebFontRendering.h out of linuxish directory
- https://bugs.webkit.org/show_bug.cgi?id=89228
-
- Reverse the dependency originally from WebKit::WebFontRendering to WebCore::FontPlatformDataHarfBuzz
- so that WebKit::WebFontRendering can be platform-independent.
-
- Reviewed by Tony Chang.
-
- Refactory only. No new tests.
-
- * platform/graphics/harfbuzz/FontPlatformDataHarfBuzz.cpp:
- (WebCore::FontPlatformData::setupPaint):
- * platform/graphics/harfbuzz/FontPlatformDataHarfBuzz.h:
- (FontPlatformData):
-
-2012-06-16 Adam Barth <abarth@webkit.org>
-
- Settings::devicePixelRatio doesn't do anything and is confusing
- https://bugs.webkit.org/show_bug.cgi?id=89272
-
- Reviewed by James Robinson.
-
- Settings::devicePixelRatio is yet another piece of state trying to
- represent the device scale factor. The canonical place to store this
- state is Page::m_deviceScaleFactor. Nothing in WebCore references
- Settings::devicePixelRatio anymore, so we can remove it.
-
- * page/Settings.cpp:
- (WebCore::Settings::Settings):
- * page/Settings.h:
- (Settings):
-
-2012-06-16 Huang Dongsung <luxtella@company100.net>
-
- [Texmap] SIGSEV in WebCore::TextureMapperGL::drawTexture.
- https://bugs.webkit.org/show_bug.cgi?id=89113
-
- TextureMapperTile::m_texture is created lazilly, so we need null check before
- using it.
-
- Reviewed by Noam Rosenthal.
-
- No new tests. This patch doesn't change behavior.
-
- * platform/graphics/texmap/TextureMapperBackingStore.cpp:
- (WebCore::TextureMapperTile::paint):
-
-2012-06-16 Huang Dongsung <luxtella@company100.net>
-
- [Texmap] Remove unused code in Texmap.
- https://bugs.webkit.org/show_bug.cgi?id=89265
-
- Reviewed by Noam Rosenthal.
-
- * platform/graphics/texmap/GraphicsLayerTextureMapper.cpp:
- (WebCore::GraphicsLayerTextureMapper::didSynchronize):
- * platform/graphics/texmap/GraphicsLayerTextureMapper.h:
- (GraphicsLayerTextureMapper):
- * platform/graphics/texmap/TextureMapperLayer.cpp:
- (WebCore::TextureMapperLayer::syncCompositingState):
- * platform/graphics/texmap/TextureMapperLayer.h:
- (TextureMapperLayer):
-
-2012-06-16 Igor Oliveira <igor.o@sisa.samsung.com>
-
- [TexmapGL] Reduce the number of glTexSubImage2D calls
- https://bugs.webkit.org/show_bug.cgi?id=83665
-
- Instead of copy the pixels row by row, put the pixels in a buffer and
- call glTexSubImage2D just once.
-
- Reviewed by Noam Rosenthal.
-
- * platform/graphics/texmap/TextureMapperGL.cpp:
- (WebCore::BitmapTextureGL::updateContents):
-
-2012-06-15 Sheriff Bot <webkit.review.bot@gmail.com>
-
- Unreviewed, rolling out r120280.
- http://trac.webkit.org/changeset/120280
- https://bugs.webkit.org/show_bug.cgi?id=89273
-
- Enabling CSS regions broke all Windows tests (Requested by
- jhomeycutt on #webkit).
-
- * css/CSSPropertyNames.in:
-
-2012-06-15 Sheriff Bot <webkit.review.bot@gmail.com>
-
- Unreviewed, rolling out r120511.
- http://trac.webkit.org/changeset/120511
- https://bugs.webkit.org/show_bug.cgi?id=89255
-
- Breaks at least Android builder (Requested by wangxianzhu on
- #webkit).
-
- * platform/graphics/harfbuzz/FontPlatformDataHarfBuzz.cpp:
- (WebCore):
- (WebCore::FontPlatformData::setHinting):
- (WebCore::FontPlatformData::setAutoHint):
- (WebCore::FontPlatformData::setUseBitmaps):
- (WebCore::FontPlatformData::setAntiAlias):
- (WebCore::FontPlatformData::setSubpixelRendering):
- (WebCore::FontPlatformData::setSubpixelPositioning):
- (WebCore::FontPlatformData::setupPaint):
- * platform/graphics/harfbuzz/FontPlatformDataHarfBuzz.h:
- (FontPlatformData):
-
-2012-06-15 Xianzhu Wang <wangxianzhu@chromium.org>
-
- [Chromium] Move chromium/public/linuxish/WebFontRendering.h out of linuxish directory
- https://bugs.webkit.org/show_bug.cgi?id=89228
-
- Reverse the dependency originally from WebKit::WebFontRendering to WebCore::FontPlatformDataHarfBuzz
- so that WebKit::WebFontRendering can be platform-independent.
-
- Reviewed by Tony Chang.
-
- Refactory only. No new tests.
-
- * platform/graphics/harfbuzz/FontPlatformDataHarfBuzz.cpp:
- (WebCore::FontPlatformData::setupPaint):
- * platform/graphics/harfbuzz/FontPlatformDataHarfBuzz.h:
- (FontPlatformData):
-
-2012-06-15 Adrienne Walker <enne@google.com>
-
- [chromium] Fix composited scrollbars with transparent thumbs
- https://bugs.webkit.org/show_bug.cgi?id=89247
-
- Reviewed by James Robinson.
-
- On some platforms, the thumb of a scrollbar can be transparent. Fix by
- always drawing the thumb quad with blending.
-
- * platform/graphics/chromium/cc/CCScrollbarLayerImpl.cpp:
- (WebCore::CCScrollbarLayerImpl::appendQuads):
- * platform/graphics/chromium/cc/CCTextureDrawQuad.cpp:
- (WebCore::CCTextureDrawQuad::setNeedsBlending):
- (WebCore):
- * platform/graphics/chromium/cc/CCTextureDrawQuad.h:
- (CCTextureDrawQuad):
-
-2012-06-14 James Robinson <jamesr@chromium.org>
-
- [chromium] Use SkBitmap in ImageLayerChromium
- https://bugs.webkit.org/show_bug.cgi?id=89134
-
- Reviewed by Adrienne Walker.
-
- GraphicsLayer::setContentsToImage(Image*) is called whenever an image layer's image is or might have changed.
- In Chromium, this used to hang on to a RefPtr<WebCore::Image> until the compositor was ready to upload texture contents.
- This is potentially a bit fishy since the Image itself might not be in exactly the same state when we get around
- to uploading textures and it also creates a bad dependency from ImageLayerChromium on WebCore::Image.
-
- This patch grabs the underlying SkBitmap in the setContentsTo call and passes that into ImageLayerChromium
- instead. I've also removed the venerable but redundant PlatformImage concept since all of chromium's images are
- skia bitmaps these days.
-
- Covered by existing tests, particularly compositing/images/ and compositing/color-matching/.
-
- * WebCore.gypi:
- * platform/graphics/chromium/GraphicsLayerChromium.cpp:
- (WebCore::GraphicsLayerChromium::setContentsToImage):
- * platform/graphics/chromium/ImageLayerChromium.cpp:
- (WebCore::ImageLayerTextureUpdater::updateTextureRect):
- (WebCore::ImageLayerTextureUpdater::setBitmap):
- (ImageLayerTextureUpdater):
- (WebCore::ImageLayerChromium::ImageLayerChromium):
- (WebCore::ImageLayerChromium::setBitmap):
- (WebCore::ImageLayerChromium::update):
- (WebCore::ImageLayerChromium::contentBounds):
- (WebCore::ImageLayerChromium::drawsContent):
- * platform/graphics/chromium/ImageLayerChromium.h:
- (ImageLayerChromium):
- * platform/graphics/chromium/PlatformImage.cpp: Removed.
- * platform/graphics/chromium/PlatformImage.h: Removed.
-
-2012-06-15 Eli Fidler <efidler@rim.com>
-
- [BlackBerry] Use platform font settings for the standard settings.
- https://bugs.webkit.org/show_bug.cgi?id=89232
-
- Reviewed by Rob Buis.
-
- RIM PR 159708
-
- * page/blackberry/SettingsBlackBerry.cpp:
- (WebCore):
- (WebCore::Settings::initializeDefaultFontFamilies):
-
-2012-06-15 Joshua Bell <jsbell@chromium.org>
-
- IndexedDB: Raise exceptions when methods are called on deleted objects
- https://bugs.webkit.org/show_bug.cgi?id=89243
-
- Reviewed by Tony Chang.
-
- Implement the IDB spec requirement that InvalidStateError exceptions are
- thrown when methods are called on objects (i.e. object stores and indexes)
- that have been deleted within a version change transaction.
-
- Test: storage/indexeddb/deleted-objects.html
-
- * Modules/indexeddb/IDBDatabase.cpp:
- (WebCore::IDBDatabase::deleteObjectStore): Don't relay to transaction if back-end failed.
- * Modules/indexeddb/IDBIndex.cpp: Check deleted state in methods, raise if set.
- (WebCore::IDBIndex::IDBIndex):
- (WebCore::IDBIndex::openCursor):
- (WebCore::IDBIndex::count):
- (WebCore::IDBIndex::openKeyCursor):
- (WebCore::IDBIndex::get):
- (WebCore::IDBIndex::getKey):
- * Modules/indexeddb/IDBIndex.h: Add flag to track deleted state, method to mark it.
- (WebCore::IDBIndex::markDeleted):
- (IDBIndex):
- * Modules/indexeddb/IDBObjectStore.cpp: Check deleted state in methods, raise if set.
- (WebCore::IDBObjectStore::IDBObjectStore):
- (WebCore::IDBObjectStore::get):
- (WebCore::IDBObjectStore::add):
- (WebCore::IDBObjectStore::put):
- (WebCore::IDBObjectStore::deleteFunction):
- (WebCore::IDBObjectStore::clear):
- (WebCore::IDBObjectStore::createIndex):
- (WebCore::IDBObjectStore::index):
- (WebCore::IDBObjectStore::deleteIndex): If the index being deleted has been instantiated,
- mark it as deleted.
- (WebCore::IDBObjectStore::openCursor):
- (WebCore::IDBObjectStore::count):
- * Modules/indexeddb/IDBObjectStore.h: Add flag to track deleted state, method to mark it.
- (WebCore::IDBObjectStore::markDeleted):
- (IDBObjectStore):
- * Modules/indexeddb/IDBTransaction.cpp:
- (WebCore::IDBTransaction::objectStore):
- (WebCore::IDBTransaction::objectStoreDeleted): If the store being deleted has been instantiated,
- mark it as deleted.
-
-2012-06-15 James Robinson <jamesr@chromium.org>
-
- [chromium] Fix LayoutTests/platform/chromium/compositing/accelerated-drawing/svg-filters.html
- https://bugs.webkit.org/show_bug.cgi?id=89126
-
- Reviewed by Stephen White.
-
- When drawing an image buffer into a deferred device context, we have to make a deep copy of the source (Skia
- can't for some reason). Stephen White fixed this in r101325 by adding a bit on PlatformContextSkia indicating if
- a given context is deferred, but I broke this again in r120346 by refactoring the SkCanvas creation to happen in
- a different location from the PlatformContextSkia construction.
-
- This moves the check into ImageBufferSkia and directly queries the state of the destination SkDevice to be more
- robust and work without needing special PlatformContextSkia setup.
-
- Covered by LayoutTests/platform/chromium/compositing/accelerated-drawing/svg-filters.html
-
- * platform/graphics/skia/ImageBufferSkia.cpp:
- (WebCore::drawNeedsCopy):
- * platform/graphics/skia/PlatformContextSkia.cpp:
- (WebCore::PlatformContextSkia::PlatformContextSkia):
- * platform/graphics/skia/PlatformContextSkia.h:
- (PlatformContextSkia):
-
-2012-06-15 Ami Fischman <fischman@chromium.org>
-
- [chromium] Compositor should be aware of |flipped| status of video textures per-platform
- https://bugs.webkit.org/show_bug.cgi?id=89189
-
- Reviewed by James Robinson.
-
- No new tests (sadly HW video decode is still only being tested manually for orientation).
-
- * platform/graphics/chromium/cc/CCVideoLayerImpl.cpp:
- (WebCore::CCVideoLayerImpl::appendQuads):
-
-2012-06-14 Ryosuke Niwa <rniwa@webkit.org>
-
- The initial value of text-align should be start instead of -webkit-auto
- https://bugs.webkit.org/show_bug.cgi?id=79914
-
- Reviewed by Tony Chang.
-
- Change the initial value of text-align CSS property from -webkit-auto to start as specified in
- http://www.w3.org/TR/css3-text/#text-align
-
- In editing, we have to coerce start and end to left and right for now because match-parent,
- which is the text-align value of li in UA stylesheet is going to result in the computed values of
- left as supposed to start by default, and this causes editing code not being able to remove
- text-align: left when computing typing styles and preserving styles.
-
- In the long term, we should detect this specific case and ignore match-parent but that seemed like
- too much work to be done in a single patch also because the test result improved because of this change.
-
- This behavior change is covered by existing regression tests.
-
- * accessibility/gtk/WebKitAccessibleInterfaceText.cpp:
- (WebCore::getAttributeSetForAccessibilityObject):
- * css/CSSParser.cpp:
- (WebCore::CSSParser::parseValue):
- * css/CSSPrimitiveValueMappings.h:
- (WebCore::CSSPrimitiveValue::CSSPrimitiveValue): No longer supports TAAUTO since it's identical to TASTART.
- (WebCore::CSSPrimitiveValue::operator ETextAlign): Ditto. Parse -webkit-auto as start.
- * css/StyleResolver.cpp:
- (WebCore::StyleResolver::collectMatchingRulesForList): Replace TAAUTO by TASTART.
- * editing/EditingStyle.cpp:
- (WebCore):
- (WebCore::textAlignResolvingStartAndEnd): Coerce start and end into left and right based on the directionality
- for editing. Otherwise, we end up adding lots of text-align: left due to li's UA style rule having match-parent
- as the text alignment and its descendent inherits this style. We need to handle it better in the future
- since start and left or end and right are semantically different.
- (WebCore::EditingStyle::prepareToApplyAt):
- (WebCore::getPropertiesNotIn):
- * rendering/RenderBlockLineLayout.cpp:
- (WebCore::RenderBlock::textAlignmentForLine): Justified text is aligned at start by default.
- (WebCore::RenderBlock::updateLogicalWidthForAlignment):
- (WebCore::RenderBlock::startAlignedOffsetForLine):
- * rendering/RenderBoxModelObject.cpp:
- (WebCore::RenderBoxModelObject::localCaretRectForEmptyElement):
- * rendering/RenderListBox.cpp:
- (WebCore::itemOffsetForAlignment):
- * rendering/RenderMarquee.cpp:
- (WebCore::RenderMarquee::updateMarqueeStyle):
- * rendering/RenderRubyText.cpp:
- (WebCore::RenderRubyText::textAlignmentForLine):
- (WebCore::RenderRubyText::adjustInlineDirectionLineBounds):
- * rendering/RenderText.cpp:
- (WebCore::RenderText::localCaretRect):
- * rendering/style/RenderStyle.h:
- * rendering/style/RenderStyleConstants.h:
-
-2012-06-15 Jian Li <jianli@chromium.org>
-
- [File API] FileReader should work in sandbox iframe
- https://bugs.webkit.org/show_bug.cgi?id=89242
-
- Reviewed by Adam Barth.
-
- Test: fast/files/file-reader-sandbox-iframe.html
-
- * fileapi/ThreadableBlobRegistry.cpp: Should remove from map for all threads.
- (WebCore::ThreadableBlobRegistry::unregisterBlobURL):
- * page/SecurityOrigin.cpp:
- (WebCore::SecurityOrigin::canRequest): Check and use cached origin for blob URL first.
-
-2012-06-15 David Barton <dbarton@mathscribe.com>
-
- Inherit style changes in MathML anonymous renderers
- https://bugs.webkit.org/show_bug.cgi?id=88476
-
- Reviewed by Julien Chaffraix.
-
- A RenderObject that is not the main renderer() for a DOM node is called "anonymous".
- Standard WebCore practice is to mark such a renderer as isAnonymous(). For example,
- RenderBlock::styleDidChange calls propagateStyleToAnonymousChildren to flow style
- changes to such children, by re-initializing their styles and then inheriting from
- this->style(). A derived class' styleDidChange() can then set non-default style
- properties as needed.
-
- This patch implements this standard practice for RenderMathMLBlock classes, except
- RenderMathMLOperator which currently uses a RenderLayer, which reportedly means it
- should not be isAnonymous(). We also follow common practice and change
- isAnonymousBlock() to return false for RenderMathMLBlock classes, since
- isAnonymousBlock() is really used by RenderBlock to detect its own anonymous blocks for
- wrapping inline children, which RenderBlock then combines or deletes assuming this.
-
- Test: mathml/presentation/style-changed.html, also added to mathml/presentation/over.xhtml
-
- * rendering/RenderObject.h:
- (WebCore::RenderObject::isAnonymousBlock):
- * rendering/RenderTreeAsText.cpp:
- (WebCore::RenderTreeAsText::writeRenderObject):
- * rendering/mathml/RenderMathMLBlock.cpp:
- (WebCore::RenderMathMLBlock::createAnonymousMathMLBlock):
- (WebCore::RenderMathMLBlock::renderName):
- * rendering/mathml/RenderMathMLBlock.h:
- * rendering/mathml/RenderMathMLFenced.cpp:
- (WebCore::RenderMathMLFenced::createMathMLOperator):
- (WebCore::RenderMathMLFenced::makeFences):
- (WebCore::RenderMathMLFenced::addChild):
- (WebCore::RenderMathMLFenced::styleDidChange):
- * rendering/mathml/RenderMathMLFenced.h:
- * rendering/mathml/RenderMathMLFraction.cpp:
- (WebCore::RenderMathMLFraction::RenderMathMLFraction):
- (WebCore::RenderMathMLFraction::fixChildStyle):
- (WebCore::RenderMathMLFraction::addChild):
- (WebCore::RenderMathMLFraction::styleDidChange):
- * rendering/mathml/RenderMathMLFraction.h:
- * rendering/mathml/RenderMathMLOperator.cpp:
- (WebCore::RenderMathMLOperator::styleDidChange):
- * rendering/mathml/RenderMathMLOperator.h:
- * rendering/mathml/RenderMathMLSquareRoot.h:
- * rendering/mathml/RenderMathMLSubSup.cpp:
- (WebCore::RenderMathMLSubSup::fixScriptsStyle):
- (WebCore::RenderMathMLSubSup::addChild):
- (WebCore::RenderMathMLSubSup::styleDidChange):
- * rendering/mathml/RenderMathMLSubSup.h:
- * rendering/mathml/RenderMathMLUnderOver.cpp:
- (WebCore::RenderMathMLUnderOver::addChild):
- (WebCore::RenderMathMLUnderOver::styleDidChange):
- * rendering/mathml/RenderMathMLUnderOver.h:
-
-2012-06-13 Vincent Scheib <scheib@chromium.org>
-
- Add new Pointer Lock spec webkitRequestPointerLock and webkitExitPointerLock methods.
- https://bugs.webkit.org/show_bug.cgi?id=88891
-
- Reviewed by Dimitri Glazkov.
-
- Part of a series of refactoring changes to update pointer lock API to
- the fullscreen locking style. https://bugs.webkit.org/show_bug.cgi?id=84402
-
- Entering and exiting mouse lock is provided in the new webkitRequestPointerLock and
- webkitExitPointerLock methods.
-
- Existing pointer-lock tests updated to use the new methods.
-
- * dom/Document.cpp:
- (WebCore::Document::webkitExitPointerLock):
- (WebCore):
- * dom/Document.h:
- (Document):
- * dom/Document.idl:
- * dom/Element.cpp:
- (WebCore):
- (WebCore::Element::webkitRequestPointerLock):
- * dom/Element.h:
- * dom/Element.idl:
-
-2012-06-15 Tony Payne <tpayne@chromium.org>
-
- [chromium] Add iccjpeg and qcms to chromium port
- https://bugs.webkit.org/show_bug.cgi?id=81974
-
- Reviewed by Adam Barth.
-
- Covered by existing layout tests which will be rebaselined.
-
- * WebCore.gyp/WebCore.gyp: Add qcms to the build.
- * platform/image-decoders/ImageDecoder.h:
- (WebCore::ImageDecoder::qcmsOutputDeviceProfile): Return an sRGB profile.
- On OSX, return the default RGB profile. Add FIXME to use the user's
- monitor profile and verify that profile for other platforms.
-
- * platform/image-decoders/jpeg/JPEGImageDecoder.cpp:
- (turboSwizzled): For libjpeg-turbo, JCS_EXT_BGRA and JCS_EXT_RGBA are the
- two known output color spaces for which the decoder uses a data swizzle.
- (colorSpaceHasAlpha): JPEG's have no alpha in the output color space. For
- libjpeg-turbo, alpha may be present in the swizzled output color space.
-
- (WebCore::JPEGImageReader::JPEGImageReader):
- (WebCore::JPEGImageReader::close):
- (WebCore::JPEGImageReader::decode): For QCMSLIB, create the color transform
- to use during decoding, and ensure we switch to inputing RGBA data to qcms
- even if the desired output data is BGRA: outputScanlines() sends BGRA data
- to the frame buffer following color correction if needed.
- (JPEGImageReader):
- (WebCore::JPEGImageReader::colorTransform): qcms color transform getter.
- (WebCore::JPEGImageReader::createColorTransform): Create color transform.
- Release the existing transform (if any) and assign to the color transform
- created from the color profile data.
- (WebCore::JPEGImageDecoder::outputScanlines): Minor style fix. Apply color
- transform to each decoded image row.
-
- * platform/image-decoders/png/PNGImageDecoder.cpp:
- (WebCore::PNGImageReader::PNGImageReader):
- (WebCore::PNGImageReader::close):
- (WebCore::PNGImageReader::currentBufferSize): Move this adjacent to other
- setters and getters.
- (WebCore::PNGImageReader::decodingSizeOnly): Ditto.
- (WebCore::PNGImageReader::setHasAlpha): Ditto.
- (WebCore::PNGImageReader::hasAlpha): Ditto.
- (WebCore::PNGImageReader::interlaceBuffer): Ditto.
- (WebCore::PNGImageReader::createRowBuffer): Creates a temporary row buffer,
- used when a color transform is applied to the decoded image pixels.
- (WebCore::PNGImageReader::rowBuffer): Return the temporary row buffer.
- (WebCore::PNGImageReader::colorTransform): qcms color transform getter.
- (WebCore::PNGImageReader::createColorTransform): Create color transform.
- Release the existing transform (if any) and assign to the color transform
- created from the color profile data.
- (WebCore::PNGImageDecoder::headerAvailable): For QCMSLIB, create the color
- transform to use for decoding. Clear m_colorProfile (not used anymore).
- (WebCore::PNGImageDecoder::rowAvailable): Create temporary row buffer if
- a color transform is needed for decoding. Apply color transform to each
- decoded image row.
-
- * platform/image-decoders/skia/ImageDecoderSkia.cpp:
- (WebCore::ImageFrame::setColorProfile): Old method of colorProfiles is no
- longer used. Add a FIXME to remove the old implementation.
- (WebCore::ImageFrame::setStatus): Remove old color correction code.
-
-2012-06-15 Silvia Pfeiffer <silviapf@chromium.org>
-
- Remove volume thumb for videos without audio track.
- https://bugs.webkit.org/show_bug.cgi?id=89093
-
- Reviewed by Eric Carlson.
-
- No new tests, since this was already tested in media/video-no-audio.html.
-
- * rendering/RenderMediaControlsChromium.cpp:
- (WebCore::paintMediaMuteButton):
- Change mute button when there is no audio or no source file.
- (WebCore::paintMediaVolumeSlider):
- Set volume slider to 0 when there is no audio or no source file.
- (WebCore::paintMediaVolumeSliderThumb):
- Don't paint the volume slider thumb when there is no audio or no source file.
-
-2012-06-15 Abhishek Arya <inferno@chromium.org>
-
- Cleanup empty anonymous block continuation.
- https://bugs.webkit.org/show_bug.cgi?id=74976
-
- Reviewed by Julien Chaffraix.
-
- Fix rendering on http://docs.google.com/demo.
-
- Test: fast/inline/inline-empty-block-continuation-remove.html
-
- * rendering/RenderBlock.cpp:
- (WebCore::RenderBlock::removeChild): If we are removing our last child,
- and are an anonymous block which is part of a continuation chain, then
- we need to first fix our continuation chain by setting our previous
- continuation renderer to point to the next continuation renderer. Then,
- we reset our continuation pointer and destroy ourselves. Since we no
- longer are part of continuation chain, we will be removed and previous
- and next anonymous block will be merged automatically.
- * rendering/RenderObject.cpp:
- (WebCore::RenderObject::previousInPreOrder): add an argument to previousInOrder
- - stayWithin.
- (WebCore):
- * rendering/RenderObject.h:
- (RenderObject):
-
-2012-06-15 Taiju Tsuiki <tzik@chromium.org>
-
- Web Inspector: Move FileSystem frame management from frontend to backend
- https://bugs.webkit.org/show_bug.cgi?id=89190
-
- Reviewed by Vsevolod Vlasov.
-
- Test: http/tests/inspector/filesystem/read-directory.html
-
- * inspector/Inspector.json:
- * inspector/InspectorFileSystemAgent.cpp:
- (WebCore::InspectorFileSystemAgent::readDirectory):
- (WebCore::InspectorFileSystemAgent::InspectorFileSystemAgent):
- (WebCore::InspectorFileSystemAgent::scriptExecutionContextForOrigin):
- (WebCore):
- * inspector/InspectorFileSystemAgent.h:
- (WebCore):
- (InspectorFileSystemAgent):
-
-2012-06-15 Alexander Pavlov <apavlov@chromium.org>
-
- Unreviewed, build fix after r120469.
-
- * css/CSSPropertySourceData.h:
- (WebCore):
-
-2012-06-15 Taiju Tsuiki <tzik@chromium.org>
-
- Web Inspector: Add FileSystemRequestManager and FileSystemDispatcher
- https://bugs.webkit.org/show_bug.cgi?id=89191
-
- Reviewed by Vsevolod Vlasov.
-
- * inspector/front-end/FileSystemModel.js:
- (WebInspector.FileSystemModel):
- (WebInspector.FileSystemRequestManager):
- (WebInspector.FileSystemRequestManager.prototoype._requestId):
- (WebInspector.FileSystemRequestManager.prototoype.readDirectory):
- (WebInspector.FileSystemRequestManager.prototoype._didReadDirectory):
- (WebInspector.FileSystemDispatcher):
- (WebInspector.FileSystemDispatcher.prototype.gotFileSystemRoot):
- (WebInspector.FileSystemDispatcher.prototype.didReadDirectory):
-
-2012-06-15 Pavel Feldman <pfeldman@chromium.org>
-
- Web Inspector: extension's Resource.getContent always returns original revision.
- https://bugs.webkit.org/show_bug.cgi?id=89219
-
- Reviewed by Vsevolod Vlasov.
-
- Fetching proper content from the UISourceCode now.
-
- * inspector/front-end/DebuggerResourceBinding.js:
- (WebInspector.DebuggerResourceBinding.prototype.canSetContent):
- (WebInspector.DebuggerResourceBinding.prototype.setContent):
- * inspector/front-end/DebuggerScriptMapping.js:
- (WebInspector.DebuggerScriptMapping.prototype._debuggerReset):
- * inspector/front-end/ExtensionServer.js:
- (WebInspector.ExtensionServer.prototype._onGetResourceContent):
- * inspector/front-end/JavaScriptSource.js:
- (WebInspector.JavaScriptSource):
- * inspector/front-end/Resource.js:
- (WebInspector.Resource.prototype.isHidden):
- (WebInspector.Resource.prototype.uiSourceCode):
- (WebInspector.Resource.prototype.setUISourceCode):
- * inspector/front-end/UISourceCode.js:
- (WebInspector.UISourceCode):
-
-2012-06-15 Ilya Tikhonovsky <loislo@chromium.org>
-
- Web Inspector: CRASH when DebuggerAgent.setBreakpoint was called twice for the same location.
- https://bugs.webkit.org/show_bug.cgi?id=89225
-
- Reviewed by Pavel Feldman.
-
- * inspector/InspectorDebuggerAgent.cpp:
- (WebCore::InspectorDebuggerAgent::setBreakpoint):
-
-2012-06-08 Alexander Pavlov <apavlov@chromium.org>
-
- Web Inspector: CSSParser::parseSheet() should provide ready-to-use source data
- https://bugs.webkit.org/show_bug.cgi?id=88646
-
- Reviewed by Antti Koivisto.
-
- This change moves the post-processing step from InspectorStyleSheet into CSSParser, so that
- CSSParser::parseSheet() will return a ready-to-use list with style rule source code data.
- Also, universal data structures are introduced, which allow for the full rule source data tree building.
-
- No new tests, as this is a refactoring.
-
- * css/CSSParser.cpp: Use universal data structures, which can be used for building the full rule tree.
- (WebCore::CSSParser::CSSParser):
- (WebCore::CSSParser::setupParser):
- (WebCore::CSSParser::parseSheet): Return ready-to-use source code data entries rather than an intermediate structure.
- (WebCore::CSSParser::parseDeclaration):
- (WebCore::CSSParser::addNewRuleToSourceTree):
- (WebCore):
- (WebCore::CSSParser::popRuleData):
- (WebCore::CSSParser::createStyleRule):
- (WebCore::CSSParser::fixUnparsedPropertyRanges): Moved in from InspectorStyleSheet.
- (WebCore::CSSParser::markSelectorListStart):
- (WebCore::CSSParser::markSelectorListEnd):
- (WebCore::CSSParser::markRuleBodyStart):
- (WebCore::CSSParser::markRuleBodyEnd):
- (WebCore::CSSParser::markPropertyEnd):
- * css/CSSParser.h:
- (CSSParser):
- (WebCore::CSSParser::resetPropertyRange): Renamed.
- (WebCore::CSSParser::isExtractingSourceData): A convenience check.
- * css/CSSPropertySourceData.h: Introduce the RuleSourceDataList typedef.
- (WebCore):
- * inspector/InspectorStyleSheet.cpp: Make use of RuleSourceDataList and follow the CSSParser::parse*() API changes.
- (ParsedStyleSheet::sourceData):
- (ParsedStyleSheet):
- (ParsedStyleSheet::setSourceData):
- (WebCore::InspectorStyleSheet::ensureSourceData): Remove source data postprocessing, follow the new parseSheet() API.
- * inspector/InspectorStyleSheet.h:
- (WebCore::InspectorCSSId::InspectorCSSId): Drive-by: uninitialized field fix.
- (WebCore::InspectorStyleProperty::InspectorStyleProperty): Ditto.
- (InspectorStyleSheet):
-
-2012-06-15 Pavel Feldman <pfeldman@chromium.org>
-
- Web Inspector: Long frame urls make all/errors/warnings/logs buttons inaccessible.
- https://bugs.webkit.org/show_bug.cgi?id=88907
-
- Reviewed by Vsevolod Vlasov.
-
- * inspector/front-end/inspector.css:
- (#console-context):
-
-2012-06-15 Florin Malita <fmalita@chromium.org>
-
- Specular light filters produce dark results
- https://bugs.webkit.org/show_bug.cgi?id=89116
-
- Reviewed by Dirk Schulze.
-
- Tests: svg/filters/feSpecularLight-premultiplied-expected.svg
- svg/filters/feSpecularLight-premultiplied.svg
-
- Per spec (http://www.w3.org/TR/SVG/filters.html#feSpecularLightingElement),
- light filters should operate on pre-multiplied RGBA. Currently, the results
- are stored in the unmultiplied buffer but the alpha channel is calculated
- for premultiplied values (which causes a darkening of the result upon the
- subsequent unmultiplied->premultiplied conversion). This patch updates
- FELighting to generate premultiplied results.
-
- * platform/graphics/filters/FELighting.cpp:
- (WebCore::FELighting::platformApplySoftware):
-
-2012-06-15 Andrey Kosyakov <caseq@chromium.org>
-
- Web Inspector: incorrect filtering of async timeline events
- https://bugs.webkit.org/show_bug.cgi?id=89214
-
- Reviewed by Vsevolod Vlasov.
-
- * inspector/front-end/TimelineOverviewPane.js:
- (WebInspector.TimelineOverviewPane.prototype.accept):
-
-2012-06-15 Stephen Chenney <schenney@chromium.org>
-
- SVG Composite of Offset filters incorrectly clips
- https://bugs.webkit.org/show_bug.cgi?id=77660
-
- Reviewed by Dirk Schulze.
-
- Prior to this patch, when a group of filtered objects was used as input to another filter,
- the filter only operated on the stroke boundary of the group, and hence excluded the results
- of filtering elements within the group, or extraneously included regions clipped from the
- elements in the group.
-
- This patch modifies the strokeBoundingBox of SVG container elements to
- be the union of the repaint rects for the children. This modifes the
- results returned for sizing filters and for absoluteRects, which will cause
- inline layout around the group to factor in the resources applied to
- the group's children.
-
- The relevant spec entry is this, in Section 3.7 of the SVG 1.1 spec: "...the result must be
- as though the paint operations had been applied to an intermediate canvas initialized to
- transparent black, of a size determined by the rules given in Filter Effects then filtered
- by the processes defined in Filter Effects." In this case the "paint operations" is implied
- to include the result of applying "paint" but no resources to the group, which in turn would
- have resources applied to the children of the group. This makes the most sense, as the current,
- incorrect behavior makes it extremely diffucult to understand the actions of filters on
- groups of filtered content.
-
- Tests: svg/filters/container-with-filters-expected.svg
- svg/filters/container-with-filters.svg
-
- * rendering/svg/RenderSVGContainer.cpp:
- (WebCore::RenderSVGContainer::updateCachedBoundaries):
- * rendering/svg/RenderSVGRoot.cpp:
- (WebCore::RenderSVGRoot::updateCachedBoundaries):
- * rendering/svg/SVGRenderSupport.cpp:
- (WebCore::SVGRenderSupport::computeContainerBoundingBoxes):
-
-2012-06-15 David Kilzer <ddkilzer@apple.com>
-
- Sort ENABLE(INSPECTOR) section of WebCore.exp.in
-
- * WebCore.exp.in: Sort ENABLE(INSPECTOR) symbols.
-
-2012-06-15 David Kilzer <ddkilzer@apple.com>
-
- Remove duplicate symbol from WebCore.exp.in
-
- * WebCore.exp.in: Remove duplicate symbol for:
- WebCore::Range::textQuads(WTF::Vector<WebCore::FloatQuad, 0ul>&, bool, WebCore::Range::RangeInFixedPosition*) const
-
-2012-06-15 Florin Malita <fmalita@chromium.org>
-
- [Chromium] Unreviewed debug build fix for r120457
-
- * platform/graphics/chromium/cc/CCDrawQuad.cpp:
- (WebCore::CCDrawQuad::toYUVVideoDrawQuad):
-
-2012-06-15 'Pavel Feldman' <pfeldman@chromium.org>
-
- Not reviewed: remove redundant Mac-specific style rule from inspector front-end.
-
- * inspector/front-end/helpScreen.css:
-
-2012-06-15 Pavel Feldman <pfeldman@chromium.org>
-
- Web Inspector: fix help close button appearance on Mac
- https://bugs.webkit.org/show_bug.cgi?id=89208
-
- Reviewed by Vsevolod Vlasov.
-
- * inspector/front-end/helpScreen.css:
- (.help-close-button):
- (body.platform-mac .help-close-button):
- (body.platform-mac .help-window-main .tabbed-pane-header-contents):
-
-2012-06-11 Dana Jansens <danakj@chromium.org>
-
- [chromium] Create a CCYUVVideoDrawQuad and remove the now-unused generic CCVideoDrawQuad
- https://bugs.webkit.org/show_bug.cgi?id=88828
-
- Reviewed by Adrienne Walker.
-
- The CCVideoDrawQuad is now only used for YUV video, so we remove the
- class and replace it with CCYUVVideoDrawQuad. This class holds what is
- needed to draw a YUV video frame.
-
- No new tests, no change in behaviour.
-
- * WebCore.gypi:
- * platform/graphics/chromium/LayerRendererChromium.cpp:
- (WebCore::LayerRendererChromium::drawQuad):
- (WebCore::LayerRendererChromium::drawYUVVideoQuad):
- * platform/graphics/chromium/LayerRendererChromium.h:
- (WebCore):
- (LayerRendererChromium):
- * platform/graphics/chromium/cc/CCDrawQuad.cpp:
- (WebCore::CCDrawQuad::toYUVVideoDrawQuad):
- * platform/graphics/chromium/cc/CCDrawQuad.h:
- (WebCore):
- (CCDrawQuad):
- * platform/graphics/chromium/cc/CCVideoLayerImpl.cpp:
- (WebCore::CCVideoLayerImpl::appendQuads):
- * platform/graphics/chromium/cc/CCYUVVideoDrawQuad.cpp: Renamed from Source/WebCore/platform/graphics/chromium/cc/CCVideoDrawQuad.cpp.
- (WebCore):
- (WebCore::CCYUVVideoDrawQuad::create):
- (WebCore::CCYUVVideoDrawQuad::CCYUVVideoDrawQuad):
- * platform/graphics/chromium/cc/CCYUVVideoDrawQuad.h: Renamed from Source/WebCore/platform/graphics/chromium/cc/CCVideoDrawQuad.h.
- (WebCore):
- (CCYUVVideoDrawQuad):
- (WebCore::CCYUVVideoDrawQuad::yPlane):
- (WebCore::CCYUVVideoDrawQuad::uPlane):
- (WebCore::CCYUVVideoDrawQuad::vPlane):
-
-2012-06-15 Ilya Tikhonovsky <loislo@chromium.org>
-
- Web Inspector: CRASH: getProfile is crashing for unknown profiles.
- https://bugs.webkit.org/show_bug.cgi?id=89202
-
- agents' functions have to set a value to errorString if it can't assign values to the mandatory out arguments.
-
- Reviewed by Pavel Feldman.
-
- Test: inspector/profiler/heap-snapshot-get-profile-crash.html
-
- * inspector/InspectorProfilerAgent.cpp:
- (WebCore::InspectorProfilerAgent::getProfile):
-
-2012-06-15 Max Feil <mfeil@rim.com>
-
- [BlackBerry] media volume slider in wrong position (master_38 regression)
- https://bugs.webkit.org/show_bug.cgi?id=89165
-
- Reviewed by Antonio Gomes.
-
- Due to upstream simplification of the volume slider (webkit.org
- bug 82150) it now appears in the wrong location below the
- media controls. The programmatic controls sizing we do in
- RenderThemeBlackBerry.cpp relies on absolute positioning of the
- volume slider container, so the best way to fix this is to set
- the bottom offset.
-
- No new tests since this is a regression fix. BlackBerry media
- controls are manually tested.
-
- * platform/blackberry/RenderThemeBlackBerry.cpp:
- (WebCore::RenderThemeBlackBerry::adjustMediaControlStyle):
-
-2012-06-15 'Pavel Feldman' <pfeldman@chromium.org>
-
- Not reviewed: remove garbage line from inspector view in docked-to-right mode.
-
- * inspector/front-end/inspectorCommon.css:
- (body.docked.dock-to-right.docked):
- (body.docked.dock-to-right.inactive):
-
-2012-06-15 Zoltan Arvai <zarvai@inf.u-szeged.hu>
-
- Buildfix for !ENABLE(BLOB) platforms after r120433.
- https://bugs.webkit.org/show_bug.cgi?id=78648
-
- Reviewed by Csaba Osztrogonác.
-
- * fileapi/ThreadableBlobRegistry.cpp:
- (WebCore::ThreadableBlobRegistry::registerBlobURL):
-
-2012-06-15 Sami Kyostila <skyostil@chromium.org>
-
- [chromium] Allow scrolling non-root layers in the compositor thread
- https://bugs.webkit.org/show_bug.cgi?id=73350
-
- Reviewed by James Robinson.
-
- This patch enables scrolling child layers in the compositor thread.
- Scroll deltas are accumulated for each scrolled CCLayerImpl and
- synchronized to the main thread.
-
- If a layer has no room to scroll in a given direction, one of its
- ancestor layers is scrolled instead if possible.
-
- Layer hit testing code by Shawn Singh.
-
- Added new unit tests to verify layer scrolling behavior:
-
- CCLayerTreeHostCommonTest.verifySubtreeSearch
- CCLayerTreeHostImplTest.clearRootRenderSurfaceAndScroll
- CCLayerTreeHostImplTest.inhibitScrollAndPageScaleUpdatesWhileAnimatingPageScale
- CCLayerTreeHostImplTest.inhibitScrollAndPageScaleUpdatesWhilePinchZooming
- CCLayerTreeHostImplTest.replaceTreeWhileScrolling
- CCLayerTreeHostImplTest.scrollBeforeRedraw
- CCLayerTreeHostImplTest.scrollBlockedByContentLayer
- CCLayerTreeHostImplTest.scrollChildAndChangePageScaleOnMainThread
- CCLayerTreeHostImplTest.scrollChildBeyondLimit
- CCLayerTreeHostImplTest.scrollChildCallsCommitAndRedraw
- CCLayerTreeHostImplTest.scrollEventBubbling
- CCLayerTreeHostImplTest.scrollMissesBackfacingChild
- CCLayerTreeHostImplTest.scrollMissesChild
- CCLayerTreeHostImplTest.scrollNonCompositedRoot
- CCLayerTreeHostImplTest.scrollRootAndChangePageScaleOnImplThread
- CCLayerTreeHostImplTest.scrollRootAndChangePageScaleOnMainThread
- CCLayerTreeHostImplTest.scrollRootIgnored
- CCLayerTreeHostImplTest.scrollWithoutRootLayer
- CCLayerTreeHostTestScrollChildLayer
- WebCompositorInputHandlerImplTest.gestureScrollOnMainThread
-
- * platform/graphics/chromium/LayerChromium.cpp:
- (WebCore::LayerChromium::LayerChromium):
- (WebCore::LayerChromium::setMaxScrollPosition):
- (WebCore):
- (WebCore::LayerChromium::scrollBy):
- (WebCore::LayerChromium::pushPropertiesTo):
- * platform/graphics/chromium/LayerChromium.h:
- (WebCore):
- (LayerChromiumScrollDelegate):
- (WebCore::LayerChromiumScrollDelegate::~LayerChromiumScrollDelegate):
- (LayerChromium):
- (WebCore::LayerChromium::maxScrollPosition):
- (WebCore::LayerChromium::scrollable):
- (WebCore::LayerChromium::setLayerScrollDelegate):
- * platform/graphics/chromium/cc/CCInputHandler.h:
- * platform/graphics/chromium/cc/CCLayerImpl.cpp:
- (WebCore::CCLayerImpl::tryScroll):
- (WebCore):
- (WebCore::sortLayers):
- * platform/graphics/chromium/cc/CCLayerImpl.h:
- (CCLayerImpl):
- * platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
- (WebCore::CCLayerTreeHost::finishCommitOnImplThread):
- (WebCore::findFirstScrollableLayer):
- (WebCore):
- (WebCore::CCLayerTreeHost::applyScrollAndScale):
- * platform/graphics/chromium/cc/CCLayerTreeHostCommon.h:
- (CCLayerTreeHostCommon):
- (WebCore):
- (WebCore::CCLayerTreeHostCommon::findLayerInSubtree):
- * platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
- (WebCore::CCLayerTreeHostImpl::CCLayerTreeHostImpl):
- (WebCore::CCLayerTreeHostImpl::~CCLayerTreeHostImpl):
- (WebCore::CCLayerTreeHostImpl::startPageScaleAnimation):
- (WebCore::CCLayerTreeHostImpl::calculateRenderSurfaceLayerList):
- (WebCore::CCLayerTreeHostImpl::calculateRenderPasses):
- (WebCore::CCLayerTreeHostImpl::contentSize):
- (WebCore::CCLayerTreeHostImpl::prepareToDraw):
- (WebCore::CCLayerTreeHostImpl::drawLayers):
- (WebCore::findRootScrollLayer):
- (WebCore):
- (WebCore::findScrollLayerForContentLayer):
- (WebCore::CCLayerTreeHostImpl::setRootLayer):
- (WebCore::CCLayerTreeHostImpl::detachLayerTree):
- (WebCore::adjustScrollsForPageScaleChange):
- (WebCore::applyPageScaleDeltaToScrollLayers):
- (WebCore::CCLayerTreeHostImpl::setPageScaleFactorAndLimits):
- (WebCore::CCLayerTreeHostImpl::setPageScaleDelta):
- (WebCore::CCLayerTreeHostImpl::updateMaxScrollPosition):
- (WebCore::CCLayerTreeHostImpl::ensureRenderSurfaceLayerList):
- (WebCore::CCLayerTreeHostImpl::clearCurrentlyScrollingLayer):
- (WebCore::CCLayerTreeHostImpl::scrollBegin):
- (WebCore::CCLayerTreeHostImpl::scrollBy):
- (WebCore::CCLayerTreeHostImpl::scrollEnd):
- (WebCore::CCLayerTreeHostImpl::pinchGestureUpdate):
- (WebCore::CCLayerTreeHostImpl::computePinchZoomDeltas):
- (WebCore::CCLayerTreeHostImpl::makeScrollAndScaleSet):
- (WebCore::collectScrollDeltas):
- (WebCore::CCLayerTreeHostImpl::processScrollDeltas):
- (WebCore::CCLayerTreeHostImpl::animatePageScale):
- (WebCore::CCLayerTreeHostImpl::animateLayers):
- (WebCore::CCLayerTreeHostImpl::clearRenderSurfaces):
- * platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:
- (FrameData):
- (CCLayerTreeHostImpl):
- (WebCore::CCLayerTreeHostImpl::rootScrollLayer):
-
-2012-06-15 Jian Li <jianli@chromium.org>
-
- FileReader is dysfunctional in documents with "null" origin string
- https://bugs.webkit.org/show_bug.cgi?id=78648
-
- Reviewed by Adam Barth.
-
- The fix is to keep in-memory map from blob URL to SecurityOrigin for the
- unique origin case.
-
- Test: fast/files/file-reader-file-url.html
-
- * fileapi/Blob.cpp:
- (WebCore::Blob::Blob):
- * fileapi/BlobURL.cpp:
- (WebCore::BlobURL::getOrigin): Return the origin string embeded in the blob URL.
- (WebCore):
- (WebCore::BlobURL::createBlobURL): Remove the check for null origin string since it is handled now.
- * fileapi/BlobURL.h:
- (BlobURL):
- * fileapi/FileReaderLoader.cpp:
- (WebCore::FileReaderLoader::start):
- * fileapi/ThreadableBlobRegistry.cpp:
- (WebCore):
- (WebCore::originMap): Thread-specific in-memory map from the blob URL to the origin.
- (WebCore::ThreadableBlobRegistry::registerBlobURL): Add the map from the blob URL to the origin.
- (WebCore::ThreadableBlobRegistry::unregisterBlobURL): Remove the map for the unregistered blob URL.
- (WebCore::ThreadableBlobRegistry::getCachedOrigin): Retrieve the origin associated with the blob URL.
- * fileapi/ThreadableBlobRegistry.h:
- (WebCore):
- (ThreadableBlobRegistry):
- * html/DOMURL.cpp:
- (WebCore::DOMURL::createObjectURL):
- * page/SecurityOrigin.cpp:
- (WebCore::getCachedOrigin): Return the cached origin for the blob URL if it exists.
- (WebCore):
- (WebCore::SecurityOrigin::create): Call getCachedOrigin to get the cached origin first.
-
-2012-06-15 Yoshifumi Inoue <yosin@chromium.org>
-
- [Forms] Move search field related code to RenderSearchField from RenderTextControlSingleLine
- https://bugs.webkit.org/show_bug.cgi?id=88980
-
- Reviewed by Kent Tamura.
-
- This patch moves search field related methods in RenderTextControlSingleLine
- to new class RenderSearchField and changes related classes to use
- RenderSearchField.
-
- No new tests. This patch doesn't change behavior.
-
- * CMakeLists.txt: Added new file RenderSearchField.cpp
- * GNUmakefile.list.am: Added new file RenderSearchField.cpp and RenderSearchField.h
- * Target.pri: ditto
- * WebCore.gypi: ditto
- * WebCore.vcproj/WebCore.vcproj: ditto
- * WebCore.xcodeproj/project.pbxproj: ditto
- * html/HTMLInputElement.cpp:
- (WebCore::HTMLInputElement::subtreeHasChanged): Call RenderSearchField::updateCancelButtonVisibility
- (WebCore::HTMLInputElement::addSearchResult): Changed to call InputType::addSearchResult.
- * html/InputType.cpp:
- (WebCore::InputType::addSearchResult): Added.
- * html/InputType.h:
- * html/SearchInputType.cpp:
- (WebCore::SearchInputType::addSearchResult): Moved from HTMLInputElement.
- (WebCore::SearchInputType::createRenderer): Added to create RenderSearchField.
- * html/SearchInputType.h:
- * html/shadow/TextControlInnerElements.cpp:
- (WebCore::SearchFieldResultsButtonElement::defaultEventHandler): Use RenderSearchField instead of RenderTextControlSingleLine.
- * loader/FormSubmission.cpp:
- (WebCore::FormSubmission::create): Got rid isSearchField() guard for addSearchResult().
- * rendering/RenderSearchField.cpp:
- (WebCore::RenderSearchField::RenderSearchField): Renamed to RenderSearchField.
- (WebCore::RenderSearchField::~RenderSearchField): ditto
- (WebCore::RenderSearchField::resultsButtonElement): ditto
- (WebCore::RenderSearchField::cancelButtonElement): ditto
- (WebCore::RenderSearchField::addSearchResult): ditto
- (WebCore::RenderSearchField::showPopup): ditto
- (WebCore::RenderSearchField::hidePopup): ditto
- (WebCore::RenderSearchField::computeControlHeight): Added.
- (WebCore::RenderSearchField::updateFromElement): Moved search field related code from RenderTextControlSingleLine.
- (WebCore::RenderSearchField::updateCancelButtonVisibility): Renamed to RenderSearchField.
- (WebCore::RenderSearchField::visibilityForCancelButton): ditto
- (WebCore::RenderSearchField::autosaveName): ditto
- (WebCore::RenderSearchField::valueChanged): ditto
- (WebCore::RenderSearchField::itemText): ditto
- (WebCore::RenderSearchField::itemLabel): ditto
- (WebCore::RenderSearchField::itemIcon): ditto
- (WebCore::RenderSearchField::itemIsEnabled): ditto
- (WebCore::RenderSearchField::itemStyle): ditto
- (WebCore::RenderSearchField::menuStyle): ditto
- (WebCore::RenderSearchField::clientInsetLeft): ditto
- (WebCore::RenderSearchField::clientInsetRight): ditto
- (WebCore::RenderSearchField::clientPaddingLeft): ditto
- (WebCore::RenderSearchField::clientPaddingRight): ditto
- (WebCore::RenderSearchField::listSize): ditto
- (WebCore::RenderSearchField::selectedIndex): ditto
- (WebCore::RenderSearchField::popupDidHide): ditto
- (WebCore::RenderSearchField::itemIsSeparator): ditto
- (WebCore::RenderSearchField::itemIsLabel): ditto
- (WebCore::RenderSearchField::itemIsSelected): ditto
- (WebCore::RenderSearchField::setTextFromItem): ditto
- (WebCore::RenderSearchField::fontSelector): ditto
- (WebCore::RenderSearchField::hostWindow): ditto
- (WebCore::RenderSearchField::createScrollbar): ditto
- (WebCore::RenderSearchField::computeHeightLimit): Added.
- (WebCore::RenderSearchField::centerContainerIfNeeded): Added.
- * rendering/RenderSearchField.h:
- (WebCore::toRenderSearchField): Added.
- * rendering/RenderTextControlSingleLine.cpp:
- (WebCore::RenderTextControlSingleLine::RenderTextControlSingleLine): Remove search field related code.
- (WebCore::RenderTextControlSingleLine::~RenderTextControlSingleLine): ditto.
- (WebCore::RenderTextControlSingleLine::computeHeightLimit): Added.
- (WebCore::RenderTextControlSingleLine::layout): Use new methods for removing isSearchField.
- (WebCore::RenderTextControlSingleLine::computeControlHeight): Added.
- (WebCore::RenderTextControlSingleLine::updateFromElement): Remove search field related code.
- * rendering/RenderTextControlSingleLine.h:
- (RenderTextControlSingleLine):
- (WebCore::RenderTextControlSingleLine::centerContainerIfNeeded): Added.
- (WebCore::RenderTextControlSingleLine::containerElement): Exposed for RenderSearchField.
- (WebCore::RenderTextControlSingleLine::innerBlockElement): Exposed for RenderSearchField.
- * rendering/RenderingAllInOne.cpp: Added RenderSearchField.cpp
-
-2012-06-15 Hironori Bono <hbono@chromium.org>
-
- Allow platforms to choose whether to remove markers on editing
- https://bugs.webkit.org/show_bug.cgi?id=88838
-
- Reviewed by Hajime Morita.
-
- This change allows platforms to choose whether to remove markers on a word being
- edited. WebKit does not remove markers when we move a selection to a markered
- word on platforms that shouldEraseMarkersAfterChangeSelection returns false.
- On such platforms, WebKit expects to set WTF_USE_MARKER_REMOVAL_UPON_EDITING to
- 1 so Editor::updateMarkersForWordsAffectedByEditing can remove markers. This
- change also checks the return value of shouldEraseMarkersAfterChangeSelection so
- platform can choose it. This change also adds grammar markers so it can also
- remove grammar markers.
-
- Test: editing/spelling/grammar-edit-word.html
-
- * editing/Editor.cpp:
- (WebCore::Editor::updateMarkersForWordsAffectedByEditing):
-
-2012-06-15 Andrey Adaikin <aandrey@chromium.org>
-
- Web Inspector: [WebGL] Simple implementation of the InjectedWebGLScriptSource to support capturing WebGL calls for a frame
- https://bugs.webkit.org/show_bug.cgi?id=89088
-
- Simple experimental implementation of the InjectedWebGLScriptSource.js that allows to wrap
- a WebGL context and capture names (for now) of the WebGL function calls for a frame being captured.
-
- Reviewed by Vsevolod Vlasov.
-
- * inspector/InjectedWebGLScriptSource.js:
- (.):
-
-2012-06-15 Silvia Pfeiffer <silviapf@chromium.org>
-
- Add fullscreen button to Chrome video controls for video.
- https://bugs.webkit.org/show_bug.cgi?id=88818
-
- Reviewed by Eric Carlson.
-
- No new tests, final patch will contain the rebaselined tests.
-
- The Chrome video controls are receiving a visual update.
- This patch includes a fullscreen button for video elements and the rendering of the controls
- in fullscreen including hiding them after 2 seconds when the mouse is out of the controls
- and not moved.
-
- * css/fullscreen.css:
- (video:-webkit-full-screen, audio:-webkit-full-screen):
- Add audio to the default fullscreen styling rules.
- * css/mediaControlsChromium.css:
- (video:-webkit-full-page-media::-webkit-media-controls-panel):
- Align controls to the bottom of the fullscreen page.
- (audio::-webkit-media-controls-fullscreen-button, video::-webkit-media-controls-fullscreen-button):
- Include styling for the fullscreen button.
- * html/shadow/MediaControlRootElementChromium.cpp:
- (WebCore):
- Add a constant for when to hide the controls in fullscreen.
- (WebCore::MediaControlRootElementChromium::MediaControlRootElementChromium):
- Add member fields for fullscreen button, hiding timer and tracking of whether we are in fullscreen.
- (WebCore::MediaControlRootElementChromium::create):
- Add fullscreen button element to the visual layout.
- (WebCore::MediaControlRootElementChromium::setMediaController):
- Add fullscreen button element to the media controller.
- (WebCore::MediaControlRootElementChromium::reset):
- Show the fullscreen button if the controller supports fullscreen.
- (WebCore::MediaControlRootElementChromium::playbackStarted):
- Start the timer to hide the controls in fullscreen.
- (WebCore::MediaControlRootElementChromium::playbackStopped):
- Don't hide the controls when the video is paused in fullscreen.
- (WebCore::MediaControlRootElementChromium::reportedError):
- Hide the fullscreen button when we hit an error.
- (WebCore::MediaControlRootElementChromium::defaultEventHandler):
- Add logic for mouse events in fullscreen to start/stop the hiding timer.
- (WebCore::MediaControlRootElementChromium::startHideFullscreenControlsTimer):
- Start the fullscreen hiding timer.
- (WebCore::MediaControlRootElementChromium::hideFullscreenControlsTimerFired):
- Timer fired: hide the video controls in fullscreen.
- (WebCore::MediaControlRootElementChromium::stopHideFullscreenControlsTimer):
- Reset the fullscreen hiding timer.
- (WebCore::MediaControlRootElementChromium::enteredFullscreen):
- Add logic to enter fullscreen.
- (WebCore::MediaControlRootElementChromium::exitedFullscreen):
- Add logic to exit fullscreen.
- * html/shadow/MediaControlRootElementChromium.h:
- (MediaControlRootElementChromium):
- Add declaration of member functions and fields for fullscreen.
- * rendering/RenderMediaControlsChromium.cpp:
- (WebCore::paintMediaFullscreenButton):
- Use the new image for the fullscreen button.
- * rendering/RenderThemeChromiumMac.h:
- (RenderThemeChromiumMac):
- Declare the fullscreen painting function for Chrome Mac.
- * rendering/RenderThemeChromiumMac.mm:
- (WebCore::RenderThemeChromiumMac::paintMediaFullscreenButton):
- Hook up the fullscreen paining function for Chrome Mac.
- * rendering/RenderThemeChromiumSkia.cpp:
- (WebCore::RenderThemeChromiumSkia::paintMediaFullscreenButton):
- Hook up the fullscreen paining function for Chrome Skia.
- * rendering/RenderThemeChromiumSkia.h:
- (RenderThemeChromiumSkia):
- Declare the fullscreen painting function for Chrome Skia.
-
-2012-06-14 Kent Tamura <tkent@chromium.org>
-
- Unreviewed, rolling out r110340.
- http://trac.webkit.org/changeset/110340
- https://bugs.webkit.org/show_bug.cgi?id=88749
-
- r110340 added a broken implementation of
- HTMLSelectElement::selectedOptions. This roll out removes
- HTMLSelectElement::selectedOptions.
-
- * html/CollectionType.h:
- * html/HTMLCollection.cpp:
- (WebCore::HTMLCollection::shouldIncludeChildren):
- (WebCore::HTMLCollection::isAcceptableElement):
- * html/HTMLSelectElement.cpp:
- * html/HTMLSelectElement.h:
- (HTMLSelectElement):
- * html/HTMLSelectElement.idl:
-
-2012-06-14 Keishi Hattori <keishi@webkit.org>
-
- Add color property to input type=range
- https://bugs.webkit.org/show_bug.cgi?id=89067
-
- Reviewed by Kent Tamura.
-
- Adding color property to input type=range in preparation for
- supporting tick marks for datalist for input type=range.
-
- * css/html.css:
- (input[type="range"]): Setting color property for input type=range.
- This will set the color of tick mark when we implement <datalist>.
- * css/themeChromiumLinux.css:
- (input[type=range]):
- * css/themeWin.css:
- (input[type="range"]):
-
-2012-06-14 Kent Tamura <tkent@chromium.org>
-
- Support file extensions in HTMLInputElement::accept
- https://bugs.webkit.org/show_bug.cgi?id=88298
-
- Reviewed by Hajime Morita.
-
- The WHATWG specification added file extensions supoprt for
- HTMLInputElement::accept recently.
-
- In the WebCore FileChooser interface, we rejected invalid MIME type
- strings in HTMLInputElement::acceptMIMETypes(), and platform file
- choosers don't expect that it containts file extensions. So, this patch
- introduces additional member "acceptFileExtensions" to
- FileChooserSettings, and it contains only file extensions specified by
- an accept attribute.
-
- * html/FileInputType.cpp:
- Sets HTMLInputElement::acceptFileExtensions() to
- FileChooserSettings::acceptFileExtensions.
- (WebCore::FileInputType::handleDOMActivateEvent):
- (WebCore::FileInputType::receiveDropForDirectoryUpload):
- * html/HTMLInputElement.cpp:
- (WebCore::isValidFileExtension): Added.
- (WebCore::parseAcceptAttribute):
- Common part for acceptMIMETyps() and acceptFileExtensions().
- (WebCore::HTMLInputElement::acceptMIMETypes):
- Uses parseAcceptAttribute() with isValidMIMEType().
- (WebCore::HTMLInputElement::acceptFileExtensions):
- Added. Uses parseAcceptAttribute() with isValidFileExtension().
- * html/HTMLInputElement.h:
- (HTMLInputElement): Add acceptFileExtensions().
- * platform/FileChooser.h:
- (FileChooserSettings): Add acceptFileExtensions and acceptTypes().
- * platform/FileChooser.cpp:
- (WebCore::FileChooserSettings::acceptTypes): Added.
-
-2012-06-14 James Robinson <jamesr@chromium.org>
-
- [chromium] Remove unused CanvasLayerChromium.h/cpp from the tree
- https://bugs.webkit.org/show_bug.cgi?id=89152
-
- Reviewed by Adrienne Walker.
-
- These files have been unused and not in the build system since r119769
-
- * platform/graphics/chromium/CanvasLayerChromium.cpp: Removed.
- * platform/graphics/chromium/CanvasLayerChromium.h: Removed.
-
-2012-06-14 Emil A Eklund <eae@chromium.org>
-
- Cast paddings to int in RenderTableCell
- https://bugs.webkit.org/show_bug.cgi?id=88918
-
- Reviewed by Levi Weintraub.
-
- Table layout uses integers throughout yet the TableCell paddingLeft/
- Right/Top/Bottom methods returns LayoutUnits. This causes inconsistent
- rounding as some call sites cast the numbers to ints before doing
- computation and others do computation before casting.
-
- By changing the methods to always cast the padding values to int we
- ensure consistent padding calculations.
-
- Ideally we'd change the type of the return value for the methods but as
- they are overriden that would likely cause more confusion.
-
- Test: fast/sub-pixel/table-cells-with-padding-do-not-wrap.html
-
- * rendering/RenderTableCell.cpp:
- (WebCore::RenderTableCell::paddingTop):
- (WebCore::RenderTableCell::paddingBottom):
- (WebCore::RenderTableCell::paddingLeft):
- (WebCore::RenderTableCell::paddingRight):
- (WebCore::RenderTableCell::paddingBefore):
- (WebCore::RenderTableCell::paddingAfter):
-
-2012-06-14 Kenichi Ishibashi <bashi@chromium.org>
-
- [Chromium] Check the result of FontCache::getCachedFontPlatformData()
- https://bugs.webkit.org/show_bug.cgi?id=89141
-
- Reviewed by Kent Tamura.
-
- The value of FontCache::getCachedFontPlatformData() could be invalid,
- so we should check the value before use it.
-
- No new tests. No new functionality.
-
- * platform/graphics/skia/FontCacheSkia.cpp:
- (WebCore::FontCache::getFontDataForCharacters):
-
-2012-06-14 Gregg Tavares <gman@google.com>
-
- Fix framebuffer completeness test
- https://bugs.webkit.org/show_bug.cgi?id=89127
-
- Reviewed by Kenneth Russell.
-
- No new tests just fixing failing tests.
-
- * html/canvas/WebGLFramebuffer.cpp:
- (WebCore::WebGLFramebuffer::initializeAttachments):
- * html/canvas/WebGLRenderingContext.cpp:
- (WebCore):
- (WebCore::WebGLRenderingContext::isTexInternalFormatColorBufferCombinationValid):
- * platform/graphics/GraphicsContext3D.cpp:
- (WebCore::GraphicsContext3D::getClearBitsByAttachmentType):
- (WebCore):
- (WebCore::GraphicsContext3D::getClearBitsByFormat):
- (WebCore::GraphicsContext3D::getChannelBitsByFormat):
- * platform/graphics/GraphicsContext3D.h:
-
-2012-06-14 Adrienne Walker <enne@google.com>
-
- [chromium] Make TiledLayerChromium robust to unexpected null tiles
- https://bugs.webkit.org/show_bug.cgi?id=89143
-
- Reviewed by James Robinson.
-
- Although there shouldn't ever be null tiles in the map, it appears to
- be occurring frequently enough to show up in crash reports. In the
- short term, be robust to this so the tiler doesn't crash. This should
- eventually be reverted.
-
- * platform/graphics/chromium/TiledLayerChromium.cpp:
- (WebCore::TiledLayerChromium::pushPropertiesTo):
- (WebCore::TiledLayerChromium::setLayerTreeHost):
- (WebCore::TiledLayerChromium::invalidateRect):
- (WebCore::TiledLayerChromium::updateTiles):
- (WebCore::TiledLayerChromium::resetUpdateState):
-
-2012-06-14 Kent Tamura <tkent@chromium.org>
-
- Validate form state strings in FormController::setStateForNewFormElements()
- https://bugs.webkit.org/show_bug.cgi?id=88768
-
- Reviewed by Hajime Morita.
-
- Reject invalid form state vectors. This state vectors are generated by
- WebKit itself. However it can be invalid because
- - Serialized state vectors can be corrupted
- - A future version of WebKit might change the format
-
- So we had better reject unexpected state vectors as possible.
-
- Test: fast/forms/state-restore-broken-state.html
-
- * WebCore.exp.in: Expose some symbols used by Internals.cpp.
- * html/FormController.cpp:
- (WebCore::isNotFormControlTypeCharacter): A helper for state validation.
- (WebCore::FormController::setStateForNewFormElements):
- Reject state vectors of which size is not a multiple of 3, or a type name is invalid.
- * testing/Internals.cpp:
- (WebCore::Internals::formControlStateOfPreviousHistoryItem):
- Returns a form state vector of the previous document.
- (WebCore::Internals::setFormControlStateOfPreviousHistoryItem):
- Sets a form state vector for the previous document.
- * testing/Internals.h: Declare new functions.
- * testing/Internals.idl: ditto.
-
-2012-06-14 Sheriff Bot <webkit.review.bot@gmail.com>
-
- Unreviewed, rolling out r120393.
- http://trac.webkit.org/changeset/120393
- https://bugs.webkit.org/show_bug.cgi?id=89163
-
- breaks cr-mac build (Requested by morrita on #webkit).
-
- * WebCore.gyp/WebCore.gyp:
- * platform/image-decoders/ImageDecoder.h:
- (ImageFrame):
- (ImageDecoder):
- * platform/image-decoders/jpeg/JPEGImageDecoder.cpp:
- (turboSwizzled):
- (WebCore::JPEGImageReader::JPEGImageReader):
- (WebCore::JPEGImageReader::close):
- (WebCore::JPEGImageReader::decode):
- (JPEGImageReader):
- (WebCore::JPEGImageDecoder::outputScanlines):
- * platform/image-decoders/png/PNGImageDecoder.cpp:
- (WebCore::PNGImageReader::PNGImageReader):
- (WebCore::PNGImageReader::close):
- (WebCore::PNGImageReader::currentBufferSize):
- (PNGImageReader):
- (WebCore::PNGImageReader::decodingSizeOnly):
- (WebCore::PNGImageReader::interlaceBuffer):
- (WebCore::PNGImageReader::hasAlpha):
- (WebCore::PNGImageReader::setHasAlpha):
- (WebCore::PNGImageDecoder::headerAvailable):
- (WebCore::PNGImageDecoder::rowAvailable):
- * platform/image-decoders/skia/ImageDecoderSkia.cpp:
- (WebCore):
- (WebCore::resolveColorSpace):
- (WebCore::createColorSpace):
- (WebCore::ImageFrame::setColorProfile):
- (WebCore::ImageFrame::setStatus):
-
-2012-06-14 Julien Chaffraix <jchaffraix@webkit.org>
-
- RenderLayer subtrees without any self-painting layer shouldn't be walked during painting
- https://bugs.webkit.org/show_bug.cgi?id=88888
-
- Reviewed by Simon Fraser.
-
- Performance optimization, covered by existing tests.
-
- The gist of this change is to add a has-self-painting-layer-descendant flag (including an
- invalidation logic) that is used to avoid walking subtrees without any self-painting layer.
-
- On http://dglazkov.github.com/performance-tests/biggrid.html with a 100,000 rows
- by 100 columns table, it brings the paint time during scrolling from ~45ms to ~6ms
- on my machine. The test case is a pathologic example here but the optimization should
- apply in other cases.
-
- The new update logic piggy-backs on top of the existing updateVisibilityStatus() one that
- got repurposed and renamed as part of this change.
-
- * rendering/RenderLayer.cpp:
- (WebCore::RenderLayer::RenderLayer):
- (WebCore::RenderLayer::addChild):
- (WebCore::RenderLayer::removeChild):
- (WebCore::RenderLayer::styleChanged):
- These functions were updated to dirty / set the new flag.
-
- (WebCore::RenderLayer::dirtyAncestorChainHasSelfPaintingLayerDescendantStatus):
- (WebCore::RenderLayer::setAncestorChainHasSelfPaintingLayerDescendant):
- Added those functions to handle setting / invalidating the new flag.
-
- (WebCore::RenderLayer::updateSelfPaintingLayerAfterStyleChange):
- Added this function to handle style update.
-
- (WebCore::RenderLayer::paintLayer):
- (WebCore::RenderLayer::paintLayerContentsAndReflection):
- (WebCore::RenderLayer::paintLayerContents):
- (WebCore::RenderLayer::paintList):
- Changed this logic to bail out if we have no self-painting descendants. This is what
- is giving the performance improvement. Also added some performance ASSERTs to ensure
- the methods are not called when they shouldn't.
-
- (WebCore::RenderLayer::updateDescendantDependentFlags):
- Renamed from updateVisibilityStatus to account for the new usage.
-
- (WebCore::RenderLayer::updateLayerPositions):
- (WebCore::RenderLayer::updateLayerPositionsAfterScroll):
- (WebCore::RenderLayer::collectLayers):
- * rendering/RenderLayerBacking.cpp:
- (WebCore::RenderLayerBacking::updateGraphicsLayerGeometry):
- Updated after updateVisibilityStatus rename.
-
- * rendering/RenderLayer.h:
- (WebCore::RenderLayer::hasSelfPaintingLayerDescendant):
- Added the declaration of the new functions as well as the new flag and dirty bit.
-
-2012-06-14 Tony Payne <tpayne@chromium.org>
-
- [chromium] Add iccjpeg and qcms to chromium port
- https://bugs.webkit.org/show_bug.cgi?id=81974
-
- Reviewed by Adam Barth.
-
- Covered by existing layout tests which will be rebaselined.
-
- * WebCore.gyp/WebCore.gyp: Add qcms to the build.
- * platform/image-decoders/ImageDecoder.h:
- (WebCore::ImageDecoder::qcmsOutputDeviceProfile): Return an sRGB profile.
- On OSX, return the default RGB profile. Add FIXME to use the user's
- monitor profile and verify that profile for other platforms.
-
- * platform/image-decoders/jpeg/JPEGImageDecoder.cpp:
- (turboSwizzled): For libjpeg-turbo, JCS_EXT_BGRA and JCS_EXT_RGBA are the
- two known output color spaces for which the decoder uses a data swizzle.
- (colorSpaceHasAlpha): JPEG's have no alpha in the output color space. For
- libjpeg-turbo, alpha may be present in the swizzled output color space.
-
- (WebCore::JPEGImageReader::JPEGImageReader):
- (WebCore::JPEGImageReader::close):
- (WebCore::JPEGImageReader::decode): For QCMSLIB, create the color transform
- to use during decoding, and ensure we switch to inputing RGBA data to qcms
- even if the desired output data is BGRA: outputScanlines() sends BGRA data
- to the frame buffer following color correction if needed.
- (JPEGImageReader):
- (WebCore::JPEGImageReader::colorTransform): qcms color transform getter.
- (WebCore::JPEGImageReader::createColorTransform): Create color transform.
- Release the existing transform (if any) and assign to the color transform
- created from the color profile data.
- (WebCore::JPEGImageDecoder::outputScanlines): Minor style fix. Apply color
- transform to each decoded image row.
-
- * platform/image-decoders/png/PNGImageDecoder.cpp:
- (WebCore::PNGImageReader::PNGImageReader):
- (WebCore::PNGImageReader::close):
- (WebCore::PNGImageReader::currentBufferSize): Move this adjacent to other
- setters and getters.
- (WebCore::PNGImageReader::decodingSizeOnly): Ditto.
- (WebCore::PNGImageReader::setHasAlpha): Ditto.
- (WebCore::PNGImageReader::hasAlpha): Ditto.
- (WebCore::PNGImageReader::interlaceBuffer): Ditto.
- (WebCore::PNGImageReader::createRowBuffer): Creates a temporary row buffer,
- used when a color transform is applied to the decoded image pixels.
- (WebCore::PNGImageReader::rowBuffer): Return the temporary row buffer.
- (WebCore::PNGImageReader::colorTransform): qcms color transform getter.
- (WebCore::PNGImageReader::createColorTransform): Create color transform.
- Release the existing transform (if any) and assign to the color transform
- created from the color profile data.
- (WebCore::PNGImageDecoder::headerAvailable): For QCMSLIB, create the color
- transform to use for decoding. Clear m_colorProfile (not used anymore).
- (WebCore::PNGImageDecoder::rowAvailable): Create temporary row buffer if
- a color transform is needed for decoding. Apply color transform to each
- decoded image row.
-
- * platform/image-decoders/skia/ImageDecoderSkia.cpp:
- (WebCore::ImageFrame::setColorProfile): Old method of colorProfiles is no
- longer used. Add a FIXME to remove the old implementation.
- (WebCore::ImageFrame::setStatus): Remove old color correction code.
-
-2012-06-14 Sheriff Bot <webkit.review.bot@gmail.com>
-
- Unreviewed, rolling out r120384.
- http://trac.webkit.org/changeset/120384
- https://bugs.webkit.org/show_bug.cgi?id=89157
-
- breaks create-blob-url-from-data-url.html (Requested by
- morrita on #webkit).
-
- * fileapi/Blob.cpp:
- (WebCore::Blob::Blob):
- * fileapi/BlobURL.cpp:
- (WebCore::BlobURL::createBlobURL):
- * fileapi/BlobURL.h:
- (BlobURL):
- * fileapi/FileReaderLoader.cpp:
- (WebCore::FileReaderLoader::start):
- * fileapi/ThreadableBlobRegistry.cpp:
- (WebCore):
- (WebCore::ThreadableBlobRegistry::registerBlobURL):
- (WebCore::ThreadableBlobRegistry::unregisterBlobURL):
- * fileapi/ThreadableBlobRegistry.h:
- (WebCore):
- (ThreadableBlobRegistry):
- * html/DOMURL.cpp:
- (WebCore::DOMURL::createObjectURL):
- * page/SecurityOrigin.cpp:
- (WebCore::SecurityOrigin::create):
-
-2012-06-14 Yoshifumi Inoue <yosin@chromium.org>
-
- [Forms] Copy RenderTextControlSingleLine.{cpp,h} to RenderSearchFiled.{cpp,h}
- https://bugs.webkit.org/show_bug.cgi?id=89155
-
- Reviewed by Kent Tamura.
-
- This patch copies RenderTextControlSingleLine.cpp and .h into RenderSearchField.cpp
- and .h with just "cp" code. New files aren't compiled until bug 88980.
-
- No new tests. This patch doesn't change behavior.
-
- * rendering/RenderSearchField.cpp: Added.
- (WebCore::RenderTextControlInnerBlock::positionForPoint):
- (WebCore::RenderTextControlSingleLine::RenderTextControlSingleLine):
- (WebCore::RenderTextControlSingleLine::~RenderTextControlSingleLine):
- (WebCore::RenderTextControlSingleLine::containerElement):
- (WebCore::RenderTextControlSingleLine::innerBlockElement):
- (WebCore::RenderTextControlSingleLine::innerSpinButtonElement):
- (WebCore::RenderTextControlSingleLine::resultsButtonElement):
- (WebCore::RenderTextControlSingleLine::cancelButtonElement):
- (WebCore::RenderTextControlSingleLine::textBaseStyle):
- (WebCore::RenderTextControlSingleLine::addSearchResult):
- (WebCore::RenderTextControlSingleLine::showPopup):
- (WebCore::RenderTextControlSingleLine::hidePopup):
- (WebCore::RenderTextControlSingleLine::paint):
- (WebCore::RenderTextControlSingleLine::layout):
- (WebCore::RenderTextControlSingleLine::nodeAtPoint):
- (WebCore::RenderTextControlSingleLine::styleDidChange):
- (WebCore::RenderTextControlSingleLine::capsLockStateMayHaveChanged):
- (WebCore::RenderTextControlSingleLine::hasControlClip):
- (WebCore::RenderTextControlSingleLine::controlClipRect):
- (WebCore::RenderTextControlSingleLine::getAvgCharWidth):
- (WebCore::RenderTextControlSingleLine::preferredContentWidth):
- (WebCore::RenderTextControlSingleLine::computeControlHeight):
- (WebCore::RenderTextControlSingleLine::updateFromElement):
- (WebCore::RenderTextControlSingleLine::createInnerTextStyle):
- (WebCore::RenderTextControlSingleLine::createInnerBlockStyle):
- (WebCore::RenderTextControlSingleLine::updateCancelButtonVisibility):
- (WebCore::RenderTextControlSingleLine::visibilityForCancelButton):
- (WebCore::RenderTextControlSingleLine::textShouldBeTruncated):
- (WebCore::RenderTextControlSingleLine::autosaveName):
- (WebCore::RenderTextControlSingleLine::valueChanged):
- (WebCore::RenderTextControlSingleLine::itemText):
- (WebCore::RenderTextControlSingleLine::itemLabel):
- (WebCore::RenderTextControlSingleLine::itemIcon):
- (WebCore::RenderTextControlSingleLine::itemIsEnabled):
- (WebCore::RenderTextControlSingleLine::itemStyle):
- (WebCore::RenderTextControlSingleLine::menuStyle):
- (WebCore::RenderTextControlSingleLine::clientInsetLeft):
- (WebCore::RenderTextControlSingleLine::clientInsetRight):
- (WebCore::RenderTextControlSingleLine::clientPaddingLeft):
- (WebCore::RenderTextControlSingleLine::clientPaddingRight):
- (WebCore::RenderTextControlSingleLine::listSize):
- (WebCore::RenderTextControlSingleLine::selectedIndex):
- (WebCore::RenderTextControlSingleLine::popupDidHide):
- (WebCore::RenderTextControlSingleLine::itemIsSeparator):
- (WebCore::RenderTextControlSingleLine::itemIsLabel):
- (WebCore::RenderTextControlSingleLine::itemIsSelected):
- (WebCore::RenderTextControlSingleLine::setTextFromItem):
- (WebCore::RenderTextControlSingleLine::fontSelector):
- (WebCore::RenderTextControlSingleLine::hostWindow):
- (WebCore::RenderTextControlSingleLine::autoscroll):
- (WebCore::RenderTextControlSingleLine::scrollWidth):
- (WebCore::RenderTextControlSingleLine::scrollHeight):
- (WebCore::RenderTextControlSingleLine::scrollLeft):
- (WebCore::RenderTextControlSingleLine::scrollTop):
- (WebCore::RenderTextControlSingleLine::setScrollLeft):
- (WebCore::RenderTextControlSingleLine::setScrollTop):
- (WebCore::RenderTextControlSingleLine::scroll):
- (WebCore::RenderTextControlSingleLine::logicalScroll):
- (WebCore::RenderTextControlSingleLine::createScrollbar):
- (WebCore::RenderTextControlSingleLine::inputElement):
- * rendering/RenderSearchField.h: Added.
- (RenderTextControlSingleLine):
- (WebCore::RenderTextControlSingleLine::popupIsVisible):
- (WebCore::RenderTextControlSingleLine::isTextField):
- (WebCore::toRenderTextControlSingleLine):
- (RenderTextControlInnerBlock):
- (WebCore::RenderTextControlInnerBlock::RenderTextControlInnerBlock):
- (WebCore::RenderTextControlInnerBlock::hasLineIfEmpty):
-
-2012-06-14 Kent Tamura <tkent@chromium.org>
-
- [JSC/V8] "DOMString[]" for function return values should not be null
- https://bugs.webkit.org/show_bug.cgi?id=89151
-
- Reviewed by Kentaro Hara.
-
- jsArray and v8Array are used for "DOMString[]", not "DOMString[]?". So
- we should not return JavaScript null object.
-
- No new tests. We have no plan to use this code in production code for
- now. It will be used for window.internals functions.
-
- * bindings/js/JSDOMBinding.cpp:
- (WebCore::jsArray): For null input, returns an empty array, not null.
- * bindings/v8/V8Binding.cpp:
- (WebCore::v8Array): Implement DOMStringList -> JavaScript array conversion.
- Like jsArray(), we don't return null object.
- * bindings/v8/V8Binding.h:
- (WebCore): Declare v8Array().
-
-2012-06-14 Dale Curtis <dalecurtis@chromium.org>
-
- Disable click/dbl-click on MediaDocument for Chromium. Fix layout test for all platforms.
- https://bugs.webkit.org/show_bug.cgi?id=89129
-
- As titled, click-to-pause and double-click-to-play behavior are unwanted on Chromium. A
- long standing issue (~3 years) has been to disable this feature.
-
- Reviewed by Eric Carlson.
-
- Uses existing click/double-click test.
-
- * html/MediaDocument.cpp:
- (WebCore::MediaDocument::defaultEventHandler):
-
-2012-06-14 Jian Li <jianli@chromium.org>
-
- FileReader is dysfunctional in documents with "null" origin string
- https://bugs.webkit.org/show_bug.cgi?id=78648
-
- Reviewed by Adam Barth.
-
- The fix is to keep in-memory map from blob URL to SecurityOrigin for the
- unique origin case.
-
- Test: fast/files/file-reader-file-url.html
-
- * fileapi/Blob.cpp:
- (WebCore::Blob::Blob):
- * fileapi/BlobURL.cpp:
- (WebCore::BlobURL::getOrigin): Return the origin string embeded in the blob URL.
- (WebCore):
- (WebCore::BlobURL::createBlobURL): Remove the check for null origin string since it is handled now.
- * fileapi/BlobURL.h:
- (BlobURL):
- * fileapi/FileReaderLoader.cpp:
- (WebCore::FileReaderLoader::start):
- * fileapi/ThreadableBlobRegistry.cpp:
- (WebCore):
- (WebCore::originMap): Thread-specific in-memory map from the blob URL to the origin.
- (WebCore::ThreadableBlobRegistry::registerBlobURL): Add the map from the blob URL to the origin.
- (WebCore::ThreadableBlobRegistry::unregisterBlobURL): Remove the map for the unregistered blob URL.
- (WebCore::ThreadableBlobRegistry::cachedOrigin): Retrieve the origin associated with the blob URL.
- * fileapi/ThreadableBlobRegistry.h:
- (WebCore):
- (ThreadableBlobRegistry):
- * html/DOMURL.cpp:
- (WebCore::DOMURL::createObjectURL):
- * page/SecurityOrigin.cpp:
- (WebCore::cachedOrigin): Return the cached origin for the blob URL if it exists.
- (WebCore):
- (WebCore::SecurityOrigin::create): Call cachedOrigin to get the cached origin first.
-
-2012-06-14 Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com>
-
- [CMAKE] Move JSDeprecatedPeerConnectionCustom.cpp from CMakeLists.txt to UseJSC.cmake
- https://bugs.webkit.org/show_bug.cgi?id=89015
-
- Reviewed by Antonio Gomes.
-
- Include JSDeprecatedPeerConnectionCustom.cpp in UseJSC.cmake
- instead of CMakeLists.txt.
-
- No change in functionality so no new tests.
-
- * CMakeLists.txt:
- * UseJSC.cmake:
-
-2012-06-14 Xianzhu Wang <wangxianzhu@chromium.org>
-
- [Chromium] Add setAutoHint() and setUseBitmaps() in WebFontRendering
- https://bugs.webkit.org/show_bug.cgi?id=89014
-
- Reviewed by James Robinson.
-
- No new tests because of no change of functionality.
-
- * platform/graphics/harfbuzz/FontPlatformDataHarfBuzz.cpp:
- (WebCore):
- (WebCore::FontPlatformData::setAutoHint):
- (WebCore::FontPlatformData::setUseBitmaps):
- (WebCore::FontPlatformData::setAntiAlias):
- (WebCore::FontPlatformData::setupPaint):
- * platform/graphics/harfbuzz/FontPlatformDataHarfBuzz.h:
- (FontPlatformData):
-
-2012-06-14 Ryuan Choi <ryuan.choi@samsung.com>
-
- [EFL] Move cursor related code from WidgetEfl to ewk_view and EflScreenUtilities.
- https://bugs.webkit.org/show_bug.cgi?id=88803
-
- Reviewed by Chang Shu.
-
- Because WebProcess can not control cursor,
- setCursor should be passed to ChromeClient like other ports.
-
- * platform/Widget.h:
- (Widget):
- * platform/efl/EflScreenUtilities.cpp:
- (WebCore::applyFallbackCursor): Moved from WidgetEfl.cpp.
- (WebCore):
- (WebCore::isUsingEcoreX): Moved from WidgetEfl.cpp.
- * platform/efl/EflScreenUtilities.h:
- (WebCore):
- * platform/efl/WidgetEfl.cpp: Removes cursor related codes.
- (WebCore::WidgetPrivate::WidgetPrivate):
- (WebCore::Widget::~Widget):
- (WebCore::Widget::setCursor): Redirect to HostWindow.
- (WebCore::Widget::setEvasObject):
-
-2012-06-14 Ryosuke Niwa <rniwa@webkit.org>
-
- Radio node lists do not get updated when inserted back into a document
- https://bugs.webkit.org/show_bug.cgi?id=88825
-
- Reviewed by Darin Adler.
-
- The bug was caused by RadioNodeList's m_node not being adjusted back to a document after
- it was removed from the document and inserted back. While we could be doing this adjustment again
- when the HTMLFormElement is inserted back into the document, this whole approach is fragile
- because adds a maintenance burden on root elements of RadioNodeList.
-
- Change the approach to the problem instead and detect when m_node is detached from the document.
- Now RadioNodeList and LabelsNodeList will always use its root element as m_node and
- DynamicSubtreeNodeList's node() will then determine whether it should use its document or not based
- on the flag (rootedAtDocument) passed by the constructor of the node list and m_node->inDocument().
-
- Also invalidate node lists rooted at the document level regardless where the DOM mutation took place.
-
- * dom/ClassNodeList.cpp:
- (WebCore::ClassNodeList::~ClassNodeList):
- * dom/Document.cpp:
- (WebCore::Document::registerDynamicSubtreeNodeList): Moved from Node.
- (WebCore::Document::unregisterDynamicSubtreeNodeList): Ditto.
- * dom/Document.h:
- (Document):
- * dom/DynamicNodeList.cpp:
- (WebCore::DynamicSubtreeNodeList::DynamicSubtreeNodeList): Takes DynamicNodeListRootType which tell us
- whether node() should return m_node's document by default or not.
- (WebCore::DynamicSubtreeNodeList::length): Refactor code to avoid node() multiple times.
- (WebCore::DynamicSubtreeNodeList::itemForwardsFromCurrent): Ditto.
- (WebCore::DynamicSubtreeNodeList::itemBackwardsFromCurrent): Ditto.
- (WebCore::DynamicNodeList::itemWithName): Ditto.
- * dom/DynamicNodeList.h:
- (WebCore::DynamicNodeList::DynamicNodeList):
- (WebCore::DynamicNodeList::node): Returns m_node->document() if m_node is still in the document and
- the node list was rooted at document.
- (WebCore::DynamicNodeList::Caches::Caches):
- (Caches):
- (DynamicNodeList):
- (DynamicSubtreeNodeList):
- * dom/NameNodeList.cpp:
- (WebCore::NameNodeList::~NameNodeList):
- * dom/Node.cpp:
- (WebCore):
- (WebCore::Node::invalidateNodeListsCacheAfterAttributeChanged): Invalidate m_listsInvalidatedAtDocument
- at document instead of trying to invalidate it on every ancestor we traverse.
- (WebCore::Node::invalidateNodeListsCacheAfterChildrenChanged): Ditto.
- (WebCore::NodeListsNodeData::invalidateCachesForDocument): Extracted from
- invalidateCachesThatDependOnAttributes.
- (WebCore::NodeListsNodeData::invalidateCachesThatDependOnAttributes):
- (WebCore::Node::radioNodeList):
- * dom/Node.h:
- (Node):
- * dom/NodeRareData.h:
- (NodeListsNodeData):
- * dom/TagNodeList.cpp:
- (WebCore::TagNodeList::~TagNodeList):
- * html/HTMLFormElement.cpp:
- (WebCore::HTMLFormElement::removedFrom):
- * html/LabelsNodeList.cpp:
- (WebCore::LabelsNodeList::LabelsNodeList):
- * html/RadioNodeList.cpp:
- (WebCore::RadioNodeList::RadioNodeList): Takes Element* first since that's the order we use elsewhere.
- * html/RadioNodeList.h:
- (WebCore::RadioNodeList::create):
- (RadioNodeList):
-
-2012-06-14 Tony Chang <tony@chromium.org>
-
- Fix bit packing of StyleRareInheritedData on Windows
- https://bugs.webkit.org/show_bug.cgi?id=89112
-
- Reviewed by Ryosuke Niwa.
-
- On my machine (64 bit Chromium Linux), StyleRareInheritedData is 168 bytes.
-
- No new tests, added a compile assert to ensure correctness going forward.
-
- * rendering/style/StyleRareInheritedData.cpp:
- (SameSizeAsStyleRareInheritedData):
- (WebCore):
- * rendering/style/StyleRareInheritedData.h:
- (StyleRareInheritedData):
-
-2012-06-14 Andreas Kling <kling@webkit.org>
-
- Crashes below IconDatabase::performPendingRetainAndReleaseOperations().
- <http://webkit.org/b/88846>
- <rdar://problem/11629106>
-
- Reviewed by Brady Eidson.
-
- Put isolatedCopy() strings in the retain/release operation queues to make sure it's safe
- for secondary threads to ref/deref them in performPendingRetainAndReleaseOperations().
- Also added assertions as appropriate.
-
- * loader/icon/IconDatabase.cpp:
- (WebCore::IconDatabase::retainIconForPageURL):
- (WebCore::IconDatabase::releaseIconForPageURL):
- (WebCore::IconDatabase::performPendingRetainAndReleaseOperations):
-
-2012-06-14 Shawn Singh <shawnsingh@chromium.org>
-
- [chromium] For hit testing in CCLayerTreeHostCommon, need to check that the transform is invertible before inverting it.
- https://bugs.webkit.org/show_bug.cgi?id=89049
-
- Reviewed by Adrienne Walker.
-
- Unit test added to CCLayerTreeHostCommonTest.cpp:
- CCLayerTreeHostCommonTest.verifyHitTestingForUninvertibleTransform
-
- * platform/graphics/chromium/cc/CCLayerTreeHostCommon.cpp:
- (WebCore::pointHitsRect):
-
-2012-06-14 Maciej Stachowiak <mjs@apple.com>
-
- The whole world rebuilds when you touch any IDL file
- https://bugs.webkit.org/show_bug.cgi?id=89125
-
- Reviewed by Sam Weinig.
-
- No new tests; this only changes the build system and its dependencies.
-
- * bindings/scripts/preprocess-idls.pl: Optionally generate the
- dependencies for supplemental IDLs in Makefile format.
- * DerivedSources.make: Use the new feature of preprocess-idls.pl to generate
- the correct IDL dependencies created by Supplemental, then include it. This way,
- we avoid the situation where every bindings file implicitly depends on every single
- IDL file in the project.
-
-2012-06-14 Ian Vollick <vollick@chromium.org>
-
- [chromium] Certain settings in CCSettings could be global
- https://bugs.webkit.org/show_bug.cgi?id=88384
-
- Reviewed by James Robinson.
-
- No new tests. No new functionality.
-
- * WebCore.gypi:
- * page/Settings.cpp:
- (WebCore::Settings::Settings):
- * page/Settings.h:
- (Settings):
- * platform/graphics/chromium/ContentLayerChromium.cpp:
- (WebCore::ContentLayerChromium::createTextureUpdaterIfNeeded):
- * platform/graphics/chromium/LayerChromium.cpp:
- (WebCore::LayerChromium::addAnimation):
- * platform/graphics/chromium/LayerRendererChromium.cpp:
- (WebCore::LayerRendererChromium::initialize):
- * platform/graphics/chromium/TiledLayerChromium.cpp:
- (WebCore::TiledLayerChromium::updateTileSizeAndTilingOption):
- * platform/graphics/chromium/cc/CCDebugRectHistory.cpp:
- (WebCore::CCDebugRectHistory::enabled):
- (WebCore::CCDebugRectHistory::saveDebugRectsForCurrentFrame):
- * platform/graphics/chromium/cc/CCDebugRectHistory.h:
- (WebCore):
- (CCDebugRectHistory):
- * platform/graphics/chromium/cc/CCHeadsUpDisplay.cpp:
- (WebCore::CCHeadsUpDisplay::enabled):
- (WebCore::CCHeadsUpDisplay::showPlatformLayerTree):
- (WebCore::CCHeadsUpDisplay::showDebugRects):
- (WebCore::CCHeadsUpDisplay::draw):
- (WebCore::CCHeadsUpDisplay::drawHudContents):
- (WebCore::CCHeadsUpDisplay::drawDebugRects):
- * platform/graphics/chromium/cc/CCHeadsUpDisplay.h:
- (WebCore):
- (CCHeadsUpDisplay):
- * platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
- (WebCore::CCLayerTreeHost::create):
- (WebCore::CCLayerTreeHost::CCLayerTreeHost):
- (WebCore::CCLayerTreeHost::animateLayers):
- * platform/graphics/chromium/cc/CCLayerTreeHost.h:
- (WebCore::CCLayerTreeSettings::CCLayerTreeSettings):
- (CCLayerTreeSettings):
- (CCLayerTreeHost):
- (WebCore::CCLayerTreeHost::settings):
- * platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
- (WebCore::CCLayerTreeHostImpl::create):
- (WebCore::CCLayerTreeHostImpl::CCLayerTreeHostImpl):
- (WebCore::CCLayerTreeHostImpl::calculateRenderSurfaceLayerList):
- (WebCore::CCLayerTreeHostImpl::animateLayers):
- * platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:
- (CCLayerTreeHostImpl):
- * platform/graphics/chromium/cc/CCRenderer.h:
- (CCRendererClient):
- (WebCore::CCRenderer::settings):
- * platform/graphics/chromium/cc/CCSettings.cpp: Added.
- (WebCore):
- (WebCore::CCSettings::perTilePaintingEnabled):
- (WebCore::CCSettings::setPerTilePaintingEnabled):
- (WebCore::CCSettings::partialSwapEnabled):
- (WebCore::CCSettings::setPartialSwapEnabled):
- (WebCore::CCSettings::acceleratedAnimationEnabled):
- (WebCore::CCSettings::setAcceleratedAnimationEnabled):
- (WebCore::CCSettings::reset):
- * platform/graphics/chromium/cc/CCSettings.h: Added.
- (WebCore):
- (CCSettings):
- * testing/InternalSettings.cpp:
- * testing/InternalSettings.h:
- (InternalSettings):
-
-2012-06-14 Alejandro G. Castro <alex@igalia.com>
-
- [GTK] Add TextureMapper ImageBuffer support as a fallback from the hardware accelerated path
- https://bugs.webkit.org/show_bug.cgi?id=73634
-
- Remove the TextureMapperCairo classes, now we use
- TextureMapperImageBuffer to implement the software fallback. Add
- implementation for the 3D transformations in the 2D cairo graphics
- context.
-
- Reviewed by Martin Robinson.
-
- This patch adds a new implementation of already tested cases.
-
- * GNUmakefile.list.am:
- * platform/graphics/cairo/GraphicsContext3DPrivate.cpp:
- (WebCore):
- (WebCore::GraphicsContext3DPrivate::paintToTextureMapper):
- Required for compilation when WebGL is enabled.
- * platform/graphics/cairo/GraphicsContextCairo.cpp:
- (WebCore::GraphicsContext::get3DTransform):
- (WebCore::GraphicsContext::concat3DTransform):
- (WebCore::GraphicsContext::set3DTransform):
- * platform/graphics/cairo/TextureMapperCairo.cpp: Removed.
- * platform/graphics/cairo/TextureMapperCairo.h: Removed.
- * platform/graphics/texmap/TextureMapperImageBuffer.cpp:
- (WebCore::BitmapTextureImageBuffer::updateContents):
-
-2012-06-14 Jia Pu <jpu@apple.com>
-
- Mark text with text alternative with blue underline.
- https://bugs.webkit.org/show_bug.cgi?id=83047
-
- Reviewed by Enrica Casucci.
-
- Tests: platform/mac/editing/input/edit-dictated-text-with-alternative.html
- platform/mac/editing/input/insert-dictated-text.html
-
- This patch implements visual indication on dictated text with alternatives, and provides UI
- to show alternative text on OS X. Majority of the changes is for generalizing existing AlternativeTextController
- class to handle dictation alternatives. The two new classes, AlternativeTextUIController and
- TextAlternativeWithRange, are used by both WebKit and WK2. So WebCore seems to be the natural place
- for them.
-
- * WebCore.exp.in:
- * WebCore.xcodeproj/project.pbxproj:
- * editing/AlternativeTextController.cpp: Expanded exising class interface to support dictation alternatives.
- (DictationAlternativeDetails): Marker detail class for dictation alternative mark.
- (WebCore::DictationAlternativeDetails::create):
- (WebCore::DictationAlternativeDetails::dictationContext):
- (WebCore::DictationAlternativeDetails::DictationAlternativeDetails):
- (WebCore::markerTypesForAppliedDictationAlternative):
- (WebCore::AlternativeTextController::applyAlternativeTextToRange): Generalized existing applyAlternativeTextToRange() to handle dictation alternatives.
- (WebCore::AlternativeTextController::timerFired): Expanded existing code to handle dictation alternatives.
- (WebCore::AlternativeTextController::handleAlternativeTextUIResult): Expanded existing code to handle dictation alternatives.
- (WebCore::AlternativeTextController::respondToChangedSelection): Moved part of the function into respondToMarkerAtEndOfWord() to improve readability.
- (WebCore::AlternativeTextController::shouldStartTimerFor):
- (WebCore::AlternativeTextController::respondToMarkerAtEndOfWord):
- (WebCore::AlternativeTextController::markerDescriptionForAppliedAlternativeText):
- (WebCore::AlternativeTextController::removeDictationAlternativesForMarker):
- (WebCore::AlternativeTextController::dictationAlternativesForMarker):
- (WebCore::AlternativeTextController::applyDictationAlternative):
- * editing/AlternativeTextController.h:
- * editing/Editor.cpp:
- (WebCore::Editor::notifyComponentsOnChangedSelection): Renamed existing respondToChangedSelection() function to avoid naming collision.
- (WebCore::Editor::appliedEditing):
- (WebCore::Editor::unappliedEditing):
- (WebCore::Editor::reappliedEditing):
- (WebCore::Editor::updateMarkersForWordsAffectedByEditing):
- (WebCore::Editor::changeSelectionAfterCommand):
- (WebCore::Editor::respondToChangedSelection):
- (WebCore::Editor::dictationAlternativesForMarker):
- (WebCore::Editor::applyDictationAlternativelternative):
- * editing/Editor.h:
- * editing/FrameSelection.h:
- * editing/mac/AlternativeTextUIController.h: Added. WK1 and WK2 use this class to keep track of text alternatives objects.
- (AlternativeTextUIController):
- (WebCore::AlternativeTextUIController::AlternativeTextUIController):
- (AlernativeTextContextController):
- (WebCore::AlternativeTextUIController::AlernativeTextContextController::AlernativeTextContextController):
- * editing/mac/AlternativeTextUIController.mm: Added.
- (WebCore::AlternativeTextUIController::AlernativeTextContextController::addAlternatives):
- (WebCore::AlternativeTextUIController::AlernativeTextContextController::alternativesForContext):
- (WebCore::AlternativeTextUIController::AlernativeTextContextController::removeAlternativesForContext):
- (WebCore::AlternativeTextUIController::AlernativeTextContextController::clear):
- (WebCore::AlternativeTextUIController::addAlternatives):
- (WebCore::AlternativeTextUIController::alternativesForContext):
- (WebCore::AlternativeTextUIController::clear):
- (WebCore::AlternativeTextUIController::showAlternatives):
- (WebCore::AlternativeTextUIController::handleAcceptedAlternative):
- (WebCore::AlternativeTextUIController::dismissAlternatives):
- (WebCore::AlternativeTextUIController::removeAlternatives):
- * editing/mac/TextAlternativeWithRange.h: Added. A simple struct to make it easier to pass around a pair of text alternatives object and range.
- * editing/mac/TextAlternativeWithRange.mm: Added.
- (WebCore::TextAlternativeWithRange::TextAlternativeWithRange):
- (WebCore::collectDictationTextAlternatives):
- * page/AlternativeTextClient.h:
- * page/ContextMenuController.cpp: Added code to show alternative dictated text in context menu.
- (WebCore::ContextMenuController::contextMenuItemSelected):
- (WebCore::ContextMenuController::populate):
- (WebCore::ContextMenuController::checkOrEnableIfNeeded):
- * platform/ContextMenuItem.h:
- * rendering/HitTestResult.cpp:
- (WebCore::HitTestResult::dictationAlternatives):
- * rendering/HitTestResult.h:
- * rendering/InlineTextBox.cpp:
- (WebCore::InlineTextBox::paintDocumentMarker):
-
-2012-06-14 Emil A Eklund <eae@chromium.org>
-
- Change RenderTableSection::calcRowLogicalHeight to round rather than floor height
- https://bugs.webkit.org/show_bug.cgi?id=88813
-
- Reviewed by Julien Chaffraix.
-
- Change RenderTableSection::calcRowLogicalHeight to round the
- logicalHeight instead of flooring it. This matches our rounding logic
- elsewhere and results in table rows better matching the expected height.
-
- Test: fast/sub-pixel/table-rows-have-stable-height.html
-
- * rendering/RenderTableSection.cpp:
- (WebCore::RenderTableSection::calcRowLogicalHeight):
-
-2012-06-14 Andrey Adaikin <aandrey@chromium.org>
-
- Web Inspector: Remove devtoolsInjectedScript hidden property
- https://bugs.webkit.org/show_bug.cgi?id=89087
-
- We use the devtoolsInjectedScript hidden property to reference a InjectedScript object
- for a given ScriptState, but we also have the same reference in the InjectedScriptManager's
- hash maps. Just use the hash maps and remove the hidden property from the global object.
-
- Reviewed by Pavel Feldman.
-
- * bindings/js/JSDOMGlobalObject.cpp:
- (WebCore::JSDOMGlobalObject::visitChildren):
- * bindings/js/JSDOMGlobalObject.h:
- (JSDOMGlobalObject):
- * bindings/js/JSInjectedScriptManager.cpp:
- (WebCore::InjectedScriptManager::createInjectedScript):
- * bindings/v8/V8HiddenPropertyName.h:
- (WebCore):
- * bindings/v8/custom/V8InjectedScriptManager.cpp:
- * inspector/InjectedScriptManager.cpp:
- (WebCore::InjectedScriptManager::discardInjectedScripts):
- (WebCore::InjectedScriptManager::discardInjectedScriptsFor):
- (WebCore::InjectedScriptManager::injectedScriptFor):
- (WebCore):
- (WebCore::InjectedScriptManager::wrapWebGLRenderingContextForInstrumentation):
- * inspector/InjectedScriptManager.h:
- (InjectedScriptManager):
-
-2012-06-14 James Robinson <jamesr@chromium.org>
-
- [chromium] Move opaque rectangle tracking logic out of compositor core
- https://bugs.webkit.org/show_bug.cgi?id=89031
-
- Reviewed by Adrienne Walker.
-
- This moves the opaque paint tracking logic from the compositor (specifically CanvasLayerTextureUpdater) out to a
- dedicated class used by GraphicsLayerChromium for GraphicsContext-painted content. This changes the interface
- exposed by the compositor to pass a SkCanvas and let the user fill in an opaque rect if needed. Callers that are
- using GraphicsContext to paint can instantiate a PlatformContextSkia / GraphicsContext around this SkCanvas if
- they choose to, or use some other strategy, or not fill it in at all. This avoids creating extra wrapper classes
- if the eventual caller is going to use the underlying SkCanvas anyway (such as WebContentLayer) and breaks the
- dependency from the compositor code on GraphicsContext / PlatformContextSkia.
-
- OpaqueRectTrackingContentLayerDelegate is a helper class that wraps a ContentLayerDelegate implementation with
- PlatformContextSkia's opaque region tracking logic.
-
- * WebCore.gypi:
- * platform/graphics/chromium/BitmapCanvasLayerTextureUpdater.cpp:
- (WebCore::BitmapCanvasLayerTextureUpdater::BitmapCanvasLayerTextureUpdater):
- (WebCore::BitmapCanvasLayerTextureUpdater::prepareToUpdate):
- (WebCore::BitmapCanvasLayerTextureUpdater::updateTextureRect):
- (WebCore::BitmapCanvasLayerTextureUpdater::setOpaque):
- * platform/graphics/chromium/BitmapCanvasLayerTextureUpdater.h:
- (WebCore):
- (BitmapCanvasLayerTextureUpdater):
- * platform/graphics/chromium/CanvasLayerTextureUpdater.cpp:
- (WebCore::CanvasLayerTextureUpdater::paintContents):
- * platform/graphics/chromium/CanvasLayerTextureUpdater.h:
- (WebCore):
- (CanvasLayerTextureUpdater):
- * platform/graphics/chromium/ContentLayerChromium.cpp:
- (WebCore::ContentLayerPainter::paint):
- * platform/graphics/chromium/ContentLayerChromium.h:
- (ContentLayerDelegate):
- (WebCore):
- * platform/graphics/chromium/GraphicsLayerChromium.cpp:
- (WebCore::GraphicsLayerChromium::GraphicsLayerChromium):
- (WebCore::GraphicsLayerChromium::paint):
- * platform/graphics/chromium/GraphicsLayerChromium.h:
- (GraphicsLayerChromium):
- * platform/graphics/chromium/LayerPainterChromium.h:
- (LayerPainterChromium):
- * platform/graphics/chromium/LinkHighlight.cpp:
- (WebCore::LinkHighlight::paintContents):
- * platform/graphics/chromium/LinkHighlight.h:
- (LinkHighlight):
- * platform/graphics/chromium/OpaqueRectTrackingContentLayerDelegate.cpp: Added.
- (WebCore):
- (WebCore::OpaqueRectTrackingContentLayerDelegate::OpaqueRectTrackingContentLayerDelegate):
- (WebCore::OpaqueRectTrackingContentLayerDelegate::~OpaqueRectTrackingContentLayerDelegate):
- (WebCore::OpaqueRectTrackingContentLayerDelegate::paintContents):
- * platform/graphics/chromium/OpaqueRectTrackingContentLayerDelegate.h: Added.
- (WebCore):
- (GraphicsContextPainter):
- (WebCore::GraphicsContextPainter::~GraphicsContextPainter):
- (OpaqueRectTrackingContentLayerDelegate):
- (WebCore::OpaqueRectTrackingContentLayerDelegate::setOpaque):
- * platform/graphics/chromium/PlatformCanvas.cpp:
- (WebCore::PlatformCanvas::Painter::Painter):
- * platform/graphics/chromium/SkPictureCanvasLayerTextureUpdater.cpp:
- (WebCore::SkPictureCanvasLayerTextureUpdater::prepareToUpdate):
- * platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
- * platform/graphics/chromium/cc/CCLayerTreeHost.h:
- (WebCore):
-
-2012-06-14 Justin Novosad <junov@chromium.org>
-
- [Chromium] webkitImageSmoothingEnabled canvas property does not work on redraw
- https://bugs.webkit.org/show_bug.cgi?id=89018
-
- Reviewed by Stephen White.
-
- Test: fast/canvas/canvas-imageSmoothingEnabled-repaint.html
-
- When an accelerated canvas layer prepares its texture for the
- compositor, it must send a notification to skia to invalidate texture
- proprties that are cached by skia, since the compositor may modify them.
- The use case this fixes is when a canvas to canvas copy is performed
- with webkitImageSmoothingEnabled=false on the destination canvas.
- The backing texture of the source canvas will be set to "nearest"
- filtering by skia in order to perform the copy. Then, the compositor
- sets filtering back to "linear" when the source canvas is drawn.
- Skia is designed to only update GL attributes when required, so errors
- occur when the skia-side GL state cache is out of sync.
-
- * platform/graphics/chromium/Canvas2DLayerBridge.cpp:
- (WebCore::Canvas2DLayerBridge::prepareTexture):
-
-2012-06-14 Jon Honeycutt <jhoneycutt@apple.com>
-
- Fix some failing tests on Windows by resetting the page scale factor
- between tests.
- https://bugs.webkit.org/show_bug.cgi?id=89078
-
- Reviewed by Dirk Pranke.
-
- * testing/Internals.cpp:
- (WebCore::Internals::reset):
- Set the scale factor to 1.0.
-
-2012-06-14 Sami Kyostila <skyostil@chromium.org>
-
- Register fixed position layers with ScrollingCoordinator
- https://bugs.webkit.org/show_bug.cgi?id=78864
-
- Reviewed by James Robinson.
-
- This patch makes ScrollingCoordinator aware of page elements that are
- either fixed positioned directly or through their ancestors and that
- also have their own composited backing layers. This allows the
- ScrollingCoordinator implementation to potentially enable fast
- scrolling even if there are fixed elements on the page, because the
- compositor can automatically reposition the fixed element layers after
- scrolling.
-
- Since fixed position layers need to be explicitly supported by the
- ScrollingCoordinator implementation, we add a new
- supportsFixedPositionLayers() query for checking this.
-
- * page/FrameView.cpp:
- (WebCore::FrameView::FrameView):
- (WebCore::FrameView::useSlowRepaints):
- (WebCore::FrameView::addFixedObject):
- (WebCore::FrameView::removeFixedObject):
- * page/FrameView.h:
- (FrameView):
- (WebCore::FrameView::fixedObjects):
- (WebCore::FrameView::hasFixedObjects):
- * page/scrolling/ScrollingCoordinator.cpp:
- (WebCore::ScrollingCoordinator::frameViewFixedObjectsDidChange):
- (WebCore::ScrollingCoordinator::hasNonLayerFixedObjects):
- (WebCore):
- (WebCore::ScrollingCoordinator::updateShouldUpdateScrollLayerPositionOnMainThread):
- (WebCore::ScrollingCoordinator::setLayerIsContainerForFixedPosition):
- (WebCore::ScrollingCoordinator::setLayerIsFixedToContainerLayer):
- * page/scrolling/ScrollingCoordinator.h:
- (ScrollingCoordinator):
- * page/scrolling/chromium/ScrollingCoordinatorChromium.cpp:
- (WebCore::ScrollingCoordinator::setLayerIsContainerForFixedPosition):
- (WebCore):
- (WebCore::ScrollingCoordinator::setLayerIsFixedToContainerLayer):
- * rendering/RenderBox.cpp:
- (WebCore::RenderBox::willBeDestroyed):
- (WebCore::RenderBox::styleWillChange):
- * rendering/RenderLayerBacking.cpp:
- (WebCore::RenderLayerBacking::updateGraphicsLayerGeometry):
- * rendering/RenderLayerCompositor.cpp:
- (WebCore::RenderLayerCompositor::updateBacking):
- (WebCore):
- (WebCore::RenderLayerCompositor::fixedPositionedByAncestor):
- (WebCore::RenderLayerCompositor::ensureRootLayer):
- * rendering/RenderLayerCompositor.h:
-
-2012-06-14 Alexey Proskuryakov <ap@apple.com>
-
- [CFNetwork] XMLHttpRequest incorrectly returns cached responses even when there is a Vary header field
- https://bugs.webkit.org/show_bug.cgi?id=88925
-
- Reviewed by David Kilzer.
-
- Test: http/tests/cache/xhr-vary-header.html
-
- * platform/network/cf/ResourceHandleCFNet.cpp: (WebCore::willCacheResponse): Don't
- cache the response at all if there is a Vary header field. CFNetwork won't look at
- it if we allowed the response cached.
-
- * platform/network/mac/ResourceHandleMac.mm:
- (WebCore::ResourceHandle::createNSURLConnection): [NSURLResponse copy] is mutable
- in practice, but we should be nice, and use -mutableCopy.
- (-[WebCoreResourceHandleAsDelegate connection:willCacheResponse:]): Same fix as in
- CFNet code.
-
-2012-06-13 Andrey Kosyakov <caseq@chromium.org>
-
- Web Inspector: use CSS gradients instead of images for timeline bars, checkboxes & bullets
- https://bugs.webkit.org/show_bug.cgi?id=89024
-
- Reviewed by Pavel Feldman.
-
- This brings a bunch of UI changes to the way Timeline bars and related controls are rendered:
-
- - introduce new color palette for categories;
- - replace images used to render timeline bars, list bullets and categories checkboxes with CSS gradients;
- - "flatten" timeline bars
- - make square list bullets, sharpen corners for lower pane bars;
- - make links on the list sidebar grey
- - add more space between categories checkboxes, make labels lighter.
-
- * WebCore.gypi: Remove old images, add tickMark.png.
- * inspector/front-end/Images/timelineBarBlue.png: Removed.
- * inspector/front-end/Images/timelineBarDarkGreen.png: Removed.
- * inspector/front-end/Images/timelineBarGray.png: Removed.
- * inspector/front-end/Images/timelineBarGreen.png: Removed.
- * inspector/front-end/Images/timelineBarLightPurple.png: Removed.
- * inspector/front-end/Images/timelineBarOrange.png: Removed.
- * inspector/front-end/Images/timelineBarPurple.png: Removed.
- * inspector/front-end/Images/timelineBarRed.png: Removed.
- * inspector/front-end/Images/timelineBarYellow.png: Removed.
- * inspector/front-end/Images/timelineCheckmarks.png: Removed.
- * inspector/front-end/Images/timelineDots.png: Removed.
- * inspector/front-end/TimelinePanel.js:
- (WebInspector.TimelinePanel.prototype.wasShown):
- (WebInspector.TimelinePanel.prototype._closeRecordDetails): Fixed trailing spaces;
- (WebInspector.TimelinePanel.prototype._injectCategoryStyles): Inject generated styles for categories, if necessary.
- * inspector/front-end/TimelinePresentationModel.js:
- (WebInspector.TimelinePresentationModel.categories):
- (WebInspector.TimelinePresentationModel.createFillStyle):
- (WebInspector.TimelinePresentationModel.createStyleRuleForCategory):
- * inspector/front-end/WebKit.qrc: Remove old images, add tickMark.png
- * inspector/front-end/inspector.css:
- (.sidebar-tree-section):
- * inspector/front-end/timelinePanel.css:
- (#timeline-container .webkit-html-resource-link):
- (.timeline-category-statusbar-item):
- (.timeline-category-statusbar-item .timeline-category-checkbox):
- (.timeline-category-statusbar-item .timeline-category-checkbox:checked::before):
- (.timeline-tree-item):
- (.timeline-tree-item .timeline-tree-icon):
- (.timeline-graph-bar):
- (.timeline-graph-bar.with-children):
- (.timeline-graph-bar.cpu):
- (.timeline-aggregated-category):
- * inspector/front-end/utilities.js:
- (Object.values): Return an array of object field's values.
-
-2012-06-14 Silvia Pfeiffer <silviapf@chromium.org>
-
- Change mute button and volume slider behaviour for new Chromium video controls.
- https://bugs.webkit.org/show_bug.cgi?id=88743
-
- Reviewed by Eric Carlson.
-
- No new tests, final patch will contain the rebaselined tests.
-
- The Chrome video controls are receiving a visual update. This patch makes the mute button and
- the volume slider interact with each other. When the user mutes the video through clicking the
- mute button, the volume slider animates to 0% volume. Upon unmute, the previous volume level
- is restored. Further, when the user drags the volume slider thumb or clicks on the slider and
- the video is muted, the video unmutes and sets the volume to the user's chosen level.
-
- * html/shadow/MediaControlElements.cpp:
- (WebCore::MediaControlVolumeSliderElement::MediaControlVolumeSliderElement):
- Add a member field to the volume slider to allow user interaction to unmute the video.
- (WebCore::MediaControlVolumeSliderElement::defaultEventHandler):
- Add the logic to unmute the video if the m_clearMutedOnUserInteraction member field is true.
- (WebCore::MediaControlVolumeSliderElement::setClearMutedOnUserInteraction):
- Add a member function to change the value of the m_clearMutedOnUserInteraction member field.
- * html/shadow/MediaControlElements.h:
- (MediaControlVolumeSliderElement):
- Add the setClearMutedOnUserInteraction member function and the m_clearMutedOnUserInteraction member field.
- * html/shadow/MediaControlRootElementChromium.cpp:
- (WebCore::MediaControlRootElementChromium::create):
- Activate unmute on user interaction on the Chromium video volume slider.
- (WebCore::MediaControlRootElementChromium::changedMute):
- Add logic to set volume slider to 0 when muted and reset to volume when unmuted.
- * rendering/RenderMediaControlsChromium.cpp:
- (WebCore::paintMediaVolumeSlider):
- Add logic to paint the volume slider active area as 0 when muted.
-
-2012-06-14 Vsevolod Vlasov <vsevik@chromium.org>
-
- Web Inspector: Breakpoints should not be set when UISourceCode content is diverged from VM version of the script.
- https://bugs.webkit.org/show_bug.cgi?id=89109
-
- Reviewed by Pavel Feldman.
-
- * inspector/front-end/BreakpointManager.js:
- (WebInspector.BreakpointManager.Breakpoint.prototype._updateBreakpoint):
- * inspector/front-end/JavaScriptSource.js:
- (WebInspector.JavaScriptSource.prototype.isDivergedFromVM):
- (WebInspector.JavaScriptSource.prototype.workingCopyCommitted):
-
-2012-06-14 Vsevolod Vlasov <vsevik@chromium.org>
-
- Web Inspector: DebuggerModel should support setting breakpoints without script by sourceURL only.
- https://bugs.webkit.org/show_bug.cgi?id=88988
-
- Reviewed by Pavel Feldman.
-
- This change allows setting all saved breakpoints in debugger model by url before the site
- with corresponding scripts was loaded (allows breaking in onload handler on first load).
- This change also simplifies implementation of snippets debugging.
-
- * inspector/front-end/BreakpointManager.js:
- * inspector/front-end/DebuggerModel.js:
- (WebInspector.DebuggerModel.prototype.setBreakpointByScriptLocation):
-
-2012-06-14 Pavel Feldman <pfeldman@chromium.org>
-
- Web Inspector: refactor settings screen to move user agent and experiments out of general tab.
- https://bugs.webkit.org/show_bug.cgi?id=89101
-
- Reviewed by Vsevolod Vlasov.
-
- See image attached to the bug.
-
- * English.lproj/localizedStrings.js:
- * inspector/front-end/SettingsScreen.js:
- (WebInspector.SettingsScreen.prototype.selectTab):
- (WebInspector.SettingsScreen.prototype._tabSelected):
- (WebInspector.SettingsScreen.prototype.set wasShown):
- (WebInspector.SettingsScreen.prototype.willHide):
- (WebInspector.SettingsTab):
- (WebInspector.SettingsTab.prototype._appendSection):
- (WebInspector.SettingsTab.prototype._createCustomSetting):
- (WebInspector.GenericSettingsTab):
- (WebInspector.GenericSettingsTab.prototype._showPaintRectsChanged):
- (WebInspector.GenericSettingsTab.prototype.get _updateScriptDisabledCheckbox):
- (WebInspector.GenericSettingsTab.prototype._javaScriptDisabledChanged):
- (WebInspector.UserAgentSettingsTab):
- (WebInspector.UserAgentSettingsTab.prototype._createUserAgentSelectRowElement.get const):
- (WebInspector.UserAgentSettingsTab.prototype._createUserAgentSelectRowElement.textDoubleClicked):
- (WebInspector.UserAgentSettingsTab.prototype._createUserAgentSelectRowElement.textChanged):
- (WebInspector.UserAgentSettingsTab.prototype._createUserAgentSelectRowElement.set checkboxClicked):
- (WebInspector.UserAgentSettingsTab.prototype._createDeviceMetricsElement):
- (WebInspector.ExperimentsSettingsTab):
- (WebInspector.ExperimentsSettingsTab.prototype._createExperimentsWarningSubsection):
- (WebInspector.ExperimentsSettingsTab.prototype._createExperimentCheckbox.listener):
- (WebInspector.ExperimentsSettingsTab.prototype._createExperimentCheckbox):
- * inspector/front-end/ShortcutsScreen.js:
- * inspector/front-end/TabbedPane.js:
- (WebInspector.TabbedPane.prototype.get headerContentsElement):
- * inspector/front-end/helpScreen.css:
- (.settings-tab.help-container):
- (.settings-tab .help-block):
- (.help-content fieldset):
- (#settings-screen .tabbed-pane-header-tabs):
- (#settings-screen .tabbed-pane-header-tab):
-
-2012-06-13 Mark Hahnenberg <mhahnenberg@apple.com>
-
- Worker tear-down can re-enter JSC during GC finalization pt. 2
- https://bugs.webkit.org/show_bug.cgi?id=88601
-
- Reviewed by David Levin.
-
- No new tests. Current regression tests are sufficient.
-
- * workers/WorkerMessagingProxy.cpp:
- (WebCore::WorkerMessagingProxy::WorkerMessagingProxy):
- (WebCore::WorkerMessagingProxy::workerObjectDestroyed): We clear the m_workerObject here because
- we don't want anybody else trying to send messages to the Worker now that it has been destroyed.
- We also queue the asynchronous task for the various other cleanup that still needs to be done.
- This allows us to avoid the problem of re-entrant JS code execution during GC.
- (WebCore):
- (WebCore::WorkerMessagingProxy::workerObjectDestroyedInternal): Here we set m_mayBeDestroyed to true.
- This is the point after which deleting the WorkerMessagingProxy in workerContextDestroyedInternal()
- is okay. It could happen during this function call if the worker thread has been shutdown already, or
- it could be called later after we shut down the worker thread.
- (WebCore::WorkerMessagingProxy::workerContextDestroyedInternal): We check m_mayBeDestroyed here
- instead of checking m_workerObject. This change effectively orthogonalizes the roles that m_workerObject
- was filling. Since we were eagerly clearing m_workerObject, but we wanted to asynchronously call
- workerObjectDestroyed(), we needed to make sure we didn't accidentally try to delete the WorkerMessagingProxy
- twice (once from destroying the Worker and once from destroying the WorkerContext). This boolean field
- should fix that issue--we set it lazily like we wanted to do without being in danger of causing use-after-free
- issues with m_workerObject.
- * workers/WorkerMessagingProxy.h: Added the new field and function.
- (WorkerMessagingProxy):
-
-2012-06-14 Alexander Pavlov <apavlov@chromium.org>
-
- Web Inspector: Selector list start position is not extracted for style rules inside @media rules
- https://bugs.webkit.org/show_bug.cgi?id=89094
-
- Reviewed by Pavel Feldman.
-
- Selector list start is now marked inside the "ruleset" rule rather than separately, before its invocation(s).
-
- * css/CSSGrammar.y:
-
-2012-06-14 Eric Penner <epenner@google.com>
-
- [chromium] Fix race condition where animations start, finish and are deleted on the composite thread, all before the start even arrives on the main thread.
- https://bugs.webkit.org/show_bug.cgi?id=88439
-
- Reviewed by James Robinson.
-
- Scheduling behavior covered by existing tests.
-
- * platform/graphics/chromium/cc/CCActiveAnimation.cpp:
- (WebCore::CCActiveAnimation::isFinishedAt):
- * platform/graphics/chromium/cc/CCActiveAnimation.h:
- (WebCore::CCActiveAnimation::isFinished):
- * platform/graphics/chromium/cc/CCLayerAnimationController.cpp:
- (WebCore::CCLayerAnimationController::suspendAnimations):
- (WebCore::CCLayerAnimationController::pushAnimationUpdatesTo):
- (WebCore::CCLayerAnimationController::animate):
- (WebCore::CCLayerAnimationController::hasActiveAnimation):
- (WebCore):
- (WebCore::CCLayerAnimationController::markAnimationsForDeletion):
- (WebCore::CCLayerAnimationController::purgeAnimationsMarkedForDeletion):
- * platform/graphics/chromium/cc/CCLayerAnimationController.h:
- (CCLayerAnimationController):
-
-2012-06-14 Vsevolod Vlasov <vsevik@chromium.org>
-
- Web Inspector: ConsoleView.evaluateUsingTextPrompt should evaluate without command line API.
- https://bugs.webkit.org/show_bug.cgi?id=89096
-
- Reviewed by Pavel Feldman.
-
- * inspector/front-end/ConsoleView.js:
-
-2012-06-14 Silvia Pfeiffer <silviapf@chromium.org>
-
- Update the time display of the new Chromium media controls.
- https://bugs.webkit.org/show_bug.cgi?id=88724
-
- Reviewed by Eric Carlson.
-
- No new tests, final patch will contain the rebaselined tests.
-
- The Chrome video controls are receiving a visual update. This patch changes
- the format of the time digits that are displayed. They are different for media
- files of different duration. For non-autoplaying videos, the duration is shown
- before playback is started.
-
- * css/mediaControlsChromium.css:
- (audio::-webkit-media-controls-time-remaining-display, video::-webkit-media-controls-time-remaining-display):
- Format the new duration display the same as the current time display.
- * html/shadow/MediaControlRootElementChromium.cpp:
- (WebCore::MediaControlRootElementChromium::MediaControlRootElementChromium):
- Add a member field for the duration display.
- (WebCore::MediaControlRootElementChromium::create):
- Add an element for the duration display and initially hide the current time display.
- (WebCore::MediaControlRootElementChromium::setMediaController):
- Add the duration display to the controller.
- (WebCore::MediaControlRootElementChromium::reset):
- Add reset functionality for the duration display.
- (WebCore::MediaControlRootElementChromium::playbackStarted):
- Show the current time display and hide the duration display upon playback start.
- (WebCore::MediaControlRootElementChromium::updateTimeDisplay):
- Show the current time display and hide the duration display when current time is non-zero.
- * html/shadow/MediaControlRootElementChromium.h:
- (WebCore):
- Add the MediaControlTimeRemainingDisplayElement which provides use with the duration display.
- (MediaControlRootElementChromium):
- Add a duration member field, reusing the existing MediaControlTimeRemainingDisplayElement.
- * rendering/RenderMediaControlsChromium.cpp:
- (WebCore::formatChromiumMediaControlsTime):
- Formats a given time under the condition of a given duration.
- (WebCore::RenderMediaControlsChromium::formatMediaControlsTime):
- When formatting a single time, assume it to also provide the duration conditions.
- (WebCore::RenderMediaControlsChromium::formatMediaControlsCurrentTime):
- Format the current time given the duration.
- (WebCore::RenderMediaControlsChromium::formatMediaControlsRemainingTime):
- Format the remaining time from the current time given the duration.
- * rendering/RenderMediaControlsChromium.h:
- (RenderMediaControlsChromium):
- Declare the time formatting member functions.
- * rendering/RenderThemeChromiumMac.h:
- (RenderThemeChromiumMac):
- Declare the time formatting member functions for Chromium on the Mac.
- * rendering/RenderThemeChromiumMac.mm:
- (WebCore::RenderThemeChromiumMac::formatMediaControlsTime):
- (WebCore::RenderThemeChromiumMac::formatMediaControlsCurrentTime):
- (WebCore::RenderThemeChromiumMac::formatMediaControlsRemainingTime):
- Call the time formatting member functions of RenderMediaControlsChromium on the Mac.
- * rendering/RenderThemeChromiumSkia.cpp:
- (WebCore::formatMediaControlsTime):
- (WebCore::formatMediaControlsCurrentTime):
- (WebCore::formatMediaControlsRemainingTime):
- Call the time formatting member functions of RenderMediaControlsChromium on Skia.
- * rendering/RenderThemeChromiumSkia.h:
- (RenderThemeChromiumSkia):
- Declare the time formatting member functions for Chromium Skia.
-
-2012-06-14 Eugene Klyuchnikov <eustas.bug@gmail.com>
-
- Web Inspector: Refactor message loop instrumentation.
- https://bugs.webkit.org/show_bug.cgi?id=88978
-
- Reviewed by Pavel Feldman.
-
- 1) Remove "messageLoop" term
- 2) Reuse WebThread::TaskObserver interface
- 3) Move implementation (from embedder) to platform code.
-
- * inspector/InspectorClient.h:
- (WebCore::InspectorClient::startMainThreadMonitoring): Renamed method.
- (WebCore::InspectorClient::stopMainThreadMonitoring): Ditto.
- * inspector/InspectorTimelineAgent.cpp:
- (WebCore::InspectorTimelineAgent::start):
- (WebCore::InspectorTimelineAgent::stop):
-
-2012-06-14 Dominik Röttsches <dominik.rottsches@intel.com>
-
- [svg] SVGResources applied to Text with Incorrect Transformations in non-CG Implementations
- https://bugs.webkit.org/show_bug.cgi?id=64966
-
- Reviewed by Nikolas Zimmermann.
-
- SVGInlineTextBox::paintTextWithShadows for non-CG implementations resets the scale aspect
- of the currently applied CTM. This leads to patterns and gradients being incorrectly downscaled.
- This way of resetting the CTM and drawing fonts "natively" scaled was introduced
- in r77485 to fix a number of issues with SVG font scaling.
- Unfortunately, this breaks scaling of patterns and gradients. To fix it,
- we need to push the transformation back into the pattern/gradient space transformation.
-
- Tests: svg/transforms/transformed-text-fill-gradient.html
- svg/transforms/transformed-text-fill-pattern.html
-
- * rendering/svg/RenderSVGInlineText.cpp:
- (WebCore::RenderSVGInlineText::computeNewScaledFontForStyle): Moving the scaling factor calculation out into SVGRenderingContext.
- * rendering/svg/RenderSVGResourceContainer.cpp:
- (WebCore::RenderSVGResourceContainer::shouldTransformOnTextPainting): Reusing the scaling factor calculation from SVGRenderingContext.
- (WebCore):
- * rendering/svg/RenderSVGResourceContainer.h:
- (RenderSVGResourceContainer):
- * rendering/svg/RenderSVGResourceGradient.cpp:
- (WebCore::RenderSVGResourceGradient::applyResource): If needed, push down transformation into gradient space.
- * rendering/svg/RenderSVGResourcePattern.cpp:
- (WebCore::RenderSVGResourcePattern::applyResource): If needed, push transformation into pattern space.
- * rendering/svg/SVGRenderingContext.cpp:
- (WebCore::SVGRenderingContext::calculateScreenFontSizeScalingFactor): Common scaling factor calculation for RenderSVGInlineText and RenderSVGResourceContainer.
- * rendering/svg/SVGRenderingContext.h:
- (SVGRenderingContext):
-
-2012-06-14 Yoshifumi Inoue <yosin@chromium.org>
-
- [Form] Replace InputNumber type to Decimal type and drop InputNumber
- https://bugs.webkit.org/show_bug.cgi?id=88746
-
- Reviewed by Kent Tamura.
-
- This patch removes InputNumber introduced by r119540 by replacing
- InputNumber type to Decimal type and changing convertDoubleToDecimal
- and convertDecimalToDouble to Decimal::fromDouble and
- Decimal::toDouble, respectively.
-
- No new tests. This patch doesn't change behavior.
-
- * html/BaseDateAndTimeInputType.cpp:
- (WebCore::BaseDateAndTimeInputType::setValueAsDecimal):
- (WebCore::BaseDateAndTimeInputType::defaultValueForStepUp):
- (WebCore::BaseDateAndTimeInputType::parseToNumber):
- (WebCore::BaseDateAndTimeInputType::serialize):
- (WebCore::BaseDateAndTimeInputType::serializeWithComponents):
- (WebCore::BaseDateAndTimeInputType::serializeWithMilliseconds):
- * html/BaseDateAndTimeInputType.h:
- (BaseDateAndTimeInputType):
- * html/DateInputType.cpp:
- (WebCore::DateInputType::createStepRange):
- * html/DateTimeInputType.cpp:
- (WebCore::DateTimeInputType::defaultValueForStepUp):
- (WebCore::DateTimeInputType::createStepRange):
- * html/DateTimeInputType.h:
- (DateTimeInputType):
- * html/DateTimeLocalInputType.cpp:
- (WebCore::DateTimeLocalInputType::createStepRange):
- * html/HTMLInputElement.cpp:
- (WebCore::HTMLInputElement::getAllowedValueStep):
- * html/HTMLInputElement.h:
- (HTMLInputElement):
- * html/InputType.cpp:
- (WebCore::InputType::setValueAsDouble):
- (WebCore::InputType::setValueAsDecimal):
- (WebCore::InputType::rangeUnderflow):
- (WebCore::InputType::rangeOverflow):
- (WebCore::InputType::defaultValueForStepUp):
- (WebCore::InputType::minimum):
- (WebCore::InputType::maximum):
- (WebCore::InputType::isInRange):
- (WebCore::InputType::isOutOfRange):
- (WebCore::InputType::stepMismatch):
- (WebCore::InputType::validationMessage):
- (WebCore::InputType::parseToNumber):
- (WebCore::InputType::parseToNumberOrNaN):
- (WebCore::InputType::serialize):
- (WebCore::InputType::applyStep):
- (WebCore::InputType::getAllowedValueStep):
- (WebCore::InputType::stepUpFromRenderer):
- * html/InputType.h:
- (InputType):
- * html/MonthInputType.cpp:
- (WebCore::MonthInputType::defaultValueForStepUp):
- (WebCore::MonthInputType::createStepRange):
- (WebCore::MonthInputType::parseToNumber):
- * html/MonthInputType.h:
- (MonthInputType):
- * html/NumberInputType.cpp:
- (WebCore::NumberInputType::setValueAsDecimal):
- (WebCore::NumberInputType::createStepRange):
- (WebCore::NumberInputType::parseToNumber):
- (WebCore::NumberInputType::serialize):
- * html/NumberInputType.h:
- (NumberInputType):
- * html/RangeInputType.cpp:
- (WebCore::ensureMaximum):
- (WebCore::RangeInputType::setValueAsDecimal):
- (WebCore::RangeInputType::createStepRange):
- (WebCore::RangeInputType::handleKeydownEvent):
- (WebCore::RangeInputType::parseToNumber):
- (WebCore::RangeInputType::serialize):
- (WebCore::RangeInputType::sanitizeValue):
- * html/RangeInputType.h:
- (RangeInputType):
- * html/StepRange.cpp:
- (WebCore::StepRange::StepRange):
- (WebCore::StepRange::acceptableError):
- (WebCore::StepRange::alignValueForStep):
- (WebCore::StepRange::clampValue):
- (WebCore::StepRange::parseStep):
- (WebCore::StepRange::roundByStep):
- (WebCore::StepRange::stepMismatch):
- * html/StepRange.h:
- (WebCore::StepRange::StepDescription::defaultValue):
- (StepRange):
- (WebCore::StepRange::maximum):
- (WebCore::StepRange::minimum):
- (WebCore::StepRange::step):
- (WebCore::StepRange::stepBase):
- (WebCore::StepRange::defaultValue):
- (WebCore::StepRange::proportionFromValue):
- (WebCore::StepRange::valueFromProportion):
- * html/TimeInputType.cpp:
- (WebCore::TimeInputType::defaultValueForStepUp):
- (WebCore::TimeInputType::createStepRange):
- * html/TimeInputType.h:
- (TimeInputType):
- * html/WeekInputType.cpp:
- (WebCore::WeekInputType::createStepRange):
- * html/shadow/CalendarPickerElement.cpp:
- (WebCore::CalendarPickerElement::writeDocument):
- * html/shadow/SliderThumbElement.cpp:
- (WebCore::sliderPosition):
- (WebCore::RenderSliderThumb::layout):
- (WebCore::SliderThumbElement::setPositionFromPoint):
-
-2012-06-14 Jan Keromnes <janx@linux.com>
-
- Web Inspector: Implement ExtensionPanel.show() method
- https://bugs.webkit.org/show_bug.cgi?id=88473
-
- Implemented ExtensionPanel.show() API method to allow extension
- developers to show their panel when needed.
-
- Reviewed by Pavel Feldman.
-
- Tests for this method are in:
- LayoutTests/inspector/extensions/extensions-panel.html
-
- * inspector/front-end/ExtensionAPI.js:
- (defineCommonExtensionSymbols):
- (injectedExtensionAPI.ExtensionPanelImpl.prototype.createStatusBarButton):
- (injectedExtensionAPI.ExtensionPanelImpl.prototype.show):
- * inspector/front-end/ExtensionServer.js:
- (WebInspector.ExtensionServer):
- (WebInspector.ExtensionServer.prototype._onShowPanel):
-
-2012-06-14 Kent Tamura <tkent@chromium.org>
-
- Fix a typo in r120304.
- https://bugs.webkit.org/show_bug.cgi?id=89070
-
- * bindings/scripts/CodeGeneratorV8.pm:
- (NativeToJSValue):
- * bindings/scripts/test/V8/V8TestObj.cpp:
-
-2012-06-14 David Barr <davidbarr@chromium.org>
-
- Add dpcm to css3-images image-resolution
- https://bugs.webkit.org/show_bug.cgi?id=85442
-
- Reviewed by Tony Chang.
-
- The css3-images module is at candidate recommendation.
- http://www.w3.org/TR/2012/CR-css3-images-20120417/#the-image-resolution
-
- No new tests; extended fast/css/image-resolution/image-resolution.html
-
- * css/CSSGrammar.y: Add DPCM token and unary term.
- * css/CSSParser.cpp: Extend range of units accepted for resolution and tokenize "dpcm".
- (WebCore::CSSParser::validUnit): Accept CSSPrimitiveValue::CSS_DPCM.
- (WebCore::CSSParser::createPrimitiveNumericValue): Accept CSSPrimitiveValue::CSS_DPCM.
- (WebCore::unitFromString): Map "dpcm" to CSSPrimitiveValue::CSS_DPCM.
- (WebCore::CSSParser::parseValidPrimitive): Accept CSSPrimitiveValue::CSS_DPCM.
- (WebCore::CSSParser::detectNumberToken): Map "dpcm" to CSSPrimitiveValue::CSS_DPCM.
- * css/CSSPrimitiveValue.cpp: Add CSSPrimitiveValue::CSS_DPCM as a numeric unit.
- (WebCore::isValidCSSUnitTypeForDoubleConversion): Accept CSSPrimitiveValue::CSS_DPCM.
- (WebCore::unitCategory): Map CSSPrimitiveValue::CSS_DPCM to CSSPrimitiveValue::UResolution.
- (WebCore::conversionToCanonicalUnitsScaleFactor): Scale CSSPrimitiveValue::CSS_DPCM to CSSPrimitiveValue::CSS_DPPX.
- (WebCore::CSSPrimitiveValue::customCssText): Format CSSPrimitiveValue::CSS_DPCM as "<num>dpcm".
- (WebCore::CSSPrimitiveValue::cloneForCSSOM): Accept CSSPrimitiveValue::CSS_DPCM as numeric unit.
- * css/CSSPrimitiveValue.h: Add CSSPrimitiveValue::CSS_DPCM.
-
-2012-06-14 Ilya Tikhonovsky <loislo@chromium.org>
-
- Web Inspector: REGRESSION HeapProfiler can't remove heap snapshot from the list if Dominators view has been opened.
- https://bugs.webkit.org/show_bug.cgi?id=89080
-
- There was no dispose method on artificial ShowMoreDataGrid node.
-
- Reviewed by Pavel Feldman.
-
- * inspector/front-end/ShowMoreDataGridNode.js:
- (WebInspector.ShowMoreDataGridNode.prototype.nodeHeight):
- (WebInspector.ShowMoreDataGridNode.prototype.dispose):
-
-2012-06-14 Kent Tamura <tkent@chromium.org>
-
- [JSC/V8] Improve DOMString[] support
- https://bugs.webkit.org/show_bug.cgi?id=89070
-
- Reviewed by Kentaro Hara.
-
- Tests: new test case in TestObj.idl
-
- * bindings/js/JSDOMBinding.cpp:
- (WebCore::jsArray): Implement jsArray() for DOMStringList.
- * bindings/js/JSDOMBinding.h: Declare jsArray() for DOMStringList.
- * bindings/scripts/CodeGeneratorJS.pm:
- (NativeToJSValue): Avoid to include JSDOMString.h and DOMString.h.
- * bindings/scripts/CodeGeneratorV8.pm:
- (GetNativeType): Move a check for DOMString[] because it's a RefPtr type
- and we'd like to avoid to generate RefPtr<DOMString[]>
- (%non_wrapper_types): DOMString[] is not a wrapper type. This is needed
- to avoid to generate unnecessary custom function template.
- (NativeToJSValue): Avoid to include V8DOMString.h and DOMString.h.
-
- * bindings/scripts/test/TestObj.idl: Add non-overload function using DOMString[].
- * bindings/scripts/test/JS/JSTestObj.cpp: Update expectation.
- * bindings/scripts/test/JS/JSTestObj.h: ditto.
- * bindings/scripts/test/V8/V8TestObj.cpp: ditto.
-
-2012-06-14 Matt Falkenhagen <falken@chromium.org>
-
- LocaleToScriptMappingDefault.cpp should also do what scriptCodeForFontSelection does in LocaleToScriptMappingICU.cpp
- https://bugs.webkit.org/show_bug.cgi?id=88845
-
- Reviewed by Kent Tamura.
-
- Test: fast/text/international/jpan-script-equivalence.html
-
- * platform/text/LocaleToScriptMappingDefault.cpp:
- (WebCore::scriptNameToCode):
-
-2012-06-14 Pavel Feldman <pfeldman@chromium.org>
-
- Web Inspector: render dock-to-right icon in status bar.
- https://bugs.webkit.org/show_bug.cgi?id=89040
-
- Reviewed by Vsevolod Vlasov.
-
- Today we render dock to bottom icon for both actions (dock to bottom and dock to right).
-
- * inspector/front-end/Images/statusbarButtonGlyphs.png:
- * inspector/front-end/inspector.css:
- (button.dock-status-bar-item.status-bar-item.toggled-undock .glyph):
- (button.dock-status-bar-item.status-bar-item.toggled-bottom .glyph):
- (button.dock-status-bar-item.status-bar-item.toggled-right .glyph):
- * inspector/front-end/inspector.js:
- (WebInspector._createGlobalStatusBarItems):
- (WebInspector._installDockToRight.listener):
- (windowLoaded):
- (WebInspector.setDockingUnavailable):
-
-2012-06-14 Pavel Feldman <pfeldman@chromium.org>
-
- Web Inspector: clear execution live before the text edit.
- https://bugs.webkit.org/show_bug.cgi?id=89016
-
- Reviewed by Vsevolod Vlasov.
-
- Otherwise we can't remove them after committing the edit.
-
- * inspector/front-end/JavaScriptSourceFrame.js:
- (WebInspector.JavaScriptSourceFrame.prototype.beforeTextChanged):
- (WebInspector.JavaScriptSourceFrame.prototype.clearExecutionLine):
-
-2012-06-14 Min Qin <qinmin@google.com>
-
- Remove the const keyword from MediaPlayerPrivate::enterFullscreen()
- https://bugs.webkit.org/show_bug.cgi?id=89044
-
- Reviewed by Adam Barth.
-
- enterFullscreen() and exitFullscreen() could both modify the player state.
- This change reverts the change we made in r120213.
-
- Just function declaration change, no test needed.
-
- * platform/graphics/MediaPlayerPrivate.h:
- (WebCore::MediaPlayerPrivateInterface::enterFullscreen):
-
-2012-06-14 Edaena Salinas Jasso <edaena@apple.com>
-
- el.getAttribute('type') returns 'null' when setting el.type to null
- https://bugs.webkit.org/show_bug.cgi?id=89030
-
- Reviewed by Alexey Proskuryakov.
-
- Test: fast/dom/HTMLButtonElement/change-type.html
-
- * html/HTMLButtonElement.cpp:
- (WebCore::HTMLButtonElement::setType): Changed parameter to be AtomicString to
- address an unrelated review comment from bug 14439 for slightly better performance.
- * html/HTMLButtonElement.h:
- (HTMLButtonElement): Changed parameter to be AtomicString to address an unrelated
- review comment from bug 14439 for slightly better performance.
- * html/HTMLButtonElement.idl: Specified TreatNullAs NullString for the type attribute.
-
-2012-06-14 Alec Flett <alecflett@chromium.org>
-
- IndexedDB: Creating a transaction from within a transaction callback should fail
- https://bugs.webkit.org/show_bug.cgi?id=80547
-
- Reviewed by Tony Chang.
-
- Prevent creation of a transaction, via IDBDatabase.transaction()
- or IDBDatabase.setVersion(), from inside a setVersion()
- transaction, as per spec. Update many tests to deal with this.
-
- Test restructuring uncovered some inconsistencies in transaction
- mode handling. So also do some minor cleanup in the way the
- transaction mode is passed between the frontend and backend
- transaction objects, and add additional asserts.
-
- * Modules/indexeddb/IDBCursor.cpp:
- (WebCore::IDBCursor::update):
- * Modules/indexeddb/IDBCursorBackendImpl.cpp:
- (WebCore::IDBCursorBackendImpl::update):
- * Modules/indexeddb/IDBDatabase.cpp:
- (WebCore::IDBDatabase::setVersion):
- (WebCore::IDBDatabase::transaction):
- * Modules/indexeddb/IDBObjectStoreBackendImpl.cpp:
- (WebCore::IDBObjectStoreBackendImpl::putInternal):
- * Modules/indexeddb/IDBRequest.cpp:
- (WebCore::IDBRequest::onSuccess):
- * Modules/indexeddb/IDBTransaction.cpp:
- (WebCore::IDBTransaction::create):
- (WebCore::IDBTransaction::IDBTransaction):
- (WebCore::IDBTransaction::stringToMode):
- (WebCore::IDBTransaction::modeToString):
- * Modules/indexeddb/IDBTransaction.h:
- (IDBTransaction):
-
-2012-06-14 Li Yin <li.yin@intel.com>
-
- [WebSocket] WebSocket object in Worker Context should fire error event when it fails connection.
- https://bugs.webkit.org/show_bug.cgi?id=88744
-
- Reviewed by Kent Tamura.
-
- Spec:http://dev.w3.org/html5/websockets/#feedback-from-the-protocol
- The behavior of firing error event in Document has been implemented in Committed r117944.
- WebSocket in WorkerContext is also required to fire error event.
-
- Test: http/tests/websocket/tests/hybi/workers/close.html
-
- * Modules/websockets/ThreadableWebSocketChannelClientWrapper.cpp:
- (WebCore::ThreadableWebSocketChannelClientWrapper::didReceiveMessageError):
- (WebCore):
- (WebCore::ThreadableWebSocketChannelClientWrapper::didReceiveMessageErrorCallback):
- * Modules/websockets/ThreadableWebSocketChannelClientWrapper.h:
- (ThreadableWebSocketChannelClientWrapper):
- * Modules/websockets/WorkerThreadableWebSocketChannel.cpp:
- (WebCore::workerContextDidReceiveMessageError):
- (WebCore):
- (WebCore::WorkerThreadableWebSocketChannel::Peer::didReceiveMessageError):
- * Modules/websockets/WorkerThreadableWebSocketChannel.h:
- (Peer):
-
-2012-06-13 Kinuko Yasuda <kinuko@chromium.org>
-
- Unreviewed build fix attempt for r120285
-
- * Modules/filesystem/DOMFileSystemBase.cpp:
- (WebCore):
-
-2012-06-13 MORITA Hajime <morrita@google.com>
-
- Unreviewed expectation update.
-
- * bindings/scripts/test/V8/V8Float64Array.cpp:
- * bindings/scripts/test/V8/V8TestActiveDOMObject.cpp:
- * bindings/scripts/test/V8/V8TestCustomNamedGetter.cpp:
- * bindings/scripts/test/V8/V8TestEventConstructor.cpp:
- * bindings/scripts/test/V8/V8TestEventTarget.cpp:
- * bindings/scripts/test/V8/V8TestException.cpp:
- * bindings/scripts/test/V8/V8TestInterface.cpp:
- * bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp:
- * bindings/scripts/test/V8/V8TestNamedConstructor.cpp:
- * bindings/scripts/test/V8/V8TestNode.cpp:
- * bindings/scripts/test/V8/V8TestObj.cpp:
- (WebCore::V8TestObj::installPerContextProperties):
- * bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:
-
-2012-06-13 Kinuko Yasuda <kinuko@chromium.org>
-
- Move isolated file system code out of chromium-specific directory
- https://bugs.webkit.org/show_bug.cgi?id=88997
-
- Reviewed by Adam Barth.
-
- The code does not need to be chromium-specific. Any platforms that
- have file system implementation and manage mappings from file system
- id to a set of files should share the code.
-
- No new tests as this has no functional/behavioral changes.
-
- * Modules/filesystem/DOMFileSystem.cpp:
- (WebCore::DOMFileSystem::createIsolatedFileSystem):
- (WebCore):
- * Modules/filesystem/DOMFileSystem.h:
- (DOMFileSystem):
- * Modules/filesystem/DOMFileSystemBase.h:
- (DOMFileSystemBase):
- * Modules/filesystem/FileSystemType.h:
- * Modules/filesystem/chromium/DOMFileSystemChromium.cpp:
- * Modules/filesystem/chromium/DOMFileSystemChromium.h: Removed.
- * Modules/filesystem/chromium/DraggedIsolatedFileSystem.cpp:
- (WebCore::DraggedIsolatedFileSystem::getDOMFileSystem):
- * WebCore.gypi:
-
-2012-06-07 Kinuko Yasuda <kinuko@chromium.org>
-
- File::lastModifiedDate should use NaN or separate boolean flag for null Date value
- https://bugs.webkit.org/show_bug.cgi?id=87826
-
- Reviewed by Kent Tamura.
-
- Test: http/tests/local/fileapi/file-last-modified-after-delete.html
-
- * fileapi/File.cpp:
- (WebCore::File::File):
- (WebCore::File::captureSnapshot):
- (WebCore::File::lastModifiedDate):
- (WebCore::File::lastModifiedDateForBinding): Removed.
- * fileapi/File.h:
- (File):
- * fileapi/File.idl:
- * platform/FileMetadata.h:
- (WebCore::FileMetadata::FileMetadata):
- * platform/FileSystem.h:
- * platform/FileStream.cpp:
- (WebCore::FileStream::getSize):
- * platform/chromium/support/WebHTTPBody.cpp:
- (WebKit::WebHTTPBody::elementAt):
- * platform/network/BlobData.h:
- (WebCore::BlobDataItem::doNotCheckFileChange): Removed.
- * platform/network/BlobData.cpp:
- * platform/network/cf/FormDataStreamCFNet.cpp:
- (WebCore::advanceCurrentStream):
- * platform/network/soup/ResourceHandleSoup.cpp:
- (WebCore::blobIsOutOfDate):
-
-2012-06-13 Eli Fidler <efidler@rim.com>
-
- Fix CMake build with SMOOTH_SCROLLING enabled
- https://bugs.webkit.org/show_bug.cgi?id=89032
-
- Reviewed by Antonio Gomes.
-
- SMOOTH_SCROLLING pulls in ScrollAnimatorNone.cpp, which has
- dependencies on platform/ActivePlatformGestureAnimation.cpp and
- platform/TouchpadFlingPlatformGestureCurve.cpp
-
- * CMakeLists.txt:
-
-2012-06-13 Mihai Balan <mibalan@adobe.com>
-
- Touched CSSPropertyNames.in to trigger a proper rebuild
-
- [CSS Regions] Adding feature defines for CSS Regions & exclusions for Windows
- https://bugs.webkit.org/show_bug.cgi?id=88645
-
- Reviewed by Sam Weinig.
-
- Previous work on #87442 added feature defines to allow proper disabling of CSS Regions and
- exclusions (previously even with the feature disabled, parsing still worked). However, the
- feature defines were enabled on Mac only - they were broken on Windows. This
- patch adds the feature defines to (re)enable regions and exclusions on Windows.
-
- * css/CSSPropertyNames.in: Touched to trigger a proper rebuild. Incremental builds were broken on Windows.
-
-2012-06-13 Arnaud Renevier <arno@renevier.net>
-
- make sure headers are included only once per file
- https://bugs.webkit.org/show_bug.cgi?id=88931
-
- Reviewed by Darin Adler.
-
- * Modules/indexeddb/IDBDatabase.cpp:
- * WebCorePrefix.h:
- * bindings/js/JSHTMLAllCollectionCustom.cpp:
- * bindings/v8/V8Utilities.cpp:
- * bindings/v8/custom/V8LocationCustom.cpp:
- * bridge/NP_jsobject.cpp:
- * editing/Editor.cpp:
- * html/HTMLMediaElement.cpp:
- * platform/graphics/cairo/PlatformContextCairo.cpp:
- * rendering/InlineFlowBox.cpp:
-
-2012-06-13 MORITA Hajime <morrita@google.com>
-
- Unreviewed typo fix.
-
- * platform/RefCountedSupplement.h:
-
-2012-06-13 Sheriff Bot <webkit.review.bot@gmail.com>
-
- Unreviewed, rolling out r120268.
- http://trac.webkit.org/changeset/120268
- https://bugs.webkit.org/show_bug.cgi?id=89060
-
- WebCompositor::setPerTilePaintingEnabled hits an assertion in
- DEBUG (Requested by dominicc|work on #webkit).
-
- * WebCore.gypi:
- * page/Settings.cpp:
- (WebCore::Settings::Settings):
- * page/Settings.h:
- (WebCore::Settings::setPerTileDrawingEnabled):
- (WebCore::Settings::perTileDrawingEnabled):
- (Settings):
- (WebCore::Settings::setPartialSwapEnabled):
- (WebCore::Settings::partialSwapEnabled):
- (WebCore::Settings::setThreadedAnimationEnabled):
- (WebCore::Settings::threadedAnimationEnabled):
- * platform/graphics/chromium/ContentLayerChromium.cpp:
- (WebCore::ContentLayerChromium::createTextureUpdaterIfNeeded):
- * platform/graphics/chromium/LayerChromium.cpp:
- (WebCore::LayerChromium::addAnimation):
- * platform/graphics/chromium/LayerRendererChromium.cpp:
- (WebCore::LayerRendererChromium::initialize):
- * platform/graphics/chromium/TiledLayerChromium.cpp:
- (WebCore::TiledLayerChromium::updateTileSizeAndTilingOption):
- * platform/graphics/chromium/cc/CCDebugRectHistory.cpp:
- (WebCore::CCDebugRectHistory::enabled):
- (WebCore::CCDebugRectHistory::saveDebugRectsForCurrentFrame):
- * platform/graphics/chromium/cc/CCDebugRectHistory.h:
- (WebCore):
- (CCDebugRectHistory):
- * platform/graphics/chromium/cc/CCHeadsUpDisplay.cpp:
- (WebCore::CCHeadsUpDisplay::enabled):
- (WebCore::CCHeadsUpDisplay::showPlatformLayerTree):
- (WebCore::CCHeadsUpDisplay::showDebugRects):
- (WebCore::CCHeadsUpDisplay::draw):
- (WebCore::CCHeadsUpDisplay::drawHudContents):
- (WebCore::CCHeadsUpDisplay::drawDebugRects):
- * platform/graphics/chromium/cc/CCHeadsUpDisplay.h:
- (WebCore):
- (CCHeadsUpDisplay):
- * platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
- (WebCore::CCLayerTreeHost::create):
- (WebCore::CCLayerTreeHost::CCLayerTreeHost):
- (WebCore::CCLayerTreeHost::animateLayers):
- * platform/graphics/chromium/cc/CCLayerTreeHost.h:
- (WebCore::CCSettings::CCSettings):
- (CCSettings):
- (CCLayerTreeHost):
- (WebCore::CCLayerTreeHost::settings):
- * platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
- (WebCore::CCLayerTreeHostImpl::create):
- (WebCore::CCLayerTreeHostImpl::CCLayerTreeHostImpl):
- (WebCore::CCLayerTreeHostImpl::calculateRenderSurfaceLayerList):
- (WebCore::CCLayerTreeHostImpl::animateLayers):
- * platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:
- (CCLayerTreeHostImpl):
- * platform/graphics/chromium/cc/CCRenderer.h:
- (CCRendererClient):
- (WebCore::CCRenderer::settings):
- * platform/graphics/chromium/cc/CCSettings.cpp: Removed.
- * platform/graphics/chromium/cc/CCSettings.h: Removed.
- * testing/InternalSettings.cpp:
- (WebCore::InternalSettings::setPerTileDrawingEnabled):
- (WebCore):
- * testing/InternalSettings.h:
- (InternalSettings):
-
-2012-06-13 Ian Vollick <vollick@chromium.org>
-
- [chromium] Certain settings in CCSettings could be global
- https://bugs.webkit.org/show_bug.cgi?id=88384
-
- Reviewed by James Robinson.
-
- No new tests. No new functionality.
-
- * WebCore.gypi:
- * page/Settings.cpp:
- (WebCore::Settings::Settings):
- * page/Settings.h:
- (Settings):
- * platform/graphics/chromium/ContentLayerChromium.cpp:
- (WebCore::ContentLayerChromium::createTextureUpdaterIfNeeded):
- * platform/graphics/chromium/LayerChromium.cpp:
- (WebCore::LayerChromium::addAnimation):
- * platform/graphics/chromium/LayerRendererChromium.cpp:
- (WebCore::LayerRendererChromium::initialize):
- * platform/graphics/chromium/TiledLayerChromium.cpp:
- (WebCore::TiledLayerChromium::updateTileSizeAndTilingOption):
- * platform/graphics/chromium/cc/CCDebugRectHistory.cpp:
- (WebCore::CCDebugRectHistory::enabled):
- (WebCore::CCDebugRectHistory::saveDebugRectsForCurrentFrame):
- * platform/graphics/chromium/cc/CCDebugRectHistory.h:
- (WebCore):
- (CCDebugRectHistory):
- * platform/graphics/chromium/cc/CCHeadsUpDisplay.cpp:
- (WebCore::CCHeadsUpDisplay::enabled):
- (WebCore::CCHeadsUpDisplay::showPlatformLayerTree):
- (WebCore::CCHeadsUpDisplay::showDebugRects):
- (WebCore::CCHeadsUpDisplay::draw):
- (WebCore::CCHeadsUpDisplay::drawHudContents):
- (WebCore::CCHeadsUpDisplay::drawDebugRects):
- * platform/graphics/chromium/cc/CCHeadsUpDisplay.h:
- (WebCore):
- (CCHeadsUpDisplay):
- * platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
- (WebCore::CCLayerTreeHost::create):
- (WebCore::CCLayerTreeHost::CCLayerTreeHost):
- (WebCore::CCLayerTreeHost::animateLayers):
- * platform/graphics/chromium/cc/CCLayerTreeHost.h:
- (WebCore::CCLayerTreeSettings::CCLayerTreeSettings):
- (CCLayerTreeSettings):
- (CCLayerTreeHost):
- (WebCore::CCLayerTreeHost::settings):
- * platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
- (WebCore::CCLayerTreeHostImpl::create):
- (WebCore::CCLayerTreeHostImpl::CCLayerTreeHostImpl):
- (WebCore::CCLayerTreeHostImpl::calculateRenderSurfaceLayerList):
- (WebCore::CCLayerTreeHostImpl::animateLayers):
- * platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:
- (CCLayerTreeHostImpl):
- * platform/graphics/chromium/cc/CCRenderer.h:
- (CCRendererClient):
- (WebCore::CCRenderer::settings):
- * platform/graphics/chromium/cc/CCSettings.cpp: Added.
- (WebCore):
- (WebCore::CCSettings::perTilePaintingEnabled):
- (WebCore::CCSettings::setPerTilePaintingEnabled):
- (WebCore::CCSettings::partialSwapEnabled):
- (WebCore::CCSettings::setPartialSwapEnabled):
- (WebCore::CCSettings::acceleratedAnimationEnabled):
- (WebCore::CCSettings::setAcceleratedAnimationEnabled):
- (WebCore::CCSettings::reset):
- * platform/graphics/chromium/cc/CCSettings.h: Added.
- (WebCore):
- (CCSettings):
- * testing/InternalSettings.cpp:
- * testing/InternalSettings.h:
- (InternalSettings):
-
-2012-06-13 Crystal Zhang <haizhang@rim.com>
-
- [BlackBerry] Apply New Style and JS for Select Popup
- https://bugs.webkit.org/show_bug.cgi?id=89020
-
- Reviewed by Rob Buis.
-
- PR 162854
-
- Use new python script for data generating, as the old one is too simple and problematic.
-
- * PlatformBlackBerry.cmake:
-
-2012-06-13 Dana Jansens <danakj@chromium.org>
-
- [chromium] Assert if iterating an invalid RenderSurfaceLayerList, where a layer in the list has no RenderSurface
- https://bugs.webkit.org/show_bug.cgi?id=89004
-
- Reviewed by Adrienne Walker.
-
- A RenderSurfaceLayerList expects that all layers in the list own a
- RenderSurface. If an invalid RSLL is iterated over, the
- CCLayerIterator class will now ASSERT in debug mode, as well as
- considering the list empty in release mode.
-
- We will be adding code to CCLayerTreeHostImpl to save a RSLL across
- frames, so adding a clearRenderSurfaces() method with a FIXME comment
- to make it clear that we should clear the RSLL when we remove
- RenderSurfaces from the layers in the saved RSLL.
-
- * platform/graphics/chromium/cc/CCLayerIterator.h:
- (WebCore::CCLayerIterator::CCLayerIterator):
- * platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
- (WebCore::CCLayerTreeHostImpl::~CCLayerTreeHostImpl):
- (WebCore::CCLayerTreeHostImpl::initializeLayerRenderer):
- (WebCore::clearRenderSurfacesOnCCLayerImplRecursive):
- (WebCore::CCLayerTreeHostImpl::clearRenderSurfaces):
- (WebCore):
- * platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:
- (CCLayerTreeHostImpl):
-
-2012-06-13 Yael Aharon <yael.aharon@nokia.com>
-
- Remove redundant code from RenderView and RenderBlock
- https://bugs.webkit.org/show_bug.cgi?id=89019
-
- Reviewed by Abhishek Arya.
-
- As pointed out in https://bugs.webkit.org/show_bug.cgi?id=83981#c7 , RenderView::insertFixedPositionedObject()
- is redundant and should be removed.
- No new tests.
-
- * rendering/RenderBlock.cpp:
- (WebCore::RenderBlock::insertPositionedObject):
- (WebCore::RenderBlock::removePositionedObject):
- * rendering/RenderView.cpp:
- (WebCore):
- * rendering/RenderView.h:
- (RenderView):
-
-2012-06-13 Dana Jansens <danakj@chromium.org>
-
- [chromium] Create a CCStreamVideoDrawQuad used for StreamTexture video output
- https://bugs.webkit.org/show_bug.cgi?id=88826
-
- Reviewed by Adrienne Walker.
-
- Remove the matrix from the CCVideoDrawQuad, and create a new quad
- specifically for StreamTexture video decoder output. This quad
- contains only the fields needed for display - textureId and the
- matrix to be applied to texture coords.
-
- Removes the (0, 0, 1, 1) "transform" from the shader used for these
- quads, as it was a no-op.
-
- No new tests, no change in behaviour.
-
- * WebCore.gypi:
- * platform/graphics/chromium/LayerRendererChromium.cpp:
- (WebCore::LayerRendererChromium::drawQuad):
- (WebCore::LayerRendererChromium::drawStreamVideoQuad):
- (WebCore::LayerRendererChromium::drawVideoQuad):
- * platform/graphics/chromium/LayerRendererChromium.h:
- (WebCore):
- (LayerRendererChromium):
- * platform/graphics/chromium/ShaderChromium.cpp:
- (WebCore::VertexShaderVideoTransform::VertexShaderVideoTransform):
- (WebCore::VertexShaderVideoTransform::init):
- (WebCore::VertexShaderVideoTransform::getShaderString):
- * platform/graphics/chromium/ShaderChromium.h:
- (VertexShaderVideoTransform):
- * platform/graphics/chromium/cc/CCDrawQuad.cpp:
- (WebCore::CCDrawQuad::toStreamVideoDrawQuad):
- (WebCore):
- * platform/graphics/chromium/cc/CCDrawQuad.h:
- (WebCore):
- (CCDrawQuad):
- * platform/graphics/chromium/cc/CCStreamVideoDrawQuad.cpp: Added.
- (WebCore):
- (WebCore::CCStreamVideoDrawQuad::create):
- (WebCore::CCStreamVideoDrawQuad::CCStreamVideoDrawQuad):
- * platform/graphics/chromium/cc/CCStreamVideoDrawQuad.h: Added.
- (WebCore):
- (CCStreamVideoDrawQuad):
- (WebCore::CCStreamVideoDrawQuad::textureId):
- (WebCore::CCStreamVideoDrawQuad::matrix):
- * platform/graphics/chromium/cc/CCVideoLayerImpl.cpp:
- (WebCore::CCVideoLayerImpl::appendQuads):
-
-2012-06-13 Martin Robinson <mrobinson@igalia.com>
-
- [GTK] Add an accelerated compositing implementation for WebKit2
- https://bugs.webkit.org/show_bug.cgi?id=86037
-
- Reviewed by Alejandro G. Castro.
-
- No new tests. These changes are covered by the compositing tests, which
- we will gradually try to turn on for the bots.
-
- Add a new GLContext method for getting to current default framebuffer size, which
- is quite useful for preventing composited content quivering while resizing.
-
- * platform/graphics/cairo/GLContext.h:
- * platform/graphics/glx/GLContextGLX.cpp:
- (WebCore::GLContextGLX::defaultFrameBufferSize): Added this implementation for X11
- which asks the X server for the window size.
- * platform/graphics/glx/GLContextGLX.h:
-
-2012-06-13 Shawn Singh <shawnsingh@chromium.org>
-
- [chromium] Implement hit-testing for impl-side input handling in accelerated compositor
- https://bugs.webkit.org/show_bug.cgi?id=88972
-
- Reviewed by Adrienne Walker.
-
- The original hit testing code by Sami Kyostila.
-
- This patch implements a simple impl-side hit-testing helper
- function. At this time, the main motivation for this is so that
- composited scrollable layers can be scrolled by the impl thread --
- and a prerequisite for that is the ability to hit-test on the impl
- thread, to determine where the scrolling action should be applied.
-
- To implement the actual hit test, it's possible to compute the hit
- test in two equivalent ways: (a) inverse-project the point into
- local space, or (b) forward-transform the rect to screen space
- It's not obvious which one would perform better, or which one
- would be more robust to w < 0 homogeneous clipping issues. For
- this patch, we simply opt for the inverse-projection approach.
-
- 10 unit tests added to CCLayerTreeHostCommonTest.cpp:
- CCLayerTreeHostCommonTest.verifyHitTestingForEmptyLayerList
- CCLayerTreeHostCommonTest.verifyHitTestingForSingleLayer
- CCLayerTreeHostCommonTest.verifyHitTestingForSinglePositionedLayer
- CCLayerTreeHostCommonTest.verifyHitTestingForSingleRotatedLayer
- CCLayerTreeHostCommonTest.verifyHitTestingForSinglePerspectiveLayer
- CCLayerTreeHostCommonTest.verifyHitTestingForSingleLayerWithScaledContents
- CCLayerTreeHostCommonTest.verifyHitTestingForSimpleClippedLayer
- CCLayerTreeHostCommonTest.verifyHitTestingForMultiClippedRotatedLayer
- CCLayerTreeHostCommonTest.verifyHitTestingForMultipleLayers
- CCLayerTreeHostCommonTest.verifyHitTestingForMultipleLayerLists
-
- * platform/graphics/chromium/cc/CCLayerTreeHostCommon.cpp:
- (WebCore::pointHitsRect):
- (WebCore):
- (WebCore::pointIsClippedBySurfaceOrClipRect):
- (WebCore::CCLayerTreeHostCommon::findLayerThatIsHitByPoint):
- * platform/graphics/chromium/cc/CCLayerTreeHostCommon.h:
- (CCLayerTreeHostCommon):
- * platform/graphics/chromium/cc/CCMathUtil.cpp:
- (WebCore::projectHomogeneousPoint):
- (WebCore::mapHomogeneousPoint):
- (WebCore::CCMathUtil::mapClippedRect):
- (WebCore::CCMathUtil::projectClippedRect):
- (WebCore::CCMathUtil::mapClippedQuad):
- (WebCore::CCMathUtil::mapQuad):
- (WebCore::CCMathUtil::projectPoint):
- (WebCore):
- * platform/graphics/chromium/cc/CCMathUtil.h:
- (WebCore):
- (CCMathUtil):
-
-2012-06-13 Charles Wei <charles.wei@torchmobile.com.cn>
-
- Need customized toDOMStringList for IndexedDB JSC binding.
- https://bugs.webkit.org/show_bug.cgi?id=87965
-
- Reviewed by Kentaro Hara.
-
- IndexedDB database interface uses DOMStringList as the input parameter.
- The generated toDOMStringList() can't convert an JSArray of Strings to
- native DOMStringList. We need a custom function to do this.
-
- Because this patch adds one new file (JSDOMStringList.cpp), all build systems
- are updated accordingly to pick up this file.
-
- Tests: Corresponding bindings/scripts/test/JS files have been updated accordingly.
-
- * GNUmakefile.list.am:
- * Target.pri:
- * UseJSC.cmake:
- * WebCore.gypi:
- * WebCore.vcproj/WebCore.vcproj:
- * WebCore.xcodeproj/project.pbxproj:
- * bindings/js/JSBindingsAllInOne.cpp:
- * bindings/js/JSDOMStringListCustom.cpp: Added.
- (WebCore):
- (WebCore::toDOMStringList):
- * bindings/scripts/CodeGeneratorJS.pm:
- (IndexGetterReturnsStrings):
- (GenerateHeader):
- (GetNativeType):
- (GetNativeTypeForCallbacks):
- (JSValueToNative):
- * bindings/scripts/test/JS/JSTestCallback.cpp:
- (WebCore::JSTestCallback::callbackWithStringList):
- * bindings/scripts/test/JS/JSTestCallback.h:
- (JSTestCallback):
- * bindings/scripts/test/JS/JSTestObj.cpp:
- (WebCore::jsTestObjPrototypeFunctionOverloadedMethod6):
- (WebCore::jsTestObjPrototypeFunctionOverloadedMethod7):
- * dom/DOMStringList.idl:
-
-2012-06-13 Jeffrey Pfau <jpfau@apple.com>
-
- Padding and borders can cause integer overflow in block layouts
- https://bugs.webkit.org/show_bug.cgi?id=88820
- <rdar://problem/11328762>
-
- Reviewed by Tony Chang.
-
- Tests: fast/block/block-size-integer-overflow.html
- fast/flexbox/box-size-integer-overflow.html
- fast/table/table-size-integer-overflow.html
-
- * rendering/AutoTableLayout.cpp: Decreased max int.
- (WebCore::AutoTableLayout::computePreferredLogicalWidths):
- * rendering/FixedTableLayout.cpp: Use shared constant.
- (WebCore::FixedTableLayout::computePreferredLogicalWidths):
- * rendering/RenderBlock.cpp: Removed unused constant.
- * rendering/TableLayout.h: Add shared constant.
- (TableLayout):
-
-2012-06-13 Gregg Tavares <gman@google.com>
-
- Refactor WebGLFramebuffer to handle texture attachments
- https://bugs.webkit.org/show_bug.cgi?id=88697
-
- Reviewed by Adrienne Walker.
-
- In order to add support for depth textures WebGLFramebuffer
- needed to be refactored to handle textures as attachments.
-
- No new tests as no new functionality.
-
- * html/canvas/WebGLFramebuffer.cpp:
- (WebCore::WebGLFramebuffer::WebGLAttachment::WebGLAttachment):
- (WebCore):
- (WebCore::WebGLFramebuffer::WebGLAttachment::~WebGLAttachment):
- (WebCore::WebGLFramebuffer::WebGLFramebuffer):
- (WebCore::WebGLFramebuffer::setAttachmentForBoundFramebuffer):
- (WebCore::WebGLFramebuffer::attach):
- (WebCore::WebGLFramebuffer::getAttachmentObject):
- (WebCore::WebGLFramebuffer::getAttachment):
- (WebCore::WebGLFramebuffer::removeAttachmentFromBoundFramebuffer):
- (WebCore::WebGLFramebuffer::getColorBufferWidth):
- (WebCore::WebGLFramebuffer::getColorBufferHeight):
- (WebCore::WebGLFramebuffer::getColorBufferFormat):
- (WebCore::WebGLFramebuffer::checkStatus):
- (WebCore::WebGLFramebuffer::onAccess):
- (WebCore::WebGLFramebuffer::hasStencilBuffer):
- (WebCore::WebGLFramebuffer::deleteObjectImpl):
- (WebCore::WebGLFramebuffer::initializeAttachments):
- * html/canvas/WebGLFramebuffer.h:
- (WebGLAttachment):
- (WebGLFramebuffer):
- * html/canvas/WebGLRenderingContext.cpp:
- (WebCore):
- (WebCore::WebGLRenderingContext::framebufferRenderbuffer):
- (WebCore::WebGLRenderingContext::reattachDepthStencilAttachments):
- (WebCore::WebGLRenderingContext::framebufferTexture2D):
- (WebCore::WebGLRenderingContext::getFramebufferAttachmentParameter):
- * html/canvas/WebGLRenderingContext.h:
- (WebGLRenderingContext):
-
-2012-06-13 Konrad Piascik <kpiascik@rim.com>
-
- Remove return statement in void method
- https://bugs.webkit.org/show_bug.cgi?id=88998
-
- Reviewed by Andreas Kling
-
- * html/HTMLInputElement.cpp:
- (WebCore::HTMLInputElement::collectStyleForAttribute):
-
-2012-06-13 Benjamin Poulain <benjamin@webkit.org>
-
- Implement the simple constructors WTFURL's KURL
- https://bugs.webkit.org/show_bug.cgi?id=85724
-
- Reviewed by Adam Barth.
-
- This patch implement the correct initialization of KURL from an absolute URL.
- The URL correctness is also relaxed in order to have KURLWTFURL works similarily to KURL.
-
- * platform/KURLWTFURL.cpp:
- (WebCore::KURL::KURL):
- (WebCore::KURL::isValid):
- (WebCore::KURL::string):
- (WebCore::KURL::protocol):
- (WebCore::KURL::host):
- (WebCore::KURL::port): Fix a bug where invalidPortNumber was returned if no port was defined.
- (WebCore::KURL::hasFragmentIdentifier):
- (WebCore::KURL::fragmentIdentifier):
- (WebCore::KURL::protocolIs):
- (WebCore::KURL::removeFragmentIdentifier):
- (WebCore):
- (WebCore::KURL::print):
- * platform/cf/KURLCFNet.cpp:
- (WebCore::KURL::KURL):
- (WebCore::KURL::createCFURL):
- (WebCore):
- * platform/mac/KURLMac.mm:
- (WebCore::KURL::KURL):
- (WebCore::KURL::createCFURL):
- (WebCore):
- Use the code of KURL to make the conversion from WTFURL to NSURL.
-
-2012-06-12 Vincent Scheib <scheib@chromium.org>
-
- Remove duplicate webkitpointerlockchange events when unlocking.
- https://bugs.webkit.org/show_bug.cgi?id=88917
-
- Reviewed by Dimitri Glazkov.
-
- Subsequent patches adding the new API for entering and exiting
- pointer lock would be burdened by handling multiple change events
- when the lock target is changed. This change introduces
- temporary code to suppress duplicate change events.
-
- Existing tests simplified by removing the duplicate change events.
-
- * page/PointerLockController.cpp:
- (WebCore::PointerLockController::requestPointerLock):
- (WebCore::PointerLockController::didLosePointerLock):
- * page/PointerLockController.h:
- (PointerLockController):
-
-2012-06-13 Silvia Pfeiffer <silviapf@chromium.org>
-
- Update range sliders rendering for volume and playback position of new Chrome video controls.
- https://bugs.webkit.org/show_bug.cgi?id=88623
-
- Reviewed by Eric Carlson.
-
- No new tests, final patch will contain the rebaselined tests.
-
- The Chrome video controls are receiving a visual update. This patch contains updates to the
- rendering of the range sliders for the playback position and the volume. This includes the
- creation of a shadowPseudoId to be able to style the range sliders via CSS, the rendering
- of the slider background and the highlighted ranges.
-
- * css/mediaControlsChromium.css:
- (input[type="range"]::-webkit-media-slider-container):
- Adjust the styling of the slider container backgrounds.
- (input[type="range"]::-webkit-media-slider-thumb):
- Adjust the styling of the slider thumbs.
- * html/shadow/SliderThumbElement.cpp:
- (WebCore::sliderThumbShadowPseudoId):
- Add an accessor function for the slider thumb shadowPseudoId.
- (WebCore::mediaSliderThumbShadowPseudoId):
- Add an accessor function for the media slider thumb shadowPseudoId.
- (WebCore::SliderThumbElement::shadowPseudoId):
- Add a different CSS pseudo-class name to the media slider thumbs.
- (WebCore::TrackLimiterElement::shadowPseudoId):
- Add a different CSS pseudo-class name to the media slider thumbs.
- (WebCore::SliderContainerElement::shadowPseudoId):
- Add a different CSS pseudo-class name to the media slider background container.
- * rendering/RenderMediaControlsChromium.cpp:
- (WebCore::paintRoundedSliderBackground):
- Add function to draw rounded background of sliders in a dark color.
- (WebCore::paintSliderRangeHighlight):
- Add function to draw a highlighted grey region on the sliders, which is rounded only at
- its ends.
- (WebCore::paintMediaSlider):
- Update the background and buffered range renderings on the playback position slider by making
- use of the new helper functions.
- (WebCore::paintMediaVolumeSlider):
- Update the background and buffered range renderings on the volume slider by making
- use of the new helper functions.
-
-2012-06-13 Christopher Hutten-Czapski <chutten@rim.com>
-
- 2012-06-13 Christopher Hutten-Czapski <chutten@rim.com>
-
- [BlackBerry] Update Select Popup's styling
- https://bugs.webkit.org/show_bug.cgi?id=89005
-
- Reviewed by Rob Buis.
-
- Add in some nicely-styled CSS and JS for the BlackBerry port's <select>
-
- * Resources/blackberry/popupControlBlackBerry.css:
- (body):
- (.popup-area):
- (.popup-area>:first-child):
- (.popup-buttons):
- (.popup-button-divider):
- (.popup-button):
- (.popup-button:active):
- (.popup-button:first-child:active):
- (.popup-button:last-child:active):
- (.popup-button:only-child:active):
- * Resources/blackberry/selectControlBlackBerry.css: Added.
- (.select-area):
- (.select-area:last-child):
- (.option):
- (.optgroup:last-child):
- (.selected):
- (.optgroup):
- (.optgroup .option):
- * Resources/blackberry/selectControlBlackBerry.js: Added.
-
-2012-06-13 Alec Flett <alecflett@chromium.org>
-
- [V8] IndexedDB: Cursor value modifications should be preserved until cursor iterates
- https://bugs.webkit.org/show_bug.cgi?id=83526
-
- Reviewed by Kentaro Hara.
-
- Cache the 'value' attribute of IDBCursorWithValue with policy
- determined by IDBCursor.cpp, to follow spec behavior of keeping a
- consistent script object until the cursor advances. See
- http://www.w3.org/TR/IndexedDB/#widl-IDBCursorWithValueSync-value
- for details.
-
- Test: storage/indexeddb/cursor-value.html
-
- * Modules/indexeddb/IDBCursor.cpp:
- (WebCore::IDBCursor::IDBCursor):
- (WebCore::IDBCursor::value):
- (WebCore::IDBCursor::setValueReady):
- * Modules/indexeddb/IDBCursor.h:
- (IDBCursor):
- (WebCore::IDBCursor::valueIsDirty):
- * Modules/indexeddb/IDBCursorWithValue.idl:
- * WebCore.gypi:
- * bindings/v8/IDBCustomBindings.cpp: Added.
- (WebCore):
- (WebCore::V8IDBCursorWithValue::valueAccessorGetter):
-
-2012-06-13 Silvia Pfeiffer <silviapf@chromium.org>
-
- Code cleanup from bug 88881 to share the SliderVerticalPart code.
- https://bugs.webkit.org/show_bug.cgi?id=88930
-
- Reviewed by Eric Carlson.
-
- No new tests - this is just code cleanup.
-
- * html/shadow/SliderThumbElement.cpp:
- (WebCore::hasVerticalAppearance):
- Avoid having two ifdef-ed returns in the code depending on ENABLE(VIDEO).
-
-2012-06-13 Mark Mentovai <mark@chromium.org>
-
- [chromium mac] Don't include things in subframeworks of
- ApplicationServices.framework.
-
- A CoreText #include (with quotes instead of brackets, even) sprung up
- in r120506, bug 69826.
-
- https://bugs.webkit.org/show_bug.cgi?id=88569
-
- Reviewed by Stephen White.
-
- No new tests.
-
- * platform/graphics/harfbuzz/ng/HarfBuzzFaceCoreText.cpp:
-
-2012-06-13 Eriq Augustine <eaugusti@chromium.org>
-
- Removing an extra HandleScope in V8Proxy::evaluateInIsolatedWorld
- https://bugs.webkit.org/show_bug.cgi?id=88451
-
- Reviewed by Adam Barth.
-
- Any values retuned by the evaluation will get destroyed with the extra
- HandleScope.
-
- I was unable to cause a test failure, however this feature is tested by:
- platform/chromium/http/tests/misc/execute-and-return-value.html
-
- * bindings/v8/V8Proxy.cpp:
- (WebCore::V8Proxy::evaluateInIsolatedWorld):
-
-2012-06-13 Zan Dobersek <zandobersek@gmail.com>
-
- [Gtk] Enable link prefetch support in the developer builds
- https://bugs.webkit.org/show_bug.cgi?id=89011
-
- Reviewed by Martin Robinson.
-
- Handle the ENABLE_LINK_PREFETCH conditional in standard way.
-
- No new tests - covered by existing link prefetch tests.
-
- * GNUmakefile.am:
-
-2012-06-13 Amy Ousterhout <aousterh@chromium.org>
-
- Rename currentDeviceMotion to lastMotion in DeviceMotionClient
- https://bugs.webkit.org/show_bug.cgi?id=88854
-
- Reviewed by Adam Barth.
-
- Rename the function currentDeviceMotion to lastMotion in DeviceMotionClient.
- This makes it consistent with the similar function lastOrientation in DeviceOrientationClient.
-
- Just a rename, so does not require any new tests.
-
- * dom/DeviceMotionClient.h:
- (DeviceMotionClient):
- * dom/DeviceMotionController.cpp:
- (WebCore::DeviceMotionController::timerFired):
- (WebCore::DeviceMotionController::addListener):
- * loader/EmptyClients.h:
- (WebCore::EmptyDeviceMotionClient::lastMotion):
- * platform/qt/DeviceMotionClientQt.cpp:
- (WebCore::DeviceMotionClientQt::lastMotion):
- * platform/qt/DeviceMotionClientQt.h:
- (DeviceMotionClientQt):
- * platform/qt/DeviceMotionProviderQt.h:
- (WebCore::DeviceMotionProviderQt::lastMotion):
-
-2012-06-13 Vsevolod Vlasov <vsevik@chromium.org>
-
- Web Inspector: Breakpoint's _uiLocationRemoved() method is never called.
- https://bugs.webkit.org/show_bug.cgi?id=89003
-
- Reviewed by Pavel Feldman.
-
- * inspector/front-end/BreakpointManager.js:
- (WebInspector.BreakpointManager.prototype.breakpointLocationsForUISourceCode):
- (WebInspector.BreakpointManager.Breakpoint):
- (WebInspector.BreakpointManager.Breakpoint.prototype._locationUpdated):
- (WebInspector.BreakpointManager.Breakpoint.prototype._resetLocations):
- (WebInspector.BreakpointManager.Breakpoint.prototype._fakeBreakpointAtPrimaryLocation):
- * inspector/front-end/FileSystemModel.js: Drive by compilation fix.
- (WebInspector.FileSystemModel):
-
-2012-06-13 David Grogan <dgrogan@chromium.org>
-
- IndexedDB: Add tests, an assert, and some comments around open/close/setVersion call sequencing
- https://bugs.webkit.org/show_bug.cgi?id=88829
-
- Reviewed by Tony Chang.
-
- Test: storage/indexeddb/three-setversion-calls.html
-
- * Modules/indexeddb/IDBDatabaseBackendImpl.cpp:
- (WebCore::IDBDatabaseBackendImpl::processPendingCalls):
-
-2012-06-09 Vsevolod Vlasov <vsevik@chromium.org>
-
- Web Inspector: Errors when pending console messages are attached to JavaScriptSourceFrame.
- https://bugs.webkit.org/show_bug.cgi?id=88712
-
- Reviewed by Pavel Feldman.
-
- * inspector/front-end/PresentationConsoleMessageHelper.js:
- (WebInspector.PresentationConsoleMessageHelper):
- (WebInspector.PresentationConsoleMessageHelper.prototype._addPendingConsoleMessage):
- (WebInspector.PresentationConsoleMessageHelper.prototype._parsedScriptSource):
-
-2012-06-13 Alexander Pavlov <apavlov@chromium.org>
-
- Web Inspector: Support user attributes in DOMNode
- https://bugs.webkit.org/show_bug.cgi?id=88706
-
- Reviewed by Pavel Feldman.
-
- This change allows clients to store arbitrary properties on DOMNodes and know if there are descendants
- (and how many of them) having a certain property set.
-
- Test: inspector/elements/user-attributes.html
-
- * inspector/front-end/DOMAgent.js:
- (WebInspector.DOMNode.prototype._removeChild):
- (WebInspector.DOMNode.prototype._updateChildUserPropertyCountsOnRemoval):
- (WebInspector.DOMNode.prototype._updateDescendantUserPropertyCount):
- (WebInspector.DOMNode.prototype.setUserProperty):
- (WebInspector.DOMNode.prototype.removeUserProperty):
- (WebInspector.DOMNode.prototype.getUserProperty):
- (WebInspector.DOMNode.prototype.descendantUserPropertyCount):
-
-2012-06-13 Vineet Chaudhary <vineet.chaudhary@motorola.com>
-
- REGRESSION:Bindings sequence<T> in Console.idl, Internals.idl and ScriptProfileNode.idl should be T[]
- https://bugs.webkit.org/show_bug.cgi?id=84863
-
- Reviewed by Kentaro Hara.
-
- With reference to http://www.w3.org/TR/WebIDL/#idl-sequence
- "Sequences must not be used as the type of an attribute, constant or exception field."
- So we should use T[] instead of sequence<T>.
-
- Tests: bindings/scripts/test/TestObj.idl
- fast/harness/user-preferred-language.html
- inspector/profiler/cpu-profiler-profiling-without-inspector.html
- media/track/track-language-preference.html
-
- * bindings/scripts/CodeGenerator.pm:
- (GetSequenceType): Getter for getting sequence type.
- (GetArrayType): Getter for getting array type.
- (AssertNotSequenceType): Check sequences must not be used as the type of an attribute,
- constant or exception field.
- * bindings/scripts/CodeGeneratorCPP.pm:
- (SkipFunction): Exclude bindings code for type sequence.
- (SkipAttribute): Check for sequences must not be used as the type of an attribute,
- constant or exception field.
- (AddIncludesForType): Exclude header inclusion code for type array/sequence.
- * bindings/scripts/CodeGeneratorGObject.pm:
- (SkipAttribute): Check for sequences must not be used as the type of an attribute,
- constant or exception field.
- (SkipFunction): Exclude bindings code for type sequence.
- * bindings/scripts/CodeGeneratorJS.pm:
- (AddIncludesForType): Exclude header inclusion code for type array/sequence.
- (GenerateImplementation): Check for sequences must not be used as the type of an attribute,
- constant or exception field.
- (GetNativeType):
- (JSValueToNative):
- (NativeToJSValue):
- * bindings/scripts/CodeGeneratorObjC.pm:
- (SkipFunction): Exclude bindings code for type sequence.
- (SkipAttribute): Exclude bindings code for type array.
- (AddForwardDeclarationsForType):
- (AddIncludesForType):
- * bindings/scripts/CodeGeneratorV8.pm:
- (GenerateNormalAttrGetter):
- (GetNativeType):
- (JSValueToNative):
- (CreateCustomSignature):
- (NativeToJSValue):
- * bindings/scripts/test/JS/JSTestObj.cpp: Updated code from run-bindings-tests.
- (WebCore):
- (WebCore::jsTestObjPrototypeFunctionMethodWithSequenceArg):
- * bindings/scripts/test/JS/JSTestObj.h: Updated code from run-bindings-tests.
- (WebCore):
- * bindings/scripts/test/TestObj.idl: Tests.
- * bindings/scripts/test/V8/V8TestObj.cpp: Updated code from run-bindings-tests.
- (TestObjV8Internal):
- (WebCore::TestObjV8Internal::methodWithSequenceArgCallback):
- (WebCore):
- * inspector/ScriptProfileNode.idl: Using sequence<T> for children().
- * page/Console.idl: Using Array[T] for profiles attribute.
- * testing/Internals.idl: Using sequence<T> for userPreferredLanguages().
-
-2012-06-13 Simon Hausmann <simon.hausmann@nokia.com>
-
- [Qt] Remove dependency to QtScript for the Qt 5 build
- https://bugs.webkit.org/show_bug.cgi?id=88993
-
- Reviewed by Kenneth Rohde Christiansen.
-
- Replace the use of QScriptEngine::ValueOwnership with an enum local
- to the class where it is used (QtInstance).
-
- * Target.pri:
- * bindings/js/ScriptControllerQt.cpp:
- (WebCore::ScriptController::createScriptInstanceForWidget):
- * bridge/qt/qt_instance.cpp:
- (JSC::Bindings::QtInstance::QtInstance):
- (JSC::Bindings::QtInstance::~QtInstance):
- (JSC::Bindings::QtInstance::getQtInstance):
- * bridge/qt/qt_instance.h:
- (QtInstance):
- (JSC::Bindings::QtInstance::create):
- * bridge/qt/qt_runtime.cpp:
- (JSC::Bindings::convertQVariantToValue):
- * bridge/qt/qt_runtime_qt4.cpp:
- (JSC::Bindings::convertQVariantToValue):
-
-2012-06-13 Caio Marcelo de Oliveira Filho <caio.oliveira@openbossa.org>
-
- [Qt] Save a JSGlobalContextRef instead of a JSContextRef in QtConnectionObject
- https://bugs.webkit.org/show_bug.cgi?id=88905
-
- Make QtConnectionObject use JSContextGetGlobalContext and store the
- JSGlobalContextRef. Previous code was working but saving JSContextRef was wrong in terms of
- API.
-
- There's an assumption that JSGlobalContextRef will outlive the connection objects, and
- because of it no JSGlobalContextRetain/Release calls were added.
-
- Reviewed by Noam Rosenthal.
-
- * bridge/qt/qt_runtime.cpp:
- (JSC::Bindings::QtRuntimeConnectionMethod::call):
- (JSC::Bindings::QtConnectionObject::QtConnectionObject):
- * bridge/qt/qt_runtime.h:
- (QtConnectionObject):
- * bridge/qt/qt_runtime_qt4.cpp:
- (JSC::Bindings::QtRuntimeConnectionMethod::call):
- (JSC::Bindings::QtConnectionObject::QtConnectionObject):
-
-2012-06-13 David Barr <davidbarr@chromium.org>
-
- Add dpi to css3-images image-resolution
- https://bugs.webkit.org/show_bug.cgi?id=85439
-
- Reviewed by Tony Chang.
-
- No new tests; extended fast/css/image-resolution/image-resolution.html
-
- * css/CSSGrammar.y:
- * css/CSSParser.cpp:
- (WebCore::CSSParser::validUnit):
- (WebCore::CSSParser::createPrimitiveNumericValue):
- (WebCore::unitFromString):
- (WebCore::CSSParser::parseValidPrimitive):
- (WebCore::CSSParser::detectNumberToken):
- * css/CSSPrimitiveValue.cpp:
- (WebCore::isValidCSSUnitTypeForDoubleConversion):
- (WebCore::unitCategory):
- (WebCore::conversionToCanonicalUnitsScaleFactor):
- (WebCore::CSSPrimitiveValue::customCssText):
- (WebCore::CSSPrimitiveValue::cloneForCSSOM):
- * css/CSSPrimitiveValue.h:
-
-2012-06-13 Li Yin <li.yin@intel.com>
-
- FileAPI: type should be converted to be lower case in Blob constructor.
- https://bugs.webkit.org/show_bug.cgi?id=88696
-
- Reviewed by Kentaro Hara.
-
- Spec: http://dev.w3.org/2006/webapi/FileAPI/#dfn-BlobPropertyBag
- Spec: http://dev.w3.org/2006/webapi/FileAPI/#attributes-blob
- The ASCII-encoded string in lower case representing the media type of the Blob.
-
- Test: fast/files/blob-constructor.html
-
- * bindings/js/JSBlobCustom.cpp:
- (WebCore::JSBlobConstructor::constructJSBlob):
- * bindings/v8/custom/V8BlobCustom.cpp:
- (WebCore::V8Blob::constructorCallback):
-
-2012-06-13 Robin Cao <robin.cao@torchmobile.com.cn>
-
- [BlackBerry] Enable MEDIA_STREAM by default
- https://bugs.webkit.org/show_bug.cgi?id=88849
-
- Reviewed by Antonio Gomes.
-
- Covered by existing test cases.
-
- * CMakeLists.txt:
- * PlatformBlackBerry.cmake:
- * platform/mediastream/blackberry/DeprecatedPeerConnectionHandler.cpp: Added.
- (WebCore):
- (WebCore::DeprecatedPeerConnectionHandler::create):
- (WebCore::DeprecatedPeerConnectionHandler::DeprecatedPeerConnectionHandler):
- (WebCore::DeprecatedPeerConnectionHandler::~DeprecatedPeerConnectionHandler):
- (WebCore::DeprecatedPeerConnectionHandler::produceInitialOffer):
- (WebCore::DeprecatedPeerConnectionHandler::handleInitialOffer):
- (WebCore::DeprecatedPeerConnectionHandler::processSDP):
- (WebCore::DeprecatedPeerConnectionHandler::processPendingStreams):
- (WebCore::DeprecatedPeerConnectionHandler::sendDataStreamMessage):
- (WebCore::DeprecatedPeerConnectionHandler::stop):
- * platform/mediastream/blackberry/MediaStreamCenterBlackBerry.cpp: Added.
- (WebCore):
- (WebCore::MediaStreamCenter::instance):
- (WebCore::MediaStreamCenterBlackBerry::MediaStreamCenterBlackBerry):
- (WebCore::MediaStreamCenterBlackBerry::~MediaStreamCenterBlackBerry):
- (WebCore::MediaStreamCenterBlackBerry::queryMediaStreamSources):
- (WebCore::MediaStreamCenterBlackBerry::didSetMediaStreamTrackEnabled):
- (WebCore::MediaStreamCenterBlackBerry::didStopLocalMediaStream):
- (WebCore::MediaStreamCenterBlackBerry::didCreateMediaStream):
- (WebCore::MediaStreamCenterBlackBerry::constructSDP):
- * platform/mediastream/blackberry/MediaStreamCenterBlackBerry.h: Added.
- (WebCore):
- (MediaStreamCenterBlackBerry):
-
-2012-06-13 Pavel Feldman <pfeldman@chromium.org>
-
- Web Inspector: working copy should be committed even if domain binding returns error.
- https://bugs.webkit.org/show_bug.cgi?id=88884
-
- Reviewed by Vsevolod Vlasov.
-
- Committing working copy is about saving file. It should always succeed.
-
- * inspector/front-end/UISourceCode.js:
- (WebInspector.UISourceCode.prototype.commitWorkingCopy):
-
-2012-06-12 Pavel Feldman <pfeldman@chromium.org>
-
- Web Inspector: show revisions of all modified files in local modifications view
- https://bugs.webkit.org/show_bug.cgi?id=88864
-
- Reviewed by Vsevolod Vlasov.
-
- This change allows all local modifications to be seen in a single view. View is now
- singleton, listening to all revisions being added. Revert captions were reworked
- (see the screenshot).
-
- * English.lproj/localizedStrings.js:
- * inspector/front-end/Resource.js:
- * inspector/front-end/RevisionHistoryView.js:
- (WebInspector.RevisionHistoryView.populateRevisions):
- (WebInspector.RevisionHistoryView):
- (WebInspector.RevisionHistoryView.showHistory):
- (WebInspector.RevisionHistoryView.reset):
- (WebInspector.RevisionHistoryView.prototype._createResourceItem.clearHistory):
- (WebInspector.RevisionHistoryView.prototype._createResourceItem):
- (WebInspector.RevisionHistoryView.prototype._revisionAdded.get if):
- (WebInspector.RevisionHistoryView.prototype._revisionAdded):
- (WebInspector.RevisionHistoryView.prototype._revealResource.get if):
- (WebInspector.RevisionHistoryView.prototype._revealResource):
- (WebInspector.RevisionHistoryView.prototype._reset):
- (WebInspector.RevisionHistoryTreeElement):
- (WebInspector.RevisionHistoryTreeElement.prototype.onattach):
- (WebInspector.RevisionHistoryTreeElement.prototype.oncollapse):
- * inspector/front-end/ScriptsPanel.js:
- (WebInspector.ScriptsPanel.prototype._reset):
- (WebInspector.ScriptsPanel.prototype._editorSelected):
- * inspector/front-end/revisionHistory.css:
- (.revision-history-link-row):
- (.revision-history-drawer li.revision-history-revision):
-
-2012-06-13 Pavel Feldman <pfeldman@chromium.org>
-
- Web Inspector: Make "Go to source and line" possible with "go to file" dialog
- https://bugs.webkit.org/show_bug.cgi?id=88740
-
- Reviewed by Vsevolod Vlasov.
-
- Selection dialog now allows search query rewrite and uses line number
- suffix to go to a particular line.
-
- * inspector/front-end/FilteredItemSelectionDialog.js:
- (WebInspector.FilteredItemSelectionDialog.prototype.onEnter):
- (WebInspector.FilteredItemSelectionDialog.prototype._createSearchRegExp):
- (WebInspector.SelectionDialogContentProvider.prototype.selectItem):
- (WebInspector.SelectionDialogContentProvider.prototype.rewriteQuery):
- (WebInspector.JavaScriptOutlineDialog.prototype.selectItem):
- (WebInspector.JavaScriptOutlineDialog.prototype.rewriteQuery):
- (WebInspector.OpenResourceDialog.prototype.selectItem):
- (WebInspector.OpenResourceDialog.prototype.rewriteQuery):
- * inspector/front-end/ScriptsPanel.js:
- (WebInspector.ScriptsPanel.prototype.showUISourceCode):
- * inspector/front-end/StylesPanel.js:
- (WebInspector.StyleSheetOutlineDialog.prototype.selectItem):
- (WebInspector.StyleSheetOutlineDialog.prototype.rewriteQuery):
-
-2012-06-12 Hans Wennborg <hans@chromium.org>
-
- Speech JavaScript API: Add test for constructing SpeechRecognitionError events
- https://bugs.webkit.org/show_bug.cgi?id=88868
-
- Reviewed by Adam Barth.
-
- This adds a test for constructing SpeechRecognitionError events, and
- code to make it work.
-
- Test: fast/events/constructors/speech-recognition-error-constructor.html
-
- * Modules/speech/SpeechRecognitionError.cpp:
- (WebCore::SpeechRecognitionError::create):
- (WebCore):
- (WebCore::SpeechRecognitionError::SpeechRecognitionError):
- (WebCore::SpeechRecognitionErrorInit::SpeechRecognitionErrorInit):
- * Modules/speech/SpeechRecognitionError.h:
- (SpeechRecognitionErrorInit):
- (WebCore):
- (SpeechRecognitionError):
- (WebCore::SpeechRecognitionError::code):
- * Modules/speech/SpeechRecognitionError.idl:
-
-2012-06-13 Taiju Tsuiki <tzik@chromium.org>
-
- Implement InspectorFileSystemAgent::readDirectory for FileSystem support.
- https://bugs.webkit.org/show_bug.cgi?id=87724
-
- Reviewed by Vsevolod Vlasov.
-
- Test: http/tests/inspector/filesystem/read-directory.html
-
- * inspector/Inspector.json:
- * inspector/InspectorController.cpp:
- (WebCore::InspectorController::InspectorController):
- * inspector/InspectorFileSystemAgent.cpp:
- (InspectorFileSystemAgent::FrontendProvider):
- (WebCore):
- (WebCore::InspectorFileSystemAgent::create):
- (WebCore::InspectorFileSystemAgent::readDirectory):
- (WebCore::InspectorFileSystemAgent::InspectorFileSystemAgent):
- * inspector/InspectorFileSystemAgent.h:
- (WebCore):
- (InspectorFileSystemAgent):
-
-2012-06-13 Silvia Pfeiffer <silviapf@chromium.org>
-
- Change the styling of the Chromium video controls.
- https://bugs.webkit.org/show_bug.cgi?id=88297
-
- Reviewed by Eric Carlson.
-
- No new tests, final patch will contain the rebaselined tests.
-
- The Chrome video controls are receiving a visual update. This patch includes CSS changes,
- the removal of the now no longer needed controls background div, and the introduction of
- new images for the buttons.
-
- * css/mediaControlsChromium.css:
- (audio):
- Adjust height of audio controls.
- (::-webkit-media-controls):
- Use flexbox on media controls shadow DOM.
- (audio::-webkit-media-controls-enclosure, video::-webkit-media-controls-enclosure):
- Adjust height, max-width, text-indent and box-sizing, and reset padding to 0.
- (video::-webkit-media-controls-enclosure):
- Use 5px padding only for video controls and adjust height accordingly.
- (audio::-webkit-media-controls-panel, video::-webkit-media-controls-panel):
- Use flexbox on panel, adjust bottom alignment, height, background color and border radius.
- (audio::-webkit-media-controls-mute-button, video::-webkit-media-controls-mute-button):
- Display buttons inline with fixed width and height, vertically centered, no padding and
- 6px space to next controls element (this will be 15px incl the space in the image).
- (audio::-webkit-media-controls-play-button, video::-webkit-media-controls-play-button):
- Display buttons inline with fixed width and height, vertically centered, no padding and
- 9px space to next controls element (this will be 15px incl the space in the image).
- (audio::-webkit-media-controls-current-time-display, video::-webkit-media-controls-current-time-display):
- Display text as block, without broder, adjusted height, font-family, font-size and 9px space
- to next controls element (this will be 15px incl the space in the image).
- (audio::-webkit-media-controls-timeline, video::-webkit-media-controls-timeline):
- Adjust height, padding, background-color, min-wdith and 15px space to next controls element.
- (audio::-webkit-media-controls-volume-slider, video::-webkit-media-controls-volume-slider):
- Adjust height, max- and min-width, background-color and 15px space to next controls element.
- * html/shadow/MediaControlRootElementChromium.cpp:
- (WebCore::MediaControlRootElementChromium::MediaControlRootElementChromium):
- Remove timeline container, which is not necessary any longer because of the use of flexbox.
- (WebCore::MediaControlRootElementChromium::create):
- Remove timeline container, which is not necessary any longer because of the use of flexbox.
- (WebCore::MediaControlRootElementChromium::setMediaController):
- Remove timeline container, which is not necessary any longer because of the use of flexbox.
- (WebCore::MediaControlRootElementChromium::reset):
- Show the timeline instead of the timeline container when resetting.
- (WebCore::MediaControlRootElementChromium::reportedError):
- Hide the timeline instead of the timeline container when running into an error.
- * rendering/RenderMediaControlsChromium.cpp:
- (WebCore::paintMediaMuteButton):
- Introduce new image resources for the mute button and adjust it based on volume levels.
- (WebCore::paintMediaPlayButton):
- Introduce new image resources for the play button.
- (WebCore::getMediaSliderThumb):
- Introduce new image resources for the position slider thumb.
- (WebCore::paintMediaVolumeSliderThumb):
- Introduce new image resources for the volume slider thumb.
- Remove timeline container rendering.
- (WebCore::RenderMediaControlsChromium::paintMediaControlsPart):
- Add timeline container painting to the "not reached" elements.
- (WebCore):
- Provide size settings for the position and volume sliders.
- (WebCore::RenderMediaControlsChromium::adjustMediaSliderThumbSize):
- Calculate correct width and height settings for the new image resources of the position and volume
- slider thumbs.
- * rendering/RenderThemeChromiumMac.h:
- (RenderThemeChromiumMac):
- Remove timeline container rendering (i.e. the media controls background).
- * rendering/RenderThemeChromiumMac.mm:
- Remove timeline container rendering (i.e. the media controls background).
- * rendering/RenderThemeChromiumSkia.cpp:
- Remove timeline container rendering (i.e. the media controls background).
- * rendering/RenderThemeChromiumSkia.h:
- (RenderThemeChromiumSkia):
- Remove timeline container rendering (i.e. the media controls background).
-
-2012-06-13 Kinuko Yasuda <kinuko@chromium.org>
-
- Unreviewed, fixing English nits suggested by review for r120165.
-
- * fileapi/Blob.cpp:
- (WebCore::Blob::webkitSlice):
- * fileapi/Blob.h:
- (Blob):
-
-2012-06-13 MORITA Hajime <morrita@google.com>
-
- REGRESSION(r118098): <content> element does not render distributed children when cloned from another document
- https://bugs.webkit.org/show_bug.cgi?id=88148
-
- Reviewed by Dimitri Glazkov.
-
- The shadow DOM availability was decided through FrameLoaderClient.
- But there are documents which don't have any associated frames, in
- which any shadow DOM related elements cannot be constructed. That
- resulsted the regression.
-
- This change introduces a Page-based client called
- ContextFeaturesClient which takes the role from FrameLoaderClient
- to decide the feature availability, and ContextFeatures which is a
- proxy of ContextFeaturesClient. ContextEnabledFeatures is is
- replaced with ContextFeatures.
-
- Each ContextFeatures object is owned by a Page, and is attached to
- each Document in the page even if the page itself has no referenct
- to Frames or Pages. With ContextFeatures, each Document can decide
- the feature availability even if it cannot reach Page or Frame.
-
- On RefCountedSupplement: Document instance can live longer than a
- Page where it is shwon. This means that ContextFeatures instance
- needs to survive after owner Page destruction because it's
- referenced from possibly surviving Documents. RefCountedSupplement
- is introduced to cover this scenario: It allows supplement classes
- to live after Page's destruction.
-
- RefCountedSupplement::hostDestroyed() is notified when the hosting
- page is gone. ContextFeatures clears its reference to the client
- using this notification.
-
- Test: fast/dom/shadow/elements-in-frameless-document.html
-
- * CMakeLists.txt:
- * GNUmakefile.list.am:
- * Target.pri:
- * WebCore.gypi:
- * WebCore.vcproj/WebCore.vcproj:
- * WebCore.xcodeproj/project.pbxproj:
- * bindings/scripts/CodeGeneratorV8.pm:
- (GenerateImplementation):
- * css/StyleResolver.cpp:
- (WebCore::StyleResolver::determineScope):
- * dom/ContextFeatures.cpp: Added.
- (WebCore):
- (WebCore::ContextFeaturesClient::empty):
- (WebCore::ContextFeatures::supplementName):
- (WebCore::ContextFeatures::defaultSwitch):
- (WebCore::ContextFeatures::shadowDOMEnabled):
- (WebCore::ContextFeatures::styleScopedEnabled):
- (WebCore::ContextFeatures::pagePopupEnabled):
- (WebCore::provideContextFeaturesTo):
- (WebCore::provideContextFeaturesToDocumentFrom):
- * dom/ContextFeatures.h: Added.
- (WebCore):
- (ContextFeatures):
- (WebCore::ContextFeatures::ContextFeatures):
- (WebCore::ContextFeatures::hostDestroyed):
- (ContextFeaturesClient):
- (WebCore::ContextFeaturesClient::~ContextFeaturesClient):
- (WebCore::ContextFeaturesClient::isEnabled):
- (WebCore::ContextFeatures::create):
- (WebCore::ContextFeatures::isEnabled):
- * dom/DOMAllInOne.cpp:
- * dom/DOMImplementation.cpp:
- (WebCore::DOMImplementation::createDocument):
- (WebCore::DOMImplementation::createHTMLDocument):
- * dom/Document.h:
- (WebCore::Document::contextFeatures):
- * dom/Document.cpp:
- (WebCore::Document::Document):
- (WebCore::Document::setContextFeatures):
- * dom/Position.cpp:
- (WebCore::Position::Position):
- (WebCore::Position::findParent):
- * dom/TreeScope.cpp:
- (WebCore::TreeScope::getSelection):
- * dom/make_names.pl:
- (printConstructorInterior):
- (printFactoryCppFile):
- (printWrapperFunctions):
- (printWrapperFactoryCppFile):
- * editing/markup.cpp:
- (WebCore::createFragmentFromMarkupWithContext):
- * html/HTMLStyleElement.cpp:
- (WebCore::HTMLStyleElement::registerWithScopingNode):
- (WebCore::HTMLStyleElement::unregisterWithScopingNode):
- * html/shadow/HTMLContentElement.cpp:
- (WebCore::contentTagName):
- * inspector/DOMPatchSupport.cpp:
- (WebCore::DOMPatchSupport::patchDocument):
- * loader/FrameLoaderClient.h:
- * platform/RefCountedSupplement.h: Copied from Source/WebCore/platform/Supplementable.h.
- (WebCore):
- (RefCountedSupplement):
- (WebCore::RefCountedSupplement::hostDestroyed):
- (Wrapper):
- (WebCore::RefCountedSupplement::Wrapper::Wrapper):
- (WebCore::RefCountedSupplement::Wrapper::~Wrapper):
- (WebCore::RefCountedSupplement::Wrapper::wrapped):
- (WebCore::RefCountedSupplement::provideTo):
- (WebCore::RefCountedSupplement::from):
- * platform/Supplementable.h:
- (WebCore::Supplement::isRefCountedWrapper):
- * xml/XMLHttpRequest.cpp:
- (WebCore::XMLHttpRequest::responseXML):
-
-2012-06-11 Kinuko Yasuda <kinuko@chromium.org>
-
- Unprefix Blob.webkitSlice
- https://bugs.webkit.org/show_bug.cgi?id=78111
-
- Reviewed by Adam Barth.
-
- Add unprefixed Blob.slice and start showing a deprecation message when webkitSlice is called.
-
- No new tests: existing tests that call webkitSlice() are converted to slice(). They should keep running.
-
- * bindings/gobject/WebKitDOMCustom.cpp:
- (webkit_dom_blob_slice): Removed.
- (webkit_dom_blob_webkit_slice): Added.
- * fileapi/Blob.cpp:
- (WebCore::Blob::slice):
- (WebCore):
- (WebCore::Blob::webkitSlice):
- (WebCore::Blob::sliceInternal): Added.
- * fileapi/Blob.h:
- (WebCore):
- (Blob):
- * fileapi/Blob.idl:
-
-2012-06-12 Sheriff Bot <webkit.review.bot@gmail.com>
-
- Unreviewed, rolling out r120036.
- http://trac.webkit.org/changeset/120036
- https://bugs.webkit.org/show_bug.cgi?id=88965
-
- "assert failed in debug build" (Requested by maryw on
- #webkit).
-
- * platform/network/blackberry/NetworkJob.cpp:
- (WebCore::NetworkJob::handleNotifyDataReceived):
-
-2012-06-12 Wei James <james.wei@intel.com>
-
- webcore should depend on webcore_arm_neon for only arm target_arch
- https://bugs.webkit.org/show_bug.cgi?id=88839
-
- Reviewed by Adam Barth.
-
- * WebCore.gyp/WebCore.gyp:
-
-2012-06-12 Edaena Salinas Jasso <edaena@apple.com>
-
- Can't set el.type on a <button> element
- https://bugs.webkit.org/show_bug.cgi?id=14439
-
- Reviewed by Darin Adler.
-
- Test: fast/dom/HTMLButtonElement/change-type.html
-
- * bindings/objc/PublicDOMInterfaces.h:
- * html/HTMLButtonElement.cpp:
- (WebCore::HTMLButtonElement::setType): Added implementation of setType method.
- (WebCore):
- * html/HTMLButtonElement.h:
- (HTMLButtonElement): Added setType method.
- * html/HTMLButtonElement.idl: Removed readonly restriction to the type variable.
-
-2012-06-12 Kenichi Ishibashi <bashi@chromium.org>
-
- [Chromium] Implement font shaping with font-feature-settings on Mac
- https://bugs.webkit.org/show_bug.cgi?id=69826
-
- Reviewed by Tony Chang.
-
- Add HarfBuzz-ng text shaper.
- Chromium mac port uses it as secondary text shaper to support OpenType features.
- HarfBuzz-ng is only used when -webkit-font-feature-settings is specified and
- corresponding font is not an AAT font.
-
- No new tests. css3/font-feature-settings-rendering.html should pass on Chromium mac port.
-
- * WebCore.gyp/WebCore.gyp: Added harfbuzz-ng dependencies.
- * WebCore.gypi: Added harfbuzz-ng files.
- * platform/graphics/FontPlatformData.h:
- (FontPlatformData): Added m_harfbuzzFace.
- * platform/graphics/cocoa/FontPlatformDataCocoa.mm:
- (WebCore::FontPlatformData::platformDataInit): Copy m_harfbuzzFace.
- (WebCore::FontPlatformData::platformDataAssign): Ditto.
- (WebCore):
- (WebCore::isAATFont):
- (WebCore::FontPlatformData::harfbuzzFace):
- * platform/graphics/harfbuzz/ng/HarfBuzzFace.cpp: Added.
- (WebCore):
- (WebCore::harfbuzzFaceCache):
- (WebCore::HarfBuzzFace::HarfBuzzFace):
- (WebCore::HarfBuzzFace::~HarfBuzzFace):
- * platform/graphics/harfbuzz/ng/HarfBuzzFace.h: Added.
- (WebCore):
- (HarfBuzzFace):
- (WebCore::HarfBuzzFace::create):
- * platform/graphics/harfbuzz/ng/HarfBuzzFaceCoreText.cpp: Added.
- (WebCore):
- (WebCore::floatToHarfBuzzPosition):
- (WebCore::getGlyph):
- (WebCore::getGlyphHorizontalAdvance):
- (WebCore::getGlyphHorizontalOrigin):
- (WebCore::getGlyphExtents):
- (WebCore::harfbuzzCoreTextGetFontFuncs):
- (WebCore::releaseTableData):
- (WebCore::harfbuzzCoreTextGetTable):
- (WebCore::HarfBuzzFace::createFace):
- (WebCore::HarfBuzzFace::createFont):
- (WebCore::HarfBuzzShaper::createGlyphBufferAdvance):
- * platform/graphics/harfbuzz/ng/HarfBuzzShaper.cpp: Added.
- (WebCore):
- (WebCore::harfbuzzPositionToFloat):
- (WebCore::HarfBuzzShaper::HarfBuzzRun::HarfBuzzRun):
- (WebCore::HarfBuzzShaper::HarfBuzzRun::setGlyphAndPositions):
- (WebCore::HarfBuzzShaper::HarfBuzzRun::characterIndexForXPosition):
- (WebCore::HarfBuzzShaper::HarfBuzzRun::xPositionForOffset):
- (WebCore::HarfBuzzShaper::HarfBuzzShaper):
- (WebCore::HarfBuzzShaper::~HarfBuzzShaper):
- (WebCore::HarfBuzzShaper::setFontFeatures):
- (WebCore::HarfBuzzShaper::shape):
- (WebCore::HarfBuzzShaper::setupHarfBuzzRun):
- (WebCore::HarfBuzzShaper::shapeHarfBuzzRun):
- (WebCore::HarfBuzzShaper::setGlyphPositionsForHarfBuzzRun):
- (WebCore::HarfBuzzShaper::offsetForPosition):
- (WebCore::HarfBuzzShaper::selectionRect):
- * platform/graphics/harfbuzz/ng/HarfBuzzShaper.h: Added.
- (WebCore):
- (HarfBuzzShaper):
- (WebCore::HarfBuzzShaper::totalWidth):
- (HarfBuzzRun):
- (WebCore::HarfBuzzShaper::HarfBuzzRun::create):
- (WebCore::HarfBuzzShaper::HarfBuzzRun::setWidth):
- (WebCore::HarfBuzzShaper::HarfBuzzRun::numCharacters):
- (WebCore::HarfBuzzShaper::HarfBuzzRun::numGlyphs):
- (WebCore::HarfBuzzShaper::HarfBuzzRun::width):
- (WebCore::HarfBuzzShaper::HarfBuzzRun::rtl):
- * platform/graphics/mac/FontComplexTextMac.cpp:
- (WebCore):
- (WebCore::preferHarfBuzz): Added.
- (WebCore::Font::selectionRectForComplexText): Use HarfBuzzShaper if font-feature-settings exists.
- (WebCore::Font::drawComplexText): Ditto.
- (WebCore::Font::floatWidthForComplexText): Ditto.
- (WebCore::Font::offsetForPositionForComplexText): Ditto.
-
-2012-06-12 Luke Macpherson <macpherson@chromium.org>
-
- WIP: Implement CSS Variables Standard.
- https://bugs.webkit.org/show_bug.cgi?id=85580
-
- Reviewed by Ojan Vafai.
-
- Implement CSS Variables Module Level 1. (See http://www.w3.org/TR/css-variables/)
-
- A HashMap of properties is referenced by RenderStyle, and used to store variables as strings.
- That HashMap is copy-on-write, and unless new variables are defined is simply a pointer to the
- parent's definitions. At usage time the variable's value is parsed according to the CSS property
- where it is used.
- Variables can:
- Define lists of values (ie. entire shorthand values).
- Define individual values.
- Refer to other variables. (Cycle detection is implemented).
- Please see the supplied test cases for example usage.
-
- Missing features:
- CSS variables cannot yet be used inside some functions such as -webkit-calc.
-
- Covered by existing test suite under fast/css/variables.
-
- * GNUmakefile.list.am:
- * Target.pri:
- * WebCore.gypi:
- * WebCore.vcproj/WebCore.vcproj:
- * WebCore.xcodeproj/project.pbxproj:
- * css/CSSComputedStyleDeclaration.cpp:
- (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
- * css/CSSGrammar.y:
- * css/CSSParser.cpp:
- (WebCore):
- (WebCore::filterProperties):
- (WebCore::CSSParser::createStylePropertySet):
- (WebCore::CSSParser::validUnit):
- (WebCore::CSSParser::createPrimitiveNumericValue):
- (WebCore::CSSParser::parseValue):
- (WebCore::CSSParser::storeVariableDeclaration):
- (WebCore::CSSParser::detectDashToken):
- (WebCore::CSSParser::lex):
- * css/CSSParser.h:
- (CSSParser):
- * css/CSSParserValues.cpp:
- (WebCore::CSSParserValue::createCSSValue):
- * css/CSSPrimitiveValue.cpp:
- (WebCore::isValidCSSUnitTypeForDoubleConversion):
- (WebCore::CSSPrimitiveValue::getStringValue):
- (WebCore::CSSPrimitiveValue::customSerializeResolvingVariables):
- (WebCore):
- * css/CSSPrimitiveValue.h:
- (CSSPrimitiveValue):
- (WebCore::CSSPrimitiveValue::isVariableName):
- * css/CSSProperty.cpp:
- (WebCore::CSSProperty::isInheritedProperty):
- * css/CSSValue.cpp:
- (WebCore::CSSValue::serializeResolvingVariables):
- (WebCore):
- (WebCore::CSSValue::destroy):
- * css/CSSValue.h:
- (CSSValue):
- (WebCore::CSSValue::isVariableValue):
- * css/CSSValueList.cpp:
- (WebCore):
- (WebCore::CSSValueList::customSerializeResolvingVariables):
- * css/CSSValueList.h:
- (CSSValueList):
- * css/CSSVariableValue.h: Added.
- (WebCore):
- (CSSVariableValue):
- (WebCore::CSSVariableValue::create):
- (WebCore::CSSVariableValue::name):
- (WebCore::CSSVariableValue::value):
- (WebCore::CSSVariableValue::CSSVariableValue):
- * css/StyleResolver.cpp:
- (WebCore::StyleResolver::collectMatchingRulesForList):
- * css/StyleResolver.h:
- * css/WebKitCSSTransformValue.cpp:
- (WebCore):
- (WebCore::WebKitCSSTransformValue::customSerializeResolvingVariables):
- * css/WebKitCSSTransformValue.h:
- (WebKitCSSTransformValue):
- * css/makeprop.pl:
- * rendering/style/RenderStyle.h:
- * rendering/style/StyleVariableData.h: Added.
- (WebCore):
- (StyleVariableData):
- (WebCore::StyleVariableData::create):
- (WebCore::StyleVariableData::copy):
- (WebCore::StyleVariableData::operator==):
- (WebCore::StyleVariableData::operator!=):
- (WebCore::StyleVariableData::setVariable):
- (WebCore::StyleVariableData::StyleVariableData):
-
-2012-06-12 MORITA Hajime <morrita@google.com>
-
- Shadow Pseudo ID should be able to nest to point nested shadow DOM.
- https://bugs.webkit.org/show_bug.cgi?id=62218
-
- Reviewed by Dimitri Glazkov.
-
- - updateSpecifiersWithElementName() didn't take nesting into account.
- tag history can contain selector entries which isn't marked as ShadowDescendant yet.
- such entry can be found by investigating isUnknownPseudoElement().
- - SelectorChecker::checkSelector() was too strict. Unknown pseudo elements are essentially a kind of class or id
- in implementation perspective. For such, rejecting by missing elementStyle doesn't make sense:
- It isn't a pseudo but a real element for WebCore after all.
- - Added Internals::setShadowPseudoId() to create a test harness whose DOM tree contains pseudo shadow ids.
-
- Before this change, following selecdtor chain is created for "p::-shadow-child::-nested-shadow-child":
-
- [both tag name and -shadow-id are set] <-(ShadowDescendant)- [-nested-shadow-id]
-
- What we want, which is created by this change is:
-
- [tag] <-(ShadowDescendant)- [-shadow-id is set] <-(ShadowdescenDant)- [-nested-shadow-id]
-
- Test: fast/dom/shadow/shadow-nested-pseudo-id.html
-
- * WebCore.exp.in:
- * css/CSSParser.cpp:
- (WebCore::CSSParser::updateSpecifiersWithElementName):
- * css/SelectorChecker.cpp:
- (WebCore::SelectorChecker::checkOneSelector):
- * testing/Internals.cpp:
- (WebCore::Internals::setShadowPseudoId):
- (WebCore):
- * testing/Internals.h:
- (Internals):
- * testing/Internals.idl:
-
-2012-06-12 Christophe Dumez <christophe.dumez@intel.com>
-
- [soup] Prevent setting or editing httpOnly cookies from JavaScript
- https://bugs.webkit.org/show_bug.cgi?id=88760
-
- Reviewed by Gustavo Noronha Silva.
-
- Prevent setting or overwriting httpOnly cookies from JavaScript.
- Fix setCookies() so that it parses all the cookies and not just
- the first one.
-
- Test: http/tests/cookies/js-get-and-set-http-only-cookie.html
-
- * platform/network/soup/CookieJarSoup.cpp:
- (WebCore::httpOnlyCookieExists):
- (WebCore):
- (WebCore::setCookies):
-
-2012-06-12 Christophe Dumez <christophe.dumez@intel.com>
-
- [EFL] Enable SHADOW_DOM flag
- https://bugs.webkit.org/show_bug.cgi?id=87732
-
- Reviewed by Kentaro Hara.
-
- Test: fast/dom/shadow/shadow-root-innerHTML.html
-
- * dom/ShadowRoot.idl: Add JSGenerateToJSObject extended attribute so
- that the ShadowRoot properties are accessible on JS side.
- * testing/Internals.idl: Fix SHADOW_DOM ifdef check.
-
-2012-06-12 Leo Yang <leo.yang@torchmobile.com.cn>
-
- Dynamic hash table in DOMObjectHashTableMap is wrong in multiple threads
- https://bugs.webkit.org/show_bug.cgi?id=87334
-
- Reviewed by Geoffrey Garen.
-
- Adapt to JSC::HashTable::copy to avoid copy dynamic table member of a HashTable.
- The dynamic table may be allocated on other thread and contains thread specific
- identifiers. For example, a hash table of JSEntryArray was first initialized on a
- worker thread, and then the user reloaded the page, another worker thread is
- created due to reload, the dynamic allocated table in *staticTable* is specific
- to the first worker thread which has died. If the user reload the page again,
- the dynamic table will be freed and memory corruption will occur.
-
- No functionalities changed, no new tests.
-
- * bindings/js/DOMObjectHashTableMap.h:
- (WebCore::DOMObjectHashTableMap::get):
-
-2012-06-12 James Robinson <jamesr@chromium.org>
-
- [chromium] Port Canvas2DLayerBridge over to WebExternalTextureLayer
- https://bugs.webkit.org/show_bug.cgi?id=88597
-
- Reviewed by Adrienne Walker.
-
- This converts Canvas2DLayerBridge to using public WebLayer API types instead of LayerChromium types.
-
- * platform/graphics/chromium/Canvas2DLayerBridge.cpp:
- (WebCore::AcceleratedDeviceContext::AcceleratedDeviceContext):
- (WebCore::AcceleratedDeviceContext::prepareForDraw):
- (AcceleratedDeviceContext):
- (WebCore::Canvas2DLayerBridge::Canvas2DLayerBridge):
- (WebCore::Canvas2DLayerBridge::~Canvas2DLayerBridge):
- (WebCore::Canvas2DLayerBridge::skCanvas):
- (WebCore::Canvas2DLayerBridge::prepareTexture):
- (WebCore::Canvas2DLayerBridge::context):
- (WebCore::Canvas2DLayerBridge::layer):
- (WebCore::Canvas2DLayerBridge::contextAcquired):
- * platform/graphics/chromium/Canvas2DLayerBridge.h:
- (WebCore):
- (Canvas2DLayerBridge):
-
-2012-06-12 Alexis Menard <alexis.menard@openbossa.org>
-
- Fix packing in StyleBoxData for Windows.
- https://bugs.webkit.org/show_bug.cgi?id=88858
-
- Reviewed by Tony Chang.
-
- MSVC doesn't pack bitfields if the types are mixed.
- We can safely change the bool type to an unsigned so
- the packing will happen. I have added a compile assert
- for future regressions.
-
- No new tests : we should not see any regressions.
-
- * rendering/style/StyleBoxData.h:
- * rendering/style/StyleBoxData.cpp:
- (StyleBoxData):
-
-2012-06-12 Adrienne Walker <enne@google.com>
-
- [chromium] Paint scrollbars on WebKit thread and composite those textures
- https://bugs.webkit.org/show_bug.cgi?id=88145
-
- Reviewed by James Robinson.
-
- Scrollbars were previously painted and uploaded on the compositor
- thread. This isn't possible to do for many scrollbar themes. This
- patch changes ScrollbarLayerChromium to paint the scrollbar into two
- parts: the thumb, and everything else. These are uploaded into
- textures and synced over to the CCScrollbarImpl where they are
- composited and drawn.
-
- Mac and overlay scrollbars are still not enabled to have compositor
- thread-updated scrollbars.
-
- As a bonus, fix LayerRendererChromium::drawTextureQuad to draw quads
- that do not fill the entire layer bounds.
-
- Tested by existing layout and unit tests by removing the condition
- that these scrollbar layers are only created when the threaded proxy
- exists.
-
- * page/scrolling/chromium/ScrollingCoordinatorChromium.cpp:
- (WebCore::scrollbarLayerDidChange):
- * platform/ScrollbarThemeComposite.cpp:
- (WebCore::ScrollbarThemeComposite::thumbRect):
- (WebCore):
- * platform/ScrollbarThemeComposite.h:
- (ScrollbarThemeComposite):
- * platform/graphics/chromium/LayerRendererChromium.cpp:
- (WebCore::LayerRendererChromium::drawTextureQuad):
- * platform/graphics/chromium/ScrollbarLayerChromium.cpp:
- (WebCore::ScrollbarLayerChromium::ScrollbarLayerChromium):
- (WebCore::ScrollbarLayerChromium::theme):
- (WebCore):
- (WebCore::ScrollbarLayerChromium::pushPropertiesTo):
- (ScrollbarBackgroundPainter):
- (WebCore::ScrollbarBackgroundPainter::create):
- (WebCore::ScrollbarBackgroundPainter::paint):
- (WebCore::ScrollbarBackgroundPainter::ScrollbarBackgroundPainter):
- (ScrollbarThumbPainter):
- (WebCore::ScrollbarThumbPainter::create):
- (WebCore::ScrollbarThumbPainter::paint):
- (WebCore::ScrollbarThumbPainter::ScrollbarThumbPainter):
- (WebCore::ScrollbarLayerChromium::setLayerTreeHost):
- (WebCore::ScrollbarLayerChromium::createTextureUpdaterIfNeeded):
- (WebCore::ScrollbarLayerChromium::updatePart):
- (WebCore::ScrollbarLayerChromium::update):
- * platform/graphics/chromium/ScrollbarLayerChromium.h:
- (WebCore):
- (ScrollbarLayerChromium):
- * platform/graphics/chromium/cc/CCScrollbarLayerImpl.cpp:
- (WebCore::CCScrollbarLayerImpl::CCScrollbarLayerImpl):
- (WebCore::CCScrollbarLayerImpl::appendQuads):
- * platform/graphics/chromium/cc/CCScrollbarLayerImpl.h:
- (WebCore::CCScrollbarLayerImpl::setBackgroundTextureId):
- (WebCore::CCScrollbarLayerImpl::setThumbTextureId):
- (CCScrollbarLayerImpl):
-
-2012-06-12 Tony Chang <tony@chromium.org>
-
- Replaced items in a flexbox should be coerced to display:block
- https://bugs.webkit.org/show_bug.cgi?id=87068
-
- Reviewed by Ojan Vafai.
-
- The flexbox spec lists HTML tags that should automatically be converted
- to display:block when a flex child. It also says that atomic inline-level
- children should become block (e.g., inline-table should be treated as table).
- http://dev.w3.org/csswg/css3-flexbox/#flex-items
-
- Test: css3/flexbox/flexitem.html
-
- * css/StyleResolver.cpp:
- (WebCore::StyleResolver::collectMatchingRulesForList):
-
-2012-06-12 Joshua Bell <jsbell@chromium.org>
-
- IndexedDB: ObjectStore/Index shouldn't hold reference to backing store
- https://bugs.webkit.org/show_bug.cgi?id=83074
-
- Reviewed by Tony Chang.
-
- We should be able to collect and close the leveldb backing store as soon as the database
- connection is closed, but the IDBObjectStoreBackendImpl and IDBIndexBackendImpl were
- holding RefPtrs, and those objects are kept alive by script references.
-
- Replaced RefPtrs to the IDBBackingStore with pointers to the IDBDatabase. On the back end,
- IDBDatabaseBackendImpl maintains a RefPtr to the IDBObjectStoreBackendImpl object, so
- a raw pointer back is safe. On the front end, the IDBObjectStore maintains a RefPtr to
- the IDBDatabase so script can navigate upwards. Ditto on both ends for the ObjectStore/Index
- relationship. The frontend objects maintain RefPtrs to the backend objects, so the backend
- objects and their owners are maintained as long as there's a script reference. To ensure
- that all LevelDB objects are destructed in the right order, transactions indirectly track all
- open cursors and ensure they are closed when the transaction finishes, and database closing
- is explicitly prevented from occurring until transactions are complete.
-
- Also made IDBDatabaseBackendImpl handle a null IDBFactoryBackendImpl pointer, for testing.
-
- Tests: storage/indexeddb/database-close.html
- storage/indexeddb/persistence.html
- [Chromium] webkit_unit_tests --gtest_filter=IDBDatabaseBackendTest.BackingStoreRetention
-
- * Modules/indexeddb/IDBCursorBackendImpl.cpp:
- (WebCore::IDBCursorBackendImpl::close): Release LevelDB resources when closed to allow backing store to close.
- * Modules/indexeddb/IDBCursorBackendImpl.h:
- (WebCore):
- * Modules/indexeddb/IDBDatabase.cpp: Ensure connection close deferred until all transactions are finished.
- (WebCore::IDBDatabase::transactionCreated): Accounting.
- (WebCore::IDBDatabase::transactionFinished): Accounting.
- (WebCore::IDBDatabase::close):
- (WebCore):
- (WebCore::IDBDatabase::closeConnection):
- * Modules/indexeddb/IDBDatabase.h:
- (IDBDatabase):
- * Modules/indexeddb/IDBDatabaseBackendImpl.cpp: Track outstanding transactions for forced-close scenarios.
- (WebCore::IDBDatabaseBackendImpl::~IDBDatabaseBackendImpl):
- (WebCore::IDBDatabaseBackendImpl::createObjectStore): Don't pass in backing store reference.
- (WebCore::IDBDatabaseBackendImpl::setVersion): Use transaction() for consistent accounting.
- (WebCore::IDBDatabaseBackendImpl::transactionFinished): Accounting.
- (WebCore::IDBDatabaseBackendImpl::transaction): Accounting.
- (WebCore::IDBDatabaseBackendImpl::close): Unregister from factory when last connection is closed.
- (WebCore::IDBDatabaseBackendImpl::loadObjectStores): Don't pass in backing store reference.
- (WebCore::IDBDatabaseBackendImpl::removeObjectStoreFromMap):
- * Modules/indexeddb/IDBDatabaseBackendImpl.h:
- (WebCore):
- (IDBDatabaseBackendImpl):
- * Modules/indexeddb/IDBFactoryBackendImpl.cpp:
- (WebCore::IDBFactoryBackendImpl::deleteDatabase): Don't hang on to deleted databases eternally.
- * Modules/indexeddb/IDBFactoryBackendImpl.h: Backend map controls IDBDatabaseBackend lifetimes.
- (IDBFactoryBackendImpl):
- * Modules/indexeddb/IDBIndexBackendImpl.cpp: Don't hold backing store references.
- (WebCore::IDBIndexBackendImpl::IDBIndexBackendImpl):
- * Modules/indexeddb/IDBIndexBackendImpl.h:
- (WebCore::IDBIndexBackendImpl::create):
- (IDBIndexBackendImpl):
- (WebCore::IDBIndexBackendImpl::backingStore):
- (WebCore::IDBIndexBackendImpl::databaseId):
- * Modules/indexeddb/IDBObjectStoreBackendImpl.cpp: Don't hold backing store references.
- (WebCore::IDBObjectStoreBackendImpl::IDBObjectStoreBackendImpl):
- (WebCore::IDBObjectStoreBackendImpl::createIndex):
- (WebCore::IDBObjectStoreBackendImpl::loadIndexes):
- * Modules/indexeddb/IDBObjectStoreBackendImpl.h:
- (WebCore::IDBObjectStoreBackendImpl::create):
- (IDBObjectStoreBackendImpl):
- (WebCore::IDBObjectStoreBackendImpl::backingStore):
- (WebCore::IDBObjectStoreBackendImpl::databaseId):
- * Modules/indexeddb/IDBRequest.cpp:
- (WebCore::IDBRequest::onSuccess):
- * Modules/indexeddb/IDBTransaction.cpp:
- (WebCore::IDBTransaction::IDBTransaction): For IDBDatabase accounting, allow ref during ctor.
- (WebCore::IDBTransaction::onAbort): Accounting.
- (WebCore::IDBTransaction::onComplete): Accounting.
- * Modules/indexeddb/IDBTransaction.h:
- (WebCore::IDBTransaction::isVersionChange): Convenience function.
- (IDBTransaction):
- * Modules/indexeddb/IDBTransactionBackendImpl.cpp:
- (WebCore::IDBTransactionBackendImpl::abort): Cleanup ordering to allow backing store to close.
- (WebCore::IDBTransactionBackendImpl::commit): Cleanup ordering to allow backing store to close.
-
-2012-06-12 Adrienne Walker <enne@google.com>
-
- [chromium] Don't set visible layer rect in CCLayerTreeHost paint iteration
- https://bugs.webkit.org/show_bug.cgi?id=88895
-
- Reviewed by James Robinson.
-
- We should only set visible layer rects during the recursion in
- CClayerTreeHostCommon and not while we're painting. This is one last
- straggling piece of code that never got moved.
-
- Tested by existing mask-related layout tests.
-
- * platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
- (WebCore::CCLayerTreeHost::paintMasksForRenderSurface):
- * platform/graphics/chromium/cc/CCLayerTreeHostCommon.cpp:
- (WebCore::calculateVisibleAndScissorRectsInternal):
-
-2012-06-12 Dana Jansens <danakj@chromium.org>
-
- [chromium] Return empty visibleLayerRect for layers with empty content bounds
- https://bugs.webkit.org/show_bug.cgi?id=88901
-
- Reviewed by Adrienne Walker.
-
- This change should only affect tests. Currently if you set up a
- CCLayerImpl with some bounds, but don't set the contentBounds, then
- they are empty by default. In this case the visibleLayerRect gets
- set inappropriately to the layer's target surface contentRect which
- in a completely different coordinate space.
-
- Fixed up tests that were passing bogusly and failed after this change.
-
- * platform/graphics/chromium/cc/CCLayerTreeHostCommon.cpp:
- (WebCore::calculateVisibleLayerRect):
-
-2012-06-12 Adrienne Walker <enne@google.com>
-
- [chromium] ScrollingCoordinator::setScrollLayer should update scroll layer ids
- https://bugs.webkit.org/show_bug.cgi?id=88882
-
- Reviewed by James Robinson.
-
- Tested manually, as scrollbar layers are currently only created when
- threaded compositing is enabled and none of those layout tests trigger
- this bug.
-
- * page/scrolling/chromium/ScrollingCoordinatorChromium.cpp:
- (WebCore::ScrollingCoordinatorPrivate::setScrollLayer):
- (ScrollingCoordinatorPrivate):
- (WebCore::ScrollingCoordinatorPrivate::setHorizontalScrollbarLayer):
- (WebCore::ScrollingCoordinatorPrivate::setVerticalScrollbarLayer):
- (WebCore::createScrollbarLayer):
- (WebCore::ScrollingCoordinator::frameViewHorizontalScrollbarLayerDidChange):
- (WebCore::ScrollingCoordinator::frameViewVerticalScrollbarLayerDidChange):
- * platform/graphics/chromium/ScrollbarLayerChromium.h:
- (WebCore::ScrollbarLayerChromium::setScrollLayerId):
- (ScrollbarLayerChromium):
- * platform/graphics/chromium/TreeSynchronizer.cpp:
- (WebCore::TreeSynchronizer::updateScrollbarLayerPointersRecursive):
-
-2012-06-12 Mark Mentovai <mark@chromium.org>
-
- [chromium mac] Don't include things in subframeworks of
- ApplicationServices.framework.
-
- Subframeworks move around from SDK to SDK and OS release to OS
- release, but just using the top-level umbrella framework guarantees
- forward compatibility. When building for Chromium Mac, just #include
- <ApplicationServices/ApplicationServices.h> instead of reaching in to
- subframeworks.
-
- https://bugs.webkit.org/show_bug.cgi?id=88569
-
- Reviewed by Stephen White.
-
- No new tests.
-
- * platform/graphics/GlyphBuffer.h:
- * platform/graphics/mac/ComplexTextControllerCoreText.mm:
- * platform/graphics/skia/GraphicsContextSkia.cpp:
-
-2012-06-12 Igor Oliveira <igor.o@sisa.samsung.com>
-
- Apply animations and transitions for first-letter element
- https://bugs.webkit.org/show_bug.cgi?id=85253
-
- Add animations and transitions support for the first-letter
- pseudo element.
- Instead of calling RenderOject::node() in the animations code,
- now we need to call RenderObject::styledGeneratingNode() because
- pseudo elements does not have a Node associated with the
- RenderObject.
-
- Initial patch by Simon Fraser
-
- Reviewed by Simon Fraser.
-
- Tests: animations/first-letter-animation.html
- animations/first-letter-play-state.html
- transitions/first-letter-color-transition.html
- transitions/first-letter-transition.html
-
- * page/animation/AnimationBase.cpp:
- (WebCore::AnimationBase::updateStateMachine):
- * page/animation/AnimationController.cpp:
- (WebCore::AnimationControllerPrivate::updateAnimations):
- (WebCore::AnimationControllerPrivate::pauseAnimationAtTime):
- (WebCore::AnimationControllerPrivate::pauseTransitionAtTime):
- (WebCore::AnimationController::cancelAnimations):
- (WebCore::AnimationController::updateAnimations):
- * page/animation/ImplicitAnimation.cpp:
- (WebCore::ImplicitAnimation::pauseAnimation):
- (WebCore::ImplicitAnimation::sendTransitionEvent):
- * page/animation/KeyframeAnimation.cpp:
- (WebCore::KeyframeAnimation::KeyframeAnimation):
- (WebCore::KeyframeAnimation::pauseAnimation):
- (WebCore::KeyframeAnimation::endAnimation):
- (WebCore::KeyframeAnimation::sendAnimationEvent):
- * rendering/RenderBlock.cpp:
- (WebCore::RenderBlock::updateFirstLetterStyle):
- (WebCore::RenderBlock::createFirstLetterRenderer):
- * rendering/RenderInline.cpp:
- (WebCore::RenderInline::clippedOverflowRectForRepaint):
- * rendering/RenderObject.cpp:
- (WebCore::RenderObject::setAnimatableStyle):
- (WebCore::RenderObject::styledGeneratingNode):
- (WebCore):
- * rendering/RenderObject.h:
- (RenderObject):
-
-2012-06-12 Kent Tamura <tkent@chromium.org>
-
- Checking a radio button doesn't uncheck other buttons in the same group in some cases.
- https://bugs.webkit.org/show_bug.cgi?id=88835
-
- Reviewed by Ryosuke Niwa.
-
- This change fixes a bug that checking a radio button in a radio button
- group in a form detached from a document tree doesn't uncheck another
- checked radio button in the radio button group.
-
- A radio button participates in a radio button group in the following
- conditions:
- - If it is owned by a form element regardless of the form is in a
- document tree or not, or
-
- - If it is not owned by any form elements and it is in a document tree.
- A radio button group for the radio button is owned by the document.
-
- For HTMLInputElement::removedFrom():
- The old code always unregistered the radio button if it was removed from
- the document tree. It was incorrect because we don't need to unregister
- it if it has an owner form and the owner form is not changed by
- removedFrom().
- If the owner form is cleared by removedFrom(), willChangeForm()
- unregisters the radio button. So what we should do in removedFrom() is
- to unregister the radio button only if the radio button group is owned
- by the document.
-
- For HTMLInputElement::insertedInto():
- The old code always registered the radio button if it is inserted into
- the document tree. It was incorrect because we don't need to register it
- if it has an owner form and the owner form is not changed by
- insertedInto().
- If the owner form is changed by insertedInto(), didChangeForm()
- registers the radio button. So We should register the radio button only
- if its radio button group will be owned by the document.
-
- Test: Add test cases to fast/forms/radio/radio-group.html
-
- * html/HTMLInputElement.cpp:
- (WebCore::HTMLInputElement::insertedInto):
- Register this to CheckedRadioButtons only if new group owner is Document.
- (WebCore::HTMLInputElement::removedFrom):
- Unregister this from CheckedRadioButtons only if old group owner was Document.
-
-2012-06-12 James Robinson <jamesr@chromium.org>
-
- [chromium] REGRESSION(119769): Canvas2DLayerBridge may go away before its TextureLayerChromium
- https://bugs.webkit.org/show_bug.cgi?id=88910
-
- Reviewed by Adrienne Walker.
-
- Unregister the bridge as its TextureLayerChromium client when going away.
-
- Covered by new unit test in Canvas2DLayerBridgeTest.cpp.
-
- * platform/graphics/chromium/Canvas2DLayerBridge.cpp:
- (WebCore::Canvas2DLayerBridge::~Canvas2DLayerBridge):
-
-2012-06-12 Alec Flett <alecflett@chromium.org>
-
- IndexedDB: Error codes, phase two
- https://bugs.webkit.org/show_bug.cgi?id=88690
-
- Reviewed by Tony Chang.
-
- Update the next phase of IndexedDB error codes to match the spec.
- This update is mostly focused on DATA_ERR vs CONSTRAINT_ERR.
-
- Also moves some of the error checking for the transaction mode
- into the frontend and replaces the backend checks with asserts, so that
- we can consolidate error checking in one place.
-
- This also removes a few FIXME's that are no longer true (about
- I/O errors - the spec was updated and our implementation was
- already correct)
-
- No new tests, existing tests cover changed behavior.
-
- * Modules/indexeddb/IDBCursor.cpp:
- (WebCore::IDBCursor::deleteFunction):
- * Modules/indexeddb/IDBCursorBackendImpl.cpp:
- (WebCore::IDBCursorBackendImpl::deleteFunction):
- * Modules/indexeddb/IDBDatabaseBackendImpl.cpp:
- (WebCore::IDBDatabaseBackendImpl::setVersionInternal):
- * Modules/indexeddb/IDBObjectStore.cpp:
- (WebCore::IDBObjectStore::add):
- (WebCore::IDBObjectStore::put):
- (WebCore::IDBObjectStore::deleteFunction):
- (WebCore::IDBObjectStore::clear):
- * Modules/indexeddb/IDBObjectStoreBackendImpl.cpp:
- (WebCore::IDBObjectStoreBackendImpl::put):
- (WebCore::IDBObjectStoreBackendImpl::putInternal):
- (WebCore::IDBObjectStoreBackendImpl::deleteFunction):
- (WebCore::IDBObjectStoreBackendImpl::clear):
- * Modules/indexeddb/IDBTransaction.h:
- (WebCore::IDBTransaction::enumMode):
- * Modules/indexeddb/IDBTransactionBackendImpl.h:
-
-2012-06-12 Min Qin <qinmin@google.com>
-
- Disable autoplay when user gesture is required for media playback
- https://bugs.webkit.org/show_bug.cgi?id=88897
-
- Reviewed by Adam Barth.
-
- When user gesture is required for media playback, we should block autoplay.
- Otherwise, people will use autoplay instead of video.play() to bypass the gesture requirement.
- Test: media/no-autoplay-with-user-gesture-requirement.html
-
- * html/HTMLMediaElement.cpp:
- (WebCore::HTMLMediaElement::setReadyState):
-
-2012-06-12 Shrey Banga <banga@chromium.org>
-
- HTML parser should yield more to improve perceived page load time
- https://bugs.webkit.org/show_bug.cgi?id=86165
-
- Reviewed by Tony Gentilcore.
-
- Test: fast/events/event-yield-timing.html
-
- We want the parser to yield at least every 500ms to keep the page somewhat responsive and allow painting.
- Since it would be too expensive to check the time after each token, the previous heuristic was to check every 4,096 tokens.
- That works fine for most tokens, but a script may spend an arbitrary amount of time executing.
-
- This patch fixes the issue by causing the parser to check the elapsed time immediately after executing a script.
-
- * html/parser/HTMLParserScheduler.cpp:
- (WebCore::HTMLParserScheduler::checkForYieldBeforeScript):
- * html/parser/HTMLParserScheduler.h:
- (WebCore::PumpSession::PumpSession):
- (PumpSession):
- (WebCore::HTMLParserScheduler::checkForYieldBeforeToken):
-
-2012-06-12 Sami Kyostila <skyostil@chromium.org>
-
- [chromium] Don't crash in CCLayerIterator if the root layer doesn't have a render surface
- https://bugs.webkit.org/show_bug.cgi?id=88886
-
- Reviewed by James Robinson.
-
- If we are iterating over a render render surface layer list where the
- root layer does not have a render surface, fail gracefully instead of
- crashing.
-
- Tests: CCLayerIteratorTest.{emptyTree,rootLayerWithoutRenderSurface}
-
- * platform/graphics/chromium/cc/CCLayerIterator.h:
- (WebCore::CCLayerIterator::CCLayerIterator):
-
-2012-06-06 Ojan Vafai <ojan@chromium.org>
-
- Change default for flex-grow back to 0
- https://bugs.webkit.org/show_bug.cgi?id=88443
-
- Reviewed by Tony Chang.
-
- * rendering/style/RenderStyle.h:
-
-2012-06-12 Brady Eidson <beidson@apple.com>
-
- <rdar://problem/11593686> and https://bugs.webkit.org/show_bug.cgi?id=88683
- Garbage collection of an <img> element can cause reentrant event dispatch.
-
- Reviewed by Darin Adler.
-
- The most straightforward solution is for ImageLoader to keep its Element alive
- with ref/deref any time the Image is actually loading.
-
- ImageLoader should always do this for all Elements, and if those Elements want/need
- different behavior for when they are detached then they need to manually stop their
- loads.
-
- Tests: http/tests/loading/embed-image-load-outlives-gc-without-crashing.html
- http/tests/loading/image-input-type-outlives-gc-without-crashing.html
- http/tests/loading/image-load-outlives-gc-without-crashing.html
- http/tests/loading/object-image-load-outlives-gc-without-crashing.html
- http/tests/loading/svg-image-load-outlives-gc-without-crashing.html
- http/tests/loading/video-poster-image-load-outlives-gc-without-crashing.html
-
- * loader/ImageLoader.cpp:
- (WebCore::ImageLoader::ImageLoader):
- (WebCore::ImageLoader::~ImageLoader):
- (WebCore::ImageLoader::setImage):
- (WebCore::ImageLoader::updateFromElement):
- (WebCore::ImageLoader::notifyFinished):
- (WebCore::ImageLoader::updatedHasPendingLoadEvent):
- (WebCore::ImageLoader::dispatchPendingBeforeLoadEvent):
- (WebCore::ImageLoader::dispatchPendingLoadEvent):
- * loader/ImageLoader.h:
- (ImageLoader):
-
-2012-06-12 Shawn Singh <shawnsingh@chromium.org>
-
- [chromium] Make damage tracking more robust to early exits
- https://bugs.webkit.org/show_bug.cgi?id=84803
-
- Reviewed by James Robinson.
-
- All CCDamageTrackerTest unit tests updated;
- One new unit test added:
- CCDamageTrackerTest.verifyDamageAccumulatesUntilReset
-
- Damage tracking inherently needs to be aware of all changes that
- occur for every frame. Before this patch, anyone modifying details
- of CCLayerTreeHostImpl and the drawing phases of the compositor
- needed to be careful to avoid early exiting once draw is
- initiated, otherwise running the risk of damage tracking's state
- getting out-of-sync from actual changes. This patch makes the
- damage tracker API more asynchronous-like, so that damage will
- continue to accumulate until it is explicitly notified that
- damaged areas have been drawn. This will allow more freedom in
- designing and restructuing drawing code in the compositor, without
- worrying as much about damage tracking getting out-of-sync.
-
- * platform/graphics/chromium/cc/CCDamageTracker.h:
- (WebCore::CCDamageTracker::didDrawDamagedArea):
- * platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
- (WebCore::CCLayerTreeHostImpl::drawLayers):
- * platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:
- (CCLayerTreeHostImpl):
-
-2012-06-12 Mike West <mkwst@chromium.org>
-
- Make document.documentURI readonly from JavaScript
- https://bugs.webkit.org/show_bug.cgi?id=65187
-
- Reviewed by Alexey Proskuryakov.
-
- The DOM4 working draft marks the documentURI attribute as read only
- (http://www.w3.org/TR/dom/#document). Firefox has shipped with this
- behavior since https://hg.mozilla.org/mozilla-central/rev/3bc751906409
- landed in October 2011, IE9 doesn't support the property, and
- Opera throws a NO_MODIFICATION_ALLOWED_ERR. This patch changes WebKit
- to silently fail (matching Firefox's behavior) by setting the property
- to readonly in the IDL.
-
- Document::setDocumentURI and the m_documentURI property are retained
- for compatibility with ObjC clients, and the readonly attribute is
- ifdeffed out for ObjC.
-
- This patch adds a single test to verify the behavior, and removes a
- variety of tests that depended on the writable behavior. In particular,
- potential security issues involving the document.baseURL property are
- avoided completely as long as this property can't be changed.
-
- Test: fast/dom/documenturi-readonly.html
-
- * dom/Document.cpp:
- (WebCore::Document::setDocumentURI):
- Adds a comment explaining that the fallback is necessary only to
- support ObjC, not for JS calls.
- * dom/Document.cpp:
- (WebCore::Document::updateBaseURL):
- Ditto.
- (Document):
- * dom/Document.idl:
- Add readonly to the attribute and drop null value when not in
- LANGUAGE_OBJECTIVE_C.
-
-2012-06-12 Silvia Pfeiffer <silviapf@chromium.org>
-
- Support !ENABLE(VIDEO) builds with horizontally layed out video controls.
- https://bugs.webkit.org/show_bug.cgi?id=88881
-
- Reviewed by Csaba Osztrogonác.
-
- No new tests as this is a regression from WK87835.
-
- * html/shadow/SliderThumbElement.cpp:
- (WebCore::hasVerticalAppearance):
- Ifdef out video related functionality, since usesVerticalVolumeSlider
- does not exist in that case.
-
-2012-06-12 Pavel Feldman <pfeldman@chromium.org>
-
- Web Inspector: show revisions of all modified files in local modifications view
- https://bugs.webkit.org/show_bug.cgi?id=88864
-
- Reviewed by Vsevolod Vlasov.
-
- This change allows all local modifications to be seen in a single view. View is now
- singleton, listening to all revisions being added. Revert captions were reworked
- (see the screenshot).
-
- * English.lproj/localizedStrings.js:
- * inspector/front-end/Resource.js:
- * inspector/front-end/RevisionHistoryView.js:
- (WebInspector.RevisionHistoryView.populateRevisions):
- (WebInspector.RevisionHistoryView):
- (WebInspector.RevisionHistoryView.showHistory):
- (WebInspector.RevisionHistoryView.reset):
- (WebInspector.RevisionHistoryView.prototype._createResourceItem.clearHistory):
- (WebInspector.RevisionHistoryView.prototype._createResourceItem):
- (WebInspector.RevisionHistoryView.prototype._revisionAdded.get if):
- (WebInspector.RevisionHistoryView.prototype._revisionAdded):
- (WebInspector.RevisionHistoryView.prototype._revealResource.get if):
- (WebInspector.RevisionHistoryView.prototype._revealResource):
- (WebInspector.RevisionHistoryView.prototype._reset):
- (WebInspector.RevisionHistoryTreeElement):
- (WebInspector.RevisionHistoryTreeElement.prototype.onattach):
- (WebInspector.RevisionHistoryTreeElement.prototype.oncollapse):
- * inspector/front-end/ScriptsPanel.js:
- (WebInspector.ScriptsPanel.prototype._reset):
- (WebInspector.ScriptsPanel.prototype._editorSelected):
- * inspector/front-end/revisionHistory.css:
- (.revision-history-link-row):
- (.revision-history-drawer li.revision-history-revision):
-
-2012-06-12 Pavel Feldman <pfeldman@chromium.org>
-
- Web Inspector: allow clearing revision history.
- https://bugs.webkit.org/show_bug.cgi?id=88847
-
- Reviewed by Vsevolod Vlasov.
-
- This change also renames "Revision history" to "Local modifications".
- I intend to list modifications to all files in that view in the subsequent change.
-
- * English.lproj/localizedStrings.js:
- * inspector/front-end/Resource.js:
- (WebInspector.Resource._clearResourceHistory):
- * inspector/front-end/RevisionHistoryView.js:
- (WebInspector.RevisionHistoryView.else.clearHistory):
- (WebInspector.RevisionHistoryView):
- (WebInspector.RevisionHistoryView.prototype._revisionAdded):
- (WebInspector.RevisionHistoryTreeElement):
- (WebInspector.RevisionHistoryTreeElement.prototype._createLine):
- (WebInspector.RevisionHistoryTreeElement.prototype.allowRevert):
- * inspector/front-end/ScriptsPanel.js:
- (WebInspector.ScriptsPanel.prototype.appendApplicableItems):
-
-2012-06-12 Pavel Feldman <pfeldman@chromium.org>
-
- Web Inspector: use jsdifflib for revision diff calculation.
- https://bugs.webkit.org/show_bug.cgi?id=88791
-
- Reviewed by Vsevolod Vlasov.
-
- Present diff calculation is incomplete, it does not properly handle the following case:
- [a, b, c, d, e, f, g, h] => [c, d, e, f, g, h, a, b]
- We should not be implementing diff by ourselves. I imported jsdifflib from
- https://github.com/cemerick/jsdifflib. It has BSD license that is compatible with WebKit.
-
- * WebCore.gypi:
- * WebCore.vcproj/WebCore.vcproj:
- * inspector/front-end/RevisionHistoryView.js:
- (WebInspector.RevisionHistoryTreeElement.prototype.onexpand.step2):
- (WebInspector.RevisionHistoryTreeElement.prototype.onexpand):
- (WebInspector.RevisionHistoryTreeElement.prototype._createLine.appendLineNumber):
- (WebInspector.RevisionHistoryTreeElement.prototype._createLine):
- * inspector/front-end/WebKit.qrc:
- * inspector/front-end/externs.js:
- (difflib.stringAsLines):
- (difflib.SequenceMatcher):
- (difflib.SequenceMatcher.prototype.get_opcodes):
- * inspector/front-end/inspector.html:
- * inspector/front-end/jsdifflib.js: Added.
- (difflib.defaultJunkFunction):
- (difflib.stripLinebreaks):
- (difflib.stringAsLines):
- (difflib.__reduce):
- (difflib.__ntuplecomp):
- (difflib.__calculate_ratio):
- (difflib.__dictget):
- (difflib.SequenceMatcher.this.set_seqs):
- (difflib.SequenceMatcher.this.set_seq1):
- (difflib.SequenceMatcher.this.set_seq2):
- (difflib.SequenceMatcher.this.__chain_b):
- (difflib.SequenceMatcher.this.find_longest_match):
- (difflib.SequenceMatcher.this.get_matching_blocks):
- (difflib.SequenceMatcher.this.get_opcodes):
- (difflib.SequenceMatcher.this.get_grouped_opcodes):
- (difflib.SequenceMatcher.this.quick_ratio):
- (difflib.SequenceMatcher.this.real_quick_ratio):
- * inspector/front-end/revisionHistory.css:
- (.revision-history-line-separator .webkit-line-number):
-
-2012-06-12 Pavel Feldman <pfeldman@chromium.org>
-
- Web Inspector: use jsdifflib for revision diff calculation.
- https://bugs.webkit.org/show_bug.cgi?id=88791
-
- Reviewed by Vsevolod Vlasov.
-
- Present diff calculation is incomplete, it does not properly handle the following case:
- [a, b, c, d, e, f, g, h] => [c, d, e, f, g, h, a, b]
- We should not be implementing diff by ourselves. I imported jsdifflib from
- https://github.com/cemerick/jsdifflib. It has BSD license that is compatible with WebKit.
-
- * WebCore.gypi:
- * WebCore.vcproj/WebCore.vcproj:
- * inspector/front-end/RevisionHistoryView.js:
- (WebInspector.RevisionHistoryTreeElement.prototype.onexpand.step2):
- (WebInspector.RevisionHistoryTreeElement.prototype.onexpand):
- (WebInspector.RevisionHistoryTreeElement.prototype._createLine.appendLineNumber):
- (WebInspector.RevisionHistoryTreeElement.prototype._createLine):
- * inspector/front-end/WebKit.qrc:
- * inspector/front-end/externs.js:
- (difflib.stringAsLines):
- (difflib.SequenceMatcher):
- (difflib.SequenceMatcher.prototype.get_opcodes):
- * inspector/front-end/inspector.html:
- * inspector/front-end/jsdifflib.js: Added.
- (difflib.defaultJunkFunction):
- (difflib.stripLinebreaks):
- (difflib.stringAsLines):
- (difflib.__reduce):
- (difflib.__ntuplecomp):
- (difflib.__calculate_ratio):
- (difflib.__dictget):
- (difflib.SequenceMatcher.this.set_seqs):
- (difflib.SequenceMatcher.this.set_seq1):
- (difflib.SequenceMatcher.this.set_seq2):
- (difflib.SequenceMatcher.this.__chain_b):
- (difflib.SequenceMatcher.this.find_longest_match):
- (difflib.SequenceMatcher.this.get_matching_blocks):
- (difflib.SequenceMatcher.this.get_opcodes):
- (difflib.SequenceMatcher.this.get_grouped_opcodes):
- (difflib.SequenceMatcher.this.quick_ratio):
- (difflib.SequenceMatcher.this.real_quick_ratio):
- * inspector/front-end/revisionHistory.css:
- (.revision-history-line-separator .webkit-line-number):
-
-2012-06-12 Christophe Dumez <christophe.dumez@intel.com>
-
- [GStreamer] http/tests/media/video-buffered-range-contains-currentTime.html is failing
- https://bugs.webkit.org/show_bug.cgi?id=87575
-
- Reviewed by Philippe Normand.
-
- When EOS is reached in forward playback, the position does not necessarily
- match the duration. This confuses HTMLMediaElement and causes the "ended"
- event not to be fired. To avoid this, we synchronize position and duration
- values in this case.
-
- Test: http/tests/media/video-buffered-range-contains-currentTime.html
-
- * platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
-
-2012-06-12 Kinuko Yasuda <kinuko@chromium.org>
-
- Refactor InputType::receiveDroppedFiles to take DragData
- https://bugs.webkit.org/show_bug.cgi?id=88860
-
- Reviewed by Kent Tamura.
-
- So that we can centralize the file paths related code into FileInputType
- and makes it easier to extract more data from DragData for
- <input type=file> (like bug 88293 for directory drag-and-drop).
-
- No new tests as this has no behavioral changes.
-
- * html/FileInputType.cpp:
- (WebCore::FileInputType::receiveDroppedFiles):
- * html/FileInputType.h:
- * html/HTMLInputElement.cpp:
- (WebCore::HTMLInputElement::receiveDroppedFiles):
- * html/HTMLInputElement.h:
- * html/InputType.cpp:
- (WebCore::InputType::receiveDroppedFiles):
- * html/InputType.h:
- * page/DragController.cpp:
- (WebCore::DragController::concludeEditDrag):
-
-2012-06-12 Thiago Marcos P. Santos <thiago.santos@intel.com>
-
- Generate -webkit-box-decoration-break property only when the feature is enabled
- https://bugs.webkit.org/show_bug.cgi?id=88861
-
- Reviewed by Alexis Menard.
-
- Otherwise it will hit an assertion if the property is present on the
- style but the feature disabled. Also fixes a compilation warning when
- the feature is disabled.
-
- * css/CSSPropertyNames.in:
- * css/StyleResolver.cpp:
- (WebCore::StyleResolver::collectMatchingRulesForList):
-
-2012-06-12 Darin Adler <darin@apple.com>
-
- Tweaked the Mac export file a bit more, adding more-correct iOS cases.
-
- Reviewed by David Kilzer.
-
- * WebCore.exp.in: Rearrangement.
-
-2012-06-11 Jocelyn Turcotte <jocelyn.turcotte@nokia.com>
-
- Using extrernal ICU library on case unsensitive drives will not work
- https://bugs.webkit.org/show_bug.cgi?id=70913
-
- Reviewed by Csaba Osztrogonác.
-
- * platform/graphics/surfaces/GraphicsSurface.h:
-
-2012-06-11 Dana Jansens <danakj@chromium.org>
-
- [chromium] Use TextureDrawQuad for video layer output when it produces a single GL texture
- https://bugs.webkit.org/show_bug.cgi?id=88814
-
- Reviewed by Adrienne Walker.
-
- When a CCVideLayerImpl produces quads for a frame that is contained
- in a single GL texture, then use the TextureDrawQuad instead of the
- VideoDrawQuad. Moves the computation for the RGBA(software) and
- NativeTexture (hardware) cases from LayerRendererChromium into
- CCVideoLayerImpl, so it can embed these values in the TextureDrawQuad.
-
- No new tests, behaviour should be the same.
-
- * platform/graphics/chromium/LayerRendererChromium.cpp:
- (WebCore::LayerRendererChromium::drawStreamTexture):
- (WebCore::LayerRendererChromium::drawVideoQuad):
- * platform/graphics/chromium/LayerRendererChromium.h:
- (LayerRendererChromium):
- * platform/graphics/chromium/cc/CCVideoLayerImpl.cpp:
- (WebCore::CCVideoLayerImpl::appendQuads):
-
-2012-06-12 Silvia Pfeiffer <silviapf@chromium.org>
-
- Change the volume slider to horizontal rendering for Chrome video controls.
- https://bugs.webkit.org/show_bug.cgi?id=87835
-
- Reviewed by Eric Carlson.
-
- No new tests - final patch in the Chrome controls update series will contain rebaselined tests.
-
- The Chrome video controls are receiving a visual update. The volume slider is moved into
- the controls with horizontal rendering, the volume slider container is removed. The visual
- update itself is in a separate patch.
-
- * css/mediaControlsChromium.css:
- (audio::-webkit-media-controls-mute-button, video::-webkit-media-controls-mute-button):
- Removed relative positioning to render all controls elements equally in DOM order.
- (audio::-webkit-media-controls-play-button, video::-webkit-media-controls-play-button):
- Removed absolute positioning to render all controls elements equally in DOM order.
- (audio::-webkit-media-controls-timeline-container, video::-webkit-media-controls-timeline-container):
- Removed absolute positioning to render all controls elements equally in DOM order.
- (audio::-webkit-media-controls-volume-slider-container, video::-webkit-media-controls-volume-slider-container):
- Removed volume slider container - it's not necessary any more.
- (audio::-webkit-media-controls-current-time-display, video::-webkit-media-controls-current-time-display):
- Remove flexbox and introduce inline display to always display this field.
- (audio::-webkit-media-controls-volume-slider, video::-webkit-media-controls-volume-slider):
- Removed absolute positioning to render all controls elements equally in DOM order.
- * html/shadow/MediaControlRootElementChromium.cpp:
- (WebCore::MediaControlRootElementChromium::MediaControlRootElementChromium):
- Removed volume slider container - it's not necessary any more.
- (WebCore::MediaControlRootElementChromium::create):
- Appended the volume slider and the mute button directly to the panel, removed volume slider container.
- (WebCore::MediaControlRootElementChromium::setMediaController):
- Removed volume slider container.
- (WebCore::MediaControlRootElementChromium::reportedError):
- Removed volume slider container.
- (WebCore::MediaControlRootElementChromium::showVolumeSlider):
- Removed volume slider container.
- * html/shadow/MediaControlRootElementChromium.h:
- (WebCore):
- (MediaControlRootElementChromium):
- Removed volume slider container.
- * html/shadow/SliderThumbElement.cpp:
- (WebCore::hasVerticalAppearance):
- Allow use of horizontal media volume slider.
- (WebCore::RenderSliderThumb::layout):
- Reuse hasVerticalAppearance function.
- * rendering/RenderMediaControlsChromium.cpp:
- (WebCore::RenderMediaControlsChromium::paintMediaVolumeSlider):
- Change line drawing from vertical to horizontal.
- * rendering/RenderTheme.h:
- (WebCore::RenderTheme::usesVerticalVolumeSlider):
- Add usesVerticalVolumeSlider function to allow horizontal volume sliders.
- * rendering/RenderThemeChromiumMac.h:
- (WebCore::RenderThemeChromiumMac::usesVerticalVolumeSlider):
- Add usesVerticalVolumeSlider function to allow horizontal volume sliders.
- Add usesVerticalVolumeSlider function to allow horizontal volume sliders.
- * rendering/RenderThemeChromiumSkia.h:
- (WebCore::RenderThemeChromiumSkia::usesVerticalVolumeSlider):
- Add usesVerticalVolumeSlider function to allow horizontal volume sliders.
-
-2012-06-12 Andrei Bucur <abucur@adobe.com>
-
- [CSSRegions]NamedFlow::overset should return true when there's no region chain attached
- https://bugs.webkit.org/show_bug.cgi?id=88515
-
- The CSS Regions specifies that the "overset" attribute needs to return true if the content overflows, there's no region attached to the flow
- or if the NamedFlow is in the NULL state:
- http://www.w3.org/TR/css3-regions/#dom-named-flow-overset
-
- This patch updates WebKit's behavior in the last two situations to match the one in the spec.
-
- Reviewed by Andreas Kling.
-
- Test: fast/regions/webkit-named-flow-overset.html was updated
-
- * rendering/RenderFlowThread.cpp:
- (WebCore::RenderFlowThread::RenderFlowThread):
- (WebCore::RenderFlowThread::computeOverflowStateForRegions): If the last valid region is null, the flow has not region chain attached or it's in the NULL state.
-
-2012-06-12 Rahul Tiwari <rahultiwari.cse.iitr@gmail.com>
-
- Web Inspector: Provide context menu for deleting recorded profile on Profiles Panel
- https://bugs.webkit.org/show_bug.cgi?id=88286
-
- Added the context menu to delete the selected profile.
-
- Reviewed by Pavel Feldman.
-
- No new tests required as UI related change
-
- * English.lproj/localizedStrings.js: Removed property svn:mime-type.
- * inspector/front-end/ProfilesPanel.js:
- (WebInspector.ProfileSidebarTreeElement.prototype.handleContextMenuEvent):
-
-2012-06-12 Pavel Feldman <pfeldman@chromium.org>
-
- Not reviewed: removed svn:mime-type property from English.lproj/localizedStrings.js
-
- * English.lproj/localizedStrings.js
-
-2012-06-12 Dan Bernstein <mitz@apple.com>
-
- Tried to fix the notification-enabled build after r120044.
-
- * notifications/NotificationController.cpp:
- (WebCore::NotificationController::NotificationController):
- (WebCore::NotificationController::create):
- (WebCore::provideNotification):
- * notifications/NotificationController.h:
- (NotificationController):
-
-2012-06-12 Huang Dongsung <luxtella@company100.net>
-
- [Qt][Texmap] Falling leaves demo missing clipping.
- https://bugs.webkit.org/show_bug.cgi?id=88704
-
- The bug originated from begining native painting mode of QPainter after enabling
- scissor test, because begining native painting mode disables scissor test.
-
- Covered by existing compositing tests.
-
- Reviewed by Noam Rosenthal.
-
- * platform/graphics/texmap/TextureMapperGL.cpp:
- (WebCore::TextureMapperGL::beginPainting):
-
-2012-06-12 Csaba Osztrogonác <ossy@webkit.org>
-
- [Qt][Win] Buildfix related to fromWinHBITMAP
- https://bugs.webkit.org/show_bug.cgi?id=88863
-
- Reviewed by Jocelyn Turcotte.
-
- * platform/graphics/qt/GraphicsContextQt.cpp: Add qt_pixmapFromWinHBITMAP and HBitmapFormat enum.
- (WebCore):
- (WebCore::GraphicsContext::releaseWindowsContext):
- * platform/graphics/qt/ImageQt.cpp:
- (WebCore): Move qt_pixmapFromWinHBITMAP to outside of WebCore namespace. (Fix after r119924.)
-
-2012-06-12 Takashi Sakamoto <tasak@google.com>
-
- [Shadow DOM] <style> inside Shadow subtree should be scoped inside the subtree.
- https://bugs.webkit.org/show_bug.cgi?id=87805
-
- Modified HTMLStyleElement to be treated as a scoped style independent
- of its "scoped" attribute's value if HTMLStyleElement is in shadow
- subtree. HTMLStyleElement has the following four cases talking about
- "scoped" attribute and whether is in shadow subtree or not:
- 1, HTMLStyleElement is "scoped" and is in document tree,
- 2, HTMLStyleElement is "scoped" and is in shadow subtree,
- 3, HTMLStyleElement is not "scoped" and is in document tree, and
- 4, HTMLStyleElement is not "scoped" and is in shadow subtree.
- The case 1 and 2 are not changed. This patch affected the case 4.
- At the case 4, the HTMLStyleElement's scoping node is the shadow root.
- This change is the first step for fixing style scope bug,
- i.e. HTMLStyleElements in shadow subtree are applied to any element
- in document tree.
-
- Reviewed by Dimitri Glazkov.
-
- Test: fast/css/style-scoped/style-scoped-change-scoped-in-shadow.html
-
- * css/StyleResolver.cpp:
- (WebCore::StyleResolver::determineScope):
- Modified to return a shadow root if a targeted stylesheet owner node is
- not scoped but in some shadow DOM subtree.
- * html/HTMLStyleElement.cpp:
- (WebCore::HTMLStyleElement::HTMLStyleElement):
- (WebCore::HTMLStyleElement::parseAttribute):
- Modified to use the below scopedAttributeChanged when a changed
- attribute's name is "scoped".
- (WebCore::HTMLStyleElement::scopedAttributeChanged):
- Newly added. According to new scoped value and isInShadowTree,
- add or remove style rules to/from scopedAuthorRules via
- registerWithScopingNode or unregisterWithScopingNode.
- (WebCore::HTMLStyleElement::registerWithScopingNode):
- Added one boolean argument to determine whether HTMLStyleElement is
- scoped or not. The reason why not using scoped() is the comment:
- "We cannot rely on the scoped element already being present when this
- method is invoked. Therefore we cannot rely on scoped()"
- (WebCore::HTMLStyleElement::unregisterWithScopingNode):
- Changed the code for updating m_isRegisteredWithScopingNode. Now
- set m_scopedStyleRegistrationState to be NotRegistered.
- (WebCore::HTMLStyleElement::insertedInto):
- Modified to invoke registerWithScopingNode when an element is not
- scoped but in some shadow subtree.
- (WebCore::HTMLStyleElement::removedFrom):
- Modified to invoke unregisterWithScopingNode when an element is not
- scoped but in some shadow subtree.
- * html/HTMLStyleElement.h:
- (HTMLStyleElement):
- Modified the type of m_isRegisteredWithScopingNode from bool to
- enum and renamed to m_scopedStyleRegistrationState. Now the member
- variable keeps what HTMLStyleElement's scoping node is, i.e.
- none (this means, not in shadow subtree and not scoped), shadow root or
- parent node.
- Added one new method scopedAttributeChanged's declaration and
- modified the declaration of registerWithScopingNode.
-
-2012-06-12 Amy Ousterhout <aousterh@chromium.org>
-
- Removing unused parameter Page
- https://bugs.webkit.org/show_bug.cgi?id=88848
-
- Reviewed by Kentaro Hara.
-
- Removed the unused parameter Page* supplied to the create function
- and constructor in DeviceOrientationController.
-
- The parameter Page* was previously stored in an instance variable
- m_page, but this was removed (see https://bugs.webkit.org/show_bug.cgi?id=88812).
-
- No new tests because the removed parameter was unused and untested.
-
- * dom/DeviceOrientationController.cpp:
- (WebCore::DeviceOrientationController::DeviceOrientationController):
- (WebCore::DeviceOrientationController::create):
- (WebCore::provideDeviceOrientationTo):
- * dom/DeviceOrientationController.h:
- (DeviceOrientationController):
-
-2012-06-12 Sheriff Bot <webkit.review.bot@gmail.com>
-
- Unreviewed, rolling out r120051.
- http://trac.webkit.org/changeset/120051
- https://bugs.webkit.org/show_bug.cgi?id=88852
-
- some tests are crashing (Requested by morrita on #webkit).
-
- * CMakeLists.txt:
- * GNUmakefile.list.am:
- * Target.pri:
- * WebCore.gypi:
- * WebCore.vcproj/WebCore.vcproj:
- * WebCore.xcodeproj/project.pbxproj:
- * bindings/generic/ContextEnabledFeatures.cpp: Renamed from Source/WebKit/chromium/src/ContextFeaturesClientImpl.cpp.
- (WebCore):
- (WebCore::ContextEnabledFeatures::shadowDOMEnabled):
- (WebCore::ContextEnabledFeatures::styleScopedEnabled):
- (WebCore::ContextEnabledFeatures::pagePopupEnabled):
- * bindings/generic/ContextEnabledFeatures.h: Renamed from Source/WebKit/chromium/src/ContextFeaturesClientImpl.h.
- (WebCore):
- (ContextEnabledFeatures):
- * bindings/scripts/CodeGeneratorV8.pm:
- (GenerateImplementation):
- * css/StyleResolver.cpp:
- (WebCore::StyleResolver::determineScope):
- * dom/ContextFeatures.cpp: Removed.
- * dom/ContextFeatures.h: Removed.
- * dom/DOMAllInOne.cpp:
- * dom/DOMImplementation.cpp:
- (WebCore::DOMImplementation::createDocument):
- (WebCore::DOMImplementation::createHTMLDocument):
- * dom/Document.cpp:
- (WebCore::Document::Document):
- * dom/Document.h:
- (WebCore):
- (Document):
- * dom/Position.cpp:
- (WebCore::Position::Position):
- (WebCore::Position::findParent):
- * dom/TreeScope.cpp:
- (WebCore::TreeScope::getSelection):
- * dom/make_names.pl:
- (printConstructorInterior):
- (printFactoryCppFile):
- (printWrapperFunctions):
- (printWrapperFactoryCppFile):
- * editing/markup.cpp:
- (WebCore::createFragmentFromMarkupWithContext):
- * html/HTMLStyleElement.cpp:
- (WebCore::HTMLStyleElement::registerWithScopingNode):
- (WebCore::HTMLStyleElement::unregisterWithScopingNode):
- * html/shadow/HTMLContentElement.cpp:
- (WebCore::contentTagName):
- * inspector/DOMPatchSupport.cpp:
- (WebCore::DOMPatchSupport::patchDocument):
- * loader/FrameLoaderClient.h:
- (WebCore::FrameLoaderClient::allowShadowDOM):
- (WebCore::FrameLoaderClient::allowStyleScoped):
- (FrameLoaderClient):
- (WebCore::FrameLoaderClient::allowPagePopup):
- * platform/RefCountedSupplement.h: Removed.
- * platform/Supplementable.h:
- * xml/XMLHttpRequest.cpp:
- (WebCore::XMLHttpRequest::responseXML):
-
-2012-06-11 Kaustubh Atrawalkar <kaustubh@motorola.com>
-
- [DRT] LTC:: counterValueForElementById() could be moved to Internals.
- https://bugs.webkit.org/show_bug.cgi?id=84406
-
- Reviewed by Hajime Morita.
-
- Move the counterValueForElementById from LayoutTestCotroller to Internals and
- remove the old platform specific implementations as it exclusively tests WebCore functionality.
-
- Covered by existing test cases.
-
- * testing/Internals.cpp:
- (WebCore::Internals::counterValue):
- (WebCore):
- * testing/Internals.h:
- (Internals):
- * testing/Internals.idl:
-
-2012-06-11 Hans Wennborg <hans@chromium.org>
-
- Speech JavaScript API: Make SpeechRecognitionError an Event
- https://bugs.webkit.org/show_bug.cgi?id=88784
-
- Reviewed by Adam Barth.
-
- Make SpeechRecognitionError an Event. The spec was updated to make it
- an event in its own right, rather than an attribute of
- SpeechRecognitionEvent.
-
- Test: fast/speech/scripted/speechrecognition-errors.html
-
- * Modules/speech/SpeechRecognition.cpp:
- (WebCore::SpeechRecognition::didReceiveError):
- * Modules/speech/SpeechRecognitionError.cpp:
- (WebCore::SpeechRecognitionError::SpeechRecognitionError):
- (WebCore::SpeechRecognitionError::interfaceName):
- (WebCore):
- * Modules/speech/SpeechRecognitionError.h:
- (WebCore::SpeechRecognitionError::create):
- (SpeechRecognitionError):
- * Modules/speech/SpeechRecognitionError.idl:
- * Modules/speech/SpeechRecognitionEvent.cpp:
- (WebCore::SpeechRecognitionEvent::SpeechRecognitionEvent):
- * Modules/speech/SpeechRecognitionEvent.h:
- (SpeechRecognitionEventInit):
- (SpeechRecognitionEvent):
- * Modules/speech/SpeechRecognitionEvent.idl:
- * dom/EventNames.in:
-
-2012-06-12 MORITA Hajime <morrita@google.com>
-
- REGRESSION(r118098): <content> element does not render distributed children when cloned from another document
- https://bugs.webkit.org/show_bug.cgi?id=88148
-
- Reviewed by Dimitri Glazkov.
-
- The shadow DOM availability was decided through FrameLoaderClient.
- But there are documents which don't have any associated frames, in
- which any shadow DOM related elements cannot be constructed. That
- resulsted the regression.
-
- This change introduces a Page-based client called
- ContextFeaturesClient which takes the role from FrameLoaderClient
- to decide the feature availability, and ContextFeatures which is a
- proxy of ContextFeaturesClient. ContextEnabledFeatures is is
- replaced with ContextFeatures.
-
- Each ContextFeatures object is owned by a Page, and is attached to
- each Document in the page even if the page itself has no referenct
- to Frames or Pages. With ContextFeatures, each Document can decide
- the feature availability even if it cannot reach Page or Frame.
-
- On RefCountedSupplement: Document instance can live longer than a
- Page where it is shwon. This means that ContextFeatures instance
- needs to survive after owner Page destruction because it's
- referenced from possibly surviving Documents. RefCountedSupplement
- is introduced to cover this scenario: It allows supplement classes
- to live after Page's destruction.
-
- RefCountedSupplement::hostDestroyed() is notified when the hosting
- page is gone. ContextFeatures clears its reference to the client
- using this notification.
-
- Test: fast/dom/shadow/elements-in-frameless-document.html
-
- * CMakeLists.txt:
- * GNUmakefile.list.am:
- * Target.pri:
- * WebCore.gypi:
- * WebCore.vcproj/WebCore.vcproj:
- * WebCore.xcodeproj/project.pbxproj:
- * bindings/scripts/CodeGeneratorV8.pm:
- (GenerateImplementation):
- * css/StyleResolver.cpp:
- (WebCore::StyleResolver::determineScope):
- * dom/ContextFeatures.cpp: Added.
- (WebCore):
- (WebCore::ContextFeaturesClient::empty):
- (WebCore::ContextFeatures::supplementName):
- (WebCore::ContextFeatures::defaultSwitch):
- (WebCore::ContextFeatures::shadowDOMEnabled):
- (WebCore::ContextFeatures::styleScopedEnabled):
- (WebCore::ContextFeatures::pagePopupEnabled):
- (WebCore::provideContextFeaturesTo):
- (WebCore::provideContextFeaturesToDocumentFrom):
- * dom/ContextFeatures.h: Added.
- (WebCore):
- (ContextFeatures):
- (WebCore::ContextFeatures::ContextFeatures):
- (WebCore::ContextFeatures::hostDestroyed):
- (ContextFeaturesClient):
- (WebCore::ContextFeaturesClient::~ContextFeaturesClient):
- (WebCore::ContextFeaturesClient::isEnabled):
- (WebCore::ContextFeatures::create):
- (WebCore::ContextFeatures::isEnabled):
- * dom/DOMAllInOne.cpp:
- * dom/DOMImplementation.cpp:
- (WebCore::DOMImplementation::createDocument):
- (WebCore::DOMImplementation::createHTMLDocument):
- * dom/Document.h:
- (WebCore::Document::contextFeatures):
- * dom/Document.cpp:
- (WebCore::Document::Document):
- (WebCore::Document::setContextFeatures):
- * dom/Position.cpp:
- (WebCore::Position::Position):
- (WebCore::Position::findParent):
- * dom/TreeScope.cpp:
- (WebCore::TreeScope::getSelection):
- * dom/make_names.pl:
- (printConstructorInterior):
- (printFactoryCppFile):
- (printWrapperFunctions):
- (printWrapperFactoryCppFile):
- * editing/markup.cpp:
- (WebCore::createFragmentFromMarkupWithContext):
- * html/HTMLStyleElement.cpp:
- (WebCore::HTMLStyleElement::registerWithScopingNode):
- (WebCore::HTMLStyleElement::unregisterWithScopingNode):
- * html/shadow/HTMLContentElement.cpp:
- (WebCore::contentTagName):
- * inspector/DOMPatchSupport.cpp:
- (WebCore::DOMPatchSupport::patchDocument):
- * loader/FrameLoaderClient.h:
- * platform/RefCountedSupplement.h: Copied from Source/WebCore/platform/Supplementable.h.
- (WebCore):
- (RefCountedSupplement):
- (WebCore::RefCountedSupplement::hostDestroyed):
- (Wrapper):
- (WebCore::RefCountedSupplement::Wrapper::Wrapper):
- (WebCore::RefCountedSupplement::Wrapper::~Wrapper):
- (WebCore::RefCountedSupplement::Wrapper::wrapped):
- (WebCore::RefCountedSupplement::provideTo):
- (WebCore::RefCountedSupplement::from):
- * platform/Supplementable.h:
- (WebCore::Supplement::isRefCountedWrapper):
- * xml/XMLHttpRequest.cpp:
- (WebCore::XMLHttpRequest::responseXML):
-
-2012-06-12 Kent Tamura <tkent@chromium.org>
-
- Remove unnecessary functions: setName() and formControlName()
- https://bugs.webkit.org/show_bug.cgi?id=88392
-
- Reviewed by Kentaro Hara.
-
- 'name' IDL attributes of form-related elements should be [Reflected],
- and we don't need to have setName(). We used formControlName() for
- name() implementation, and formControlName() is not needed because it
- just converts a null attribute to an empty string. Our binding code does it.
-
- We don't remove FormAssociatedElement::name() because many C++ code use it.
-
- FormAssociatedElement::name() is virtual, and HTMLInputElement overrides
- it so that it returns a cache of the name attribtue value because
- CheckedRadioButtons class needs to know an old name attribute value when
- the name attribtue is changed.
-
- References:
- http://www.whatwg.org/specs/web-apps/current-work/multipage/the-iframe-element.html#dom-object-name
- http://www.whatwg.org/specs/web-apps/current-work/multipage/forms.html#dom-form-name
- http://www.whatwg.org/specs/web-apps/current-work/multipage/association-of-controls-and-forms.html#dom-fe-name
-
- Test: fast/forms/name-attribute.html
-
- * dom/Element.h: Remove formControlName().
- * html/FormAssociatedElement.cpp:
- (WebCore::FormAssociatedElement::name):
- Copied from formControlName() implementation of HTMLFormControlElement.
- * html/FormAssociatedElement.h:
- (FormAssociatedElement): Make name() virtual, remove formControlName().
- * html/FormController.cpp:
- (WebCore::FormController::formElementsState):
- Use name() instead of formControlName().
- * html/HTMLFormControlElement.cpp:
- Remove formControlName() and setName().
- * html/HTMLFormControlElement.h: ditto.
- * html/HTMLInputElement.cpp:
- (WebCore::HTMLInputElement::name): Renamed from formControlName().
- * html/HTMLInputElement.h:
- (HTMLInputElement): Renamed formControlName() to name(), and make it public.
- * html/HTMLKeygenElement.idl: Make 'name' [Reflected].
- * html/HTMLObjectElement.cpp: Remove formControlName().
- * html/HTMLObjectElement.h: ditto.
- * html/HTMLSelectElement.cpp:
- (WebCore::HTMLSelectElement::appendFormData):
- Use name() instead of formControlName().
- * html/HTMLSelectElement.idl: Make 'name' [Reflected].
- * html/HTMLTextAreaElement.idl: Make 'name' [Reflected].
-
-2012-06-11 Nico Weber <thakis@chromium.org>
-
- Remove unused member variables found by clang's -Wunused-private-field
- https://bugs.webkit.org/show_bug.cgi?id=88812
-
- Reviewed by Anders Carlsson.
-
- Change a few |class|s that were used only to pin down the size of
- existing classes to |struct|, so that clang doesn't warn about these
- memvars.
-
- No intended behavior change.
-
- * Modules/geolocation/GeolocationController.cpp:
- (WebCore::GeolocationController::GeolocationController):
- * Modules/geolocation/GeolocationController.h:
- (GeolocationController):
- * Modules/webaudio/AudioContext.h:
- (AudioContext):
- * Modules/webaudio/AudioParamTimeline.h:
- (AudioParamTimeline):
- * accessibility/AccessibilityScrollbar.h:
- (AccessibilityScrollbar):
- * bindings/v8/ScriptScope.cpp:
- (WebCore::ScriptScope::ScriptScope):
- * bindings/v8/ScriptScope.h:
- (ScriptScope):
- * css/CSSValue.cpp:
- * css/StylePropertySet.cpp:
- * dom/DeviceOrientationController.cpp:
- (WebCore::DeviceOrientationController::DeviceOrientationController):
- * dom/DeviceOrientationController.h:
- (DeviceOrientationController):
- * editing/ReplaceSelectionCommand.cpp:
- (ReplacementFragment):
- (WebCore::ReplacementFragment::ReplacementFragment):
- * editing/TextIterator.cpp:
- (WebCore::SimplifiedBackwardsTextIterator::SimplifiedBackwardsTextIterator):
- * editing/TextIterator.h:
- (SimplifiedBackwardsTextIterator):
- (BackwardsCharacterIterator):
- * html/HTMLFormCollection.cpp:
- (WebCore::HTMLFormCollection::HTMLFormCollection):
- * html/HTMLFormCollection.h:
- (HTMLFormCollection):
- * html/shadow/MediaControlElements.cpp:
- (WebCore::MediaControlFullscreenButtonElement::MediaControlFullscreenButtonElement):
- * html/shadow/MediaControlElements.h:
- (MediaControlFullscreenButtonElement):
- * html/shadow/MediaControlRootElementChromium.cpp:
- (WebCore::MediaControlRootElementChromium::MediaControlRootElementChromium):
- * html/shadow/MediaControlRootElementChromium.h:
- (MediaControlRootElementChromium):
- * html/track/LoadableTextTrack.cpp:
- (WebCore::LoadableTextTrack::LoadableTextTrack):
- * html/track/LoadableTextTrack.h:
- (LoadableTextTrack):
- * inspector/CodeGeneratorInspector.py:
- (Generator.go):
- * inspector/InspectorCSSAgent.cpp:
- (WebCore::InspectorCSSAgent::InspectorCSSAgent):
- * inspector/InspectorCSSAgent.h:
- (InspectorCSSAgent):
- * inspector/InspectorDOMDebuggerAgent.cpp:
- (WebCore::InspectorDOMDebuggerAgent::InspectorDOMDebuggerAgent):
- * inspector/InspectorDOMDebuggerAgent.h:
- (InspectorDOMDebuggerAgent):
- * inspector/InspectorMemoryAgent.cpp:
- (WebCore::InspectorMemoryAgent::InspectorMemoryAgent):
- * inspector/InspectorMemoryAgent.h:
- (InspectorMemoryAgent):
- * notifications/NotificationController.cpp:
- (WebCore::NotificationController::NotificationController):
- * notifications/NotificationController.h:
- (NotificationController):
- * page/animation/CompositeAnimation.h:
- (WebCore::CompositeAnimation::CompositeAnimation):
- (CompositeAnimation):
- * platform/Length.cpp:
- * platform/audio/ReverbConvolver.cpp:
- (WebCore::ReverbConvolver::ReverbConvolver):
- * platform/audio/ReverbConvolver.h:
- (ReverbConvolver):
- * platform/audio/ReverbConvolverStage.cpp:
- (WebCore::ReverbConvolverStage::ReverbConvolverStage):
- * platform/audio/ReverbConvolverStage.h:
- (ReverbConvolverStage):
- * platform/graphics/TextRun.cpp:
- (ExpectedTextRunSize):
- * platform/graphics/chromium/cc/CCThreadProxy.h:
- (CCThreadProxy):
- * platform/graphics/filters/FECustomFilter.cpp:
- (WebCore::FECustomFilter::FECustomFilter):
- * platform/graphics/filters/FECustomFilter.h:
- (FECustomFilter):
- * platform/image-decoders/jpeg/JPEGImageDecoder.cpp:
- (JPEGImageReader):
- * platform/leveldb/LevelDBTransaction.cpp:
- (WebCore::LevelDBTransaction::TreeIterator::next):
- * platform/text/TextCodecICU.cpp:
- (WebCore::TextCodecICU::TextCodecICU):
- * platform/text/TextCodecICU.h:
- (TextCodecICU):
- * rendering/InlineBox.cpp:
- * rendering/InlineFlowBox.cpp:
- * rendering/RenderText.cpp:
- * rendering/style/KeyframeList.h:
- (WebCore::KeyframeList::KeyframeList):
- (KeyframeList):
- * rendering/svg/RenderSVGTextPath.cpp:
- (WebCore::RenderSVGTextPath::RenderSVGTextPath):
- * rendering/svg/RenderSVGTextPath.h:
- * rendering/svg/SVGInlineTextBox.cpp:
- * svg/SVGPathByteStreamSource.cpp:
- * svg/SVGPathByteStreamSource.h:
- * svg/SVGPathTraversalStateBuilder.cpp:
- (WebCore::SVGPathTraversalStateBuilder::SVGPathTraversalStateBuilder):
- * svg/SVGPathTraversalStateBuilder.h:
- (SVGPathTraversalStateBuilder):
- * xml/XSLStyleSheet.h:
-
-2012-06-11 Kinuko Yasuda <kinuko@chromium.org>
-
- XHR returns size==0 Blob
- https://bugs.webkit.org/show_bug.cgi?id=88750
-
- Reviewed by Alexey Proskuryakov.
-
- Response Blob's .size field must have the correct response size.
-
- Test: http/tests/xmlhttprequest/response-blob-size.html
-
- * xml/XMLHttpRequest.cpp:
- (WebCore::XMLHttpRequest::responseBlob):
-
-2012-06-11 Silvia Pfeiffer <silviapf@chromium.org>
-
- Introduce an Enclosure Element for Chromium video controls.
- https://bugs.webkit.org/show_bug.cgi?id=87683
-
- Reviewed by Eric Carlson.
-
- Updated tests.
-
- The Chrome video controls are receiving a visual update. A new enclosure div is required
- to provide for a offset space from the video's boundaries. The visual update itself is in
- a separate patch.
-
- * css/mediaControlsChromium.css:
- (video::-webkit-media-controls-enclosure):
- Introduce CSS for enclosure div so it doesn't show yet.
- * html/shadow/MediaControlRootElementChromium.cpp:
- (WebCore::MediaControlChromiumEnclosureElement::MediaControlChromiumEnclosureElement):
- Definition of the new enclosure element.
- (WebCore::MediaControlChromiumEnclosureElement::create):
- Definition of a create operator for the new enclosure element.
- (WebCore::MediaControlChromiumEnclosureElement::shadowPseudoId):
- Definition of the shadowPseudoId of -webkit-media-controls-enclosure for the enclosure div.
- (WebCore::MediaControlRootElementChromium::MediaControlRootElementChromium):
- Initialize member element for enclosure div.
- (WebCore::MediaControlRootElementChromium::create):
- Instantiate enclosure div and add into DOM between controls and panel elements.
- (WebCore::MediaControlRootElementChromium::setMediaController):
- Set media controller for enclosure div.
- (WebCore::MediaControlRootElementChromium::createTextTrackDisplay):
- Insert text track display container to enclosure rather than panel.
- * html/shadow/MediaControlRootElementChromium.h:
- (WebCore):
- (MediaControlChromiumEnclosureElement):
- (WebCore::MediaControlChromiumEnclosureElement::setMediaController):
- (WebCore::MediaControlChromiumEnclosureElement::mediaController):
- (WebCore::MediaControlChromiumEnclosureElement::isMediaControlElement):
- Add declaration of the new enclosure element and its member functions.
- (MediaControlRootElementChromium):
- Add member variable to controls root element to hold the enclosure element.
-
-2012-06-11 Elliott Sprehn <esprehn@gmail.com>
-
- WebKit doesn't allow replacing the document element with a DocumentFragment containing one element
- https://bugs.webkit.org/show_bug.cgi?id=88681
-
- Reviewed by Ojan Vafai.
-
- Fix bug where replacing an immediate child of a Document with a DocumentFragment
- would throw a HIERARCHY_REQUEST_ERR instead of replacing the node as required by DOM4.
- http://www.w3.org/TR/domcore/#mutation-algorithms
-
- * dom/Document.cpp:
- (WebCore::Document::canReplaceChild):
- When the newChild was a DocumentFragment we incorrectly
- iterated over the document's children twice instead of the
- fragment when counting the total number of elements and
- doctypes to enfoce that there's only one of each.
-
-2012-06-11 Mary Wu <mary.wu@torchmobile.com.cn>
-
- [BlackBerry] Add handling of notifyDataReceived in NetworkJob even there's no data inside
- https://bugs.webkit.org/show_bug.cgi?id=88773
-
- Reviewed by Rob Buis.
-
- Handling notifyDataReceived event even if there is no data inside.
- This event was critical because it gives downloadFilterStream a chance
- to follow up NetworkStream close event, and it also make pluginView in
- FrameLoaderBlackBerry return normal logic.
-
- RIM PR# 164563
-
- Reviewed internally by Leo Yang.
-
- * platform/network/blackberry/NetworkJob.cpp:
- (WebCore::NetworkJob::handleNotifyDataReceived):
-
-2012-06-11 Mary Wu <mary.wu@torchmobile.com.cn>
-
- [BlackBerry] Wrong mimetype for empty file link
- https://bugs.webkit.org/show_bug.cgi?id=88642
-
- Reviewed by Rob Buis.
-
- RIM PR# 164164
-
- For empty file link, we shouldn't give "application/octet-stream"
- which will lead to download.
-
- Reviewed internally by Charles Wei.
-
- * platform/network/blackberry/NetworkJob.cpp:
- (WebCore::NetworkJob::sendResponseIfNeeded):
-
-2012-06-11 Jin Yang <jin.a.yang@intel.com>
-
- GeneratorGeneratedImage should cache images for the non-tiled case
- https://bugs.webkit.org/show_bug.cgi?id=87094
-
- Reviewed by Simon Fraser.
-
- We cache the generated image if generator is not changed. By compared
- with generating image on the fly, it will lose a little pixel precision
- and several layout tests should be rebaselined. With this patch, the IE test
- drive benchmark "Bayou" can gain about 50%.
-
- No new tests. Performance optimization.
-
- * platform/graphics/GeneratorGeneratedImage.cpp:
- (WebCore::GeneratorGeneratedImage::draw):
-
-2012-06-11 Vincent Scheib <scheib@chromium.org>
-
- Add new Pointer Lock spec attribute webkitPointerLockElement.
- https://bugs.webkit.org/show_bug.cgi?id=88799
-
- Reviewed by Dimitri Glazkov.
-
- Part of a series of refactoring changes to update pointer lock API to
- the fullscreen locking style. https://bugs.webkit.org/show_bug.cgi?id=84402
-
- New attribute webkitPointerLockElement added. Follow up patches
- will remove the previous isLocked attribute. Tests updated to use
- the new attribute.
-
- * bindings/generic/RuntimeEnabledFeatures.h:
- (WebCore::RuntimeEnabledFeatures::webkitPointerLockElementEnabled):
- * dom/Document.cpp:
- (WebCore):
- (WebCore::Document::webkitPointerLockElement):
- * dom/Document.h:
- (Document):
- * dom/Document.idl:
- * page/PointerLockController.h:
- (WebCore::PointerLockController::element):
-
-2012-06-11 Vincent Scheib <scheib@chromium.org>
-
- Consolidate Pointer Lock runtime enabled flags to just one.
- https://bugs.webkit.org/show_bug.cgi?id=88810
-
- Reviewed by Dimitri Glazkov.
-
- No new tests.
-
- * bindings/generic/RuntimeEnabledFeatures.h:
- (WebCore::RuntimeEnabledFeatures::pointerLockEnabled):
- (WebCore::RuntimeEnabledFeatures::setPointerLockEnabled):
- * dom/MouseEvent.idl:
- * page/Navigator.idl:
-
-2012-06-11 Alexis Menard <alexis.menard@openbossa.org>
-
- [CSS3 Backgrounds and Borders] Protect box-decoration-break behind a feature flag.
- https://bugs.webkit.org/show_bug.cgi?id=88804
-
- Reviewed by Tony Chang.
-
- Protect box-decoration-break behind a feature flag enabled by default.
-
- No new tests : no behavior change here.
-
- * Configurations/FeatureDefines.xcconfig:
- * GNUmakefile.am:
- * css/CSSComputedStyleDeclaration.cpp:
- (WebCore):
- (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
- * css/CSSParser.cpp:
- (WebCore::isValidKeywordPropertyAndValue):
- (WebCore::isKeywordPropertyID):
- (WebCore::CSSParser::parseValue):
- * css/CSSPrimitiveValueMappings.h:
- (WebCore):
- * css/CSSProperty.cpp:
- (WebCore::CSSProperty::isInheritedProperty):
- * css/CSSValueKeywords.in:
- * css/StyleBuilder.cpp:
- (WebCore::StyleBuilder::StyleBuilder):
- * rendering/style/RenderStyle.h:
- * rendering/style/StyleBoxData.cpp:
- (WebCore::StyleBoxData::StyleBoxData):
- (WebCore::StyleBoxData::operator==):
- * rendering/style/StyleBoxData.h:
- (StyleBoxData):
-
-2012-06-11 James Robinson <jamesr@chromium.org>
-
- [chromium] Port DrawingBufferChromium from TextureLayerChromium over to WebExternalTextureLayer
- https://bugs.webkit.org/show_bug.cgi?id=86273
-
- Reviewed by Adrienne Walker.
-
- This converts more WebCore code over to using public APIs instead of internal compositor layer types.
-
- Refactor only, no change in behavior thus no new tests.
-
- * platform/graphics/chromium/DrawingBufferChromium.cpp:
- (WebCore::DrawingBufferPrivate::DrawingBufferPrivate):
- (WebCore::DrawingBufferPrivate::~DrawingBufferPrivate):
- (WebCore::DrawingBufferPrivate::layer):
- (DrawingBufferPrivate):
- * platform/graphics/chromium/TextureLayerChromium.cpp:
- (WebCore::TextureLayerChromium::~TextureLayerChromium):
- (WebCore::TextureLayerChromium::setRateLimitContext):
- (WebCore::TextureLayerChromium::setNeedsDisplayRect):
- (WebCore::TextureLayerChromium::update):
- * platform/graphics/chromium/TextureLayerChromium.h:
- (WebKit):
- (TextureLayerChromiumClient):
-
-2012-06-11 Max Feil <mfeil@rim.com>
-
- [BlackBerry] Seek calls are being unnecessarily delayed
- https://bugs.webkit.org/show_bug.cgi?id=88732
-
- Reviewed by Antonio Gomes.
-
- There is a problem with the way the m_userDrivenSeekTimer is
- implemented. When MediaPlayerPrivate::seek() is called, there
- is always a 100ms delay even if the timer is not running. The
- timer is supposed to space out (i.e. throttle) repeated seeks
- that come in too soon after a previous seek, but currently it
- is slowing down even single seeks and seeks that come in with
- adequate delay after a previous seek. I fixed this in my patch
- by improving the way the timer fired function is called.
-
- A note on the new m_lastSeekTimePending flag: This flag is
- needed so that userDrivenSeekTimerFired() knows whether or not
- to perform the seek. The only case where this flag will not be
- set is if no MediaPlayerPrivate::seek() call came in while the
- timer was active, in which case it's important to do nothing.
- I could encode this flag's information into the m_lastSeekTime
- float, for example by initializing it and resetting it to NAN
- and using isnan(). But I feel that using a separate bool is a
- more portable approach.
-
- No new tests. I would like to propose not including a layout test
- with this fix. Doing timing tests for 100ms delays is tricky
- from Javascript, and I don't think the benefit of such a test
- outweighs the extra time it would take to develop one. The test
- would also be a problem to maintain as it may give different
- results over different runs and across different target hardware.
-
- * platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.cpp:
- (WebCore::MediaPlayerPrivate::MediaPlayerPrivate):
- (WebCore::MediaPlayerPrivate::seek):
- (WebCore::MediaPlayerPrivate::userDrivenSeekTimerFired):
- * platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.h:
- (MediaPlayerPrivate):
-
-2012-06-11 Max Feil <mfeil@rim.com>
-
- [BlackBerry] Unexpected repeats of short media
- https://bugs.webkit.org/show_bug.cgi?id=88733
-
- Reviewed by Antonio Gomes.
-
- The m_userDrivenSeekTimer is causing unwanted repeats of short
- media such as sound effects because it is causing the current
- time to not reflect that the media has finished playing.
- This problem only affects media whose duration is close to
- or less than the SeekSubmissionDelay, which is currently
- set to 100ms. My fix is to ignore the userDrivenSeekTimer in
- MediaPlayerPrivate::currentTime() if the duration of the media
- is within twice the SeekSubmissionDelay. Seek drag smoothness
- is a non-issue for such short media.
-
- Test: platform/blackberry/media/short-media-repeats-correctly.html
-
- * platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.cpp:
- (WebCore::MediaPlayerPrivate::MediaPlayerPrivate):
- (WebCore):
- (WebCore::MediaPlayerPrivate::currentTime):
- (WebCore::MediaPlayerPrivate::seek):
- (WebCore::MediaPlayerPrivate::userDrivenSeekTimerFired):
- * platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.h:
- (MediaPlayerPrivate):
-
-2012-06-11 Julien Chaffraix <jchaffraix@webkit.org>
-
- Account for margin after when laying out <legend> element
- https://bugs.webkit.org/show_bug.cgi?id=35981
-
- Reviewed by Abhishek Arya.
-
- Tests: fast/forms/legend-after-margin-horizontal-writing-mode.html
- fast/forms/legend-after-margin-vertical-writing-mode.html
- fast/forms/legend-after-margin-with-before-border-horizontal-mode.html
- fast/forms/legend-small-after-margin-before-border-horizontal-mode.html
-
- The existing code would ignore margin after when layouting out the <legend>. This
- change only adds the code to handle the margin after, the margin before is still
- ignored as it's not obvious how it should be working.
-
- * rendering/RenderFieldset.cpp:
- (WebCore::RenderFieldset::layoutSpecialExcludedChild):
- Split the code in 2 code paths to reflect how we position and size. Those are covered by the
- tests above.
-
-2012-06-11 James Robinson <jamesr@chromium.org>
-
- [chromium] Use WebGraphicsContext3D in rate limiting logic inside compositor
- https://bugs.webkit.org/show_bug.cgi?id=86259
-
- Reviewed by Adrienne Walker.
-
- This refactors the compositor's rate limiting implementation to use the Platform API's WebGraphicsContext3D
- directly instead of WebCore::GraphicsContext3D to cut down on the number of spurious WebCore dependencies in the
- compositor. The one change in contract is that the caller to CCLayerTreeHost::startRateLimit() now has to call
- CCLayerTreeHost::stopRateLimit() before allowing the referenced context to go away since CCLayerTreeHost no
- longer retains a reference, but this was always happening already.
-
- * platform/graphics/chromium/Canvas2DLayerChromium.cpp:
- (WebCore::Canvas2DLayerChromium::~Canvas2DLayerChromium):
- (WebCore::Canvas2DLayerChromium::setNeedsDisplayRect):
- * platform/graphics/chromium/RateLimiter.cpp:
- (WebCore::RateLimiter::create):
- (WebCore::RateLimiter::RateLimiter):
- (WebCore::RateLimiter::start):
- (WebCore::RateLimiter::rateLimitContext):
- * platform/graphics/chromium/RateLimiter.h:
- (WebKit):
- (RateLimiter):
- * platform/graphics/chromium/TextureLayerChromium.cpp:
- (WebCore::TextureLayerChromium::~TextureLayerChromium):
- (WebCore::TextureLayerChromium::setRateLimitContext):
- (WebCore::TextureLayerChromium::setNeedsDisplayRect):
- * platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
- (WebCore::CCLayerTreeHost::startRateLimiter):
- (WebCore::CCLayerTreeHost::stopRateLimiter):
- (WebCore::CCLayerTreeHost::rateLimit):
- (WebCore):
- * platform/graphics/chromium/cc/CCLayerTreeHost.h:
- (CCLayerTreeHost):
-
-2012-06-11 Dana Jansens <danakj@chromium.org>
-
- [chromium] Separate CCVideoDrawQuad and from the layer tree and video provider by removing ManagedTexture and WebVideoFrame pointers from the quad
- https://bugs.webkit.org/show_bug.cgi?id=88363
-
- Reviewed by Adrienne Walker.
-
- CCVideoDrawQuad should not contain any pointers to data in the layer
- tree so we are able to serialize it across process boundaries. This
- patch removes the ManagedTexture pointers from the quad class,
- replacing them with texture ids. It removes the WebVideoFrame* from
- the quad, replacing it with the frame provider's texture id included
- in the WebVideoFrame structure. And it uses a WebTransformationMatrix
- instead of a pointer to an array of floats.
-
- Texture allocation is done in CCVideoLayerImpl via the
- contentsTextureAllocator, so that the memory usage can be tracked.
-
- We move the copyPlaneToTextures() method back from LayerRendererChromium
- to CCVideoLayerImpl, as this method uses the texture data pointer in the
- WebVideoFrame, and we do not want to give this pointer to the quad
- class. Instead, this method makes use of the LayerTextureSubImage class
- to copy the pixel data into the texture.
-
- LayerTextureSubImage is updated to allow non-4byte texture formats.
-
- * platform/graphics/chromium/LayerRendererChromium.cpp:
- (WebCore::LayerRendererChromium::drawYUV):
- (WebCore::LayerRendererChromium::drawRGBA):
- (WebCore::LayerRendererChromium::drawNativeTexture2D):
- (WebCore::LayerRendererChromium::drawStreamTexture):
- (WebCore::LayerRendererChromium::drawVideoQuad):
- * platform/graphics/chromium/LayerTextureSubImage.cpp:
- (WebCore::LayerTextureSubImage::uploadWithTexSubImage):
- (WebCore::LayerTextureSubImage::uploadWithMapTexSubImage):
- * platform/graphics/chromium/TextureCopier.cpp:
- * platform/graphics/chromium/cc/CCVideoDrawQuad.cpp:
- (WebCore::CCVideoDrawQuad::create):
- (WebCore::CCVideoDrawQuad::CCVideoDrawQuad):
- * platform/graphics/chromium/cc/CCVideoDrawQuad.h:
- (CCVideoDrawQuad):
- (WebCore::CCVideoDrawQuad::planes):
- (WebCore::CCVideoDrawQuad::frameProviderTextureId):
- * platform/graphics/chromium/cc/CCVideoLayerImpl.cpp:
- (WebCore::CCVideoLayerImpl::~CCVideoLayerImpl):
- (WebCore::CCVideoLayerImpl::willDraw):
- (WebCore::CCVideoLayerImpl::willDrawInternal):
- (WebCore::CCVideoLayerImpl::appendQuads):
- (WebCore::CCVideoLayerImpl::didDraw):
- (WebCore::CCVideoLayerImpl::FramePlane::allocateData):
- (WebCore):
- (WebCore::CCVideoLayerImpl::FramePlane::freeData):
- (WebCore::CCVideoLayerImpl::allocatePlaneData):
- (WebCore::CCVideoLayerImpl::copyPlaneData):
- (WebCore::CCVideoLayerImpl::freePlaneData):
- (WebCore::CCVideoLayerImpl::freeUnusedPlaneData):
- (WebCore::CCVideoLayerImpl::didLoseContext):
- * platform/graphics/chromium/cc/CCVideoLayerImpl.h:
- (FramePlane):
- (WebCore::CCVideoLayerImpl::FramePlane::FramePlane):
-
-2012-06-11 Joshua Bell <jsbell@chromium.org>
-
- IndexedDB: Object stores are not successfully deleted
- https://bugs.webkit.org/show_bug.cgi?id=88788
-
- Reviewed by Tony Chang.
-
- Discovered while working on http://webkit.org/b/83074 - object stores are not
- being deleted from the backing store. Deletion would succeed in the in-memory
- data structures, but after closing/re-opening the backing store the object store
- (but not its indexes/data) would reappear. Due to 83074, this isn't detectable
- by DRT without a full restart.
-
- Test: [chromium] webkit_unit_tests --gtest_filter='IDBLevelDBCodingTest.ComparisonTest'
-
- * Modules/indexeddb/IDBLevelDBCoding.cpp:
- (WebCore::IDBLevelDBCoding::ObjectStoreMetaDataKey::compare):
-
-2012-06-05 Eric Uhrhane <ericu@chromium.org>
-
- Crash in fast/files/read tests during Garbage Collection
- https://bugs.webkit.org/show_bug.cgi?id=87165
-
- Reviewed by Michael Saboff
-
- Fix previous fix for hasPendingActivity, and fix a bug in a complex
- abort case as well--abort during the final progress event of a write
- would hang the writer.
-
- * Modules/filesystem/FileWriter.cpp:
- (WebCore::FileWriter::stop):
- (WebCore::FileWriter::write):
- (WebCore::FileWriter::truncate):
- (WebCore::FileWriter::didWrite):
- (WebCore::FileWriter::didTruncate):
- (WebCore::FileWriter::didFail):
- (WebCore::FileWriter::completeAbort):
- (WebCore::FileWriter::doOperation):
- (WebCore::FileWriter::signalCompletion):
-
-2012-06-11 Shawn Singh <shawnsingh@chromium.org>
-
- [chromium] Implement position:fixed in compositor thread
- https://bugs.webkit.org/show_bug.cgi?id=70103
-
- Reviewed by Adrienne Walker.
-
- Significant contributions to this patch by Alpha Lam and Sami Kyostila.
-
- This patch is the compositor-side change that adds support for
- fixed-position layers to be composited layers. Before this patch,
- fixed-position elements were positioned only by WebCore (i.e. main
- thread when painting), and the compositor did not have enough
- knowledge on its own to position it properly. This patch adds the
- necessary math and plumbs the necessary layer information so that
- the impl thread can properly position fixed-position elements on
- its own. This support is necessary for correctness of composited
- fixed-position elements, which can greatly help to avoid
- repainting container layers when scrolling with a fixed-position
- layer.
-
- There also needs to be WebCore-side support for this, which is
- addressed in https://bugs.webkit.org/show_bug.cgi?id=78864
-
- Unit tests added to CCLayerTreeHostCommonTest:
- CCLayerTreeHostCommonTest.verifyScrollCompensationForFixedPositionLayerWithDirectContainer
- CCLayerTreeHostCommonTest.verifyScrollCompensationForFixedPositionLayerWithTransformedDirectContainer
- CCLayerTreeHostCommonTest.verifyScrollCompensationForFixedPositionLayerWithDistantContainer
- CCLayerTreeHostCommonTest.verifyScrollCompensationForFixedPositionLayerWithDistantContainerAndTransforms
- CCLayerTreeHostCommonTest.verifyScrollCompensationForFixedPositionLayerWithMultipleScrollDeltas
- CCLayerTreeHostCommonTest.verifyScrollCompensationForFixedPositionLayerWithIntermediateSurfaceAndTransforms
- CCLayerTreeHostCommonTest.verifyScrollCompensationForFixedPositionLayerWithMultipleIntermediateSurfaces
- CCLayerTreeHostCommonTest.verifyScrollCompensationForFixedPositionLayerWithContainerLayerThatHasSurface
- CCLayerTreeHostCommonTest.verifyScrollCompensationForFixedPositionLayerThatIsAlsoFixedPositionContainer
- CCLayerTreeHostCommonTest.verifyScrollCompensationForFixedPositionLayerThatHasNoContainer
-
- * platform/graphics/chromium/LayerChromium.cpp:
- (WebCore::LayerChromium::LayerChromium):
- (WebCore::LayerChromium::pushPropertiesTo):
- * platform/graphics/chromium/LayerChromium.h:
- (WebCore::LayerChromium::setIsContainerForFixedPositionLayers):
- (WebCore::LayerChromium::isContainerForFixedPositionLayers):
- (LayerChromium):
- (WebCore::LayerChromium::setFixedToContainerLayerVisibleRect):
- (WebCore::LayerChromium::fixedToContainerLayerVisibleRect):
- * platform/graphics/chromium/cc/CCLayerImpl.cpp:
- (WebCore::CCLayerImpl::CCLayerImpl):
- * platform/graphics/chromium/cc/CCLayerImpl.h:
- (WebCore::CCLayerImpl::setIsContainerForFixedPositionLayers):
- (WebCore::CCLayerImpl::isContainerForFixedPositionLayers):
- (CCLayerImpl):
- (WebCore::CCLayerImpl::setFixedToContainerLayerVisibleRect):
- (WebCore::CCLayerImpl::fixedToContainerLayerVisibleRect):
- * platform/graphics/chromium/cc/CCLayerTreeHostCommon.cpp:
- (WebCore::computeScrollCompensationForThisLayer):
- (WebCore):
- (WebCore::computeScrollCompensationMatrixForChildren):
- (WebCore::calculateDrawTransformsInternal):
- (WebCore::CCLayerTreeHostCommon::calculateDrawTransforms):
-
-2012-06-11 Sam Weinig <sam@webkit.org>
-
- Remove support for disconnected/excluded from search frames, they are not used by Safari anymore
- https://bugs.webkit.org/show_bug.cgi?id=88723
-
- Reviewed by Dan Bernstein.
-
- * WebCore.exp.in:
- Update export.
- * editing/Editor.cpp:
- (WebCore::Editor::rangeOfString):
- (WebCore::Editor::countMatchesForText):
- * editing/Editor.h:
- (Editor):
- * loader/FrameLoader.cpp:
- (WebCore::FrameLoader::findFrameForNavigation):
- * page/DOMWindow.cpp:
- (WebCore::DOMWindow::parent):
- (WebCore::DOMWindow::top):
- * page/EventHandler.cpp:
- (WebCore::EventHandler::hitTestResultAtPoint):
- * page/Frame.cpp:
- (WebCore::Frame::Frame):
- * page/Frame.h:
- (Frame):
- * page/FrameTree.cpp:
- (WebCore::FrameTree::parent):
- (WebCore::FrameTree::top):
- * page/FrameTree.h:
- (FrameTree):
- * page/Location.cpp:
- (WebCore::Location::ancestorOrigins):
- * xml/XMLTreeViewer.cpp:
- (WebCore::XMLTreeViewer::hasNoStyleInformation):
- Update for the removal of disconnected frames and text search exclusions concepts.
-
-2012-06-11 Xianzhu Wang <wangxianzhu@chromium.org>
-
- SVGImageCache leaks image data
- https://bugs.webkit.org/show_bug.cgi?id=87792
-
- There are two functions to remove a client from a CachedImage:
- - CachedResource::removeClient()
- - CachedImage::removeClientForRenderer().
- It's easy to make error to call the former which will leak the cached
- image buffers in SVGImageCache.
-
- This change combined the two by adding the virtual
- CachedResource::didRemoveClient(). CachedImage will do SVGImageCache
- cleanup in the function.
-
- Reviewed by Nikolas Zimmermann.
-
- Test: svg/as-image/svg-image-leak-cached-data.html
-
- * loader/cache/CachedFont.h:
- (WebCore::CachedFontClient::resourceClientType): Added 'const'.
- * loader/cache/CachedImage.cpp:
- (WebCore):
- (WebCore::CachedImage::didRemoveClient): Removes the client from SVGImageCache.
- (WebCore::CachedImage::lookupOrCreateImageForRenderer):
- * loader/cache/CachedImage.h:
- (CachedImage):
- (WebCore::CachedImageClient::resourceClientType): Added 'const'.
- * loader/cache/CachedRawResource.h:
- (WebCore::CachedRawResourceClient::resourceClientType): Added 'const'.
- * loader/cache/CachedResource.cpp:
- (WebCore::CachedResource::removeClient): Added invocation of didRemoveClient().
- * loader/cache/CachedResource.h:
- (WebCore::CachedResource::didRemoveClient): Added for subclasses to do additional works.
- * loader/cache/CachedResourceClient.h:
- (WebCore::CachedResourceClient::resourceClientType): Added 'const'.
- * loader/cache/CachedSVGDocument.h:
- (WebCore::CachedSVGDocumentClient::resourceClientType): Added 'const'.
- * loader/cache/CachedStyleSheetClient.h:
- (WebCore::CachedStyleSheetClient::resourceClientType): Added 'const'.
- * rendering/style/StyleCachedImage.cpp:
- (WebCore::StyleCachedImage::removeClient):
- * rendering/style/StyleCachedImageSet.cpp:
- (WebCore::StyleCachedImageSet::removeClient):
- * svg/graphics/SVGImageCache.cpp:
- (WebCore::SVGImageCache::~SVGImageCache): Added checking for leaks.
- (WebCore::SVGImageCache::removeClientFromCache):
- (WebCore::SVGImageCache::setRequestedSizeAndScales):
- (WebCore::SVGImageCache::requestedSizeAndScales):
- (WebCore::SVGImageCache::lookupOrCreateBitmapImageForClient):
- * svg/graphics/SVGImageCache.h:
- (WebCore):
- (SVGImageCache):
-
-2012-06-11 Mark Pilgrim <pilgrim@chromium.org>
-
- [Chromium] Call shared timer functions directly
- https://bugs.webkit.org/show_bug.cgi?id=88781
-
- Reviewed by Adam Barth.
-
- Part of a refactoring series. See tracking bug 82948.
-
- * platform/chromium/PlatformSupport.h:
- (PlatformSupport):
- * platform/chromium/SharedTimerChromium.cpp:
- (WebCore::setSharedTimerFiredFunction):
- (WebCore::setSharedTimerFireInterval):
-
-2012-06-11 Pravin D <pravind.2k4@gmail.com>
-
- Relative pos. input fields in columns vanish when you start typing in them
- https://bugs.webkit.org/show_bug.cgi?id=76834
-
- Reviewed by Julien Chaffraix.
-
- Test: fast/multicol/multicol-with-child-renderLayer-for-input.html
-
- * page/FrameView.cpp:
- (WebCore::updateLayerPositionFlags):
- Helper function to prepare the UpdateLayerPositionsFlags based on the input parameters.
- If didFullRepaint flag is set, then CheckForRepaints flag is removed from the default flags.
- Also during a relayout of a subtree, if the RenderLayer of the subtree root is paginated then updatePagination flag is
- included in the flags.
-
- (WebCore):
- (WebCore::FrameView::layout):
- Now uses the helper function updateLayerPositionFlags() to get the final set of UpdateLayerPositionsFlags.
-
- * rendering/RenderLayer.h:
- (WebCore::RenderLayer::isPaginated):
- (RenderLayer):
- isPaginated function is made public so that FrameView class can use it prepare UpdateLayerPositionsFlags.
-
-2012-06-11 Mark Pilgrim <pilgrim@chromium.org>
-
- [Chromium] Remove some dead code in PasteboardChromium
- https://bugs.webkit.org/show_bug.cgi?id=88782
-
- Reviewed by Adam Barth.
-
- Part of a refactoring series. See tracking bug 82948.
- Leftover detritus from bug 88038.
-
- * platform/chromium/PasteboardChromium.cpp:
- (WebCore::Pasteboard::documentFragment):
-
-2012-06-11 Peter Beverloo <peter@chromium.org>
-
- [Chromium] Theme updates for Android in menu list rendering and selection backgrounds
- https://bugs.webkit.org/show_bug.cgi?id=88775
-
- Reviewed by Adam Barth.
-
- For Chrome on Android, use the width of the scrollbar down arrow instead
- of the scrollbar's width for determining the arrow padding to apply for
- menu list rendering, as WebKit isn't drawing a scrollbar (thus width=0).
-
- Furthermore, change the default active selection background color to be
- equal to the tap highlighting color.
-
- These changes should be covered by existing layout tests.
-
- * rendering/RenderThemeChromiumAndroid.cpp:
- (WebCore::RenderThemeChromiumAndroid::menuListArrowPadding):
- (WebCore): Retrieve the scrollbar down arrow's size via PlatformSupport.
- * rendering/RenderThemeChromiumAndroid.h: Override the menuListArrowPadding
- and platformActiveSelectionBackgroundColor methods, and add a static
- static RGBA32 color for the default active selection bg color.
- * rendering/RenderThemeChromiumSkia.cpp:
- (WebCore::RenderThemeChromiumSkia::menuListArrowPadding): Default to
- the scrollbar thickness, not changing behavior for non-Android.
- (WebCore::RenderThemeChromiumSkia::menuListInternalPadding): Instead
- of polling the scrollbar thickness, call menuListArrowPadding().
- * rendering/RenderThemeChromiumSkia.h:
- (RenderThemeChromiumSkia): Add the menuListArrowPadding() as a protected method.
-
-2012-06-11 David Barr <davidbarr@chromium.org>
-
- Add css3-images image-resolution (dppx only)
- https://bugs.webkit.org/show_bug.cgi?id=85332
-
- Reviewed by Tony Chang.
-
- The css3-images module is at candidate recommendation.
- http://www.w3.org/TR/2012/CR-css3-images-20120417/#image-resolution
-
- Test: fast/css/image-resolution.html
-
- * css/CSSComputedStyleDeclaration.cpp:
- (WebCore):
- (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
- * css/CSSGrammar.y:
- * css/CSSParser.cpp:
- (WebCore::CSSParser::validUnit):
- (WebCore::CSSParser::createPrimitiveNumericValue):
- (WebCore::unitFromString):
- (WebCore::CSSParser::parseValidPrimitive):
- (WebCore::CSSParser::parseValue):
- (WebCore):
- (WebCore::CSSParser::parseImageResolution):
- (WebCore::CSSParser::detectNumberToken):
- * css/CSSParser.h:
- * css/CSSPrimitiveValue.cpp:
- (WebCore::isValidCSSUnitTypeForDoubleConversion):
- (WebCore::unitCategory):
- (WebCore::CSSPrimitiveValue::canonicalUnitTypeForCategory):
- (WebCore::CSSPrimitiveValue::customCssText):
- (WebCore::CSSPrimitiveValue::cloneForCSSOM):
- * css/CSSPrimitiveValue.h:
- * css/CSSProperty.cpp:
- (WebCore::CSSProperty::isInheritedProperty):
- * css/CSSPropertyNames.in:
- * css/StyleBuilder.cpp:
- (WebCore):
- (ApplyPropertyImageResolution):
- (WebCore::ApplyPropertyImageResolution::applyInheritValue):
- (WebCore::ApplyPropertyImageResolution::applyInitialValue):
- (WebCore::ApplyPropertyImageResolution::applyValue):
- (WebCore::ApplyPropertyImageResolution::createHandler):
- (WebCore::StyleBuilder::StyleBuilder):
- * css/StyleResolver.cpp:
- (WebCore::StyleResolver::collectMatchingRulesForList):
- * rendering/RenderImage.cpp:
- (WebCore::RenderImage::styleDidChange):
- (WebCore::RenderImage::imageDimensionsChanged):
- * rendering/style/RenderStyle.cpp:
- (WebCore::RenderStyle::diff):
- * rendering/style/RenderStyle.h:
- * rendering/style/StyleRareInheritedData.cpp:
- (WebCore::StyleRareInheritedData::StyleRareInheritedData):
- (WebCore::StyleRareInheritedData::operator==):
- * rendering/style/StyleRareInheritedData.h:
- (StyleRareInheritedData):
-
-2012-06-05 Dana Jansens <danakj@chromium.org>
-
- [chromium] Free texture from CCIOSurfaceLayerImpl when it is destroyed
- https://bugs.webkit.org/show_bug.cgi?id=88371
-
- Reviewed by James Robinson.
-
- Unit test: CCLayerTreeHostImplTest.layersFreeTextures
-
- * platform/graphics/chromium/cc/CCIOSurfaceLayerImpl.cpp:
- (WebCore::CCIOSurfaceLayerImpl::~CCIOSurfaceLayerImpl):
- (WebCore::CCIOSurfaceLayerImpl::willDraw):
-
-2012-06-11 Carlos Garcia Campos <cgarcia@igalia.com>
-
- Unreviewed. Fix make distcheck issues.
-
- * GNUmakefile.am: Add idl files in editing dir to EXTRA_DIST.
- * GNUmakefile.list.am: Add missing header file.
-
-2012-06-11 Dan Bernstein <mitz@apple.com>
-
- Reverted r119940 because it caused multiple media tests to fail on Lion.
-
- * html/HTMLMediaElement.cpp:
- (WebCore::HTMLMediaElement::prepareForLoad):
- (WebCore):
- (WebCore::HTMLMediaElement::userCancelledLoad):
- * html/HTMLMediaElement.h:
- (HTMLMediaElement):
- * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
- (WebCore::MediaPlayerPrivateQTKit::commonMovieAttributes):
-
-2012-06-11 Zoltan Horvath <zoltan@webkit.org>
-
- [Qt] Add config tests for WEBP imagedecoder library, modify HAVE(decoderlibrary) to USE(...)$
- https://bugs.webkit.org/show_bug.cgi?id=87841
-
- Reviewed by Simon Hausmann.
-
- No new tests were needed.
-
- * Target.pri:
- * WebCore.pri:
- * platform/image-decoders/ImageDecoder.cpp:
- (WebCore::ImageDecoder::create):
-
-2012-06-11 Kenneth Rohde Christiansen <kenneth@webkit.org>
-
- Add QML api for setting device width and height
- https://bugs.webkit.org/show_bug.cgi?id=88777
-
- Reviewed by Simon Hausmann.
-
- Change the default values for deviceWidth/Height to be 0 (unset). The
- original values were introduced by Qt and 0 makes it possible to
- detect if a value has never been set and therefore fall back.
-
- Only Qt depended on the former values.
-
- * page/Settings.cpp:
- (WebCore::Settings::Settings):
-
-2012-06-11 Csaba Osztrogonác <ossy@webkit.org>
-
- [Qt][Win] Fix UString related build problem in Source/WebCore/bridge/qt/qt_instance.cpp
- https://bugs.webkit.org/show_bug.cgi?id=88310
-
- Reviewed by Simon Hausmann.
-
- * bridge/qt/qt_instance.cpp:
- (JSC::Bindings::QtInstance::getPropertyNames):
-
-2012-06-11 Michael Brüning <michael.bruning@nokia.com>
-
- [Qt][WK2] Compute and set cache capacities using the current CacheModel
- https://bugs.webkit.org/show_bug.cgi?id=73918
-
- Unreviewed build fix.
-
- No new tests added as this is a build fix.
-
- * platform/qt/FileSystemQt.cpp:
-
-2012-06-11 Allan Sandfeld Jensen <allan.jensen@nokia.com>
-
- Rect-based hittesting doesn't work in tables.
- https://bugs.webkit.org/show_bug.cgi?id=86605
-
- Reviewed by Julien Chaffraix.
-
- The existing code only performed a single binary lookup for the central
- hit-test point. This meant area-based hit-testing did not work across
- table-cell borders. All cells spanned by a hit-test area must be hit
- tested.
-
- This patch introduces three auxilary functions to help calculate rows
- and columns spanned by an rect. These are intended to also be used by
- repaint logic in a later patch.
-
- For point-based hit-testing we maintain unchanged behavior and still
- only hit test a single column in a single row.
-
- Test: fast/dom/nodesFromRect-table.html
-
- * rendering/RenderTableSection.cpp:
- (WebCore::RenderTableSection::logicalRectForWritingModeAndDirection):
- (WebCore::RenderTableSection::spannedRows):
- (WebCore::RenderTableSection::spannedColumns):
- (WebCore::RenderTableSection::nodeAtPoint):
- * rendering/RenderTableSection.h:
- (RenderTableSection):
-
-2012-06-11 Min Qin <qinmin@google.com>
-
- Adding a flag to show fullscreen media controls in chromium
- https://bugs.webkit.org/show_bug.cgi?id=88266
-
- Reviewed by Adam Barth.
-
- The default chromium shadow DOM for media element does not contain fullscreen button.
- This change adds a flag to display the fullscreen button.
- It will be used by the android port.
-
- No new tests needed. We will use the same layout tests as desktop chromium.
- However, new test result expections will be added later.
-
- * html/shadow/MediaControlRootElementChromium.cpp:
- (WebCore::MediaControlRootElementChromium::MediaControlRootElementChromium):
- (WebCore::MediaControlRootElementChromium::create):
- (WebCore::MediaControlRootElementChromium::setMediaController):
- (WebCore::MediaControlRootElementChromium::reset):
- (WebCore::MediaControlRootElementChromium::reportedError):
- * html/shadow/MediaControlRootElementChromium.h:
- (MediaControlRootElementChromium):
-
-2012-06-11 Michael Brüning <michael.bruning@nokia.com>
-
- [Qt][WK2] Compute and set cache capacities using the current CacheModel
- https://bugs.webkit.org/show_bug.cgi?id=73918
-
- Reviewed by Kenneth Rohde Christiansen.
-
- No new tests needed / applicable (using operating system functionality).
-
- Added method to read free file system space for a path to support cache model
- implementation in Qt WK 2.
-
- * platform/FileSystem.h:
- (WebCore):
- * platform/qt/FileSystemQt.cpp:
- (WebCore::getVolumeFreeSizeForPath): Added for Qt ports.
- (WebCore):
-
-2012-06-11 Peter Wang <peter.wang@torchmobile.com.cn>
-
- [JSC] Web Inspector: implement breaking from native callback
- https://bugs.webkit.org/show_bug.cgi?id=43332
-
- Reviewed by Pavel Feldman.
-
- These test cases were enabled:
- LayoutTests/inspector/debugger/dom-breakpoints.html
- LayoutTests/inspector/debugger/event-listener-breakpoints.html
- LayoutTests/inspector/debugger/step-through-event-listeners.html
- LayoutTests/inspector/debugger/xhr-breakpoints.html
-
- * bindings/js/ScriptDebugServer.cpp:
- (WebCore::ScriptDebugServer::breakProgram):
- * bindings/js/ScriptDebugServer.h:
- (WebCore::supportsNativeBreakpoints):
-
-2012-06-11 MORITA Hajime <morrita@google.com>
-
- Spellchecker crash in async scenario.
- https://bugs.webkit.org/show_bug.cgi?id=88617
-
- Reviewed by Tony Chang.
-
- SpellCheckRequest::invokeRequest() can be reached after the frame is detached.
- SpellCheckRequest should ignore such a request since TextCheckerClient is not available
- for detached Frames.
-
- No new tests. It's hard to reproduce this.
-
- * editing/SpellChecker.cpp:
- (WebCore::SpellChecker::invokeRequest):
-
-2012-06-11 Ryuan Choi <ryuan.choi@samsung.com>
-
- [EFL] Extract CursorMap from WidgetEfl.cpp.
- https://bugs.webkit.org/show_bug.cgi?id=88633
-
- Reviewed by Ryosuke Niwa.
-
- In order to share CursorMap in WebKit/efl and UIProcess of WebKit2/Efl,
- extract it and expose getEcoreCursor.
-
- No new tests, refactoring only.
-
- * platform/efl/EflScreenUtilities.cpp:
- (WebCore):
- (CursorMap):
- (WebCore::CursorMap::cursor):
- (WebCore::CursorMap::CursorMap):
- (WebCore::getEcoreCursor):
- * platform/efl/EflScreenUtilities.h:
- (WebCore):
- * platform/efl/WidgetEfl.cpp:
- (WebCore::Widget::applyFallbackCursor):
-
-2012-06-10 Sheriff Bot <webkit.review.bot@gmail.com>
-
- Unreviewed, rolling out r119955.
- http://trac.webkit.org/changeset/119955
- https://bugs.webkit.org/show_bug.cgi?id=88758
-
- Breaks Chromium compile - Chromium depends on removed API
- (Requested by dominicc on #webkit).
-
- * WebCore.exp.in:
- * editing/Editor.cpp:
- (WebCore::Editor::insideVisibleArea):
- (WebCore):
- (WebCore::Editor::firstVisibleRange):
- (WebCore::Editor::lastVisibleRange):
- (WebCore::Editor::nextVisibleRange):
- (WebCore::Editor::rangeOfString):
- (WebCore::Editor::countMatchesForText):
- * editing/Editor.h:
- (Editor):
- * loader/FrameLoader.cpp:
- (WebCore::FrameLoader::findFrameForNavigation):
- * page/DOMWindow.cpp:
- (WebCore::DOMWindow::parent):
- (WebCore::DOMWindow::top):
- * page/EventHandler.cpp:
- (WebCore::EventHandler::hitTestResultAtPoint):
- * page/Frame.cpp:
- (WebCore::Frame::Frame):
- * page/Frame.h:
- (Frame):
- (WebCore::Frame::isDisconnected):
- (WebCore):
- (WebCore::Frame::setIsDisconnected):
- (WebCore::Frame::excludeFromTextSearch):
- (WebCore::Frame::setExcludeFromTextSearch):
- * page/FrameTree.cpp:
- (WebCore::FrameTree::parent):
- (WebCore::FrameTree::top):
- * page/FrameTree.h:
- (FrameTree):
- * page/Location.cpp:
- (WebCore::Location::ancestorOrigins):
- * xml/XMLTreeViewer.cpp:
- (WebCore::XMLTreeViewer::hasNoStyleInformation):
-
-2012-06-08 Kinuko Yasuda <kinuko@chromium.org>
-
- Using BlobBuilder should show a deprecation warning message (if it is enabled)
- https://bugs.webkit.org/show_bug.cgi?id=88644
-
- Reviewed by Jian Li.
-
- Mac has already disabled BlobBuilder, but Chromium still has it.
- We should start showing a warning to let people migrate to using Blob constructor.
-
- Tests: fast/files/blob-builder-crash.html
-
- * fileapi/WebKitBlobBuilder.cpp:
- (WebCore):
- (WebCore::WebKitBlobBuilder::create):
- * fileapi/WebKitBlobBuilder.h:
- (WebCore):
- (WebKitBlobBuilder):
- * fileapi/WebKitBlobBuilder.idl:
-
-2012-06-10 Sam Weinig <sam@webkit.org>
-
- Remove support for disconnected/excluded from search frames, they are not used by Safari anymore
- https://bugs.webkit.org/show_bug.cgi?id=88723
-
- Reviewed by Dan Bernstein.
-
- * WebCore.exp.in:
- Update export.
- * editing/Editor.cpp:
- (WebCore::Editor::rangeOfString):
- (WebCore::Editor::countMatchesForText):
- * editing/Editor.h:
- (Editor):
- * loader/FrameLoader.cpp:
- (WebCore::FrameLoader::findFrameForNavigation):
- * page/DOMWindow.cpp:
- (WebCore::DOMWindow::parent):
- (WebCore::DOMWindow::top):
- * page/EventHandler.cpp:
- (WebCore::EventHandler::hitTestResultAtPoint):
- * page/Frame.cpp:
- (WebCore::Frame::Frame):
- * page/Frame.h:
- (Frame):
- * page/FrameTree.cpp:
- (WebCore::FrameTree::parent):
- (WebCore::FrameTree::top):
- * page/FrameTree.h:
- (FrameTree):
- * page/Location.cpp:
- (WebCore::Location::ancestorOrigins):
- * xml/XMLTreeViewer.cpp:
- (WebCore::XMLTreeViewer::hasNoStyleInformation):
- Update for the removal of disconnected frames and text search exclusions concepts.
-
-2012-06-07 Kinuko Yasuda <kinuko@google.com>
-
- Move Quota related code out of DOMWindow and into the quota/ folder
- https://bugs.webkit.org/show_bug.cgi?id=88512
-
- Reviewed by Adam Barth.
-
- No new tests: no visible changes.
-
- * CMakeLists.txt:
- * DerivedSources.cpp:
- * DerivedSources.make:
- * DerivedSources.pri:
- * Modules/quota/DOMWindowQuota.cpp: Added.
- * Modules/quota/DOMWindowQuota.h: Added.
- * Modules/quota/DOMWindowQuota.idl: Added.
- * Modules/quota/StorageInfo.cpp: Renamed from Source/WebCore/storage/StorageInfo.cpp.
- * Modules/quota/StorageInfo.h: Renamed from Source/WebCore/storage/StorageInfo.h.
- * Modules/quota/StorageInfo.idl: Renamed from Source/WebCore/storage/StorageInfo.idl.
- * Modules/quota/StorageInfoErrorCallback.h: Renamed from Source/WebCore/storage/StorageInfoErrorCallback.h.
- * Modules/quota/StorageInfoErrorCallback.idl: Renamed from Source/WebCore/storage/StorageInfoErrorCallback.idl.
- * Modules/quota/StorageInfoQuotaCallback.h: Renamed from Source/WebCore/storage/StorageInfoQuotaCallback.h.
- * Modules/quota/StorageInfoQuotaCallback.idl: Renamed from Source/WebCore/storage/StorageInfoQuotaCallback.idl.
- * Modules/quota/StorageInfoUsageCallback.h: Renamed from Source/WebCore/storage/StorageInfoUsageCallback.h.
- * Modules/quota/StorageInfoUsageCallback.idl: Renamed from Source/WebCore/storage/StorageInfoUsageCallback.idl.
- * Target.pri:
- * WebCore.gyp/WebCore.gyp:
- * WebCore.gypi:
- * WebCore.pri:
- * WebCore.vcproj/WebCore.vcproj:
- * WebCore.vcproj/WebCoreCommon.vsprops:
- * WebCore.vcproj/copyForwardingHeaders.cmd:
- * WebCore.xcodeproj/project.pbxproj:
- * page/DOMWindow.cpp:
- * page/DOMWindow.h:
- * page/DOMWindow.idl:
-
-2012-06-10 Hayato Ito <hayato@chromium.org>
-
- An inheritance of '-webkit-user-modify' does not stop at shadow boundary.
- https://bugs.webkit.org/show_bug.cgi?id=88514
-
- Reviewed by Ryosuke Niwa.
-
- In StyleResolver::styleForElement(), we reset '-webkit-user-modify'
- CSS property after inheriting a parent style, but that is not
- enough. We also have to reset '-webkit-user-modify' when we use a
- cached result in applying matched properties.
-
- Test: fast/dom/shadow/user-modify-inheritance.html
-
- * css/StyleResolver.cpp:
- (WebCore::StyleResolver::applyMatchedProperties):
- (WebCore::StyleResolver::styleForElement):
- * css/StyleResolver.h:
- (StyleResolver):
- * rendering/style/RenderStyle.cpp:
- (WebCore::RenderStyle::inheritFrom):
- * rendering/style/RenderStyle.h:
-
-2012-06-10 Yoshifumi Inoue <yosin@chromium.org>
-
- [Forms] Introduce Decimal behind the InputNumber type
- https://bugs.webkit.org/show_bug.cgi?id=88383
-
- Reviewed by Kent Tamura.
-
- This patch introduces decimal arithmetic for steppable input types,
- e.g. date, datetime, number, range, and so on, to avoid rounding error
- caused by base 2 floating point representation, e.g. C/C++ double type.
-
- Most of decimal arithmetic calculations are implemented in StepRange
- class, replacing "double" with "Decimal", InputType::applyStep, and
- InputType::stepFromRenderer.
-
- Changes introduced by this patch are still intermediate state.
- Following patch will replace InputNumber type to Decimal type for
- completion of introducing decimal arithmetic.
-
- Test: fast/forms/range/range-value-rounding.html
-
- * html/BaseDateAndTimeInputType.cpp:
- (WebCore::BaseDateAndTimeInputType::serialize): Changed for Decimal type.
- (WebCore::BaseDateAndTimeInputType::serializeWithComponents): ditto.
- * html/DateInputType.cpp:
- (WebCore::DateInputType::createStepRange): Replaced NumberWithDecimalPlaces to InputNumber.
- * html/DateTimeInputType.cpp:
- (WebCore::DateTimeInputType::createStepRange): Replaced NumberWithDecimalPlaces to InputNumber.
- * html/DateTimeLocalInputType.cpp:
- (WebCore::DateTimeLocalInputType::createStepRange): Replaced NumberWithDecimalPlaces to InputNumber.
- * html/InputType.cpp:
- (WebCore::InputType::rangeUnderflow): Changed for Decimal type.
- (WebCore::InputType::rangeOverflow): Changed for Decimal type.
- (WebCore::InputType::minimum): Changed for Decimal type.
- (WebCore::InputType::maximum): ditto.
- (WebCore::InputType::isInRange): ditto.
- (WebCore::InputType::isOutOfRange): ditto.
- (WebCore::InputType::stepMismatch): ditto.
- (WebCore::InputType::validationMessage): ditto.
- (WebCore::InputType::parseToNumberOrNaN): ditto.
- (WebCore::InputType::applyStep): ditto.
- (WebCore::InputType::stepUpFromRenderer): ditto.
- * html/InputType.h:
- (InputType): Removed parseToNumberWIthDecimaplPlaces.
- * html/MonthInputType.cpp:
- (WebCore::MonthInputType::createStepRange): Changed for Decimal type.
- * html/NumberInputType.cpp:
- (WebCore::RealNumberRenderSize): Added for calculateRenderSize.
- (WebCore::calculateRenderSize): Added. This function replacess lengthBeforeDecimalPoint.
- (WebCore::NumberInputType::createStepRange): Changed for Decimal type.
- (WebCore::NumberInputType::sizeShouldIncludeDecoration): Changed to use calculateRenderSize.
- (WebCore::NumberInputType::parseToNumber): Changed for Decimal type.
- (WebCore::NumberInputType::serialize): ditto.
- * html/NumberInputType.h:
- (NumberInputType): Removed parseToNumberWIthDecimaplPlaces.
- * html/RangeInputType.cpp:
- (WebCore::RangeInputType::createStepRange): Changed for Decimal type.
- (WebCore::RangeInputType::handleKeydownEvent): ditto.
- (WebCore::RangeInputType::parseToNumber): ditto.
- (WebCore::RangeInputType::serialize): ditto.
- * html/StepRange.cpp:
- (WebCore::StepRange::StepRange): Removed decimal places and changed for Decimal type.
- (WebCore::StepRange::acceptableError): Changed for Decimal type.
- (WebCore::StepRange::alignValueForStep): ditto.
- (WebCore::StepRange::clampValue): Changed for Decimal type and std::min/max.
- (WebCore::StepRange::parseStep): Changed for Decimal type and removed NumberWithDecimalPlaces.
- (WebCore::StepRange::stepMismatch): Changed for Decimal type.
- (WebCore::convertDoubleToInputNumber): Changed to real implementation.
- (WebCore::convertInputNumberToDouble): Changed to real implementation.
- * html/StepRange.h:
- (InputNumber): Replacement of NumberWithDecimalPlaces.
- (WebCore::StepRange::InputNumber::InputNumber):
- * html/TimeInputType.cpp:
- (WebCore::TimeInputType::createStepRange): Changed for Decimal type.
- * html/WeekInputType.cpp:
- (WebCore::WeekInputType::createStepRange): Changed for Decimal type.
- * html/parser/HTMLParserIdioms.cpp:
- (WebCore::serializeForNumberType): Added Decimal version.
- (WebCore::parseToDecimalForNumberType): Added.
- * html/parser/HTMLParserIdioms.h: Updated comments for parseToDoubleForNumberType.
- * html/shadow/SliderThumbElement.cpp:
- (WebCore::sliderPosition): Changed for Decimal type.
-
-2012-06-10 Jason Liu <jason.liu@torchmobile.com.cn>
-
- [BlackBerry] Possible to clobber httponly cookie.
- https://bugs.webkit.org/show_bug.cgi?id=86067
-
- Reviewed by Rob Buis.
-
- If a cookie is set by javaScript and there is already a same httpOnly cookie in cookieManager,
- we should reject it. If it has a httpOnly property, we reject it, too.
-
- Test: http/tests/cookies/js-get-and-set-http-only-cookie.html
-
- * platform/blackberry/CookieJarBlackBerry.cpp:
- (WebCore::setCookies):
- * platform/blackberry/CookieManager.cpp:
- (WebCore::CookieManager::setCookies):
- (WebCore::CookieManager::checkAndTreatCookie):
- (WebCore::CookieManager::addCookieToMap):
- (WebCore::CookieManager::setPrivateMode):
- * platform/blackberry/CookieManager.h:
- * platform/blackberry/CookieMap.cpp:
- (WebCore::CookieMap::addOrReplaceCookie):
- (WebCore::CookieMap::removeCookie):
- * platform/blackberry/CookieMap.h:
- (CookieMap):
-
-2012-06-10 Pablo Flouret <pablof@motorola.com>
-
- Access control allow lists starting with a comma are parsed incorrectly (CORS)
- https://bugs.webkit.org/show_bug.cgi?id=88461
-
- Reviewed by Adam Barth.
-
- The parsing algorithm would stop parsing at the first comma (being an
- empty entry, of sorts) and bail out, effectively ignoring the whole
- header.
-
- Test: http/tests/xmlhttprequest/access-control-allow-lists-starting-with-comma.html
-
- * loader/CrossOriginPreflightResultCache.cpp:
- (WebCore::parseAccessControlAllowList):
-
-2012-06-10 Darin Adler <darin@apple.com>
-
- Some additional tweaks to keep TreeShared code simple/clean
- https://bugs.webkit.org/show_bug.cgi?id=88738
-
- Reviewed by Adam Barth.
-
- * platform/TreeShared.h: Make constructor and destructor both protected.
- It's slightly dangerous to have a public non-virtual destructor, and there
- is no reason it needs to be public.
- (WebCore::TreeShared::~TreeShared): Make debug-only destructor non-virtual;
- we were getting no value from it being virtual. Now that it's non-virtual,
- there is no need to use an #if on it since it's an empty inline destructor
- in non-debug builds.
-
-2012-06-06 Jer Noble <jer.noble@apple.com>
-
- REGRESSION: Setting invalid media "src" does not cause "error" event
- https://bugs.webkit.org/show_bug.cgi?id=88423
-
- Reviewed by Eric Carlson.
-
- Test: http/tests/media/video-src-invalid-error.html
-
- Two problems here. When the loadTimer is scheduled, the m_pendingLoadFlags
- variable is set to specify what type of load is scheduled. It is cleared
- when the loadTimer fires. But, when prepareForLoad() stops the loadTimer,
- it does not clear the m_pendingLoadFlags variable, so the next time
- scheduleLoad() is called (when the src is changed to an invalid URL)
- prepareForLoad() is not called again.
-
- Second problem: Due to a bug in QTKit (<rdar://problem/11606415>), the
- QTMovieLoadStateChangedNotification is never fired for an invalid http
- URL if QTMovieOpenAsyncRequiredAttribute:YES is not passed when creating
- the QTMovie.
-
- Add a new utility method which both stops the m_loadTimer and clears the
- m_pendingLoadFlags, and use it in all the places where m_loadTimer was
- stopped explicitly:
-
- * html/HTMLMediaElement.cpp:
- (WebCore::HTMLMediaElement::prepareForLoad):
- (WebCore::HTMLMediaElement::stopLoadTimer): Added
- (WebCore::HTMLMediaElement::userCancelledLoad):
- * html/HTMLMediaElement.h:
-
- And pass QTMovieOpenAsyncRequiredAttribute:YES when creating the QTMovie:
-
- * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
- (WebCore::MediaPlayerPrivateQTKit::commonMovieAttributes):
-
-2012-06-06 Jer Noble <jer.noble@apple.com>
-
- Add logging functions to MediaPlayerPrivateQTKit.
- https://bugs.webkit.org/show_bug.cgi?id=88425
-
- Reviewed by Eric Carlson.
-
- No new tests; adds logging functions to aide debugging.
-
- MediaPlayerPrivateQTKit should emit the same kind of logging messages as
- other MediaPlayerPrivate engines to aide in debugging.
-
- Distinguish between loadedRangesChanged() and loadStateChanged() for logging
- purposes:
- * platform/graphics/mac/MediaPlayerPrivateQTKit.h:
- * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
- (WebCore::MediaPlayerPrivateQTKit::loadedRangesChanged):
- (-[WebCoreMovieObserver loadedRangesChanged:]):
-
- Add LOG messages for each of the following functions:
- * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
- (WebCore::MediaPlayerPrivateQTKit::~MediaPlayerPrivateQTKit):
- (WebCore::MediaPlayerPrivateQTKit::createQTMovie):
- (WebCore::MediaPlayerPrivateQTKit::createQTMovieView):
- (WebCore::MediaPlayerPrivateQTKit::detachQTMovieView):
- (WebCore::MediaPlayerPrivateQTKit::createQTVideoRenderer):
- (WebCore::MediaPlayerPrivateQTKit::destroyQTVideoRenderer):
- (WebCore::MediaPlayerPrivateQTKit::createQTMovieLayer):
- (WebCore::MediaPlayerPrivateQTKit::destroyQTMovieLayer):
- (WebCore::MediaPlayerPrivateQTKit::setUpVideoRendering):
- (WebCore::MediaPlayerPrivateQTKit::tearDownVideoRendering):
- (WebCore::MediaPlayerPrivateQTKit::load):
- (WebCore::MediaPlayerPrivateQTKit::prepareToPlay):
- (WebCore::MediaPlayerPrivateQTKit::play):
- (WebCore::MediaPlayerPrivateQTKit::pause):
- (WebCore::MediaPlayerPrivateQTKit::seek):
- (WebCore::MediaPlayerPrivateQTKit::cancelSeek):
- (WebCore::MediaPlayerPrivateQTKit::setVolume):
- (WebCore::MediaPlayerPrivateQTKit::setRate):
- (WebCore::MediaPlayerPrivateQTKit::setPreservesPitch):
- (WebCore::MediaPlayerPrivateQTKit::cancelLoad):
- (WebCore::MediaPlayerPrivateQTKit::prepareForRendering):
- (WebCore::MediaPlayerPrivateQTKit::updateStates):
- (WebCore::MediaPlayerPrivateQTKit::loadStateChanged):
- (WebCore::MediaPlayerPrivateQTKit::rateChanged):
- (WebCore::MediaPlayerPrivateQTKit::sizeChanged):
- (WebCore::MediaPlayerPrivateQTKit::timeChanged):
- (WebCore::MediaPlayerPrivateQTKit::didEnd):
- (WebCore::MediaPlayerPrivateQTKit::clearMediaCache):
- (WebCore::MediaPlayerPrivateQTKit::clearMediaCacheForSite):
- (WebCore::MediaPlayerPrivateQTKit::disableUnsupportedTracks):
-
-2012-06-07 Jer Noble <jer.noble@apple.com>
-
- WebCore should use a single definition of an invalid media time.
- https://bugs.webkit.org/show_bug.cgi?id=88572
-
- Reviewed by Eric Carlson.
-
- No new tests; no change in functionality, so covered by existing tests.
-
- Add a new, universal definition for an invalid media time:
- * platform/graphics/MediaPlayer.h:
- (WebCore::MediaPlayer::invalidTime):
-
- Use this new definition instead of the hodge podge of (identical) local
- definitions for an invalid media time:
- * html/HTMLMediaElement.cpp:
- (WebCore::HTMLMediaElement::HTMLMediaElement):
- (WebCore::HTMLMediaElement::invalidateCachedTime):
- (WebCore::HTMLMediaElement::currentTime):
- (WebCore::HTMLMediaElement::initialTime):
- (WebCore::HTMLMediaElement::playbackProgressTimerFired):
- (WebCore::HTMLMediaElement::prepareMediaFragmentURI):
- (WebCore::HTMLMediaElement::applyMediaFragmentURI):
- * html/MediaFragmentURIParser.cpp:
- (WebCore::MediaFragmentURIParser::invalidTimeValue):
- (WebCore::MediaFragmentURIParser::MediaFragmentURIParser):
- (WebCore::MediaFragmentURIParser::startTime):
- (WebCore::MediaFragmentURIParser::endTime):
- (WebCore::MediaFragmentURIParser::parseTimeFragment):
- * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:
- (WebCore::MediaPlayerPrivateAVFoundation::MediaPlayerPrivateAVFoundation):
- (WebCore::MediaPlayerPrivateAVFoundation::duration):
- (WebCore::MediaPlayerPrivateAVFoundation::seeking):
- (WebCore::MediaPlayerPrivateAVFoundation::seekCompleted):
- (WebCore::MediaPlayerPrivateAVFoundation::invalidateCachedDuration):
- * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h:
- (MediaPlayerPrivateAVFoundation):
- * platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
- (WebCore::MediaPlayerPrivateAVFoundationObjC::platformDuration):
- * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
- (WebCore::MediaPlayerPrivateQTKit::duration):
- (WebCore::MediaPlayerPrivateQTKit::updateStates):
- (WebCore::MediaPlayerPrivateQTKit::timeChanged):
-
-2012-06-10 Darin Adler <darin@apple.com>
-
- Remove unneeded callRemovedLastRef function from TreeShared refactoring
- https://bugs.webkit.org/show_bug.cgi?id=88653
-
- Reviewed by Sam Weinig.
-
- * WebCore.exp.in: Updated to remove callRemovedLastRef and add removedLastRef.
-
- * dom/ContainerNode.cpp: Removed callRemovedLastRef, which is no longer
- needed and also had a bad cast in it.
-
- * dom/Document.h: Made removedLastRef private and non-virtual and made Node
- a friend so it can call the private function.
-
- * dom/Node.cpp:
- (WebCore::Node::removedLastRef): Moved here. This should not be an inline
- function. Added comments explaining why it should not be inlined. Also added
- explicit code to call to Document::removedLastRef, and added a comment why
- that's the right thing to do here.
- * dom/Node.h: Inherit from TreeShared<Node, ContainerNode>. Made the
- removedLastRef function non-virtual and removed it from the header file.
- Updated TreeShared using statements. Made the TreeShared template class a
- friend so it can call the private removedLastRef.
-
- * html/HTMLFormControlElement.h: Updated TreeShared using statements to specify
- Node instead, which accomplishes the same thing.
- * html/HTMLObjectElement.h: Ditto.
-
- * platform/TreeShared.h: Made TreeShared take two template arguments for the
- node type and the parent node type. Removed the callRemovedLastRef functions and
- the extra forward declarations it required. Removed the private unused
- removedLastRef function; not sure why it was left in here at all.
- (WebCore::TreeShared::deref): Call removedLastRef instead of callRemovedLastRef.
- (WebCore::TreeShared::setParent): Use ParentNodeType.
- (WebCore::TreeShared::parent): Ditto.
- (WebCore::adopted): Updated to have both template arguments.
-
- * svg/SVGElementInstance.cpp:
- (WebCore::SVGElementInstance::removedLastRef): Replaced callRemovedLastRef with
- this. Moved the body out of the header and added a comment explaining why the
- function should not be inlined.
- * svg/SVGElementInstance.h: Made removedLastRef non-virtual, non-inline, and
- private. Made TreeShared a friend so it can call the private removedLastRef.
- Updated TreeShared using statements.
-
-2012-06-10 Darin Adler <darin@apple.com>
-
- * WebCore.exp.in: Re-sorted and alphabetized the file.
-
-2012-06-10 Balazs Kelemen <kbalazs@webkit.org>
-
- [Qt][Win] Fix building Source/WebCore/plugins/win/PluginViewWin.cpp
- https://bugs.webkit.org/show_bug.cgi?id=88308
-
- Reviewed by Simon Hausmann.
-
- No new tests, just a build fix.
-
- Use ownerWindow() from page client. It has been
- introduced for x11 plugins to solve exactly the
- same problem.
-
- * plugins/win/PluginViewWin.cpp:
- (windowHandleForPageClient):
-
-2012-06-10 Balazs Kelemen <kbalazs@webkit.org>
-
- [Qt][Win] Fix building ImageQt.cpp
- https://bugs.webkit.org/show_bug.cgi?id=88306
-
- Reviewed by Simon Hausmann.
-
- No new tests, this is just a build fix.
-
- * platform/graphics/qt/ImageQt.cpp:
- (WebCore):
- (WebCore::BitmapImage::create):
- Adapt to the "API" changes in Qt.
-
-2012-06-09 Gregg Tavares <gman@google.com>
-
- Make WebGL mark draws for compositing even if the draw count is zero
- https://bugs.webkit.org/show_bug.cgi?id=88718
-
- Reviewed by Kenneth Russell.
-
- No new tests as no new functionality.
-
- * html/canvas/WebGLRenderingContext.cpp:
- (WebCore):
- (WebCore::WebGLRenderingContext::drawArrays):
- (WebCore::WebGLRenderingContext::drawElements):
-
-2012-06-09 Dominic Cooney <dominicc@chromium.org>
-
- [Chromium] Remove JavaScriptCore dependencies from gyp
- https://bugs.webkit.org/show_bug.cgi?id=88510
-
- Reviewed by Adam Barth.
-
- Chromium doesn't support JSC any more and there doesn't seem to be
- a strong interest in using GYP as the common build system in other
- ports.
-
- No new functionality => No new tests.
-
- * gyp/WebCore.gyp: Removed.
- * gyp/copy-forwarding-and-icu-headers.sh: Removed.
- * gyp/copy-inspector-resources.sh: Removed.
- * gyp/generate-derived-sources.sh: Removed.
- * gyp/generate-webcore-export-file-generator.sh: Removed.
- * gyp/gtk.gyp: Removed.
- * gyp/run-if-exists.sh: Removed.
- * gyp/streamline-inspector-source.sh: Removed.
- * gyp/update-info-plist.sh: Removed.
-
-2012-06-07 Darin Adler <darin@apple.com>
-
- Refactor and improve code style in TextResourceDecoder to prepare for buffering improvement
- https://bugs.webkit.org/show_bug.cgi?id=88566
-
- Reviewed by Alexey Proskuryakov.
-
- * loader/TextResourceDecoder.cpp:
- (WebCore::bytesEqual): Added helper function to make comparing against sequences of bytes
- easier to read at the call site.
- (WebCore::KanjiCode::judge): Changed to use bytesEqual in a few places, merged multiple if
- statements, got rid of else after goto.
- (WebCore::TextResourceDecoder::checkForCSSCharset): Changed to use early return instead of
- nesting the whole function. Changed to use bytesEqual.
- (WebCore::skipComment): Changed to use early return for more cases. Changed to use bytesEqual.
- (WebCore::TextResourceDecoder::checkForHeadCharset): Changed to use bytesEqual.
- (WebCore::TextResourceDecoder::decode): Changed to use emptyString() instead of "", since
- the former is more efficient.
-
-2012-06-09 Sheriff Bot <webkit.review.bot@gmail.com>
-
- Unreviewed, rolling out r118618 and r119353.
- http://trac.webkit.org/changeset/118618
- http://trac.webkit.org/changeset/119353
- https://bugs.webkit.org/show_bug.cgi?id=88720
-
- Caused at least 30 different crashes on ClusterFuzz (Requested
- by inferno-sec on #webkit).
-
- * loader/SubresourceLoader.cpp:
- (WebCore::SubresourceLoader::checkForHTTPStatusCodeError):
- * loader/cache/CachedCSSStyleSheet.cpp:
- (WebCore::CachedCSSStyleSheet::allClientsRemoved):
- * loader/cache/CachedFont.cpp:
- (WebCore::CachedFont::allClientsRemoved):
- * loader/cache/CachedFont.h:
- (WebCore::CachedFontClient::resourceClientType):
- * loader/cache/CachedImage.cpp:
- (WebCore::CachedImage::removeClientForRenderer):
- (WebCore):
- (WebCore::CachedImage::allClientsRemoved):
- (WebCore::CachedImage::lookupOrCreateImageForRenderer):
- * loader/cache/CachedImage.h:
- (CachedImage):
- (WebCore::CachedImageClient::resourceClientType):
- * loader/cache/CachedRawResource.cpp:
- (WebCore::CachedRawResource::allClientsRemoved):
- (WebCore):
- * loader/cache/CachedRawResource.h:
- (CachedRawResource):
- (WebCore::CachedRawResourceClient::resourceClientType):
- * loader/cache/CachedResource.cpp:
- (WebCore::CachedResource::removeClient):
- * loader/cache/CachedResource.h:
- (WebCore::CachedResource::allClientsRemoved):
- * loader/cache/CachedResourceClient.h:
- (WebCore::CachedResourceClient::resourceClientType):
- * loader/cache/CachedSVGDocument.h:
- (WebCore::CachedSVGDocumentClient::resourceClientType):
- * loader/cache/CachedScript.cpp:
- (WebCore::CachedScript::allClientsRemoved):
- * loader/cache/CachedStyleSheetClient.h:
- (WebCore::CachedStyleSheetClient::resourceClientType):
- * rendering/style/StyleCachedImage.cpp:
- (WebCore::StyleCachedImage::removeClient):
- * rendering/style/StyleCachedImageSet.cpp:
- (WebCore::StyleCachedImageSet::removeClient):
- * svg/graphics/SVGImageCache.cpp:
- (WebCore::SVGImageCache::~SVGImageCache):
- (WebCore::SVGImageCache::removeRendererFromCache):
- (WebCore::SVGImageCache::setRequestedSizeAndScales):
- (WebCore::SVGImageCache::requestedSizeAndScales):
- (WebCore::SVGImageCache::lookupOrCreateBitmapImageForRenderer):
- * svg/graphics/SVGImageCache.h:
- (WebCore):
- (SVGImageCache):
-
-2012-06-09 Florin Malita <fmalita@chromium.org>
-
- Fixed-position foreignObject descendants should be relative to the foreignObject viewport
- https://bugs.webkit.org/show_bug.cgi?id=88547
-
- Reviewed by Abhishek Arya.
-
- Tests: svg/foreignObject/fO-fixed-position-crash.html
- svg/foreignObject/fixed-position-expected.svg
- svg/foreignObject/fixed-position.svg
-
- Fixed position elements are currently registered with the top level
- RenderView even when embedded within an SVG foreignOject. This patch
- changes containingBlock() & container() to return the containing
- foreignObject renderer instead.
-
- The new foreignObject fixed position behavior matches that of current
- FireFox and Opera versions and is consistent with the spec:
- http://www.w3.org/TR/CSS2/visuren.html#fixed-positioning
- http://www.w3.org/TR/SVG/coords.html#EstablishingANewViewport
-
- * rendering/RenderObject.cpp:
- (WebCore::RenderObject::containingBlock):
- (WebCore::RenderObject::container):
-
-2012-06-09 Adam Barth <abarth@webkit.org>
-
- Can't use eval in iframes sanbdoxed via CSP header
- https://bugs.webkit.org/show_bug.cgi?id=88450
-
- Reviewed by Mihai Parparita.
-
- The initial empty document in a frame inherits the security context of
- its parent (including the CSP policy). When we load the real document,
- in some cases we'll do a "secure transition" to the new document. That
- means that we leave the global object in place in case the parent
- document has created any properties that it expects will be visible to
- the new document.
-
- If the parent document has a CSP policy that blocks eval, the "no eval"
- bit will be set on the global object of the initial document. When we
- perform a "secure transition" to the new document, we'll keep the bit,
- which is wrong. In this patch, we reset the bit by always enabling
- eval when clearing the context, regardless of whether we're performing
- a "secure transition".
-
- Test: http/tests/security/contentSecurityPolicy/iframe-inside-csp.html
-
- * bindings/js/ScriptController.cpp:
- (WebCore::ScriptController::enableEval):
- (WebCore):
- * bindings/js/ScriptController.h:
- (ScriptController):
- * bindings/v8/ScriptController.cpp:
- (WebCore::ScriptController::enableEval):
- (WebCore):
- (WebCore::ScriptController::disableEval):
- * bindings/v8/ScriptController.h:
- (ScriptController):
- * loader/FrameLoader.cpp:
- (WebCore::FrameLoader::clear):
-
-2012-06-09 Pablo Flouret <pablof@motorola.com>
-
- The value in Access-Control-Allow-Origin is not being matched correctly for CORS-enabled requests
- https://bugs.webkit.org/show_bug.cgi?id=88139
-
- Reviewed by Adam Barth.
-
- Compare a request's origin with the value given in any
- Access-Control-Allow-Origin headers in an exact, case-sensitive manner,
- instead of using SecurityOrigin::isSameSchemeHostPort(). Per step 3 of
- the resource sharing check algorithm in
- http://dvcs.w3.org/hg/cors/raw-file/tip/Overview.html#resource-sharing-check
-
- Test: http/tests/xmlhttprequest/origin-exact-matching.html
-
- * loader/CrossOriginAccessControl.cpp:
- (WebCore::passesAccessControlCheck):
-
-2012-06-09 Huang Dongsung <luxtella@company100.net>
-
- [Qt][Texmap] All layers with backingStore are opaque when using TextureMapperGL.
- https://bugs.webkit.org/show_bug.cgi?id=88703
-
- The bug originated from StillImage that is not override
- Image::currentFrameHasAlpha(), so it always returns false.
- StillImage is used by ImageBuffer, and if Texmap draws contents on ImageBuffer,
- TextureMapperBackingStore thinks contents does not have alpha.
-
- Covered by existing compositing tests.
-
- Reviewed by Noam Rosenthal.
-
- * platform/graphics/qt/StillImageQt.cpp:
- (WebCore::StillImage::currentFrameHasAlpha):
- (WebCore):
- * platform/graphics/qt/StillImageQt.h:
- (StillImage):
-
-2012-06-09 Victor Carbune <victor@rosedu.org>
-
- Basic support for timestamps within a TextTrackCue
- https://bugs.webkit.org/show_bug.cgi?id=88187
-
- Implemented support for timestamps within a TextTrackCue.
- This enables rendering functionality for Karaoke and Paint-on captions.
-
- Reviewed by Eric Carlson.
-
- Test: media/track/track-cue-rendering-inner-timestamps.html
-
- * css/mediaControls.css: Remove the background shadow pseudo-id and
- added two others, which can be further used for styling past / future
- contents of the cue.
- (video::-webkit-media-text-track-past-nodes): Used to style elements
- within the cue that are before the current movie time.
- (video::-webkit-media-text-track-future-nodes): Used to style elements
- within the cue that are after the current movie time.
- * html/HTMLMediaElement.cpp:
- (WebCore::HTMLMediaElement::updateActiveTextTrackCues): Regardless of whether
- the active set changed or not, the current cues need to be informed of the current
- movie time.
- * html/track/TextTrackCue.cpp:
- (WebCore::TextTrackCue::TextTrackCue): Initiliazed past and future containers.
- (WebCore::TextTrackCue::getCueAsHTML): Checked whether the current cue text has
- inner timestamps or not, in order to render faster if no timestamps are there.
- (WebCore::TextTrackCue::updateDisplayTree): Added method that keeps the past and future
- containers up to date, given a current movie time.
- (WebCore):
- (WebCore::TextTrackCue::getDisplayTree): Replaced the cue background container with the
- past cues container. The *internal* display tree of the cue now has two containers,
- representing past and future elements.
- * html/track/TextTrackCue.h: Added several variables to support the new functionality.
- (TextTrackCue):
- * html/track/WebVTTParser.cpp:
- (WebCore::WebVTTParser::constructTreeFromToken): Updated representation for this patch.
- * html/track/WebVTTParser.h:
- (WebVTTParser): Made public the collectTimeStamp method, as this is required for
- parsing timestamps within a cue as well.
-
-2012-06-09 Vsevolod Vlasov <vsevik@chromium.org>
-
- Web Inspector: Open links in Sources panel by default and fallback to Resources and Network panel otherwise.
- https://bugs.webkit.org/show_bug.cgi?id=88710
-
- Reviewed by Pavel Feldman.
-
- * inspector/front-end/inspector.js:
- (WebInspector.documentClick.followLink):
- (WebInspector.documentClick):
- (WebInspector._showAnchorLocation):
-
-2012-06-09 Vsevolod Vlasov <vsevik@chromium.org>
-
- Web Inspector: Only expand root domain in Sources/Scripts panel
- https://bugs.webkit.org/show_bug.cgi?id=88135
-
- Reviewed by Pavel Feldman.
-
- * inspector/front-end/NavigatorView.js:
- (WebInspector.NavigatorTreeOutline._treeElementsCompare.compare.typeWeight):
- (WebInspector.NavigatorTreeOutline._treeElementsCompare):
- (WebInspector.NavigatorFolderTreeElement.prototype.onattach):
-
-2012-06-09 Vsevolod Vlasov <vsevik@chromium.org>
-
- Web Inspector: Pretty print should respect text editor indent setting.
- https://bugs.webkit.org/show_bug.cgi?id=88713
-
- Reviewed by Pavel Feldman.
-
- * inspector/front-end/ScriptFormatter.js:
-
-2012-06-09 Dan Bernstein <mitz@apple.com>
-
- Fixed the build after r119895.
-
- * WebCore.xcodeproj/project.pbxproj:
-
-2012-06-09 Andrey Kosyakov <caseq@chromium.org>
-
- Web Inspector: [refactoring] rename TimelineVerticalOverview into TimelineFrameOverview
- https://bugs.webkit.org/show_bug.cgi?id=88708
-
- Reviewed by Vsevolod Vlasov.
-
- - rename TimelineVerticalOverview to TimelineFrameOverview;
- - rename associated fields, parameters, CSS classes etc;
- - rename overview mode designators to match the UI;
- - drop unused CSS rules for old-style mode selector;
-
- * inspector/front-end/TimelineOverviewPane.js:
- (WebInspector.TimelineOverviewPane):
- (WebInspector.TimelineOverviewPane.prototype._showEvents):
- (WebInspector.TimelineOverviewPane.prototype._showFrames):
- (WebInspector.TimelineOverviewPane.prototype._showMemoryGraph):
- (WebInspector.TimelineOverviewPane.prototype._setFrameMode):
- (WebInspector.TimelineOverviewPane.prototype._onCategoryVisibilityChanged):
- (WebInspector.TimelineOverviewPane.prototype._update):
- (WebInspector.TimelineOverviewPane.prototype.addFrame):
- (WebInspector.TimelineOverviewPane.prototype.zoomToFrame):
- (WebInspector.TimelineOverviewPane.prototype._reset):
- (WebInspector.TimelineOverviewPane.prototype._onWindowChanged):
- (WebInspector.TimelineFrameOverview):
- * inspector/front-end/TimelinePanel.js:
- (WebInspector.TimelinePanel):
- (WebInspector.TimelinePanel.prototype._shouldShowFrames):
- (WebInspector.TimelinePanel.prototype.revealRecordAt):
- * inspector/front-end/timelinePanel.css:
- (.timeline-frame-overview #timeline-overview-grid):
- (.timeline-frame-overview .timeline-overview-window):
- (.timeline-frame-overview .timeline-overview-dividers-background):
- (.timeline-frame-overview #timeline-overview-memory):
- (.timeline-frame-overview-status-bar-item.toggled-on .glyph):
- (.timeline-frame-overview-bars):
- (.timeline.timeline-frame-overview .resources-divider):
- (.sidebar-tree-item .timeline-frame-overview-status-bar-item):
-
-2012-06-08 Vsevolod Vlasov <vsevik@chromium.org>
-
- IndexedDB: Inspector should handle null, string, and array keyPaths
- https://bugs.webkit.org/show_bug.cgi?id=84303
-
- Reviewed by Pavel Feldman.
-
- Supported different key path types and updated tests to cover each case.
- Key path strings are now highlighted in the DataGrid column headers.
-
- * inspector/Inspector.json:
- * inspector/InspectorIndexedDBAgent.cpp:
- (WebCore):
- * inspector/front-end/IndexedDBModel.js:
- (WebInspector.IndexedDBModel.idbKeyPathFromKeyPath):
- (WebInspector.IndexedDBModel.keyPathStringFromIDBKeyPath):
- (WebInspector.IndexedDBModel.prototype._loadDatabase.callback):
- (WebInspector.IndexedDBModel.prototype._loadDatabase):
- (WebInspector.IndexedDBModel.ObjectStore.prototype.get keyPathString):
- (WebInspector.IndexedDBModel.Index.prototype.get keyPathString):
- * inspector/front-end/IndexedDBViews.js:
- (WebInspector.IDBDataView.prototype._createDataGrid):
- (WebInspector.IDBDataView.prototype._keyColumnHeaderFragment):
- (WebInspector.IDBDataView.prototype._keyPathStringFragment):
- (WebInspector.IDBDataGridNode.prototype.createCell):
- * inspector/front-end/ResourcesPanel.js:
- (WebInspector.IDBObjectStoreTreeElement.prototype._updateTooltip):
- (WebInspector.IDBIndexTreeElement.prototype._updateTooltip):
-
-2012-06-08 Vsevolod Vlasov <vsevik@chromium.org>
-
- Web Inspector: Increase size limits for resource content cached in InspectorResourceAgent.
- https://bugs.webkit.org/show_bug.cgi?id=88674
-
- Reviewed by Pavel Feldman.
-
- * inspector/NetworkResourcesData.cpp:
-
-2012-05-25 Vsevolod Vlasov <vsevik@chromium.org>
-
- Web Inspector: Limit DebuggerAgent.Location use to DebuggerModel only, introduce WebInspector.RawLocation to be used elsewhere.
- https://bugs.webkit.org/show_bug.cgi?id=87270
-
- Reviewed by Pavel Feldman.
-
- Introduced WebInspector.RawLocation interface, a generic raw location independent from concrete domain (Styles, Debugger).
- Made WebInspector.DebuggerModel.Location implement it and switched all debugger related methods to it.
-
- * inspector/front-end/BreakpointManager.js:
- (WebInspector.BreakpointManager.prototype._breakpointResolved):
- * inspector/front-end/CompilerScriptMapping.js:
- (WebInspector.CompilerScriptMapping.prototype.rawLocationToUILocation):
- * inspector/front-end/DebuggerModel.js:
- (WebInspector.DebuggerModel.Location):
- (WebInspector.DebuggerModel.prototype.continueToLocation):
- (WebInspector.DebuggerModel.prototype.setBreakpointByScriptLocation):
- (WebInspector.DebuggerModel.prototype.setBreakpoint.didSetBreakpoint):
- (WebInspector.DebuggerModel.prototype.setBreakpoint):
- (WebInspector.DebuggerModel.prototype.setBreakpointBySourceId):
- (WebInspector.DebuggerModel.prototype._breakpointResolved):
- (WebInspector.DebuggerModel.prototype.createRawLocation):
- (WebInspector.DebuggerModel.prototype.createRawLocationByURL):
- (WebInspector.DebuggerModel.prototype.setSelectedCallFrame):
- (WebInspector.DebuggerModel.prototype.createLiveLocation):
- (WebInspector.DebuggerModel.CallFrame.prototype.get location):
- (WebInspector.DebuggerModel.CallFrame.prototype.createLiveLocation):
- * inspector/front-end/DebuggerResourceBinding.js:
- (WebInspector.DebuggerResourceBinding.setScriptSource.didEditScriptSource):
- (WebInspector.DebuggerResourceBinding.setScriptSource):
- (WebInspector.DebuggerResourceBinding.prototype.setContent.get if):
- (WebInspector.DebuggerResourceBinding.prototype.setContent):
- (WebInspector.DebuggerResourceBinding.prototype._setContentWithInitialContent):
- * inspector/front-end/JavaScriptSource.js:
- (WebInspector.JavaScriptSource.prototype.uiLocationToRawLocation):
- * inspector/front-end/Linkifier.js:
- * inspector/front-end/ObjectPopoverHelper.js:
- (WebInspector.ObjectPopoverHelper.prototype._showObjectPopover.showObjectPopover.):
- (WebInspector.ObjectPopoverHelper.prototype._showObjectPopover):
- * inspector/front-end/PresentationConsoleMessageHelper.js:
- * inspector/front-end/RawSourceCode.js:
- * inspector/front-end/ResourceScriptMapping.js:
- (WebInspector.ResourceScriptMapping.prototype.rawLocationToUILocation):
- * inspector/front-end/Script.js:
- (WebInspector.Script.prototype.rawLocationToUILocation):
- * inspector/front-end/ScriptSnippetModel.js:
- (WebInspector.SnippetScriptMapping.prototype.rawLocationToUILocation):
- * inspector/front-end/SourceMapping.js:
- * inspector/front-end/UISourceCode.js:
- (WebInspector.RawLocation):
-
-2012-06-09 Eugene Klyuchnikov <eustas.bug@gmail.com>
-
- Web Inspector: Add message loop instrumentation to public API and timeline agent
- https://bugs.webkit.org/show_bug.cgi?id=88639
-
- Reviewed by Vsevolod Vlasov.
-
- Message loop instrumentation will show when the render thread is busy.
- That way developer can discover if a render thread business causes low fps, or not.
-
- * inspector/InspectorClient.h:
- (WebCore::InspectorClient::startMessageLoopMonitoring): Starts observer.
- (WebCore::InspectorClient::stopMessageLoopMonitoring): Stops observer.
- * inspector/InspectorController.cpp:
- (WebCore::InspectorController::InspectorController):
- Changed timeline agent constructor parameters.
- * inspector/InspectorInstrumentation.cpp:
- (WebCore::InspectorInstrumentation::willProcessTaskImpl):
- Forwards observer notification.
- (WebCore):
- (WebCore::InspectorInstrumentation::didProcessTaskImpl):
- Ditto.
- * inspector/InspectorInstrumentation.h:
- (InspectorInstrumentation):
- (WebCore::InspectorInstrumentation::willProcessTask):
- Ditto.
- (WebCore):
- (WebCore::InspectorInstrumentation::didProcessTask):
- Ditto.
- * inspector/InspectorTimelineAgent.cpp:
- (WebCore::InspectorTimelineAgent::start):
- Starts observer.
- (WebCore::InspectorTimelineAgent::stop):
- Stops observer.
- (WebCore::InspectorTimelineAgent::supportsFrameInstrumentation):
- Changed result origin.
- (WebCore::InspectorTimelineAgent::willProcessTask):
- Noop implementqation.
- (WebCore):
- (WebCore::InspectorTimelineAgent::didProcessTask):
- Noop implementqation.
- (WebCore::InspectorTimelineAgent::InspectorTimelineAgent):
- Changed constructor parameters.
- * inspector/InspectorTimelineAgent.h:
- (WebCore::InspectorTimelineAgent::create):
- Ditto.
- (InspectorTimelineAgent):
- * inspector/WorkerInspectorController.cpp:
- (WebCore::WorkerInspectorController::WorkerInspectorController):
- Changed timeline agent constructor parameters.
-
-2012-06-08 Andrey Kosyakov <caseq@chromium.org>
-
- Web Inspector: optimize timeline's frame mode overview appearance for 30fps
- https://bugs.webkit.org/show_bug.cgi?id=88556
-
- Reviewed by Vsevolod Vlasov.
-
- - adjust frame overview scale to 30fps == full height by default;
- - provide a fall-back auto-scale mode when median frame is longer than 1/30s;
- - add horizontal lines for 30 and 60fps;
- - drive-by fix: always use same order of categories in frame bars.
-
- * inspector/front-end/TimelineOverviewPane.js:
- (WebInspector.TimelineVerticalOverview.prototype.update):
- (WebInspector.TimelineVerticalOverview.prototype._aggregateFrames):
- (WebInspector.TimelineVerticalOverview.prototype._renderBars):
- (WebInspector.TimelineVerticalOverview.prototype._drawFPSMarks):
- (WebInspector.TimelineVerticalOverview.prototype._renderBar):
-
-
-2012-06-09 Sukolsak Sakshuwong <sukolsak@google.com>
-
- Add UNDO_MANAGER flag
- https://bugs.webkit.org/show_bug.cgi?id=87908
-
- Reviewed by Tony Chang.
-
- Add undoManager property to document behind the UNDO_MANAGER flag and
- add placeholders for some methods of undoManager.
-
- Test: editing/undomanager/document-has-undomanager.html
-
- * CMakeLists.txt:
- * Configurations/FeatureDefines.xcconfig:
- * DerivedSources.cpp:
- * DerivedSources.make:
- * DerivedSources.pri:
- * GNUmakefile.am:
- * GNUmakefile.list.am:
- * WebCore.gypi:
- * WebCore.xcodeproj/project.pbxproj:
- * dom/Document.cpp:
- (WebCore::Document::Document):
- (WebCore):
- (WebCore::Document::undoManager):
- * dom/Document.h:
- (WebCore):
- (Document):
- * dom/Document.idl:
- * editing/UndoManager.cpp: Added.
- (WebCore):
- (WebCore::UndoManager::create):
- (WebCore::UndoManager::UndoManager):
- (WebCore::UndoManager::undo):
- (WebCore::UndoManager::redo):
- (WebCore::UndoManager::clearUndo):
- (WebCore::UndoManager::clearRedo):
- * editing/UndoManager.h: Added.
- (WebCore):
- (UndoManager):
- * editing/UndoManager.idl: Added.
-
-2012-06-08 Levi Weintraub <leviw@chromium.org>
-
- RenderLayer::paintChildLayerIntoColumns doesn't properly pixel snap
- https://bugs.webkit.org/show_bug.cgi?id=88554
-
- Reviewed by Darin Adler.
-
- Column handling code in RenderLayer and RenderBlock was improperly clipping and translating
- using floats derived from FractionalLayoutUnits without pixel snapping. RenderLayer also
- improperly stored render tree offsets in ints instead of LayoutUnits. This corrects this
- issue.
-
- Test: fast/sub-pixel/column-clipping.html
-
- * rendering/RenderBlock.cpp:
- (WebCore::RenderBlock::paintColumnContents):
- * rendering/RenderLayer.cpp:
- (WebCore::RenderLayer::paintChildLayerIntoColumns):
-
-2012-06-08 Rakesh KN <rakesh.kn@motorola.com>
-
- REGRESSION(r116487?): HTMLFormElement::elements['name'] is empty if the form is detached from the document tree
- https://bugs.webkit.org/show_bug.cgi?id=88632
-
- Reviewed by Ryosuke Niwa.
-
- Update root node of RadioNodeList when the form element is detached from dom tree.
-
- Test: fast/forms/radionodelist-whose-form-element-detached-from-domtree.html
-
- * dom/Node.cpp:
- (WebCore::Node::resetCachedRadioNodeListRootNode):
- New function to update the root node of RadioNodeLists to form element from document.
- * dom/Node.h: Ditto.
- * html/HTMLFormElement.cpp:
- (WebCore::HTMLFormElement::removedFrom):
- On detach, we update the root node of all RadioNodeLists of this form element.
- * html/RadioNodeList.cpp:
- (WebCore::RadioNodeList::setRootElement):
- Setter for updating root node.
- * html/RadioNodeList.h:
- (RadioNodeList): Ditto.
-
-2012-06-08 David Reveman <reveman@chromium.org>
-
- [Chromium] Compositor doesn't support translucent root layers.
- https://bugs.webkit.org/show_bug.cgi?id=87821
-
- Reviewed by James Robinson.
-
- Forward the isTransparent WebView setting to WebLayerTreeView,
- CCLayerTreeHost and CCLayerTreeHostImpl as hasTransparentBackground.
- Use hasTransparentBackground setting to determine how to clear the
- root render pass and draw the background. Set opaque flag correctly
- on the NonCompositedContentHost's graphics layer to make sure
- sub-pixel rendering is not used with a transparent WebView.
-
- Unit tests: CCLayerTreeHostImplTest.hasTransparentBackground
- LayerRendererChromiumTest2.opaqueRenderPass
- LayerRendererChromiumTest2.transparentRenderPass
-
- * platform/graphics/chromium/BitmapCanvasLayerTextureUpdater.cpp:
- (WebCore::BitmapCanvasLayerTextureUpdater::prepareToUpdate):
- * platform/graphics/chromium/LayerRendererChromium.cpp:
- (WebCore::LayerRendererChromium::clearRenderPass):
- (WebCore::LayerRendererChromium::drawRenderPass):
- (WebCore::LayerRendererChromium::drawBackgroundFilters):
- * platform/graphics/chromium/LayerRendererChromium.h:
- (LayerRendererChromium):
- * platform/graphics/chromium/SkPictureCanvasLayerTextureUpdater.cpp:
- (WebCore::SkPictureCanvasLayerTextureUpdater::prepareToUpdate):
- * platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
- (WebCore::CCLayerTreeHost::CCLayerTreeHost):
- (WebCore::CCLayerTreeHost::finishCommitOnImplThread):
- * platform/graphics/chromium/cc/CCLayerTreeHost.h:
- (WebCore::CCLayerTreeHost::setHasTransparentBackground):
- (CCLayerTreeHost):
- * platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
- (WebCore::CCLayerTreeHostImpl::CCLayerTreeHostImpl):
- (WebCore::CCLayerTreeHostImpl::calculateRenderPasses):
- * platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:
- (WebCore::CCLayerTreeHostImpl::hasTransparentBackground):
- (WebCore::CCLayerTreeHostImpl::setHasTransparentBackground):
- (CCLayerTreeHostImpl):
- * platform/graphics/chromium/cc/CCRenderPass.cpp:
- (WebCore::CCRenderPass::CCRenderPass):
- * platform/graphics/chromium/cc/CCRenderPass.h:
- (WebCore::CCRenderPass::hasTransparentBackground):
- (WebCore::CCRenderPass::setHasTransparentBackground):
- (CCRenderPass):
-
-2012-06-08 Ian Vollick <vollick@chromium.org>
-
- [chromium] Single thread proxy's animation timer should short circuit if the layer renderer has not been initialized
- https://bugs.webkit.org/show_bug.cgi?id=88668
-
- Reviewed by James Robinson.
-
- Unit test: CCSingleThreadProxyTestDidAddAnimationBeforeInitializingLayerRenderer.runSingleThreaded
-
- * platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:
- * platform/graphics/chromium/cc/CCSingleThreadProxy.h:
-
-2012-06-08 Shezan Baig <shezbaig.wk@gmail.com>
-
- Caret is not rendered in empty inline contenteditable elements
- https://bugs.webkit.org/show_bug.cgi?id=85793
-
- Reviewed by Ryosuke Niwa.
-
- Override localCaretRect in RenderInline. The implementation was almost
- identical to localCaretRect in RenderBlock for empty block elements, so
- I refactored RenderBlock::localCaretRect and moved the logic to a new
- method 'localCaretRectForEmptyElement' in RenderBoxModelObject. The
- implementation of 'localCaretRect' in RenderBlock and RenderInline both
- use this helper method in RenderBoxModelObject.
-
- Tests: editing/selection/caret-in-empty-inline-1.html
- editing/selection/caret-in-empty-inline-2.html
-
- * rendering/RenderBlock.cpp:
- (WebCore::RenderBlock::localCaretRect):
- Modified to use RenderBoxModelObject::localCaretRectForEmptyElement.
- * rendering/RenderBoxModelObject.cpp:
- (WebCore::RenderBoxModelObject::localCaretRectForEmptyElement):
- (WebCore):
- * rendering/RenderBoxModelObject.h:
- (RenderBoxModelObject):
- Add localCaretRectForEmptyElement helper method.
- * rendering/RenderInline.cpp:
- (WebCore::RenderInline::localCaretRect):
- (WebCore):
- * rendering/RenderInline.h:
- (RenderInline):
- Override localCaretRect using localCaretRectForEmptyElement.
-
-2012-06-08 Mike West <mkwst@chromium.org>
-
- Treat blob: and filesystem: URLs generated via secure origins as secure.
- https://bugs.webkit.org/show_bug.cgi?id=84054
-
- Loading a blob: or filesystem: URL into an iframe or image that's
- contained on an HTTPS page shouldn't generate a mixed content warning.
- This change adds a SecurityOrigin::isSecure to check both against a
- URLs protocol, and the protocol of it's so-called "inner URL" if it's
- the type of URL that has such a thing. These sorts of URLs which are
- generated from secure sources will themselves be treated as secure.
-
- Reviewed by Adam Barth.
-
- Tests: http/tests/security/mixedContent/blob-url-in-iframe.html
- http/tests/security/mixedContent/filesystem-url-in-iframe.html
-
- * loader/FrameLoader.cpp:
- (WebCore::FrameLoader::isMixedContent):
- * page/SecurityOrigin.cpp:
- (WebCore):
- (WebCore::SecurityOrigin::isSecure):
- * page/SecurityOrigin.h:
- (SecurityOrigin):
-
-2012-06-08 Martin Robinson <mrobinson@igalia.com>
-
- [Cairo] [TextureMapperGL] Nvidia card does not update WebGL texture when interacting with canvas
- https://bugs.webkit.org/show_bug.cgi?id=87797
-
- Reviewed by Philippe Normand.
-
- No new tests. WebGL is already covered by WebGL tests and this
- bug is only present on certain hardware.
-
- After resolving multisampling before drawing the texture via the
- TextureMapper, first rebind the multisampling framebuffer. This ensures
- that the texture isn't active in two framebuffers at a time.
-
- * platform/graphics/cairo/GraphicsContext3DPrivate.cpp:
- (WebCore::GraphicsContext3DPrivate::paintToTextureMapper): Rebind the multisampling
- framebuffer.
-
-2012-06-08 Alexey Proskuryakov <ap@apple.com>
-
- <rdar://problem/11412294> Add appropriate iOS default font settings
-
- Reviewed by Dan Bernstein.
-
- * page/mac/SettingsMac.mm: (WebCore::Settings::initializeDefaultFontFamilies):
-
-2012-06-08 Charles Wei <charles.wei@torchmobile.com.cn>
-
- IndexedDB: Transactions without any request scheduled should abort itself.
- https://bugs.webkit.org/show_bug.cgi?id=88052
-
- Reviewed by Kentaro Hara.
-
- This is needed for indexedDB to make it work for JSC. We need to clean up all the
- pending transactions(transactions without any request scheduled) when leaving Javascript context.
-
- Manually tested using the existing test LayoutTests/storage/indexeddb/tutorial.html
-
- * bindings/js/JSMainThreadExecState.cpp:
- (WebCore):
- (WebCore::JSMainThreadExecState::didLeaveScriptContext):
- * bindings/js/JSMainThreadExecState.h:
- (WebCore::JSMainThreadExecState::~JSMainThreadExecState):
- (JSMainThreadExecState):
-
-2012-06-08 Ryosuke Niwa <rniwa@webkit.org>
-
- Crash in WebCore::CompositeEditCommand::breakOutOfEmptyListItem
- https://bugs.webkit.org/show_bug.cgi?id=88361
-
- Reviewed by Levi Weintraub.
-
- Use RefPtr instead of raw pointers across DOM mutations.
-
- No tests are added for the lack of a reliable reduction.
-
- * editing/CompositeEditCommand.cpp:
- (WebCore::CompositeEditCommand::breakOutOfEmptyListItem):
-
-2012-06-08 Sheriff Bot <webkit.review.bot@gmail.com>
-
- Unreviewed, rolling out r119514.
- http://trac.webkit.org/changeset/119514
- https://bugs.webkit.org/show_bug.cgi?id=88664
-
- Broke JSFiddle.net (Requested by arv on #webkit).
-
- * bindings/v8/V8DOMWindowShell.cpp:
- (WebCore::V8DOMWindowShell::initContextIfNeeded):
- * bindings/v8/WorkerContextExecutionProxy.cpp:
- (WebCore::WorkerContextExecutionProxy::initIsolate):
-
-2012-06-08 Ryosuke Niwa <rniwa@webkit.org>
-
- Crash in WebCore::InsertParagraphSeparatorCommand::doApply
- https://bugs.webkit.org/show_bug.cgi?id=88108
-
- Reviewed by Levi Weintraub.
-
- Use NodeVector instead of walking through siblings as we mutate the DOM.
-
- No new tests are added since there is no reliable reduction.
-
- * editing/BreakBlockquoteCommand.cpp:
- (WebCore::BreakBlockquoteCommand::doApply):
- * editing/CompositeEditCommand.cpp:
- (WebCore::CompositeEditCommand::moveRemainingSiblingsToNewParent):
- (WebCore):
- * editing/CompositeEditCommand.h:
- (CompositeEditCommand):
- * editing/InsertParagraphSeparatorCommand.cpp:
- (WebCore::InsertParagraphSeparatorCommand::doApply):
-
-2012-06-08 David Grogan <dgrogan@chromium.org>
-
- IndexedDB: rename some instances of open to registerFrontendCallbacks
- https://bugs.webkit.org/show_bug.cgi?id=88611
-
- We should still make the change in the WebKit API.
-
- Reviewed by Tony Chang.
-
- No new tests, just a method rename.
-
- * Modules/indexeddb/IDBDatabase.cpp:
- (WebCore::IDBDatabase::registerFrontendCallbacks):
- * Modules/indexeddb/IDBDatabase.h:
- (IDBDatabase):
- * Modules/indexeddb/IDBDatabaseBackendImpl.cpp:
- (WebCore::IDBDatabaseBackendImpl::registerFrontendCallbacks):
- * Modules/indexeddb/IDBDatabaseBackendImpl.h:
- (IDBDatabaseBackendImpl):
- * Modules/indexeddb/IDBDatabaseBackendInterface.h:
- (IDBDatabaseBackendInterface):
- * Modules/indexeddb/IDBRequest.cpp:
- (WebCore::IDBRequest::onSuccess):
-
-2012-06-08 Dana Jansens <danakj@chromium.org>
-
- [chromium] Skip willDraw() and didDraw() on fully occluded layers
- https://bugs.webkit.org/show_bug.cgi?id=88435
-
- Reviewed by Adrienne Walker.
-
- Current willDraw() is called on all layers with non-empty
- visibleLayerRect and non-empty scissorRect. This excludes
- layers outside the viewport, but does not exclude occluded
- layers. We add a check for occlusion to calculateRenderPasses
- in order to avoid willDraw() when it will be culled anyway.
-
- We prevent didDraw() from being called for occluded layers, for
- which we did not call didDraw() by holding a vector of layers
- for which we did call willDraw(). This lets us avoid storing a
- flag on the layers, or computing occlusion again in
- didDrawAllLayers.
-
- Unit test: CCLayerTreeHostImplTest.willDrawNotCalledOnOccludedLayer
-
- * platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
- (WebCore::CCLayerTreeHostImpl::calculateRenderPasses):
- (WebCore::CCLayerTreeHostImpl::prepareToDraw):
- (WebCore::CCLayerTreeHostImpl::didDrawAllLayers):
- * platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:
- (FrameData):
- (CCLayerTreeHostImpl):
-
-2012-06-08 Antonio Gomes <agomes@rim.com>
-
- EventHandler shouldn't schedule the fake mousemove event timer when scrolling on devices that don't have a mouse
- https://bugs.webkit.org/show_bug.cgi?id=88379
-
- Reviewed by James Robinson.
-
- Paraphrasing Andy Estes:
- "In <http://trac.webkit.org/changeset/119465> we stopped dispatching fake
- mousemove events when scrolling on devices that don't support mice. This event
- is dispatched on a timer, so one better would be to not even schedule the
- timer (rather than scheduling the timer but making it a no-op).
-
- No new tests, as no functionality has changed. We basically do not
- start a timer under a given circumstance instead of fire it, it times out,
- and we make the callback no-op when under the given circumstance.
-
- It is still possible though that we have the following scenario:
- - Setting::deviceSupportsMouse set as true;
- - we fire the timer;
- - before its callback gets executed (timed out) the setting gets toggled.
- So for sakeness, lets keep the check in both places.
-
- * page/EventHandler.cpp:
- (WebCore::EventHandler::dispatchFakeMouseMoveEventSoon):
- (WebCore::EventHandler::fakeMouseMoveEventTimerFired):
-
-2012-06-08 James Robinson <jamesr@chromium.org>
-
- [chromium] Clean up some unnecessary LayerChromium.h includes
- https://bugs.webkit.org/show_bug.cgi?id=88599
-
- Reviewed by Adam Barth.
-
- Reworks test code slightly to use WebCore interfaces.
-
- * testing/Internals.cpp:
- (WebCore::Internals::setBackgroundBlurOnNode):
-
-2012-06-08 Erik Arvidsson <arv@chromium.org>
-
- [V8] Keep TextTrackList alive as long as its owner is alive
- https://bugs.webkit.org/show_bug.cgi?id=88541
-
- Reviewed by Adam Barth.
-
- Add a hidden reference from the owner to the text track list.
-
- Covered by existing tests.
-
- * Target.pri: Add V8TextTrackListCustom.cpp.
- * UseV8.cmake: Ditto.
- * WebCore.gypi: Ditto.
- * bindings/v8/V8HiddenPropertyName.h:
- (WebCore):
- * bindings/v8/custom/V8TextTrackListCustom.cpp: Copied from Source/WebCore/bindings/v8/V8HiddenPropertyName.h.
- (WebCore):
- (WebCore::toV8): When the wrapper is created add a reference to the owner of the TextTrackList to the TextTrackList.
- * html/track/TextTrackList.idl:
-
-2012-06-08 Ian Vollick <vollick@chromium.org>
-
- [chromium] Accelerated animations should use WebTransformOperations
- https://bugs.webkit.org/show_bug.cgi?id=87686
-
- Reviewed by James Robinson.
-
- CCTransformKeyframe new owns a WebTransformOperations rather than a
- TransformOperations. LayerChromium's API has been changed so that
- LayerChromium::addAnimation should take only a CCActiveAnimation.
- GraphicsLayerChromium is new responsible for translating to
- WebTransformOperations and creating CCActiveAnimations. Tests that use
- the public API (that is, they call addAnimation with KeyframeValueList
- and Animation arguments) have been moved to GraphicsLayerChromiumTest.
-
- Unit tests:
- GraphicsLayerChromiumTest.createOpacityAnimation
- GraphicsLayerChromiumTest.createTransformAnimation
- GraphicsLayerChromiumTest.createTransformAnimationWithBigRotation
- GraphicsLayerChromiumTest.createTransformAnimationWithSingularMatrix
- GraphicsLayerChromiumTest.createReversedAnimation
- GraphicsLayerChromiumTest.createAlternatingAnimation
- GraphicsLayerChromiumTest.createReversedAlternatingAnimation
-
- * WebCore.gypi:
- * platform/graphics/chromium/AnimationTranslationUtil.cpp: Added.
- (WebCore):
- (WebCore::toWebTransformOperations):
- (WebCore::appendKeyframe):
- (WebCore::CCKeyframedTransformAnimationCurve):
- (WebCore::createActiveAnimation):
- * platform/graphics/chromium/AnimationTranslationUtil.h: Added.
- (WebCore):
- * platform/graphics/chromium/GraphicsLayerChromium.cpp:
- (WebCore::GraphicsLayerChromium::addAnimation):
- * platform/graphics/chromium/LayerChromium.cpp:
- (WebCore::LayerChromium::addAnimation):
- * platform/graphics/chromium/LayerChromium.h:
- (WebCore):
- (WebCore::LayerChromium::bounds):
- (LayerChromium):
- * platform/graphics/chromium/LinkHighlight.cpp:
- (WebCore::LinkHighlight::LinkHighlight):
- * platform/graphics/chromium/cc/CCAnimationCurve.h:
- (CCTransformAnimationCurve):
- * platform/graphics/chromium/cc/CCKeyframedAnimationCurve.cpp:
- (WebCore::CCTransformKeyframe::create):
- (WebCore::CCTransformKeyframe::CCTransformKeyframe):
- (WebCore::CCTransformKeyframe::value):
- (WebCore::CCTransformKeyframe::clone):
- (WebCore::CCKeyframedTransformAnimationCurve::getValue):
- * platform/graphics/chromium/cc/CCKeyframedAnimationCurve.h:
- (CCTransformKeyframe):
- (CCKeyframedTransformAnimationCurve):
- * platform/graphics/chromium/cc/CCLayerAnimationController.cpp:
- (WebCore::CCLayerAnimationController::removeAnimation):
- (WebCore):
- (WebCore::CCLayerAnimationController::addAnimation):
- (WebCore::CCLayerAnimationController::getActiveAnimation):
- (WebCore::CCLayerAnimationController::pushNewAnimationsToImplThread):
- (WebCore::CCLayerAnimationController::replaceImplThreadAnimations):
- (WebCore::CCLayerAnimationController::tickAnimations):
- * platform/graphics/chromium/cc/CCLayerAnimationController.h:
- (CCLayerAnimationControllerClient):
- (CCLayerAnimationController):
- * platform/graphics/chromium/cc/CCLayerImpl.h:
- (WebCore::CCLayerImpl::bounds):
-
-2012-06-08 No'am Rosenthal <noam.rosenthal@nokia.com>
-
- [Texmap] Accelerated versions of drop-shadow and blur filters
- https://bugs.webkit.org/show_bug.cgi?id=87695
-
- Reviewed by Kenneth Rohde Christiansen.
-
- Added shaders for blur and drop-shadow effects.
- The shaders use sampling of multiple coordinates and averaging them with normal-
- distribution to create a fast gaussian blur effect.
-
- Covered by existing tests in css3/filters.
-
- * platform/graphics/texmap/TextureMapperGL.cpp:
- (WebCore::TextureMapperGL::drawFiltered):
- Call the prepare function explicitly, with a size argument that's used to calculate
- some of the uniform values.
-
- * platform/graphics/texmap/TextureMapperLayer.cpp:
- (WebCore::TextureMapperLayer::intermediateSurfaceRect):
- The outsets of the effect have to be considered when calculating the intermediate rect.
- Otherwise the resulting image is scaled instead of outsetted.
-
- (WebCore::applyFilters):
- * platform/graphics/texmap/TextureMapperShaderManager.cpp:
- (WebCore::StandardFilterProgram::StandardFilterProgram):
- Added the new shaders.
-
- (WebCore::StandardFilterProgram::prepare):
- (WebCore::TextureMapperShaderManager::getShaderForFilter):
- * platform/graphics/texmap/TextureMapperShaderManager.h:
- (StandardFilterProgram):
-
-2012-06-08 Dan Bernstein <mitz@apple.com>
-
- Tried to fix the build after r119844.
-
- * bindings/js/GCController.cpp:
- (WebCore::GCController::discardAllCompiledCode):
-
-2012-06-08 Mike West <mkwst@chromium.org>
-
- Add COMPILE_ASSERT to StyledElement to ensure it doesn't accidentally grow larger.
- https://bugs.webkit.org/show_bug.cgi?id=88627
-
- Reviewed by Adam Barth.
-
- No change in user-facing behavior.
-
- * dom/StyledElement.cpp:
- (WebCore):
-
-2012-06-08 Vsevolod Vlasov <vsevik@chromium.org>
-
- Web Inspector: Fix several compiler warnings and errors.
- https://bugs.webkit.org/show_bug.cgi?id=88660
-
- Reviewed by Pavel Feldman.
-
- Fixed several compiler warnings and errors.
- Removed isEmpty method from Object.prototype and made it static method on Object.
-
- * inspector/InjectedScriptExterns.js:
- * inspector/front-end/FileSystemModel.js:
- (WebInspector.FileSystemModel.prototype._detachFrame):
- * inspector/front-end/HeapSnapshot.js:
- (WebInspector.HeapSnapshot.prototype._buildDominatorTree):
- * inspector/front-end/utilities.js:
- (Object.isEmpty):
-
-2012-06-08 Max Feil <mfeil@rim.com>
-
- [BlackBerry] Fix assertion failure introduced by bug 87551
- https://bugs.webkit.org/show_bug.cgi?id=88659
-
- Reviewed by Antonio Gomes.
-
- The determineRenderSlider() convenience function added in bug
- 87551 made an assumption that wasn't always true. This didn't
- cause a functional error but it caused an assertion failure,
- which indicates a problem with the code. PR164142.
-
- No new tests because this case is already covered by ASSERT's.
-
- * platform/blackberry/RenderThemeBlackBerry.cpp:
- (WebCore::determineRenderSlider):
-
-2012-06-08 Ion Rosca <rosca@adobe.com>
-
- Some overlay scrollbar API calls in ScrollAnimatorMac can lead to an assertion in RenderBox::mapAbsoluteToLocalPoint
- https://bugs.webkit.org/show_bug.cgi?id=74111
-
- Reviewed by Simon Fraser.
-
- Added zero-delay timer for AppKit scroll notification that can be called during layout.
- Manual test: ManualTests/scrollbar-crash-on-hide-scrolled-area.html
- This assertion does not fire when running layout tests. It can be easly reproduced using a debug build by loading the manual test page.
-
- * platform/mac/ScrollAnimatorMac.h:
- (ScrollAnimatorMac):
- * platform/mac/ScrollAnimatorMac.mm:
- (WebCore::ScrollAnimatorMac::ScrollAnimatorMac):
- (WebCore::ScrollAnimatorMac::notifyContentAreaScrolled):
- (WebCore::ScrollAnimatorMac::sendContentAreaScrolledSoon):
- (WebCore):
- (WebCore::ScrollAnimatorMac::sendContentAreaScrolledTimerFired):
-
-2012-06-08 Renata Hodovan <reni@webkit.org>
-
- Adding few already supported features to the FeatureSet in DOMImplementation
- https://bugs.webkit.org/show_bug.cgi?id=86482
-
- Text, Filter and View features are already implemented but they
- are not added to the SVG11 feature set. This is corrected in this patch.
-
- Reviewed by Nikolas Zimmermann.
-
- No new testcase is needed because we already have one what checks the svg features via
- DOMImplementation (svg/custom/svg-features.html).
-
- * dom/DOMImplementation.cpp:
- (WebCore::isSVG11Feature):
-
-2012-06-08 Stephen Chenney <schenney@chromium.org>
-
- WebCore::ImageBuffer.cpp has broken color table code
- https://bugs.webkit.org/show_bug.cgi?id=80321
-
- Reviewed by Dirk Schulze.
-
- The code in ImageBuffer::transformColorSpace had two problems that are
- fixed by this patch.
-
- First, it was using member variables for data
- that is static constant. This is incredibly wasteful, as every
- ImageBuffer that is created (and we make a lot of them) gets its own
- copy of the LUT and the table is initialized again and again. The
- patch replaces this with a static local, with lazy evaluation, in
- the method that uses the tables.
-
- Second, the code for filling the table was mapping 255 to 254, thus
- reducing the intensity and alpha of every image it pushed through a
- color transform.
-
- Test: svg/filters/color-space-conversion.svg
-
- * platform/graphics/ImageBuffer.cpp:
- (WebCore::ImageBuffer::transformColorSpace):
- * platform/graphics/ImageBuffer.h:
- (ImageBuffer):
-
-2012-06-08 Alexei Filippov <alexeif@chromium.org>
-
- Web Inspector: Better labels positioning on the memory pie chart
- https://bugs.webkit.org/show_bug.cgi?id=88652
-
- Reviewed by Vsevolod Vlasov.
-
- * inspector/front-end/NativeMemorySnapshotView.js:
- (WebInspector.NativeMemoryPieChart.prototype._paint.paintPercentAndLabel):
- (WebInspector.NativeMemoryPieChart.prototype._paint):
-
-2012-06-08 Bryan McQuade <bmcquade@google.com>
-
- Web Inspector: Annotate timeline records with a frame identifier
- https://bugs.webkit.org/show_bug.cgi?id=86406
-
- Reviewed by Vsevolod Vlasov.
-
- Tests: Updated existing layout tests.
-
- * inspector/InspectorController.cpp:
- (WebCore::InspectorController::InspectorController):
- * inspector/InspectorInstrumentation.cpp:
- (WebCore::frameForScriptExecutionContext):
- (WebCore):
- (WebCore::InspectorInstrumentation::didScheduleResourceRequestImpl):
- (WebCore::InspectorInstrumentation::didInstallTimerImpl):
- (WebCore::InspectorInstrumentation::didRemoveTimerImpl):
- (WebCore::InspectorInstrumentation::willCallFunctionImpl):
- (WebCore::InspectorInstrumentation::willChangeXHRReadyStateImpl):
- (WebCore::InspectorInstrumentation::willDispatchEventImpl):
- (WebCore::InspectorInstrumentation::willDispatchEventOnWindowImpl):
- (WebCore::InspectorInstrumentation::willEvaluateScriptImpl):
- (WebCore::InspectorInstrumentation::willFireTimerImpl):
- (WebCore::InspectorInstrumentation::willLayoutImpl):
- (WebCore::InspectorInstrumentation::willLoadXHRImpl):
- (WebCore::InspectorInstrumentation::willPaintImpl):
- (WebCore::InspectorInstrumentation::willRecalculateStyleImpl):
- (WebCore::InspectorInstrumentation::willSendRequestImpl):
- (WebCore::InspectorInstrumentation::willReceiveResourceDataImpl):
- (WebCore::InspectorInstrumentation::willReceiveResourceResponseImpl):
- (WebCore::InspectorInstrumentation::didFinishLoadingImpl):
- (WebCore::InspectorInstrumentation::didFailLoadingImpl):
- (WebCore::InspectorInstrumentation::domContentLoadedEventFiredImpl):
- (WebCore::InspectorInstrumentation::loadEventFiredImpl):
- (WebCore::InspectorInstrumentation::willWriteHTMLImpl):
- (WebCore::InspectorInstrumentation::didRequestAnimationFrameImpl):
- (WebCore::InspectorInstrumentation::didCancelAnimationFrameImpl):
- (WebCore::InspectorInstrumentation::willFireAnimationFrameImpl):
- * inspector/InspectorInstrumentation.h:
- (InspectorInstrumentation):
- (WebCore::InspectorInstrumentation::didScheduleResourceRequest):
- (WebCore::InspectorInstrumentation::didInstallTimer):
- (WebCore::InspectorInstrumentation::didRemoveTimer):
- (WebCore::InspectorInstrumentation::willCallFunction):
- (WebCore::InspectorInstrumentation::willChangeXHRReadyState):
- (WebCore::InspectorInstrumentation::willDispatchEvent):
- (WebCore::InspectorInstrumentation::willEvaluateScript):
- (WebCore::InspectorInstrumentation::willFireTimer):
- (WebCore::InspectorInstrumentation::willLayout):
- (WebCore::InspectorInstrumentation::willLoadXHR):
- (WebCore::InspectorInstrumentation::willPaint):
- (WebCore::InspectorInstrumentation::willRecalculateStyle):
- (WebCore::InspectorInstrumentation::willReceiveResourceData):
- (WebCore::InspectorInstrumentation::willReceiveResourceResponse):
- (WebCore::InspectorInstrumentation::willWriteHTML):
- (WebCore::InspectorInstrumentation::didRequestAnimationFrame):
- (WebCore::InspectorInstrumentation::didCancelAnimationFrame):
- (WebCore::InspectorInstrumentation::willFireAnimationFrame):
- * inspector/InspectorTimelineAgent.cpp:
- (WebCore::InspectorTimelineAgent::pushGCEventRecords):
- (WebCore::InspectorTimelineAgent::didBeginFrame):
- (WebCore::InspectorTimelineAgent::willCallFunction):
- (WebCore::InspectorTimelineAgent::willDispatchEvent):
- (WebCore::InspectorTimelineAgent::willLayout):
- (WebCore::InspectorTimelineAgent::willRecalculateStyle):
- (WebCore::InspectorTimelineAgent::willPaint):
- (WebCore::InspectorTimelineAgent::willComposite):
- (WebCore::InspectorTimelineAgent::willWriteHTML):
- (WebCore::InspectorTimelineAgent::didInstallTimer):
- (WebCore::InspectorTimelineAgent::didRemoveTimer):
- (WebCore::InspectorTimelineAgent::willFireTimer):
- (WebCore::InspectorTimelineAgent::willChangeXHRReadyState):
- (WebCore::InspectorTimelineAgent::willLoadXHR):
- (WebCore::InspectorTimelineAgent::willEvaluateScript):
- (WebCore::InspectorTimelineAgent::didScheduleResourceRequest):
- (WebCore::InspectorTimelineAgent::willSendResourceRequest):
- (WebCore::InspectorTimelineAgent::willReceiveResourceData):
- (WebCore::InspectorTimelineAgent::willReceiveResourceResponse):
- (WebCore::InspectorTimelineAgent::didFinishLoadingResource):
- (WebCore::InspectorTimelineAgent::didTimeStamp):
- (WebCore::InspectorTimelineAgent::didMarkDOMContentEvent):
- (WebCore::InspectorTimelineAgent::didMarkLoadEvent):
- (WebCore::InspectorTimelineAgent::didRequestAnimationFrame):
- (WebCore::InspectorTimelineAgent::didCancelAnimationFrame):
- (WebCore::InspectorTimelineAgent::willFireAnimationFrame):
- (WebCore::InspectorTimelineAgent::addRecordToTimeline):
- (WebCore::InspectorTimelineAgent::innerAddRecordToTimeline):
- (WebCore::InspectorTimelineAgent::didCompleteCurrentRecord):
- (WebCore::InspectorTimelineAgent::InspectorTimelineAgent):
- (WebCore::InspectorTimelineAgent::appendRecord):
- (WebCore::InspectorTimelineAgent::pushCurrentRecord):
- (WebCore::InspectorTimelineAgent::pushCancelableRecord):
- (WebCore::InspectorTimelineAgent::commitCancelableRecords):
- * inspector/InspectorTimelineAgent.h:
- (WebCore):
- (WebCore::InspectorTimelineAgent::create):
- (InspectorTimelineAgent):
- (WebCore::InspectorTimelineAgent::TimelineRecordEntry::TimelineRecordEntry):
- (TimelineRecordEntry):
- * inspector/WorkerInspectorController.cpp:
- (WebCore::WorkerInspectorController::WorkerInspectorController):
- * inspector/front-end/TimelinePresentationModel.js:
- (WebInspector.TimelinePresentationModel.isEventDivider):
- (WebInspector.TimelinePresentationModel.Record):
-
-2012-06-08 Sheriff Bot <webkit.review.bot@gmail.com>
-
- Unreviewed, rolling out r119821.
- http://trac.webkit.org/changeset/119821
- https://bugs.webkit.org/show_bug.cgi?id=88648
-
- Seems to have regression on Mac (Requested by kinuko on
- #webkit).
-
- * fileapi/File.cpp:
- (WebCore::File::File):
- (WebCore::File::lastModifiedDate):
- (WebCore::File::lastModifiedDateForBinding):
- (WebCore):
- (WebCore::File::captureSnapshot):
- * fileapi/File.h:
- (File):
- * fileapi/File.idl:
- * platform/FileMetadata.h:
- (WebCore::FileMetadata::FileMetadata):
- * platform/FileSystem.h:
- * platform/chromium/support/WebHTTPBody.cpp:
- (WebKit::WebHTTPBody::elementAt):
- * platform/network/BlobData.cpp:
- (WebCore):
- * platform/network/BlobData.h:
- (BlobDataItem):
- (WebCore::BlobDataItem::BlobDataItem):
- * platform/network/FormData.cpp:
- (WebCore::FormData::appendFile):
- * platform/network/cf/FormDataStreamCFNet.cpp:
- (WebCore::advanceCurrentStream):
- * platform/network/soup/ResourceHandleSoup.cpp:
- (WebCore::blobIsOutOfDate):
-
-2012-06-08 Kinuko Yasuda <kinuko@chromium.org>
-
- Unreviewed, removing duplicated entries in gyp.
-
- * WebCore.gypi:
-
-2012-06-08 Arko Saha <arko@motorola.com>
-
- Microdata: An element with an empty itemprop='' should not get listed in the .properties list.
- https://bugs.webkit.org/show_bug.cgi?id=88235
-
- Reviewed by Ryosuke Niwa.
-
- As per the specification change http://html5.org/r/6854, an element should be listed in .properties
- if the elelement has an attribute itemprop specified and the element has one or more property names.
-
- Test: fast/dom/MicroData/element-with-empty-itemprop.html
-
- * html/HTMLPropertiesCollection.cpp:
- (WebCore::HTMLPropertiesCollection::itemAfter):
-
-2012-06-07 Kinuko Yasuda <kinuko@chromium.org>
-
- File::lastModifiedDate should use NaN or separate boolean flag for null Date value
- https://bugs.webkit.org/show_bug.cgi?id=87826
-
- Reviewed by Kent Tamura.
-
- Test: http/tests/local/fileapi/file-last-modified-after-delete.html
-
- * fileapi/File.cpp:
- (WebCore::File::File):
- (WebCore::File::captureSnapshot):
- (WebCore::File::lastModifiedDate):
- (WebCore::File::lastModifiedDateForBinding): Removed.
- * fileapi/File.h:
- (File):
- * fileapi/File.idl:
- * platform/FileMetadata.h:
- (WebCore::FileMetadata::FileMetadata):
- * platform/FileSystem.h:
- * platform/chromium/support/WebHTTPBody.cpp:
- (WebKit::WebHTTPBody::elementAt):
- * platform/network/BlobData.h:
- (WebCore::BlobDataItem::doNotCheckFileChange): Removed.
- * platform/network/BlobData.cpp:
- * platform/network/cf/FormDataStreamCFNet.cpp:
- (WebCore::advanceCurrentStream):
- * platform/network/soup/ResourceHandleSoup.cpp:
- (WebCore::blobIsOutOfDate):
-
-2012-06-08 Kent Tamura <tkent@chromium.org>
-
- Move form-related functions of Document to FormController
- https://bugs.webkit.org/show_bug.cgi?id=88497
-
- Reviewed by Hajime Morita.
-
- A lot of files depend on Document.h. We had to build many files when we
- touched form-related features in Document.h or
- CheckedRadioButtons.h. This patch reduces such pain.
-
- No new tests. Just a refactoring.
-
- * CMakeLists.txt: Add FormController.cpp and/or FormController.h.
- * GNUmakefile.list.am: ditto.
- * Target.pri: ditto.
- * WebCore.gypi: ditto.
- * WebCore.vcproj/WebCore.vcproj: ditto.
- * WebCore.xcodeproj/project.pbxproj: ditto.
-
- * dom/Document.cpp: Removed form-releated features except the followings.
- (WebCore::Document::formController): Accessor for a FormController.
- (WebCore::Document::formElementsState):
- Just returns FormController::formElementsState().
- We don't create new FormController.
- (WebCore::Document::setStateForNewFormElements):
- Just returns FormController::setStateForNewFormElements().
- We don't create new FormController if the specified vector is empty.
- * dom/Document.h:
- Moved form-related functions to FormController.
-
- * html/FormController.cpp: Added. Moved from Document.cpp.
- * html/FormController.h: Added. Moved from Document.h
-
- * html/FormAssociatedElement.cpp: Use Document::formController().
- (WebCore::FormAssociatedElement::didMoveToNewDocument):
- (WebCore::FormAssociatedElement::insertedInto):
- (WebCore::FormAssociatedElement::removedFrom):
- (WebCore::FormAssociatedElement::formAttributeChanged):
- * html/HTMLFormControlElementWithState.cpp: Use Document::formController().
- (WebCore::HTMLFormControlElementWithState::HTMLFormControlElementWithState):
- (WebCore::HTMLFormControlElementWithState::~HTMLFormControlElementWithState):
- (WebCore::HTMLFormControlElementWithState::didMoveToNewDocument):
- (WebCore::HTMLFormControlElementWithState::finishParsingChildren):
- * html/HTMLFormElement.cpp: Use Document::formController().
- (WebCore::HTMLFormElement::didNotifyDescendantInsertions):
- (WebCore::HTMLFormElement::removedFrom):
- * html/HTMLInputElement.cpp: Use Document::formController().
- (WebCore::HTMLInputElement::~HTMLInputElement):
- (WebCore::HTMLInputElement::didMoveToNewDocument):
- (WebCore::HTMLInputElement::checkedRadioButtons):
- * html/HTMLInputElement.h:
- Declare CheckedRadioButtons. It was provided by Document.h.
- * html/parser/HTMLConstructionSite.h:
- Declare HTMLFormElement. It was provided by Document.h
-
-2012-06-08 Taiju Tsuiki <tzik@chromium.org>
-
- Add FileSystem item to storage tree.
- https://bugs.webkit.org/show_bug.cgi?id=72691
-
- Reviewed by Vsevolod Vlasov.
-
- * WebCore.gypi:
- * WebCore.vcproj/WebCore.vcproj:
- * inspector/compile-front-end.py:
- * inspector/front-end/FileSystemModel.js: Added.
- * inspector/front-end/Images/fileSystem.png: Added.
- * inspector/front-end/ResourcesPanel.js:
- (WebInspector.FileSystemListTreeElement):
- (WebInspector.FileSystemListTreeElement.prototype.onexpand):
- (WebInspector.FileSystemListTreeElement.prototype.onattach):
- (WebInspector.FileSystemListTreeElement.prototype._handleContextMenuEvent):
- (WebInspector.FileSystemListTreeElement.prototype._fileSystemAdded):
- (WebInspector.FileSystemListTreeElement.prototype._fileSystemRemoved):
- (WebInspector.FileSystemListTreeElement.prototype._fileSystemTreeElementByName):
- (WebInspector.FileSystemListTreeElement.prototype._refreshFileSystem):
- (WebInspector.FileSystemTreeElement):
- (WebInspector.FileSystemTreeElement.prototype.get fileSystemName):
- (WebInspector.FileSystemTreeElement.prototype.get itemURL):
- * inspector/front-end/Settings.js:
- (WebInspector.ExperimentsSettings):
- * inspector/front-end/WebKit.qrc:
- * inspector/front-end/inspector.html:
- * inspector/front-end/resourcesPanel.css:
- (.file-system-storage-tree-item .icon):
- * inspector/front-end/utilities.js:
-
-2012-06-08 Kentaro Hara <haraken@chromium.org>
-
- REGRESSION r119802: Remove unnecessary ASSERT(!m_deletionHasBegun) from Document.h
- https://bugs.webkit.org/show_bug.cgi?id=88528
-
- Reviewed by Ryosuke Niwa.
-
- m_deletionHasBegun should become true just before 'delete this'.
-
- No tests. No change in behavior.
-
- * dom/Document.h:
- (WebCore::Document::guardRef):
- (WebCore::Document::guardDeref):
-
-2012-06-08 Adam Barth <abarth@webkit.org>
-
- HTTP 204 No Content responses shouldn't trigger MIME type warnings in the web inspector
- https://bugs.webkit.org/show_bug.cgi?id=88603
-
- Reviewed by Pavel Feldman.
-
- A 204 response doesn't have an entity body, so its MIME type is kind of
- meaningless. We shouldn't spam the console with a warning about MIME
- types.
-
- * inspector/front-end/NetworkManager.js:
- (WebInspector.NetworkDispatcher.prototype._mimeTypeIsConsistentWithType):
-
-2012-06-08 Yoshifumi Inoue <yosin@chromium.org>
-
- [Forms] Drop StepRange::NumberWithDecimalPlacesOrMissing
- https://bugs.webkit.org/show_bug.cgi?id=88621
-
- Reviewed by Kent Tamura.
-
- This patch changes NumberWithDecimalPlacesOrMissing to NumberWithDecimalPlaces.
- We use NaN as indication of having value or not.
-
- No new tests, because this patch doesn't change behavior.
-
- * html/DateInputType.cpp:
- (WebCore::DateInputType::createStepRange): Replace NumberWithDecimalPlacesOrMissing to NumberWithDecimalPlaces.
- * html/DateTimeInputType.cpp:
- (WebCore::DateTimeInputType::createStepRange): ditto.
- * html/DateTimeLocalInputType.cpp:
- (WebCore::DateTimeLocalInputType::createStepRange): ditto.
- * html/MonthInputType.cpp:
- (WebCore::MonthInputType::createStepRange): ditto.
- * html/NumberInputType.cpp:
- (WebCore::NumberInputType::createStepRange): ditto.
- * html/RangeInputType.cpp:
- (WebCore::RangeInputType::createStepRange): ditto.
- * html/StepRange.cpp:
- (WebCore::StepRange::StepRange): Checks value is finite or not.
- (WebCore::StepRange::parseStep): Replace NumberWithDecimalPlacesOrMissing to NumberWithDecimalPlaces.
- * html/StepRange.h:
- (StepRange): Removed NumberWithDecimalPlacesOrMissing.
- * html/TimeInputType.cpp:
- (WebCore::TimeInputType::createStepRange): NumberWithDecimalPlacesOrMissing to NumberWithDecimalPlaces.
- * html/WeekInputType.cpp:
- (WebCore::WeekInputType::createStepRange): ditto.
-
-2012-06-08 Kentaro Hara <haraken@chromium.org>
-
- Unreviewed. Fixed a comment, pointed out by ap@.
-
- * platform/TreeShared.h:
- (WebCore):
-
-2012-06-08 Noel Gordon <noel.gordon@gmail.com>
-
- [chromium] WEBP image blue and red color channels reversed on Android
- https://bugs.webkit.org/show_bug.cgi?id=88613
-
- Reviewed by Kent Tamura.
-
- No new tests. Covered by test fast/images/webp-image-decoding.html though I'm
- not sure where/how the Androids run their layout tests.
-
- * platform/image-decoders/webp/WEBPImageDecoder.cpp:
- (outputMode): Detect little-endian Skia with a blue pixel shift (aka Android)
- which seems to be the way for them per bug 75861.
-
-2012-06-08 Ryosuke Niwa <rniwa@webkit.org>
-
- Remove the assertion that has been moved to TreeScope after r119802.
-
- * dom/Document.cpp:
- (WebCore::Document::removedLastRef):
-
-2012-06-07 Kentaro Hara <haraken@chromium.org>
-
- Reduce Node object size from 72 byte to 64 byte
- https://bugs.webkit.org/show_bug.cgi?id=88528
-
- Reviewed by Ryosuke Niwa.
-
- This patch removes all virtual methods from TreeShared.h,
- by which we can remove a virtual method table pointer (8 byte
- in a 64bit architechture) from each Node object. Consequently,
- this patch reduces the Node object size from 72 byte to 64 byte.
-
- e.g. The HTML spec (http://www.whatwg.org/specs/web-apps/current-work/)
- contains 325640 Node objects. Thus this patch saves 325640 * 8 byte = 2.6 MB.
-
- e.g. sizeof(Element) is reduced from 104 byte to 96 byte.
-
- - In multiple inheritance, a virtual method table pointer is allocated
- for each base class that has virtual methods. For example, for
- 'class A : public B, C {};' where B and C have virtual methods,
- two virtual method table pointers are allocated for each A object.
- In this patch, A = Node, B = EventTarget, and C = TreeShared.
- By removing the virtual methods from TreeShared, we can save the virtual
- method table pointer for TreeShared. 8 byte saving.
-
- - Node and SVGElementInstance are the only classes that inherit TreeShared.
-
- - This patch removes virtual TreeShared::removeLastRef() and implements
- virtual Node::removeLastRef() and virtual SVGElementInstance::removeLastRef().
- Node::removeLastRef() calls 'delete this' for 'this' of type Node*,
- and SVGElementInstance::removeLastRef() calls 'delete this' for 'this' of type
- SVGElementInstance*.
-
- - This patch removes the virtual destructor of TreeShared. This removal is safe
- because (1) no one calls 'delete this' for 'this' of type TreeShared*,
- and (2) both Node and SVGElementInstance have virtual destructor.
-
- No change in behavior. Confirm no regression in existing tests.
-
- * dom/ContainerNode.cpp:
- (WebCore::callRemovedLastRef):
- (WebCore):
- * dom/Node.h:
- (WebCore::Node::removedLastRef):
- * platform/TreeShared.h:
- (WebCore):
- (TreeShared):
- (WebCore::TreeShared::deref):
- * svg/SVGElementInstance.cpp:
- (WebCore::callRemovedLastRef):
- (WebCore):
- * svg/SVGElementInstance.h:
- (WebCore::SVGElementInstance::removedLastRef):
-
- * WebCore.order: Added a symbol for callRemovedLastRef().
- * WebCore.exp.in: Ditto.
-
-2012-06-07 Takashi Sakamoto <tasak@google.com>
-
- ShadowRoot needs resetStyleInheritance
- https://bugs.webkit.org/show_bug.cgi?id=84048
-
- Added resetStyleInheritance API to ShadowRoot. The spec URL is
- http://dvcs.w3.org/hg/webcomponents/raw-file/tip/spec/shadow/index.html#shadow-root-attributes
- To implement the API, modified StyleResolver to use empty style
- instead of parent style if resetStyleInheritance is true,
- and a node and its parent node are placed in different shadow trees.
-
- Reviewed by Hajime Morita.
-
- Test: fast/dom/shadow/shadow-root-resetStyleInheritance.html
- fast/dom/shadow/shadow-root-resetStyleInheritance-expected.html
-
- * css/StyleResolver.cpp:
- (WebCore::StyleResolver::initForStyleResolve):
- Set m_parentStyle to NULL when resetStyleInheritance.
- (WebCore::StyleResolver::documentSettings):
- Added a new method to obtain current document's settings.
- (WebCore::StyleResolver::initializeFontStyle):
- Initialize m_style by using document settings. Its code was move
- from the code initializing font style in applyProperty.
- (WebCore::StyleResolver::styleForElement):
- Initialize font style if m_parentStyle is NULL. The old code just
- used style() and don't touch font style. The new code uses the above
- initializeFontStyle.
- (WebCore::StyleResolver::applyProperty):
- Moved a code for initializing font style as "initial" to
- a new method: initializeFontStyle and modified to use the method.
- Modified to use documentSettings().
- (WebCore::StyleResolver::checkForGenericFamilyChange):
- Modified to use documentSettings().
- * css/StyleResolver.h:
- (WebCore::StyleResolver::documentSettings):
- (WebCore::StyleResolver::initializeFontStyle):
- Added two new methods to class StyleResolver.
- * dom/NodeRenderingContext.cpp:
- (WebCore::NodeRenderingContext::NodeRenderingContext):
- Modified to calculate m_resetStyleInheritance in its constructor.
- * dom/NodeRenderingContext.h:
- (WebCore::NodeRenderingContext::resetStyleInheritance):
- Implemented a new method, just returning m_resetStyleInheritance.
- * dom/ShadowRoot.cpp:
- (WebCore::ShadowRoot::setResetStyleInheritance):
- Modified to force to recalculate children's styles if
- resetStyleInheritance is changed.
- * dom/ShadowRoot.h:
- (ShadowRoot):
- Added resetStyleInheritance getter and setter.
- * dom/ShadowRoot.idl:
- Added an attribute, resetStyleInheritance.
- * dom/TreeScope.cpp:
- (WebCore::TreeScope::resetStyleInheritance):
- * dom/TreeScope.h:
- (TreeScope):
- Added resetStyleInheritance's default getter.
- The getter will be overrided by class ShadowRoot's getter.
-
-2012-06-07 Victor Carbune <victor@rosedu.org>
-
- addTextTrack should set track mode to HIDDEN
- https://bugs.webkit.org/show_bug.cgi?id=88317
-
- Reviewed by Eric Carlson.
-
- Updated existing test.
-
- * html/HTMLMediaElement.cpp:
- (WebCore::HTMLMediaElement::addTextTrack): Set the default parameters
- for the newly created TextTrack.
- * html/track/TextTrack.cpp:
- (WebCore::TextTrack::TextTrack):
-
-2012-06-07 Li Yin <li.yin@intel.com>
-
- FileAPI: Blob should support ArrayBufferView instead of ArrayBuffer for Constructor Parameters
- https://bugs.webkit.org/show_bug.cgi?id=88294
-
- Reviewed by Jian Li.
-
- From Spec: http://dev.w3.org/2006/webapi/FileAPI/#dfn-Blob
- Currently we add the support for ArrayBufferView, while still keeping ArrayBuffer for
- backward compatibility. We will remove it in the near future.
-
- Test: fast/files/blob-constructor.html
-
- * bindings/js/JSBlobCustom.cpp:
- (WebCore::JSBlobConstructor::constructJSBlob):
- * bindings/v8/custom/V8BlobCustom.cpp:
- (WebCore::V8Blob::constructorCallback):
- * fileapi/WebKitBlobBuilder.cpp:
- (WebCore::WebKitBlobBuilder::append):
- (WebCore):
- * fileapi/WebKitBlobBuilder.h:
- (WebCore):
- (WebKitBlobBuilder):
- * fileapi/WebKitBlobBuilder.idl: Add support for ArrayBufferView in append method
-
-2012-06-07 MORITA Hajime <morrita@google.com>
-
- A style in an older shadow subtree causes assert when composing with <shadow>
- https://bugs.webkit.org/show_bug.cgi?id=88299
-
- Reviewed by Dimitri Glazkov.
-
- InsertionPoint::attach() assumes its distributed content not being attach()-ed.
- But this assumption can break. This change added a guard for that.
- This can happen for shadow boundaries in general. But ShadowRoot already handles that case.
-
- Test: fast/dom/shadow/insertion-point-shadow-crash.html
-
- * html/shadow/InsertionPoint.cpp:
- (WebCore::InsertionPoint::attach):
-
-2012-06-07 Max Feil <mfeil@rim.com>
-
- [BlackBerry] Show correct fullscreen button image (media controls)
- https://bugs.webkit.org/show_bug.cgi?id=88563
-
- Reviewed by Antonio Gomes.
-
- PR159306: Show "exit" fullscreen button image instead of "enter"
- fullscreen button image when in fullscreen mode (HTML5 media
- controls).
-
- I am not providing a test due to the simplicity of this patch
- and the relative difficulty and maintainability issues associated
- with testing how an image is rendered.
-
- * platform/blackberry/RenderThemeBlackBerry.cpp:
- (WebCore::RenderThemeBlackBerry::paintMediaFullscreenButton):
-
-2012-06-07 Noel Gordon <noel.gordon@gmail.com>
-
- [chromium] Use WEBPImportPictureRGBX|BGRX to import picture data
- https://bugs.webkit.org/show_bug.cgi?id=88218
-
- Reviewed by Kent Tamura.
-
- Stop using the RGBA and RGBA variants of the picture import routines (since
- these will import alpha channel data in a future libwebp). Use the RGBX and
- BGRX variants to import picture data for encoding to make it clear that the
- alpha channel is (and must be) ignored.
-
- Test: fast/canvas/canvas-toDataURL-webp.html
-
- * platform/image-encoders/skia/WEBPImageEncoder.cpp:
- (WebCore::rgbPictureImport):
- (WebCore::importPictureBGRX): Use WEBPImportPictureBGRX for picture imports
- that must ignore the alpha channel. Change the template parameter to be the
- premultiplied alpha state of the input image data.
- (WebCore::importPictureRGBX): Use WEBPImportPictureRGBX, ditto.
- (WebCore::encodePixels): Invert the sense of the template parameter to make
- it now indicate the premultiplied alpha state of the input image data.
-
-2012-06-07 Takashi Sakamoto <tasak@google.com>
-
- Improve the performance of pushScope in StyleResolver
- https://bugs.webkit.org/show_bug.cgi?id=88222
-
- Reviewed by Hajime Morita.
-
- As setupScopeStack always sets m_scopeStackParent to be NULL,
- m_scopeStack is never reused. m_scopeStackParent should be the last
- element of m_scopeStack.
-
- No new tests, because fast/css/style-scoped/ uses pushScope,
- popScope and setupScopeStack and checks whether there exists
- any crash bug or not. And this patch doesn't change any behavior
- of scoped author syltes.
-
- * css/StyleResolver.cpp:
- (WebCore::StyleResolver::setupScopeStack):
- Modified to set m_scopeSackParent to be the last element of
- m_scopeStack.
- (WebCore::StyleResolver::popScope):
- Modified to remove the last element if m_scopeStack is not empty and
- the last element of m_scopeStack has the same scope as the scoping
- element given by the argument.
-
-2012-06-07 Mark Pilgrim <pilgrim@chromium.org>
-
- [Chromium] Move didStartWorkerRunLoop to Platform.h
- https://bugs.webkit.org/show_bug.cgi?id=88562
-
- Reviewed by Adam Barth.
-
- Part of a refactoring series. See tracking bug 82948.
-
- * WebCore.gyp/WebCore.gyp:
- * bindings/v8/WorkerScriptController.cpp:
- (WebCore::WorkerScriptController::~WorkerScriptController):
- * platform/chromium/PlatformSupport.h:
- (WebCore):
- * workers/WorkerThread.cpp:
- (WebCore::WorkerThread::workerThread):
-
-2012-06-07 Mike West <mkwst@chromium.org>
-
- Dropping m_startingLineNumber property from StyledElement.
- https://bugs.webkit.org/show_bug.cgi?id=86848
-
- Reviewed by Adam Barth.
-
- We can have the same effect by moving the line-number calculation
- directly into StyledElement::styleAttributeChanged. This means that
- subsequent changes to the style attribute (via script) won't generate
- error messages with line numbers, but that's an acceptable tradeoff.
-
- Behavior is covered by existing CSP tests.
-
- * dom/StyledElement.cpp:
- (WebCore::StyledElement::StyledElement):
- (WebCore::StyledElement::styleAttributeChanged):
- * dom/StyledElement.h:
- (WebCore::StyledElement::destroyInlineStyle):
-
-2012-06-07 Peter Beverloo <peter@chromium.org>
-
- Initialize m_document in AXObjectCache's constructor for !HAVE(ACCESSIBILITY) builds
- https://bugs.webkit.org/show_bug.cgi?id=88527
-
- Reviewed by Adam Barth.
-
- Initialize the m_document member with the passed on document in the stubbed
- AXObjectCache constructor. No behavioral changes.
-
- * accessibility/AXObjectCache.h:
- (WebCore::AXObjectCache::AXObjectCache):
-
-2012-06-05 James Robinson <jamesr@chromium.org>
-
- [chromium] Move deferral-related logic out of Canvas2DLayerChromium
- https://bugs.webkit.org/show_bug.cgi?id=86050
-
- Reviewed by Stephen White.
-
- This removes Canvas2DLayerChromium and puts the deferral and double-buffering related logic in a new class,
- Canvas2DLayerBridge, that uses TextureLayerChromium for compositing. The bridge is responsible for managing the
- front texture when double buffering is active, inserting the correct makeContextCurrent() and flush() calls on
- the GraphicsContext3D and SkCanvas when appropriate, and owning the lifetime of the layer.
-
- * WebCore.gypi:
- * platform/graphics/chromium/Canvas2DLayerBridge.cpp: Added.
- (WebCore):
- (AcceleratedDeviceContext):
- (WebCore::AcceleratedDeviceContext::AcceleratedDeviceContext):
- (WebCore::AcceleratedDeviceContext::prepareForDraw):
- (WebCore::Canvas2DLayerBridge::Canvas2DLayerBridge):
- (WebCore::Canvas2DLayerBridge::~Canvas2DLayerBridge):
- (WebCore::Canvas2DLayerBridge::skCanvas):
- (WebCore::Canvas2DLayerBridge::prepareTexture):
- (WebCore::Canvas2DLayerBridge::context):
- (WebCore::Canvas2DLayerBridge::layer):
- (WebCore::Canvas2DLayerBridge::contextAcquired):
- * platform/graphics/chromium/Canvas2DLayerBridge.h: Added.
- (WebCore):
- (Canvas2DLayerBridge):
- (WebCore::Canvas2DLayerBridge::create):
- * platform/graphics/chromium/Canvas2DLayerChromium.cpp: Removed.
- * platform/graphics/chromium/Canvas2DLayerChromium.h: Removed.
- * platform/graphics/chromium/GraphicsLayerChromium.cpp:
- * platform/graphics/chromium/ImageBufferDataSkia.h:
- (WebCore):
- (ImageBufferData):
- * platform/graphics/chromium/TextureLayerChromium.cpp:
- (WebCore::TextureLayerChromium::willModifyTexture):
- willModifyTexture() is called whenever the texture currently owned by the TextureLayerChromium will be
- modified by a system out of the compositor's control. It makes sure that the compositor does not attempt to
- draw with the potentially-modified texture until the next commit. For canvas, this is used when threading is
- enabled and a non-deferrable drawing command is invoked from JS.
- (WebCore):
- * platform/graphics/chromium/TextureLayerChromium.h:
- (TextureLayerChromium):
- * platform/graphics/chromium/cc/CCTextureUpdater.cpp:
- (WebCore::CCTextureUpdater::hasMoreUpdates):
- (WebCore::CCTextureUpdater::update):
- (WebCore::CCTextureUpdater::clear):
- * platform/graphics/chromium/cc/CCTextureUpdater.h:
- (CCTextureUpdater):
- * platform/graphics/skia/ImageBufferSkia.cpp:
- (WebCore::createAcceleratedCanvas):
- (WebCore::ImageBuffer::~ImageBuffer):
- (WebCore::ImageBuffer::context):
- (WebCore::ImageBuffer::platformLayer):
-
-2012-06-07 Patrick Gansterer <paroga@webkit.org>
-
- Remove HAVE(PATH_BASED_BORDER_RADIUS_DRAWING)
- https://bugs.webkit.org/show_bug.cgi?id=87931
-
- Reviewed by Beth Dakin.
-
- r62035 added HAVE(PATH_BASED_BORDER_RADIUS_DRAWING) until all ports implement
- GraphicsContext::clipConvexPolygon(). All major ports define HAVE_PATH_BASED_BORDER_RADIUS_DRAWING in the
- meantime and the alternative path has unnecessary maintainace costs and even don't compile at the moment.
-
- * rendering/RenderBoxModelObject.cpp:
- (WebCore::RenderBoxModelObject::drawBoxSideFromPath):
- * rendering/RenderObject.cpp:
- (WebCore::RenderObject::paintFocusRing):
- * rendering/RenderObject.h:
- (RenderObject):
-
-2012-06-06 Vincent Scheib <scheib@chromium.org>
-
- Add new Pointer Lock spec events webkitpointerlockchange and webkitpointerlockerror
- https://bugs.webkit.org/show_bug.cgi?id=88377
-
- Reviewed by Dimitri Glazkov.
-
- Part of a series of refactoring changes to update pointer lock API to
- the fullscreen locking style. https://bugs.webkit.org/show_bug.cgi?id=84402
-
- New change and error events added. Follow up patches will remove
- the previous callbacks and pointerlocklost event. Tests updated
- to include the new events, and a new test added specifically for
- the new events, pointerlockchange-pointerlockerror-events.html.
-
- Test: pointer-lock/pointerlockchange-pointerlockerror-events.html
-
- * dom/Document.h:
- (Document):
- * dom/Document.idl:
- * dom/EventNames.h:
- (WebCore):
- * page/PointerLockController.cpp:
- (WebCore::PointerLockController::requestPointerLock):
- (WebCore::PointerLockController::didAcquirePointerLock):
- (WebCore::PointerLockController::didNotAcquirePointerLock):
- (WebCore::PointerLockController::didLosePointerLock):
- (WebCore::PointerLockController::enqueueEvent):
- (WebCore):
- * page/PointerLockController.h:
- (PointerLockController):
-
-2012-06-07 Sheriff Bot <webkit.review.bot@gmail.com>
-
- Unreviewed, rolling out r119744.
- http://trac.webkit.org/changeset/119744
- https://bugs.webkit.org/show_bug.cgi?id=88584
-
- Fails assertions in debug builds (Requested by jamesr_ on
- #webkit).
-
- * platform/graphics/chromium/cc/CCIOSurfaceLayerImpl.cpp:
- (WebCore::CCIOSurfaceLayerImpl::~CCIOSurfaceLayerImpl):
- (WebCore::CCIOSurfaceLayerImpl::willDraw):
-
-2012-06-07 Julien Chaffraix <jchaffraix@webkit.org>
-
- Cache RenderLayer::isRootLayer for better performance
- https://bugs.webkit.org/show_bug.cgi?id=88570
-
- Reviewed by Ojan Vafai.
-
- Caching covered by existing tests.
-
- RenderLayer::isRootLayer()'s answer will be the same during the RenderLayer's
- lifetime as a RenderLayer is tied to a RenderBoxModelObject. This change caches
- isRootLayer value in the constructor.
-
- On http://dglazkov.github.com/performance-tests/biggrid.html with a 100,000 rows
- by 100 columns table, it saves about 10% on the paint time during scrolling on
- my machine (going from 50ms to 45ms). It would expect all code paths to see some
- improvement as checking renderer()->isRenderView() was pretty common.
-
- * rendering/RenderLayer.cpp:
- (WebCore::RenderLayer::RenderLayer):
- Added code to cache the result of renderer()->isRenderView() here.
-
- (WebCore::RenderLayer::stackingContext):
- (WebCore::isPositionedContainer):
- (WebCore::isFixedPositionedContainer):
- (WebCore::RenderLayer::enclosingTransformedAncestor):
- (WebCore::RenderLayer::clippingRootForPainting):
- (WebCore::shouldSuppressPaintingLayer):
- (WebCore::RenderLayer::hitTest):
- (WebCore::RenderLayer::intersectsDamageRect):
- * rendering/RenderLayer.h:
- (WebCore::RenderLayer::isStackingContext):
- Updated all the call sites to use isRootLayer() instead of renderer()->isRenderView()
- as it is faster.
-
- (WebCore::RenderLayer::isRootLayer):
- Added our caching here. Also made m_canSkipRepaintRectsUpdateOnScroll to follow
- m_isRootLayer example.
-
-2012-06-07 Takashi Sakamoto <tasak@google.com>
-
- Incorrect border rendering when border radius is above 2px.
- https://bugs.webkit.org/show_bug.cgi?id=88046
-
- Fixing findInnerVertex's logic to decide which is the better line
- to find an inner vertex, x=center point's x of a rendering box or
- y=center point's y of a rendering box.
-
- Reviewed by Simon Fraser.
-
- Test: fast/borders/border-radius-valid-border-clipping.html
-
- * rendering/RenderBoxModelObject.cpp:
- (WebCore::findInnerVertex):
-
-2012-06-07 Edaena Salinas Jasso <edaena@apple.com>
-
- Should fire error event for empty 404 script
- https://bugs.webkit.org/show_bug.cgi?id=50589
-
- Reviewed by Brady Eidson.
-
- Tests:
- http/tests/loading/fire-error-event-empty-404-script.html
- http/tests/loading/fire-error-script-no-content-type.html
-
- * loader/SubresourceLoader.cpp:
- (WebCore::SubresourceLoader::didReceiveResponse): We should check for http status
- codes here to stop depending on the response being non-empty.
- (WebCore::SubresourceLoader::didReceiveData): Moved the http status check but
- avoid messing with multipart responses.
- (WebCore::SubresourceLoader::checkForHTTPStatusCodeError): Renamed from
- errorLoadingResource for clarity.
-
- * loader/SubresourceLoader.h:
- * loader/cf/SubresourceLoaderCF.cpp:
- (WebCore::SubresourceLoader::didReceiveDataArray):
- Updated for errorLoadingResource renaming.
-
-2012-06-07 Konrad Piascik <kpiascik@rim.com>
-
- [BlackBerry] Update PlayBook's User Agent String for Web Inspector
- https://bugs.webkit.org/show_bug.cgi?id=88543
-
- Reviewed by Antonio Gomes.
-
- We expect users to upgrade their devices so developers only need the latest UA String.
-
- No tests needed.
-
- * inspector/front-end/SettingsScreen.js:
- (WebInspector.SettingsScreen.prototype._createUserAgentSelectRowElement.get const):
-
-2012-06-07 Shawn Singh <shawnsingh@chromium.org>
-
- [chromium] Remove obsolete FIXME comment about a layer sorting bug.
- https://bugs.webkit.org/show_bug.cgi?id=88546
-
- Reviewed by James Robinson.
-
- No tests needed, only comment changed. The comment referred to a
- potential bug that actually will not occur. The W3C spec on CSS 3d
- transforms indicates that layers that do not share the same "3d
- rendering context" do not sort together, and our existing code
- sorts this way already.
-
- * platform/graphics/chromium/cc/CCLayerTreeHostCommon.cpp:
- (WebCore::subtreeShouldRenderToSeparateSurface):
-
-2012-06-07 Adam Barth <abarth@webkit.org>
-
- Settings::defaultDeviceScaleFactor is redundant with Page::deviceScaleFactor
- https://bugs.webkit.org/show_bug.cgi?id=88375
-
- Reviewed by James Robinson.
-
- This patch removes Settings::defaultDeviceScaleFactor because it is
- redundant with Page::deviceScaleFactor now that we no longer support
- target-densitydpi. Page::deviceScaleFactor is the canonical place to
- store the device scale factor.
-
- * WebCore.exp.in:
- * page/Settings.cpp:
- (WebCore::Settings::Settings):
- (WebCore):
- * page/Settings.h:
- (Settings):
- * testing/InternalSettings.cpp:
- (WebCore::InternalSettings::setDeviceScaleFactor):
-
-2012-06-07 Alec Flett <alecflett@chromium.org>
-
- IndexedDB: Error codes, phase one
- https://bugs.webkit.org/show_bug.cgi?id=88459
-
- Reviewed by Tony Chang.
-
- This phase gets rid of the now-deprecated NOT_ALLOWED_ERR and
- NON_TRANSIENT_ERR from earlier versions of the spec, and
- normalizes the place where TypeError should be thrown so that it's
- easier to update when the bindings change.
-
- No new tests: existing tests cover these changes and have been updated.
-
- * Modules/indexeddb/IDBCursor.cpp:
- (WebCore::IDBCursor::advance):
- (WebCore::IDBCursor::continueFunction):
- (WebCore::IDBCursor::stringToDirection):
- (WebCore::IDBCursor::directionToString):
- * Modules/indexeddb/IDBCursorBackendImpl.cpp:
- (WebCore::IDBCursorBackendImpl::update):
- (WebCore::IDBCursorBackendImpl::deleteFunction):
- * Modules/indexeddb/IDBDatabase.cpp:
- (WebCore::IDBDatabase::createObjectStore):
- (WebCore::IDBDatabase::deleteObjectStore):
- (WebCore::IDBDatabase::setVersion):
- (WebCore::IDBDatabase::transaction):
- * Modules/indexeddb/IDBDatabaseBackendImpl.cpp:
- (WebCore::IDBDatabaseBackendImpl::createObjectStore):
- (WebCore::IDBDatabaseBackendImpl::deleteObjectStore):
- (WebCore::IDBDatabaseBackendImpl::setVersion):
- * Modules/indexeddb/IDBDatabaseException.cpp:
- (WebCore):
- * Modules/indexeddb/IDBDatabaseException.h:
- * Modules/indexeddb/IDBDatabaseException.idl:
- * Modules/indexeddb/IDBFactory.cpp:
- (WebCore::IDBFactory::open):
- (WebCore::IDBFactory::deleteDatabase):
- * Modules/indexeddb/IDBObjectStore.cpp:
- (WebCore::IDBObjectStore::index):
- * Modules/indexeddb/IDBObjectStoreBackendImpl.cpp:
- (WebCore::IDBObjectStoreBackendImpl::createIndex):
- (WebCore::IDBObjectStoreBackendImpl::deleteIndex):
- * Modules/indexeddb/IDBRequest.cpp:
- (WebCore::IDBRequest::result):
- (WebCore::IDBRequest::errorCode):
- (WebCore::IDBRequest::webkitErrorMessage):
- * Modules/indexeddb/IDBTransaction.cpp:
- (WebCore::IDBTransaction::objectStore):
- (WebCore::IDBTransaction::stringToMode):
- (WebCore::IDBTransaction::modeToString):
- * Modules/indexeddb/IDBTransactionBackendImpl.cpp:
- (WebCore::IDBTransactionBackendImpl::objectStore):
-
-2012-06-07 Dana Jansens <danakj@chromium.org>
-
- [chromium] Free texture from CCIOSurfaceLayerImpl when it is destroyed
- https://bugs.webkit.org/show_bug.cgi?id=88371
-
- Reviewed by James Robinson.
-
- Unit test: CCLayerTreeHostImplTest.layersFreeTextures
-
- * platform/graphics/chromium/cc/CCIOSurfaceLayerImpl.cpp:
- (WebCore::CCIOSurfaceLayerImpl::~CCIOSurfaceLayerImpl):
- (WebCore::CCIOSurfaceLayerImpl::willDraw):
-
-2012-06-07 Peter Beverloo <peter@chromium.org>
-
- Buildfix for ENABLE_OVERFLOW_SCROLLING=0 (though defined)
- https://bugs.webkit.org/show_bug.cgi?id=88564
-
- Reviewed by Adam Barth.
-
- Where ENABLE(X) mandates that X both has to be defined and evaluates to
- true as a lone preprocessor statement, there were two places in the CSS
- property and value input files where only was checked whether is has
- been defined. This also goes against other #ifdefs in those files.
-
- * css/CSSPropertyNames.in:
- * css/CSSValueKeywords.in:
-
-2012-06-07 Ami Fischman <fischman@chromium.org>
-
- Plumb CORS attribute information from HTMLMediaElement to media players so it can be used
- https://bugs.webkit.org/show_bug.cgi?id=88349
-
- Reviewed by Adam Barth.
-
- Test: http/tests/security/video-cross-origin-readback.html
-
- * html/HTMLMediaElement.cpp:
- (WebCore::HTMLMediaElement::mediaPlayerCORSMode):
- (WebCore):
- * html/HTMLMediaElement.h:
- (HTMLMediaElement):
- * html/canvas/CanvasRenderingContext.cpp:
- (WebCore::CanvasRenderingContext::wouldTaintOrigin):
- * platform/graphics/MediaPlayer.cpp:
- (WebCore::MediaPlayer::didPassCORSAccessCheck):
- (WebCore):
- * platform/graphics/MediaPlayer.h:
- (WebCore::MediaPlayerClient::mediaPlayerCORSMode):
- (MediaPlayer):
- * platform/graphics/MediaPlayerPrivate.h:
- (WebCore::MediaPlayerPrivateInterface::didPassCORSAccessCheck):
- (MediaPlayerPrivateInterface):
-
-2012-06-07 Mark Hahnenberg <mhahnenberg@apple.com>
-
- Worker tear-down can re-enter JSC during GC finalization
- https://bugs.webkit.org/show_bug.cgi?id=88449
-
- Reviewed by Geoffrey Garen.
-
- No new tests.
-
- This is the first of two patches to fix this issue with Workers.
-
- * workers/AbstractWorker.cpp:
- (WebCore::AbstractWorker::~AbstractWorker): We don't need to call onDestroyWorker() here, it
- will be called elsewhere in contextDestroyed().
-
-2012-06-07 Jer Noble <jer.noble@apple.com>
-
- sometimes all slaved videos don't start playing
- https://bugs.webkit.org/show_bug.cgi?id=88553
-
- Reviewed by Darin Adler.
-
- Test: media/media-controller-time-clamp.html
-
- Some PlatformClock classes will occasionally return times < 0 and will
- always return times slightly > duration() when playback has ended. Clamp
- the value of currentTime() to the specified [0..duration] range.
-
- * html/MediaController.cpp:
- (MediaController::currentTime):
-
-2012-06-07 Simon Fraser <simon.fraser@apple.com>
-
- Optimize FrameView::scrollXForFixedPosition() / scrollYForFixedPosition()
- https://bugs.webkit.org/show_bug.cgi?id=88475
-
- Reviewed by Sam Weinig.
-
- FrameView's scrollXForFixedPosition() and scrollYForFixedPosition()
- methods were often called together, but they do duplicate work,
- including calling into platform widget code which might be slow.
-
- Fix by converting scrollOffsetForFixedPosition() from being a wrapper
- that just calls scrollXForFixedPosition() and scrollYForFixedPosition()
- to the method that does all the work, calling just once into platform
- widget code.
-
- Changed callers to use scrollOffsetForFixedPosition() rather than make
- two separate method calls.
-
- Added ScrollView::layoutSize() and visibleSize() methods for
- convenience.
-
- Removed FrameView::scrollXForFixedPosition and FrameView::scrollYForFixedPosition
- to avoid inefficient callers in future.
-
- No new tests; refactoring only.
-
- * page/FrameView.cpp:
- (WebCore::fixedPositionScrollOffset):
- (WebCore::FrameView::scrollOffsetForFixedPosition):
- * page/FrameView.h: Removed scrollXForFixedPosition and scrollYForFixedPosition.
- * platform/ScrollView.cpp:
- (WebCore::ScrollView::layoutSize):
- * platform/ScrollView.h:
- (WebCore::ScrollView::visibleSize):
- * rendering/RenderLayer.cpp:
- (WebCore::RenderLayer::backgroundClipRect):
- * rendering/RenderLayer.h:
- (WebCore::ClipRect::move):
- * rendering/RenderLayerCompositor.cpp:
- (WebCore::RenderLayerCompositor::requiresCompositingForPosition):
- * rendering/RenderView.cpp:
- (WebCore::RenderView::computeRectForRepaint):
-
-2012-06-07 Raymes Khoury <raymes@chromium.org>
-
- Incorrect rect-based hit-test result for culled-inline elements
- https://bugs.webkit.org/show_bug.cgi?id=85849
-
- Reviewed by Levi Weintraub.
-
- Modified code which blindly adds culled inlines to rect-based hit-test
- results so that it only does so if the child node does not fully cover
- the hit-test region.
-
- Test: fast/dom/nodesFromRect-culled-inline.html
-
- * rendering/HitTestResult.cpp:
- (WebCore::HitTestResult::addNodeToRectBasedTestResult):
-
-2012-06-07 Daniel Erat <derat@chromium.org>
-
- Make Skia backend honor requests for subpixel-positioned text.
- https://bugs.webkit.org/show_bug.cgi?id=88263
-
- Reviewed by Tony Chang.
-
- Add subpixel positioning field to FontRenderStyle and rename
- subpixel rendering field.
-
- Pass setting to SkPaint in FontPlatformDataHarfBuzz and remove
- round() call when computing glyph widths in SimpleFontDataSkia.
-
- Test: platform/chromium-linux/fast/text/chromium-linux-text-subpixel-positioning.html
-
- * platform/graphics/blackberry/skia/PlatformSupport.cpp:
- (WebCore::setFontRenderStyleDefaults):
- (WebCore::PlatformSupport::getRenderStyleForStrike):
- * platform/graphics/chromium/FontRenderStyle.h:
- (WebCore::FontRenderStyle::FontRenderStyle):
- (WebCore::FontRenderStyle::operator==):
- (FontRenderStyle):
- * platform/graphics/harfbuzz/FontPlatformDataHarfBuzz.cpp:
- (WebCore):
- (WebCore::FontPlatformData::setSubpixelRendering):
- (WebCore::FontPlatformData::setSubpixelPositioning):
- (WebCore::FontPlatformData::setupPaint):
- (WebCore::FontPlatformData::querySystemForRenderStyle):
- * platform/graphics/harfbuzz/FontPlatformDataHarfBuzz.h:
- (FontPlatformData):
- * platform/graphics/skia/SimpleFontDataSkia.cpp:
- (WebCore::SimpleFontData::platformWidthForGlyph):
-
-2012-06-06 Dana Jansens <danakj@chromium.org>
-
- [chromium] In each composited frame, didDraw() should only be called on layers for which willDraw() was called
- https://bugs.webkit.org/show_bug.cgi?id=88469
-
- Reviewed by James Robinson.
-
- Unit test: CCLayerTreeHostImplTest.didDrawNotCalledOnScissoredLayer
-
- * platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
- (WebCore::shouldDrawLayer):
- (WebCore):
- (WebCore::CCLayerTreeHostImpl::calculateRenderPasses):
- (WebCore::CCLayerTreeHostImpl::didDrawAllLayers):
-
-2012-06-07 Alexei Filippov <alexeif@chromium.org>
-
- Web Inspector: sorting of object fields is broken in heap profiler
- https://bugs.webkit.org/show_bug.cgi?id=88532
-
- A recent change to heap profiler has replaced getters with functions.
- Function calls were missing in couple places after that change.
-
- Reviewed by Vsevolod Vlasov.
-
- Tests: inspector/profiler/heap-snapshot-summary-sorting-fields.html
- inspector/profiler/heap-snapshot-summary-sorting-instances.html
-
- * inspector/front-end/HeapSnapshot.js:
- (WebInspector.HeapSnapshotEdgesProvider.prototype.sort.compareNodeField):
-
-2012-06-07 Alexander Pavlov <apavlov@chromium.org>
-
- Web Inspector: Consider Ctrl+Shift+key as valid zoom change combinations
- https://bugs.webkit.org/show_bug.cgi?id=88520
-
- Reviewed by Vsevolod Vlasov.
-
- * inspector/front-end/inspector.js:
- (WebInspector.documentKeyDown):
-
-2012-06-07 Arvid Nilsson <anilsson@rim.com>
-
- [BlackBerry] Allow WebPageCompositor to blend a transparent web page
- https://bugs.webkit.org/show_bug.cgi?id=88233
-
- Reviewed by Rob Buis.
-
- RIM PR #159998
-
- Add a parameter to LayerRenderer::compositeBuffer() indicating whether
- the buffer contents are opaque, and set the GL blend mode accordingly.
-
- This is not currently testable using BlackBerry testing infrastructure.
-
- Reviewed internally by Jakob Petsovits.
-
- * platform/graphics/blackberry/LayerRenderer.cpp:
- (WebCore::LayerRenderer::compositeBuffer):
- * platform/graphics/blackberry/LayerRenderer.h:
- (LayerRenderer):
-
-2012-06-07 Alexei Filippov <alexeif@chromium.org>
-
- Web Inspector: reuse edge_count field of heap snapshot to store retained size
- https://bugs.webkit.org/show_bug.cgi?id=88416
-
- The edge_count field is unused after node first edge indexes have been built.
- Store node retained size in there instead of allocating an extra array for it.
-
- Reviewed by Vsevolod Vlasov.
-
- * inspector/front-end/HeapSnapshot.js:
- (WebInspector.HeapSnapshotNode.prototype.retainedSize):
- (WebInspector.HeapSnapshot.prototype._calculateRetainedSizes):
-
-2012-06-07 Sheriff Bot <webkit.review.bot@gmail.com>
-
- Unreviewed, rolling out r119694.
- http://trac.webkit.org/changeset/119694
- https://bugs.webkit.org/show_bug.cgi?id=88529
-
- it broke PrerenderBrowserTest.PrerenderHTML5VideoNetwork
- (Requested by loislo on #webkit).
-
- * html/HTMLMediaElement.cpp:
- * html/HTMLMediaElement.h:
- (HTMLMediaElement):
- * html/canvas/CanvasRenderingContext.cpp:
- (WebCore::CanvasRenderingContext::wouldTaintOrigin):
- * platform/graphics/MediaPlayer.cpp:
- * platform/graphics/MediaPlayer.h:
- (MediaPlayer):
- * platform/graphics/MediaPlayerPrivate.h:
-
-2012-06-07 Shinya Kawanaka <shinyak@chromium.org>
-
- Delete a contenteditable element having a Shadow DOM causes a crash.
- https://bugs.webkit.org/show_bug.cgi?id=86345
-
- Reviewed by Ryosuke Niwa.
-
- In VisibleSelection::validate(), m_start.downstream() or m_end.upstream() might cross
- editing boundaries. So we adjust selection after calling them again.
-
- Test: editing/shadow/select-contenteditable-shadowhost.html
-
- * editing/VisibleSelection.cpp:
- (WebCore::VisibleSelection::validate):
-
-2012-06-07 Vivek Galatage <vivekgalatage@gmail.com>
-
- No new line at the end for SVGCSSPropertyNames.in causes compilation warning
- https://bugs.webkit.org/show_bug.cgi?id=88503
-
- Reviewed by Ryosuke Niwa.
-
- Added new line at the end of the file.
-
- No new tests required.
-
- * css/SVGCSSPropertyNames.in:
-
-2012-06-07 Csaba Osztrogonác <ossy@webkit.org>
-
- [Qt][Win] Use OS(WINDOWS) instead of Q_WS_WIN in WebCore/platform/graphics/GraphicsContext.h
- https://bugs.webkit.org/show_bug.cgi?id=88305
-
- Reviewed by Simon Hausmann.
-
- * platform/graphics/GraphicsContext.h: Buildfix.
- (GraphicsContext):
-
-2012-06-07 Shinya Kawanaka <shinyak@chromium.org>
-
- Incorrect data retrieved in calls to get selection data in client->textWillBeReplaced from CharacterData::setDataAndUpdate
- https://bugs.webkit.org/show_bug.cgi?id=66120
-
- Reviewed by Ryosuke Niwa.
-
- Since FrameSelection::textWillBeReplaced was called before replacing text, updated Selection became
- temporarily invalid. The invalid selection was set to updateSelection(), so client will have
- invalid selection.
-
- This patch makes calling updateSelection() after updating selection.
-
- No new tests, it's too hard to create a correct test cases in DRT.
-
- * dom/CharacterData.cpp:
- (WebCore::CharacterData::setDataAndUpdate):
- * editing/FrameSelection.cpp:
- (WebCore::updatePositionAfterAdoptingTextReplacement):
- (WebCore::FrameSelection::textWasReplaced):
- * editing/FrameSelection.h:
- (FrameSelection):
-
-2012-06-07 Li Yin <li.yin@intel.com>
-
- FileAPI: If type consists of non-ASCII characters in Blob constructor, it should throw a SyntaxError.
- https://bugs.webkit.org/show_bug.cgi?id=88411
-
- Reviewed by Kentaro Hara.
-
- From spec: http://dev.w3.org/2006/webapi/FileAPI/#constructorBlob
- If type consists of any non-ASCII characters, throw a SyntaxError and
- return from this algorithm.
- This patch checks the String is ASCii or not, if not, throw SyntaxError.
-
- Test: fast/files/blob-constructor.html
-
- * bindings/js/JSBlobCustom.cpp:
- (WebCore::JSBlobConstructor::constructJSBlob):
- * bindings/v8/custom/V8BlobCustom.cpp:
- (WebCore::V8Blob::constructorCallback):
-
-2012-06-07 Arpita Bahuguna <arpitabahuguna@gmail.com>
-
- InsertUnorderedList and InsertOrderedList (execCommand) do not remove bullets
- https://bugs.webkit.org/show_bug.cgi?id=84597
-
- Reviewed by Ryosuke Niwa.
-
- Comparison between start and end VisiblePositions will fail when a position inside
- a paragraph is compared with one at the start of the paragraph.
-
- This fix thus converts the end VisiblePosition (which could be inside the paragraph)
- to the start of the paragraph thereby enabling a proper comparison of start and end
- positions.
-
- Test: editing/execCommand/remove-list-from-multi-list-items.html
-
- * editing/InsertListCommand.cpp:
- (WebCore::InsertListCommand::selectionHasListOfType):
-
-2012-06-07 Li Yin <li.yin@intel.com>
-
- [FileAPI] FileReader should throw an InvalidStateError exception when readyState is LOADING
- https://bugs.webkit.org/show_bug.cgi?id=88212
-
- Reviewed by Jian Li.
-
- From Spec: http://www.w3.org/TR/FileAPI/#readAsBinaryString
- FileReader should throw an InvalidStateError exception instead of NOT_ALLOWED_ERR
- when the readyState is LOADING.
- Also delete OperationNotAllowedException related code, because it is not longer needed.
-
- Tests: fast/files/read-file-async.html
- fast/files/workers/worker-read-file-async.html
-
- * CMakeLists.txt:
- * DerivedSources.cpp:
- * DerivedSources.make:
- * DerivedSources.pri:
- * GNUmakefile.list.am:
- * Target.pri:
- * WebCore.gypi:
- * WebCore.vcproj/WebCore.vcproj:
- * WebCore.xcodeproj/project.pbxproj:
- * dom/DOMExceptions.in:
- * fileapi/FileReader.cpp:
- (WebCore::FileReader::readInternal): Changed it to throw INVALID_STATE_ERR.
- * fileapi/FileReader.idl: Changed it to raise DOMException for all read methods.
- * fileapi/OperationNotAllowedException.cpp: Removed.
- * fileapi/OperationNotAllowedException.h: Removed.
- * fileapi/OperationNotAllowedException.idl: Removed.
-
-2012-06-07 Sheriff Bot <webkit.review.bot@gmail.com>
-
- Unreviewed, rolling out r119689.
- http://trac.webkit.org/changeset/119689
- https://bugs.webkit.org/show_bug.cgi?id=88516
-
- it broke didDrawNotCalledOnScissoredLayer webkit_unit_test
- (Requested by loislo on #webkit).
-
- * platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
- (WebCore::CCLayerTreeHostImpl::calculateRenderPasses):
- (WebCore::CCLayerTreeHostImpl::didDrawAllLayers):
-
-2012-06-07 Ami Fischman <fischman@chromium.org>
-
- Plumb CORS attribute information from HTMLMediaElement to media players so it can be used
- https://bugs.webkit.org/show_bug.cgi?id=88349
-
- Reviewed by Adam Barth.
-
- Test: http/tests/security/video-cross-origin-readback.html
-
- * html/HTMLMediaElement.cpp:
- (WebCore::HTMLMediaElement::mediaPlayerCORSMode):
- (WebCore):
- * html/HTMLMediaElement.h:
- (HTMLMediaElement):
- * platform/graphics/MediaPlayer.h:
- (WebCore::MediaPlayerClient::mediaPlayerCORSMode):
-
-2012-06-07 Hironori Bono <hbono@chromium.org>
-
- Use light gray for grammar markers on Windows and Linux
- https://bugs.webkit.org/show_bug.cgi?id=88398
-
- Reviewed by Ryosuke Niwa.
-
- This change changes the color of grammar markers from dark gray to light gray
- and rebaselines a couple of pixel tests affected by this change.
-
- No new tests because it changes the marker color of an existing test 'grammar-markers.html'.
-
- * platform/graphics/skia/GraphicsContextSkia.cpp: Change dark gray to light gray.
-
-2012-06-07 Yoshifumi Inoue <yosin@chromium.org>
-
- [Platform] Introduce conversion from/to Deciaml to/from double
- https://bugs.webkit.org/show_bug.cgi?id=88480
-
- Reviewed by Kent Tamura.
-
- This patch added functions for Decimal/Double conversion and isInfinity
- for reducing patch size of introducing Decimal arithmetic, bug 88383.
-
- Tests: WebKit/chromium/tests/DecimalTest.cpp
-
- * platform/Decimal.cpp:
- (WebCore::Decimal::fromDouble): Added.
- (WebCore::Decimal::toDouble): Added.
- * platform/Decimal.h:
- (WebCore::Decimal::EncodedData::isInfinity): Added for isinf()
- (WebCore::Decimal::isInfinity): Added.
-
-2012-06-06 Xianzhu Wang <wangxianzhu@chromium.org>
-
- Element.getBoundingClientRect() and Element.getClientRects() return incorrect values in frames in a scaled page
- https://bugs.webkit.org/show_bug.cgi?id=88430
-
- Element.getBoudingClientRect() and Element.getClientRects() should not scale back the rects
- if the element is in a frame because page scale only apply to elements in the main frame.
-
- Reviewed by James Robinson.
-
- Tests: fast/dom/Element/scale-page-bounding-client-rect-in-frame.html
- fast/dom/Element/scale-page-client-rects-in-frame.html
-
- * dom/Document.cpp:
- (WebCore):
- (WebCore::Document::adjustFloatQuadsForScrollAndAbsoluteZoomAndFrameScale): Extracted from Element.cpp and Range.cpp and fixed issue of pageScale in frames.
- (WebCore::Document::adjustFloatRectForScrollAndAbsoluteZoomAndFrameScale): Extracted from Element.cpp and fixed issue of pageScale in frames.
- * dom/Document.h:
- (WebCore):
- (Document):
- * dom/Element.cpp:
- (WebCore::Element::getClientRects):
- (WebCore::Element::getBoundingClientRect):
- * dom/Range.cpp:
- (WebCore):
- (WebCore::adjustFloatQuadsForScrollAndAbsoluteZoomAndPageScale): Moved into Document and fixed issue of pageScale in frames.
- (WebCore::Range::getBorderAndTextQuads):
- * rendering/RenderObject.h: Removed adjustFloatQuadForPageScale and adjustFloatRectForPageScale because they seem unrelated to RenderObject.
- (WebCore):
-
-2012-06-06 Dana Jansens <danakj@chromium.org>
-
- [chromium] In each composited frame, didDraw() should only be called on layers for which willDraw() was called
- https://bugs.webkit.org/show_bug.cgi?id=88469
-
- Reviewed by James Robinson.
-
- Unit test: CCLayerTreeHostImplTest.didDrawNotCalledOnScissoredLayer
-
- * platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
- (WebCore::shouldDrawLayer):
- (WebCore):
- (WebCore::CCLayerTreeHostImpl::calculateRenderPasses):
- (WebCore::CCLayerTreeHostImpl::didDrawAllLayers):
-
-2012-06-06 Andy Estes <aestes@apple.com>
-
- Wrap uppercaseWord, lowercaseWord, and capitalizeWord with USE(APPKIT)
- https://bugs.webkit.org/show_bug.cgi?id=88504
-
- Reviewed by Dan Bernstein.
-
- uppercaseWord, lowercaseWord, and capitalizeWord are methods declared
- by NSResponder that subclasses are expected to implement. WebKit should
- only support these implementations on platforms that use AppKit.
-
- * WebCore.exp.in:
- * editing/Editor.cpp:
- * editing/Editor.h:
- * loader/EmptyClients.h:
- * page/ContextMenuController.cpp:
- * page/EditorClient.h:
-
-2012-06-06 Sheriff Bot <webkit.review.bot@gmail.com>
-
- Unreviewed, rolling out r119683.
- http://trac.webkit.org/changeset/119683
- https://bugs.webkit.org/show_bug.cgi?id=88505
-
- it broke webkit-unit-test
- WebLayerTreeViewThreadedTest.InstrumentationCallbacks on mac
- (Requested by loislo on #webkit).
-
- * platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
- (WebCore::CCLayerTreeHost::initializeLayerRenderer):
- (WebCore::CCLayerTreeHost::setVisible):
-
-2012-06-06 Robert Kroeger <rjkroege@chromium.org>
-
- [Chromium] Re-enable handling of smooth scrolling on Chromium Linux/Windows
- https://bugs.webkit.org/show_bug.cgi?id=87535 by adding support for
- m_hasPreciseScrollingDelta on all Chromium platforms and adjusting ScrollAnimator
- and ScrollAnimatorNone accordingly to let m_hasPreciseScrollingDelta == true
- force exact (non-animated) scrolling.
-
- Reviewed by James Robinson.
-
- Updated WebKit unit tests to validate change.
-
- * platform/PlatformWheelEvent.h:
- (WebCore::PlatformWheelEvent::PlatformWheelEvent): Adjusted #ifdefs to
- make m_hasPreciseScrollingDelta available on all Chromium platforms.
- (PlatformWheelEvent):
- * platform/ScrollAnimator.cpp:
- (WebCore::ScrollAnimator::handleWheelEvent): Default scroll type is set based on
- m_hasPreciseScrollingDelta value.
- * platform/ScrollAnimatorNone.cpp:
- (WebCore::ScrollAnimatorNone::scroll): Scroll precisely when necessary.
- * platform/ScrollTypes.h: Added additional pixel scrolling subtype.
- * platform/ScrollableArea.cpp:
- (WebCore::ScrollableArea::scroll): Updated for additional pixel scroll subtype.
-
-2012-06-06 Michal Mocny <mmocny@google.com>
-
- [chromium] Stop dropping texture limits when the layer tree host becomes invisible, and initialize with 0 allocation.
- https://bugs.webkit.org/show_bug.cgi?id=87747
-
- Reviewed by Adrienne Walker.
-
- GpuMemoryManager manages texture memory allocation limits. It will send a 0 allocation when a renderer becomes
- invisible, and an appropriate allocation after a renderer is initialized. These numbers will change
- depending on the state of memory across devices and other renderers, so we would like to remove all explicit
- management by the renderers themselves.
-
- * platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
- (WebCore::CCLayerTreeHost::initializeLayerRenderer):
- (WebCore::CCLayerTreeHost::setVisible):
-
-2012-06-06 Sheriff Bot <webkit.review.bot@gmail.com>
-
- Unreviewed, rolling out r119680.
- http://trac.webkit.org/changeset/119680
- https://bugs.webkit.org/show_bug.cgi?id=88498
-
- It broke mac build (Requested by kinuko on #webkit).
-
- * fileapi/File.cpp:
- (WebCore::File::File):
- (WebCore::File::lastModifiedDate):
- (WebCore::File::lastModifiedDateForBinding):
- (WebCore):
- (WebCore::File::captureSnapshot):
- * fileapi/File.h:
- (File):
- * fileapi/File.idl:
- * platform/FileMetadata.h:
- (WebCore::FileMetadata::FileMetadata):
- * platform/FileSystem.h:
- * platform/chromium/support/WebHTTPBody.cpp:
- (WebKit::WebHTTPBody::elementAt):
- * platform/network/BlobData.cpp:
- (WebCore):
-
-2012-06-06 Kinuko Yasuda <kinuko@chromium.org>
-
- File::lastModifiedDate should use NaN or separate boolean flag for null Date value
- https://bugs.webkit.org/show_bug.cgi?id=87826
-
- Reviewed by Kent Tamura.
-
- Test: http/tests/local/fileapi/file-last-modified-after-delete.html
-
- * fileapi/File.cpp:
- (WebCore::File::File):
- (WebCore::File::captureSnapshot):
- (WebCore::File::lastModifiedDate):
- (WebCore::File::lastModifiedDateForBinding): Removed.
- * fileapi/File.h:
- (File):
- * fileapi/File.idl:
- * platform/FileMetadata.h:
- (WebCore::FileMetadata::FileMetadata):
- * platform/FileSystem.h:
- * platform/chromium/support/WebHTTPBody.cpp:
- (WebKit::WebHTTPBody::elementAt):
- * platform/network/BlobData.cpp:
- (WebCore):
-
-2012-06-06 Sheriff Bot <webkit.review.bot@gmail.com>
-
- Unreviewed, rolling out r119668.
- http://trac.webkit.org/changeset/119668
- https://bugs.webkit.org/show_bug.cgi?id=88493
-
- Hitting assertions in debug builds (Requested by rniwa on
- #webkit).
-
- * rendering/RenderBlock.cpp:
- (WebCore::RenderBlock::localCaretRect):
- * rendering/RenderBoxModelObject.cpp:
- * rendering/RenderBoxModelObject.h:
- (RenderBoxModelObject):
- * rendering/RenderInline.cpp:
- * rendering/RenderInline.h:
- (RenderInline):
-
-2012-06-06 Julien Chaffraix <jchaffraix@webkit.org>
-
- Cache isSelfPaintingLayer() for better performance
- https://bugs.webkit.org/show_bug.cgi?id=88464
-
- Reviewed by Simon Fraser.
-
- Covered by existing tests (repaint tests among them).
-
- isSelfPaintingLayer() has shown up several times on some scrolling benchmarks due
- to the function being called several time per paint phase. This change caches the
- boolean at style change time.
-
- On http://dglazkov.github.com/performance-tests/biggrid.html, this nearly speed-up
- painting by 2 (lowering the time taken to paint the newly exposed area when scrolling
- on a 10,000 * 100 table from 95ms to 50ms).
-
- * rendering/RenderLayer.cpp:
- (WebCore::RenderLayer::RenderLayer):
- Initialized m_isSelfPaintingLayer here.
-
- (WebCore::RenderLayer::paintLayer):
- Changed the order of the checks to get the more likely check first.
-
- (WebCore::RenderLayer::shouldBeSelfPaintingLayer):
- Renamed from isSelfPaintingLayer to make m_isNormalFlowOnly.
-
- (WebCore::RenderLayer::styleChanged):
- Added code to update our cached m_isSelfPaintingLayer.
-
- * rendering/RenderLayer.h:
- (WebCore::RenderLayer::isSelfPaintingLayer):
- Changed to return m_isSelfPaintingLayer.
-
-2012-06-06 Yoshifumi Inoue <yosin@chromium.org>
-
- REGRESSION(r109729) [Form] Rendering of select/optgroup/option combination is too slow.
- https://bugs.webkit.org/show_bug.cgi?id=88059
-
- Reviewed by Kent Tamura.
-
- This patch changes not to share RenderStyle object for option and
- optgroup element regardless attributes.
-
- When we tried to shared RenderStyle object, rendering performance was
- good but we had issue in selected option and text transform, see
- https://bugs.webkit.org/show_bug.cgi?id=88405 for details.
-
- No new tests. This patch doesn't change behavior but rendering performance.
-
- * css/StyleResolver.cpp:
- (WebCore::StyleResolver::canShareStyleWithElement): Changed to always
- return false for option and optgroup.
-
-2012-06-06 Alec Flett <alecflett@chromium.org>
-
- IndexedDB: Optimize single-key get()
- https://bugs.webkit.org/show_bug.cgi?id=85288
-
- Reviewed by Tony Chang.
-
- No new tests, this is just an optimization.
-
- After a recent refactoring, we started creating
- an internal cursor with every call to get(). The
- most common use of get() is with a single key,
- so provide a fast-path to avoid creating the cursor.
-
- * Modules/indexeddb/IDBIndexBackendImpl.cpp:
- (WebCore::IDBIndexBackendImpl::getByRangeInternal):
- * Modules/indexeddb/IDBKeyRange.h:
- (WebCore::IDBKeyRange::isOnlyKey):
- (IDBKeyRange):
- * Modules/indexeddb/IDBObjectStoreBackendImpl.cpp:
- (WebCore::IDBObjectStoreBackendImpl::getByRangeInternal):
-
-2012-06-06 Shezan Baig <shezbaig.wk@gmail.com>
-
- Caret is not rendered in empty inline contenteditable elements
- https://bugs.webkit.org/show_bug.cgi?id=85793
-
- Reviewed by Ryosuke Niwa.
-
- Override localCaretRect in RenderInline. The implementation was almost
- identical to localCaretRect in RenderBlock for empty block elements, so
- I refactored RenderBlock::localCaretRect and moved the logic to a new
- method 'localCaretRectForEmptyElement' in RenderBoxModelObject. The
- implementation of 'localCaretRect' in RenderBlock and RenderInline both
- use this helper method in RenderBoxModelObject.
-
- Tests: editing/selection/caret-in-empty-inline-1.html
- editing/selection/caret-in-empty-inline-2.html
-
- * rendering/RenderBlock.cpp:
- (WebCore::RenderBlock::localCaretRect):
- Modified to use RenderBoxModelObject::localCaretRectForEmptyElement.
- * rendering/RenderBoxModelObject.cpp:
- (WebCore::RenderBoxModelObject::localCaretRectForEmptyElement):
- (WebCore):
- * rendering/RenderBoxModelObject.h:
- (RenderBoxModelObject):
- Add localCaretRectForEmptyElement helper method.
- * rendering/RenderInline.cpp:
- (WebCore::RenderInline::localCaretRect):
- (WebCore):
- * rendering/RenderInline.h:
- (RenderInline):
- Override localCaretRect using localCaretRectForEmptyElement.
-
-2012-06-06 Alexis Menard <alexis.menard@openbossa.org>
-
- Fix border-image-slice failures on http://css3test.com.
- https://bugs.webkit.org/show_bug.cgi?id=88328
-
- Reviewed by Tony Chang.
-
- The old parsing code was assuming that the fill keyword comes after the
- numbers or the percentage values. http://www.w3.org/TR/css3-background/#the-border-image-slice
- defines the property like this : [<number> | <percentage>]{1,4} && fill? where the fill
- keyword is not mandatory. But according to http://www.w3.org/TR/CSS2/about.html "&&"
- separates two or more components, all of which must occur, in any order. So the previous
- code was wrong the fill can come first following by the percentages or the numbers. http://css3test.com
- was covering this particular case. I took the opportunity to extend our coverage
- by adding tests on many different values the boder-image-slice property could take. I
- also did a small cleanup by removing unused functions in BorderImageSliceParseContext.
-
- Test: fast/css/getComputedStyle/getComputedStyle-border-image-slice.html
-
- * css/CSSParser.cpp:
- (WebCore::BorderImageSliceParseContext::BorderImageSliceParseContext):
- (WebCore::BorderImageSliceParseContext::commitNumber):
- (WebCore::BorderImageSliceParseContext::commitFill):
-
-2012-06-06 Levi Weintraub <leviw@chromium.org>
-
- Use enclosingIntRect instead of pixelSnappedIntRect in RenderFileUploadControl
- https://bugs.webkit.org/show_bug.cgi?id=88454
-
- Reviewed by Kent Tamura.
-
- Properly clipping the file upload control to avoid clipping out the top of the file upload button
- when the control is positioned at a sub-pixel offset that rounds up.
-
- Test: fast/sub-pixel/file-upload-control-at-fractional-offset.html
-
- * rendering/RenderFileUploadControl.cpp:
- (WebCore::RenderFileUploadControl::paintObject):
-
-2012-06-06 Filip Pizlo <fpizlo@apple.com>
-
- Global object variable accesses should not require an extra load
- https://bugs.webkit.org/show_bug.cgi?id=88385
-
- Reviewed by Gavin Barraclough and Geoffrey Garen.
-
- Updated JSDOMWindowBase.cpp to use the new symbol table API. this->symbolTableFoo(...)
- becomes symbolTableFoo(this, ...).
-
- No new tests because no change in behavior.
-
- * bindings/js/JSDOMWindowBase.cpp:
- (WebCore::JSDOMWindowBase::updateDocument):
-
-2012-06-06 James Robinson <jamesr@chromium.org>
-
- [chromium] Move implementation of WebCore::GraphicsContext3D and related from WebKit/chromium/src to WebCore/platform/chromium/support
- https://bugs.webkit.org/show_bug.cgi?id=86257
-
- Reviewed by Kenneth Russell.
-
- The WebCore platform interfaces GraphicsContext3D and Extensions3DChromium are implemented in chromium
- on top of the Platform interface WebGraphicsContext3D. This moves the implementation support code from
- WebKit/chromium/src to WebCore/platform/chromium/support, which avoids having code in WebKit/ implementing WebCore
- interfaces and allows code in WebCore/platform to use this support code directly where appropriate.
-
- Refactor only, no new functionality or tests.
-
- * WebCore.gypi:
- * platform/chromium/support/Extensions3DChromium.cpp: Renamed from Source/WebKit/chromium/src/Extensions3DChromium.cpp.
- (WebCore):
- (WebCore::Extensions3DChromium::Extensions3DChromium):
- (WebCore::Extensions3DChromium::~Extensions3DChromium):
- (WebCore::Extensions3DChromium::supports):
- (WebCore::Extensions3DChromium::ensureEnabled):
- (WebCore::Extensions3DChromium::isEnabled):
- (WebCore::Extensions3DChromium::getGraphicsResetStatusARB):
- (WebCore::Extensions3DChromium::blitFramebuffer):
- (WebCore::Extensions3DChromium::renderbufferStorageMultisample):
- (WebCore::Extensions3DChromium::postSubBufferCHROMIUM):
- (WebCore::Extensions3DChromium::mapBufferSubDataCHROMIUM):
- (WebCore::Extensions3DChromium::unmapBufferSubDataCHROMIUM):
- (WebCore::Extensions3DChromium::mapTexSubImage2DCHROMIUM):
- (WebCore::Extensions3DChromium::unmapTexSubImage2DCHROMIUM):
- (WebCore::Extensions3DChromium::setVisibilityCHROMIUM):
- (WebCore::Extensions3DChromium::discardFramebufferEXT):
- (WebCore::Extensions3DChromium::ensureFramebufferCHROMIUM):
- (WebCore::Extensions3DChromium::setGpuMemoryAllocationChangedCallbackCHROMIUM):
- (WebCore::Extensions3DChromium::createVertexArrayOES):
- (WebCore::Extensions3DChromium::deleteVertexArrayOES):
- (WebCore::Extensions3DChromium::isVertexArrayOES):
- (WebCore::Extensions3DChromium::bindVertexArrayOES):
- (WebCore::Extensions3DChromium::getTranslatedShaderSourceANGLE):
- (WebCore::Extensions3DChromium::setSwapBuffersCompleteCallbackCHROMIUM):
- (WebCore::Extensions3DChromium::rateLimitOffscreenContextCHROMIUM):
- (WebCore::Extensions3DChromium::paintFramebufferToCanvas):
- (WebCore::Extensions3DChromium::texImageIOSurface2DCHROMIUM):
- (WebCore::Extensions3DChromium::texStorage2DEXT):
- (WebCore::Extensions3DChromium::createQueryEXT):
- (WebCore::Extensions3DChromium::deleteQueryEXT):
- (WebCore::Extensions3DChromium::isQueryEXT):
- (WebCore::Extensions3DChromium::beginQueryEXT):
- (WebCore::Extensions3DChromium::endQueryEXT):
- (WebCore::Extensions3DChromium::getQueryivEXT):
- (WebCore::Extensions3DChromium::getQueryObjectuivEXT):
- * platform/chromium/support/GraphicsContext3DChromium.cpp: Renamed from Source/WebKit/chromium/src/GraphicsContext3DChromium.cpp.
- (WebCore):
- (WebCore::GraphicsContext3D::GraphicsContext3D):
- (WebCore::GraphicsContext3D::~GraphicsContext3D):
- (WebCore::GraphicsContext3D::setContextLostCallback):
- (WebCore::GraphicsContext3D::setErrorMessageCallback):
- (WebCore::GraphicsContext3D::create):
- (WebCore::GraphicsContext3D::platformGraphicsContext3D):
- (WebCore::GraphicsContext3D::platformTexture):
- (WebCore::GraphicsContext3D::grContext):
- (WebCore::GraphicsContext3D::platformLayer):
- (WebCore::GraphicsContext3D::isGLES2Compliant):
- (WebCore::GraphicsContext3D::isResourceSafe):
- (WebCore::GraphicsContext3D::bindAttribLocation):
- (WebCore::GraphicsContext3D::bufferData):
- (WebCore::GraphicsContext3D::getActiveAttrib):
- (WebCore::GraphicsContext3D::getActiveUniform):
- (WebCore::GraphicsContext3D::getAttribLocation):
- (WebCore::GraphicsContext3D::getContextAttributes):
- (WebCore::GraphicsContext3D::getProgramInfoLog):
- (WebCore::GraphicsContext3D::getShaderInfoLog):
- (WebCore::GraphicsContext3D::getShaderSource):
- (WebCore::GraphicsContext3D::getString):
- (WebCore::GraphicsContext3D::getUniformLocation):
- (WebCore::GraphicsContext3D::shaderSource):
- (WebCore::GraphicsContext3D::texImage2D):
- (WebCore::GraphicsContext3D::texSubImage2D):
- (WebCore::GraphicsContext3D::reshape):
- (WebCore::GraphicsContext3D::markContextChanged):
- (WebCore::GraphicsContext3D::layerComposited):
- (WebCore::GraphicsContext3D::markLayerComposited):
- (WebCore::GraphicsContext3D::paintRenderingResultsToCanvas):
- (WebCore::GraphicsContext3D::paintRenderingResultsToImageData):
- (WebCore::GraphicsContext3D::paintCompositedResultsToCanvas):
- (WebCore::GraphicsContext3D::getExtensions):
- (WebCore::GraphicsContext3D::getInternalFramebufferSize):
- * platform/chromium/support/GraphicsContext3DPrivate.cpp: Renamed from Source/WebKit/chromium/src/GraphicsContext3DPrivate.cpp.
- (WebCore):
- (WebCore::GraphicsContext3DPrivate::GraphicsContext3DPrivate):
- (WebCore::GraphicsContext3DPrivate::~GraphicsContext3DPrivate):
- (WebCore::GraphicsContext3DPrivate::createGraphicsContextFromWebContext):
- (WebCore::GraphicsContext3DPrivate::extractWebGraphicsContext3D):
- (GrMemoryAllocationChangedCallback):
- (WebCore::GrMemoryAllocationChangedCallback::GrMemoryAllocationChangedCallback):
- (WebCore::GrMemoryAllocationChangedCallback::onGpuMemoryAllocationChanged):
- (WebCore::GraphicsContext3DPrivate::grContext):
- (WebCore::GraphicsContext3DPrivate::markContextChanged):
- (WebCore::GraphicsContext3DPrivate::layerComposited):
- (WebCore::GraphicsContext3DPrivate::markLayerComposited):
- (WebCore::GraphicsContext3DPrivate::paintFramebufferToCanvas):
- (GraphicsContext3DContextLostCallbackAdapter):
- (WebCore::GraphicsContext3DContextLostCallbackAdapter::GraphicsContext3DContextLostCallbackAdapter):
- (WebCore::GraphicsContext3DContextLostCallbackAdapter::~GraphicsContext3DContextLostCallbackAdapter):
- (WebCore::GraphicsContext3DContextLostCallbackAdapter::onContextLost):
- (WebCore::GraphicsContext3DPrivate::setContextLostCallback):
- (GraphicsContext3DErrorMessageCallbackAdapter):
- (WebCore::GraphicsContext3DErrorMessageCallbackAdapter::GraphicsContext3DErrorMessageCallbackAdapter):
- (WebCore::GraphicsContext3DErrorMessageCallbackAdapter::~GraphicsContext3DErrorMessageCallbackAdapter):
- (WebCore::GraphicsContext3DErrorMessageCallbackAdapter::onErrorMessage):
- (WebCore::GraphicsContext3DPrivate::setErrorMessageCallback):
- (WebCore::GraphicsContext3DPrivate::getExtensions):
- (WebCore::GraphicsContext3DPrivate::initializeExtensions):
- (WebCore::GraphicsContext3DPrivate::supportsExtension):
- (WebCore::GraphicsContext3DPrivate::ensureExtensionEnabled):
- (WebCore::GraphicsContext3DPrivate::isExtensionEnabled):
- (WebCore::GraphicsContext3DPrivate::isResourceSafe):
- (GraphicsContext3DMemoryAllocationChangedCallbackAdapter):
- (WebCore::GraphicsContext3DMemoryAllocationChangedCallbackAdapter::GraphicsContext3DMemoryAllocationChangedCallbackAdapter):
- (WebCore::GraphicsContext3DMemoryAllocationChangedCallbackAdapter::~GraphicsContext3DMemoryAllocationChangedCallbackAdapter):
- (WebCore::GraphicsContext3DMemoryAllocationChangedCallbackAdapter::onMemoryAllocationChanged):
- (WebCore::GraphicsContext3DPrivate::setGpuMemoryAllocationChangedCallbackCHROMIUM):
- (GraphicsContext3DSwapBuffersCompleteCallbackAdapter):
- (WebCore::GraphicsContext3DSwapBuffersCompleteCallbackAdapter::GraphicsContext3DSwapBuffersCompleteCallbackAdapter):
- (WebCore::GraphicsContext3DSwapBuffersCompleteCallbackAdapter::~GraphicsContext3DSwapBuffersCompleteCallbackAdapter):
- (WebCore::GraphicsContext3DSwapBuffersCompleteCallbackAdapter::onSwapBuffersComplete):
- (WebCore::GraphicsContext3DPrivate::setSwapBuffersCompleteCallbackCHROMIUM):
- * platform/chromium/support/GraphicsContext3DPrivate.h: Renamed from Source/WebKit/chromium/src/GraphicsContext3DPrivate.h.
- (WebKit):
- (WebCore):
- (GraphicsContext3DPrivate):
- (WebCore::GraphicsContext3DPrivate::webContext):
- (WebCore::GraphicsContext3DPrivate::preserveDrawingBuffer):
-
-2012-06-06 Sheriff Bot <webkit.review.bot@gmail.com>
-
- Unreviewed, rolling out r119624.
- http://trac.webkit.org/changeset/119624
- https://bugs.webkit.org/show_bug.cgi?id=88472
-
- Caused worker tests to become flaky (Requested by mhahnenberg
- on #webkit).
-
- * workers/AbstractWorker.cpp:
- (WebCore::AbstractWorker::~AbstractWorker):
- * workers/WorkerMessagingProxy.cpp:
- (WebCore::WorkerMessagingProxy::workerObjectDestroyed):
-
-2012-06-06 Brady Eidson <beidson@apple.com>
-
- <rdar://problem/11575112> and https://bugs.webkit.org/show_bug.cgi?id=88428
- REGRESSION (r115654): Opening many non-English WebArchives shows obvious encoding issues
-
- Reviewed by Nate Chapin.
-
- Test: fast/loader/webarchive-encoding-respected.html
-
- * loader/DocumentLoader.cpp:
- (WebCore::DocumentLoader::commitData): Properly set the main resource encoding from the webarchive.
-
-2012-06-06 Mark Hahnenberg <mhahnenberg@apple.com>
-
- Worker tear-down can re-enter JSC during GC finalization
- https://bugs.webkit.org/show_bug.cgi?id=88449
-
- Reviewed by Geoffrey Garen.
-
- No new tests. Current regression tests cover these changes.
-
- * workers/AbstractWorker.cpp:
- (WebCore::AbstractWorker::~AbstractWorker): We don't need to call onDestroyWorker() here, it
- will be called elsewhere in contextDestroyed().
- * workers/WorkerMessagingProxy.cpp:
- (WebCore::WorkerMessagingProxy::workerObjectDestroyed): We make the call to terminateWorkerContext()
- and workerContextDestroyed() asynchronous to avoid entering JSC during GC finalization.
-
-2012-06-06 Tony Chang <tony@chromium.org>
-
- webkit crashes on debug builds when running IETC flexbox-ordinal-group-001.htm
- https://bugs.webkit.org/show_bug.cgi?id=85832
-
- Reviewed by Ojan Vafai.
-
- We were using a HashSet<unsigned>, which can't hold the value of 0.
- According to the spec, 0 isn't a valid value, so at CSS parse time,
- reject the value 0. This lets us pass the test, although that's kind
- of by accident.
-
- We could allow 0 for box-ordinal-group, but there are some perf implications
- to having allowing a value below the initial value (1 in this case).
-
- We still allow 0 for box-flex-group, because that's what the existing code
- does and there are tests expecting this behavior.
-
- No new tests, covered by ietestcenter/css3/flexbox/flexbox-ordinal-group-001.htm
- which was crashing.
-
- * css/CSSParser.cpp:
- (WebCore::CSSParser::parseValue): Reject 0 for -webkit-box-ordinal-group.
-
-2012-06-06 Ojan Vafai <ojan@chromium.org>
-
- Remove some magic from the -webkit-flex shorthand parsing to match the changes in the spec
- https://bugs.webkit.org/show_bug.cgi?id=88444
-
- Reviewed by Tony Chang.
-
- -Unset positive flex defaults to 0.
- -Unset negative flex defaults to 1. No magic of doing something different if positive flex was set.
-
- * css/CSSParser.cpp:
- (WebCore::CSSParser::parseFlex):
-
-2012-06-06 Ryosuke Niwa <rniwa@webkit.org>
-
- Revert r119440 now that I have a time to rebaseline them all!
-
- * platform/ScrollbarThemeComposite.cpp:
- (WebCore::ScrollbarThemeComposite::thumbLength):
-
-2012-06-06 Joshua Bell <jsbell@chromium.org>
-
- IndexedDB: Infinite recursion in IDBObjectStore.openCursor(key, legacy_constant)
- https://bugs.webkit.org/show_bug.cgi?id=88431
-
- Reviewed by Tony Chang.
-
- Function was calling itself, rather than delegating to the correct (IDBKeyRange) overload.
-
- Test: storage/indexeddb/legacy-constants.html
-
- * Modules/indexeddb/IDBObjectStore.cpp:
- (WebCore::IDBObjectStore::openCursor):
-
-2012-06-06 Joshua Bell <jsbell@chromium.org>
-
- IndexedDB: Rename IDBFactory.getDatabaseNames() to webkitGetDatabaseNames()
- https://bugs.webkit.org/show_bug.cgi?id=86874
-
- Reviewed by Ojan Vafai.
-
- The function is non-standard, and should be prefixed.
-
- Test: storage/indexeddb/factory-basics.html
-
- * Modules/indexeddb/IDBFactory.idl:
-
-2012-06-06 Julien Chaffraix <jchaffraix@webkit.org>
-
- Add support for direction on table row group with collapsing borders
- https://bugs.webkit.org/show_bug.cgi?id=87900
-
- Reviewed by Ojan Vafai.
-
- Tests: fast/table/border-collapsing/first-cell-left-border-hidden-table-ltr-section-rtl.html
- fast/table/border-collapsing/last-cell-left-border-hidden-table-ltr-section-rtl.html
- fast/table/border-collapsing/left-border-table-ltr-section-rtl.html
- fast/table/border-collapsing/left-border-table-rtl-section-ltr.html
- fast/table/border-collapsing/left-border-table-rtl-section-rtl.html
- fast/table/border-collapsing/left-border-vertical-lr-table-ltr-section-rtl.html
- fast/table/border-collapsing/left-border-vertical-lr-table-rtl-section-ltr.html
- fast/table/border-collapsing/left-border-vertical-lr-table-rtl-section-rtl.html
- fast/table/border-collapsing/rtl-table-left-border-hidden.html
- fast/table/border-collapsing/top-border-vertical-rl-table-ltr-section-rtl.html
- fast/table/border-collapsing/top-border-vertical-rl-table-rtl-section-ltr.html
- fast/table/border-collapsing/top-border-vertical-rl-table-rtl-section-rtl.html
- fast/table/table-ltr-section-rtl.html
- fast/table/table-rtl-section-ltr.html
- fast/table/table-rtl-section-rtl.html
-
- This change enables proper support for direction on table row group.
- The current code would allow people to set direction on the row group but would still
- use the table's code for directionality checks (with surprising consequences).
-
- The main change involve swapping end / start borders in case of mixed directionality
- as those 2 are not in sync.
-
- Example: <table dir="ltr"><tbody dir="rtl"><td id="cell0"></td><td id="cell1"></td></tbody></table>
-
- Visually:
- Table: Start ---------------------> End
- Tbody: End <---------------------- Start
- Cell: | #cell0 | #cell1 |
-
- In this example, the end table border should be compared with the tbody's start border
- and the last cell's (in DOM order) start border.
-
- * rendering/RenderTable.cpp:
- (WebCore::RenderTable::tableStartBorderAdjoiningCell):
- (WebCore::RenderTable::tableEndBorderAdjoiningCell):
- Same as the other adjoining functions.
-
- * rendering/RenderTable.h:
- (WebCore::RenderTable::lastColumnIndex):
- Helper function to get the last column index.
-
- * rendering/RenderTableCell.cpp:
- (WebCore::RenderTableCell::computeCollapsedStartBorder):
- (WebCore::RenderTableCell::computeCollapsedEndBorder):
- Updated to call the table's adjoining border helpers.
-
- * rendering/RenderTableCell.h:
- (WebCore::RenderTableCell::styleForCellFlow):
- Updated to use the table row group's style now that we properly support it.
-
- (WebCore::RenderTableCell::isFirstOrLastCellInRow):
- Debug only helper to make sure we don't call the border adjoining function
- on non-terminal cells.
-
- (WebCore::RenderTableCell::borderAdjoiningTableStart):
- (WebCore::RenderTableCell::borderAdjoiningTableEnd):
- * rendering/RenderTableRow.h:
- (WebCore::RenderTableRow::borderAdjoiningTableStart):
- (WebCore::RenderTableRow::borderAdjoiningTableEnd):
- * rendering/RenderTableSection.cpp:
- (WebCore::RenderTableSection::firstRowCellAdjoiningTableStart):
- (WebCore::RenderTableSection::firstRowCellAdjoiningTableEnd):
- Updated the previous function to account for mixed directionality.
-
- (WebCore::RenderTableSection::layoutRows):
- Move some of the code to setLogicalPositionForCell to match RenderBlock.
-
- (WebCore::RenderTableSection::setLogicalPositionForCell):
- Switched direction checks to styleForCellFlow (this doesn't change anything as we
- were already properly flipping already but ensure better).
-
- * rendering/RenderTableSection.h:
- (WebCore::RenderTableSection::hasSameDirectionAsTable):
- Added this helper to know if we have a mixed direction.
-
- (WebCore::RenderTableSection::borderAdjoiningTableStart):
- (WebCore::RenderTableSection::borderAdjoiningTableEnd):
- Updated to account for mixed directionality.
-
-2012-06-06 Keyar Hood <keyar@chromium.org>
-
- [Chromium] imageSmoothingEnabled should apply to patterns
- https://bugs.webkit.org/show_bug.cgi?id=88103
-
- Reviewed by Stephen White.
-
- Test: fast/canvas/canvas-imageSmoothingEnabled-patterns.html
-
- When drawing patterns on a Canvas, the imageSmoothingEnabled flag is
- respected.
- * platform/graphics/skia/PlatformContextSkia.cpp:
- (WebCore::PlatformContextSkia::setupShader):
-
-2012-06-06 Andrey Adaikin <aandrey@chromium.org>
-
- Web Inspector: [JSC] Add WebGL instrumentation support
- https://bugs.webkit.org/show_bug.cgi?id=87975
-
- Reviewed by Vsevolod Vlasov.
-
- * bindings/js/JSInjectedScriptManager.cpp:
- (WebCore::injectAndExecuteFunction):
- (WebCore::InjectedScriptManager::createInjectedScript):
- (WebCore):
- (WebCore::InjectedScriptManager::injectWebGLScript):
- * bindings/v8/custom/V8InjectedScriptManager.cpp:
- (WebCore::InjectedScriptManager::injectWebGLScript):
- * inspector/InjectedScriptManager.cpp:
- (WebCore::InjectedScriptManager::wrapWebGLRenderingContextForInstrumentation):
- * inspector/InjectedScriptManager.h:
- (InjectedScriptManager):
- * inspector/InspectorInstrumentation.h:
- (InspectorInstrumentation):
- * inspector/InspectorWebGLAgent.cpp:
- (WebCore::InspectorWebGLAgent::wrapWebGLRenderingContextForInstrumentation):
- * inspector/InspectorWebGLAgent.h:
- (InspectorWebGLAgent):
- * inspector/InspectorWebGLInstrumentation.h:
- (WebCore::InspectorInstrumentation::wrapWebGLRenderingContextForInstrumentation):
-
-2012-06-06 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
-
- Fix a few spelling mistakes in IconDatabase logging
-
- Makes debugging harder if the logging is confusing.
-
- Reviewed by Jocelyn Turcotte.
-
- * loader/icon/IconDatabase.cpp:
- (WebCore::IconDatabase::notifyPendingLoadDecisions):
- (WebCore::IconDatabase::readFromDatabase):
-
-2012-05-25 Vsevolod Vlasov <vsevik@chromium.org>
-
- Web Inspector: [Compiler] Remove compile-front-end.sh and fix InjectedScriptSource errors.
- https://bugs.webkit.org/show_bug.cgi?id=87512
-
- Reviewed by Yury Semikhatsky.
-
- Removed compile-front-end.sh, compile-front-end.py should be used instead now.
- Made generate_protocol_externs a python module to call it from compile-front-end.py.
- Temporary copy of InjectedScriptSource.js is created and modified to
- avoid "This code lacks side effects" warning.
-
- * inspector/compile-front-end.py:
- * inspector/compile-front-end.sh: Removed.
- * inspector/generate-protocol-externs: Removed.
- * inspector/generate_protocol_externs.py: Added.
- (full_qualified_type_id):
- (param_type):
- (generate_protocol_externs):
-
-2012-06-06 Zoltan Herczeg <zherczeg@webkit.org>
-
- [Qt] REGRESSION(r118616): It made all tests crash in debug mode
- https://bugs.webkit.org/show_bug.cgi?id=87701
-
- Reviewed by Csaba Osztrogonác.
-
- Replace WriteBarrier<JSObject> to Weak<JSObject> by introducing a new
- QtWeakObjectReference sub class. Rewrite all affected type definitions.
-
- All existing test in debug mode cover this issue.
-
- * bridge/qt/qt_class.cpp:
- (JSC::Bindings::QtClass::fallbackObject):
- * bridge/qt/qt_instance.cpp:
- (QtRuntimeObject):
- (JSC::Bindings::QtInstance::removeUnusedMethods):
- * bridge/qt/qt_instance.h:
- (QtInstance):
- (QtWeakObjectReference):
- (JSC::Bindings::QtInstance::QtWeakObjectReference::QtWeakObjectReference):
- (JSC::Bindings::QtInstance::QtWeakObjectReference::operator=):
- (JSC::Bindings::QtInstance::QtWeakObjectReference::get):
- * bridge/qt/qt_runtime.cpp:
- (JSC::Bindings::QtRuntimeMethodData::finalize):
- * bridge/qt/qt_runtime_qt4.cpp:
- (JSC::Bindings::QtRuntimeMethodData::finalize):
-
-2012-06-06 Eugene Klyuchnikov <eustas.bug@gmail.com>
-
- Web Inspector: help/settings screen does not overlay console in split screen mode
- https://bugs.webkit.org/show_bug.cgi?id=88352
-
- Reviewed by Pavel Feldman.
-
- * inspector/front-end/HelpScreen.js:
- (WebInspector.HelpScreen): Mark view as root.
- (WebInspector.HelpScreen.prototype.showModal): Change view parent.
- * inspector/front-end/helpScreen.css:
- (.help-window-outer): Add panel and status bar indent.
- (body.compact .help-window-outer): Ditto.
-
-2012-06-06 Yoshifumi Inoue <yosin@chromium.org>
-
- [Form] Changes for InputNumber type
- https://bugs.webkit.org/show_bug.cgi?id=88394
-
- Reviewed by Kent Tamura.
-
- This patch changes codes for consitency of InputNumber usage for
- reducing size of patch when we change InputNumber type alias from
- double to Decimal.
-
- No new tests. This patch doesn't change behavior.
-
- * html/BaseDateAndTimeInputType.cpp:
- (WebCore::BaseDateAndTimeInputType::serializeWithComponents): Fixed parameter type for getAllowedValueStep.
- * html/InputType.cpp:
- (WebCore::InputType::minimum): Fixed return value type to InputNumber.
- (WebCore::InputType::maximum): ditto.
- * html/MonthInputType.cpp:
- (WebCore::MonthInputType::defaultValueForStepUp): Fix return value type to InputNumber.
- (WebCore::MonthInputType::parseToNumber): ditto.
- * html/NumberInputType.cpp:
- (WebCore::NumberInputType::setValueAsDouble): Removed extra convertDoubleToInputNumber.
- * html/StepRange.cpp:
- (WebCore::StepRange::alignValueForStep): Use roundByStep for code sharing.
- (WebCore::StepRange::clampValue): ditto.
- (WebCore::StepRange::roundByStep): Added.
- * html/StepRange.h:
- (StepRange): Added a declaration of roundByStep.
-
-2012-06-06 Michael Brüning <michael.bruning@nokia.com>
-
- [Qt] Fix harmattan builds broken by r119247.
- https://bugs.webkit.org/show_bug.cgi?id=88330
-
- Reviewed by Jocelyn Turcotte.
-
- Fix Harmattan build break caused by undefined constant
- GL_TEXTURE_RECTANGLE_ARB by adding defined(GL_ARB_texture_rectangle)
- guards around TextureMapperGL::drawTextureRectangleARB.
-
- * platform/graphics/texmap/TextureMapperGL.cpp: Added defined(GL_ARB_texture_rectangle) guards around drawTextureRectangleARB.
- (WebCore):
- * platform/graphics/texmap/TextureMapperGL.h: Added definded(GL_ARB_texture_rectangle) guards around drawTextureRectangleARB.
-
-2012-06-06 Shinya Kawanaka <shinyak@chromium.org>
-
- PositionIterator:;setOffsetInLeafNode() is not used anywhere.
- https://bugs.webkit.org/show_bug.cgi?id=88397
-
- Reviewed by Ryosuke Niwa.
-
- It's not used anywhere. We can remove it safely.
-
- No new tests, no change in behavior.
-
- * WebCore.order:
- * dom/PositionIterator.cpp:
- * dom/PositionIterator.h:
-
-2012-06-06 Andrey Adaikin <aandrey@chromium.org>
-
- Web Inspector: [WebGL] Add WebGL instrumentation support on the backend
- https://bugs.webkit.org/show_bug.cgi?id=87960
-
- Adds a WebGLAgent, injects a WebGL script upon calling the getContext
- method of a HTMLCanvasElement that will wrap the WebGL rendering context
- for instrumentation purposes.
-
- Reviewed by Yury Semikhatsky.
-
- * CMakeLists.txt:
- * DerivedSources.make:
- * DerivedSources.pri:
- * GNUmakefile.am:
- * GNUmakefile.list.am:
- * Target.pri:
- * WebCore.gyp/WebCore.gyp:
- * WebCore.gypi:
- * WebCore.vcproj/WebCore.vcproj:
- * WebCore.xcodeproj/project.pbxproj:
- * bindings/js/JSHTMLCanvasElementCustom.cpp:
- (WebCore::JSHTMLCanvasElement::getContext):
- (WebCore::JSHTMLCanvasElement::toDataURL):
- * bindings/js/JSInjectedScriptManager.cpp:
- (WebCore):
- (WebCore::InjectedScriptManager::injectWebGLScript):
- * bindings/v8/ScriptState.cpp:
- (WebCore::ScriptState::forContext):
- * bindings/v8/custom/V8HTMLCanvasElementCustom.cpp:
- (WebCore::V8HTMLCanvasElement::getContextCallback):
- * bindings/v8/custom/V8InjectedScriptManager.cpp:
- (WebCore::InjectedScriptManager::createInjectedScript):
- (WebCore):
- (WebCore::InjectedScriptManager::injectWebGLScript):
- (WebCore::InjectedScriptManager::discardInjectedScript):
- (WebCore::InjectedScriptManager::injectedScriptFor):
- * inspector/CodeGeneratorInspector.py:
- * inspector/InjectedScriptManager.cpp:
- (WebCore):
- (WebCore::InjectedScriptManager::wrapWebGLRenderingContextForInstrumentation):
- (WebCore::InjectedScriptManager::injectedWebGLScriptSource):
- * inspector/InjectedScriptManager.h:
- (InjectedScriptManager):
- * inspector/InjectedWebGLScriptSource.js: Added.
- * inspector/Inspector.json:
- * inspector/InspectorAllInOne.cpp:
- * inspector/InspectorController.cpp:
- (WebCore::InspectorController::InspectorController):
- * inspector/InspectorInstrumentation.h:
- (WebCore):
- (InspectorInstrumentation):
- (WebCore::InspectorInstrumentation::markResourceAsCached):
- * inspector/InspectorWebGLAgent.cpp: Added.
- (WebCore):
- (WebGLAgentState):
- (WebCore::InspectorWebGLAgent::InspectorWebGLAgent):
- (WebCore::InspectorWebGLAgent::~InspectorWebGLAgent):
- (WebCore::InspectorWebGLAgent::setFrontend):
- (WebCore::InspectorWebGLAgent::clearFrontend):
- (WebCore::InspectorWebGLAgent::restore):
- (WebCore::InspectorWebGLAgent::enable):
- (WebCore::InspectorWebGLAgent::disable):
- (WebCore::InspectorWebGLAgent::wrapWebGLRenderingContextForInstrumentation):
- * inspector/InspectorWebGLAgent.h: Added.
- (WebCore):
- (InspectorWebGLAgent):
- (WebCore::InspectorWebGLAgent::create):
- (WebCore::InspectorWebGLAgent::enabled):
- * inspector/InspectorWebGLInstrumentation.h: Added.
- (WebCore):
- (WebCore::InspectorInstrumentation::wrapWebGLRenderingContextForInstrumentation):
- * inspector/InstrumentingAgents.h:
- (WebCore):
- (WebCore::InstrumentingAgents::InstrumentingAgents):
- (InstrumentingAgents):
- (WebCore::InstrumentingAgents::inspectorWebGLAgent):
- (WebCore::InstrumentingAgents::setInspectorWebGLAgent):
-
-2012-06-06 Joone Hur <joone.hur@intel.com>
-
- [GTK] Build fix for Accelerated Compositing with OpenGL
- https://bugs.webkit.org/show_bug.cgi?id=88292
-
- Reviewed by Martin Robinson.
-
- Build fix after r119247.
- Do not include GraphicsSurface.h when not building
- with GRAPHICS_SURFACE.
-
- No new tests. This is only a build fix.
-
- * platform/graphics/texmap/TextureMapperBackingStore.cpp:
- * platform/graphics/texmap/TextureMapperBackingStore.h:
- * platform/graphics/texmap/TextureMapperGL.cpp:
-
-2012-06-05 Joe Thomas <joethomas@motorola.com>
-
- ASSERTION FAILED: ASSERT(!isPercentageIntrinsicSize) in RenderReplaced::computeIntrinsicRatioInformationForRenderBox
- https://bugs.webkit.org/show_bug.cgi?id=88197
-
- Reviewed by Daniel Bates.
-
- RenderSVGRoot extends RenderReplaced and it overrides the computeIntrinsicRatioInformation()
- method of RenderReplaced. RenderSVGRoot::computeIntrinsicRatioInformation
- sets isPercentageIntrinsicSize to true while it handles width and height of percentage types.
- So this assertion should be fired only if intrinsicRatio is non-zero.
-
- Test: svg/in-html/svg-assert-failure-percentage.html
-
- * rendering/RenderReplaced.cpp:
- (WebCore::RenderReplaced::computeIntrinsicRatioInformationForRenderBox):
-
-2012-06-05 Tony Chang <tony@chromium.org>
-
- Changing flexbox justify/alignment doesn't update their positioning
- https://bugs.webkit.org/show_bug.cgi?id=88366
-
- Reviewed by Ojan Vafai.
-
- Test: css3/flexbox/style-change.html
-
- * rendering/style/RenderStyle.cpp:
- (WebCore::RenderStyle::diff): Since these member variables were moved
- out of StyleFlexibleBoxData, we have to compare them in RenderStyle::diff.
-
-2012-06-05 Charles Wei <charles.wei@torchmobile.com.cn>
-
- JSC implementation of SerializedScriptValue for IndexedDB
- https://bugs.webkit.org/show_bug.cgi?id=88048
-
- Reviewed by George Staikos.
-
- No new tests. All the current indexeddb test cases apply when indexeddb works for JSC.
-
- * bindings/js/SerializedScriptValue.cpp:
- (WebCore::CloneSerializer::serializeNumber):
- (CloneSerializer):
- (WebCore::CloneDeserializer::toWireString):
- (CloneDeserializer):
- (WebCore::SerializedScriptValue::create):
- (WebCore::SerializedScriptValue::toWireString):
- (WebCore):
- (WebCore::SerializedScriptValue::createFromWire):
- (WebCore::SerializedScriptValue::numberValue):
- (WebCore::SerializedScriptValue::deserialize):
-
-2012-06-05 Ojan Vafai <ojan@chromium.org>
-
- Nested CSS flexbox renders incorrectly
- https://bugs.webkit.org/show_bug.cgi?id=87679
-
- Reviewed by Julien Chaffraix.
-
- If the containing block with a perpendicular writing mode has an overrideHeight,
- then its logical height should be based off that instead of its RenderStyle.
-
- Test: css3/flexbox/perpendicular-writing-modes-inside-flex-item.html
-
- * rendering/RenderBox.cpp:
- (WebCore::RenderBox::perpendicularContainingBlockLogicalHeight):
-
-2012-06-05 Charles Wei <charles.wei@torchmobile.com.cn>
-
- Need special-case toJS(IDBAny) for IDBCursorWithValue
- https://bugs.webkit.org/show_bug.cgi?id=87963
-
- Reviewed by George Staikos.
-
- No new tests, this is for indexedDB, which is not working for JSC binding.
- When indexedDB working for JSC, all the indexdb test cases should apply.
-
- * bindings/js/JSIDBAnyCustom.cpp:
- (WebCore::toJS):
-
-2012-06-05 Michal Mocny <mmocny@google.com>
-
- [chromium] Set default memory allocation limit bytes when GL_CHROMIUM_gpu_memory_manager is not supported by graphics context.
- https://bugs.webkit.org/show_bug.cgi?id=87996
-
- Reviewed by James Robinson.
-
- Soon we hope to have renderers not manage there own memory allocation limits, and rely exclusively on the
- allocation given by GpuMemoryManager. However, when the graphics context does not support the
- GL_CHROMIUM_gpu_memory_manager extension, such as the one used by DumpRenderTree, we must default the
- memory allocation limit to some non-0 value.
-
- * platform/graphics/chromium/LayerRendererChromium.cpp:
- (WebCore::LayerRendererChromium::initialize):
- * platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:
- (WebCore::CCSingleThreadProxy::postSetContentsMemoryAllocationLimitBytesToMainThreadOnImplThread):
- * platform/graphics/chromium/cc/CCSingleThreadProxy.h:
- (WebCore):
- (DebugScopedSetMainThreadFromEither):
- (WebCore::DebugScopedSetMainThreadFromEither::DebugScopedSetMainThreadFromEither):
- (WebCore::DebugScopedSetMainThreadFromEither::~DebugScopedSetMainThreadFromEither):
-
-2012-06-05 Roland Takacs <takacs.roland@stud.u-szeged.hu>
-
- [Qt] Use GraphicsContext3DOpenGLES.cpp when using OpenGL ES
- https://bugs.webkit.org/show_bug.cgi?id=78720
-
- Reviewed by Noam Rosenthal.
-
- Functions are removed from GraphicsContext3DQt that already implemented
- in GraphicsContext3DCommon. Macros that not supported at GLES have been
- changed to their appropriate pair that found in GraphicsContext3D
- (e.g. GL_FRAMEBUFFER_EXT to GraphicsContext3D::FRAMEBUFFER).
- It was needed because OpenGLES does not support these macros.
- Extensions3DQt is removed beceause it has never been used.
- Some functions have been moved fron GraphicsContext3DCommon to *OpenGL
- and *OpenGLES to provide specialization.
- The "m_depthStencilBuffer" member is added to Qt port because it uses
- "m_depthStencilBuffer" like the other platforms.
-
- * Target.pri:
- * platform/graphics/GraphicsContext3D.h:
- * platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:
- (WebCore::GraphicsContext3D::depthRange):
- (WebCore):
- (WebCore::GraphicsContext3D::clearDepth):
- * platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:
- (WebCore::GraphicsContext3D::prepareTexture):
- (WebCore::GraphicsContext3D::readRenderingResults):
- (WebCore::GraphicsContext3D::reshape):
- (WebCore::GraphicsContext3D::copyTexImage2D):
- (WebCore::GraphicsContext3D::copyTexSubImage2D):
- (WebCore::GraphicsContext3D::readPixels):
- * platform/graphics/opengl/GraphicsContext3DOpenGLES.cpp:
- (WebCore::GraphicsContext3D::reshapeFBOs):
- (WebCore::GraphicsContext3D::depthRange):
- (WebCore):
- (WebCore::GraphicsContext3D::clearDepth):
- * platform/graphics/qt/GraphicsContext3DQt.cpp:
- (WebCore::GraphicsContext3D::isGLES2Compliant):
- (WebCore::GraphicsContext3DPrivate::blitMultisampleFramebuffer):
- (WebCore::GraphicsContext3D::GraphicsContext3D):
- (WebCore::GraphicsContext3D::~GraphicsContext3D):
- (WebCore):
-
2012-06-05 Vitaly Buka <vitalybuka@chromium.org>
Special layout handler should be done on top frame being printed.
« no previous file with comments | « no previous file | Source/WebCore/page/Frame.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698