Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(541)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10699057: Move application creation and extension install prompt showing off Browser and onto ExtensionTabHel… (Closed)

Created:
8 years, 5 months ago by Ben Goodger (Google)
Modified:
8 years, 5 months ago
Reviewers:
Aaron Boodman
CC:
chromium-reviews, mihaip-chromium-reviews_chromium.org, jam, Dmitry Titov, dcheng, joi+watch-content_chromium.org, jennb, darin-cc_chromium.org, jianli
Visibility:
Public.

Description

Move application creation and extension install prompt showing off Browser and onto ExtensionTabHelper. ExtensionInstallPrompt does not need a Browser, just a parent window, a PageNavigator and a Profile. WebApp metadata retrieval/updating can be done entirely from ExtensionTabHelper. This results in the removal of ExtensionTabHelperDelegate. http://crbug.com/133576 TEST=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=145384

Patch Set 1 : #

Total comments: 18

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+365 lines, -363 lines) Patch
M chrome/browser/automation/testing_automation_provider.cc View 1 2 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/extensions/file_manager_util.cc View 1 2 1 chunk +3 lines, -1 line 0 comments Download
M chrome/browser/download/download_browsertest.cc View 1 2 6 chunks +20 lines, -9 lines 0 comments Download
M chrome/browser/download/download_crx_util.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/identity/identity_api.cc View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/extensions/api/permissions/permissions_api.cc View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/extensions/api/webstore_private/webstore_private_api.cc View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/extensions/bundle_installer.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/crx_installer_browsertest.cc View 1 2 7 chunks +19 lines, -6 lines 0 comments Download
M chrome/browser/extensions/extension_browsertest.cc View 1 2 3 chunks +17 lines, -8 lines 0 comments Download
M chrome/browser/extensions/extension_disabled_ui.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_install_dialog.h View 1 2 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/extensions/extension_install_dialog.cc View 1 2 2 chunks +7 lines, -2 lines 0 comments Download
M chrome/browser/extensions/extension_install_prompt.h View 1 2 4 chunks +23 lines, -3 lines 0 comments Download
M chrome/browser/extensions/extension_install_prompt.cc View 1 2 7 chunks +26 lines, -11 lines 0 comments Download
M chrome/browser/extensions/extension_install_ui.h View 1 2 3 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/extensions/extension_install_ui.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_install_ui_android.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_install_ui_default.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_install_ui_default.cc View 1 2 4 chunks +10 lines, -10 lines 0 comments Download
M chrome/browser/extensions/extension_management_api.cc View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/extensions/extension_navigation_observer.cc View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/extensions/extension_service.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_tab_helper.h View 1 2 4 chunks +33 lines, -11 lines 0 comments Download
M chrome/browser/extensions/extension_tab_helper.cc View 1 2 8 chunks +103 lines, -7 lines 0 comments Download
D chrome/browser/extensions/extension_tab_helper_delegate.h View 1 2 1 chunk +0 lines, -29 lines 0 comments Download
D chrome/browser/extensions/extension_tab_helper_delegate.cc View 1 2 1 chunk +0 lines, -17 lines 0 comments Download
M chrome/browser/extensions/unpacked_installer.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/webstore_inline_installer.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/infobars/infobars_browsertest.cc View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/browser.h View 1 2 7 chunks +0 lines, -26 lines 0 comments Download
M chrome/browser/ui/browser.cc View 1 2 6 chunks +0 lines, -85 lines 0 comments Download
M chrome/browser/ui/browser_command_controller.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/browser_commands.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/browser_commands.cc View 1 2 2 chunks +9 lines, -1 line 0 comments Download
M chrome/browser/ui/browser_dialogs.h View 1 2 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/browser/ui/browser_window.h View 1 2 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/browser_window_cocoa.h View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/browser_window_cocoa.mm View 1 2 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/browser/ui/cocoa/extensions/extension_install_dialog_controller.h View 1 2 3 chunks +5 lines, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/extensions/extension_install_dialog_controller.mm View 1 2 5 chunks +8 lines, -17 lines 0 comments Download
M chrome/browser/ui/cocoa/extensions/extension_install_dialog_controller_unittest.mm View 1 2 6 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/ui/extensions/application_launch.cc View 1 2 1 chunk +3 lines, -1 line 0 comments Download
M chrome/browser/ui/gtk/browser_window_gtk.h View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/ui/gtk/browser_window_gtk.cc View 1 2 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/browser/ui/gtk/create_application_shortcuts_dialog_gtk.cc View 1 2 2 chunks +8 lines, -4 lines 0 comments Download
M chrome/browser/ui/gtk/extensions/extension_install_dialog_gtk.cc View 1 2 5 chunks +11 lines, -20 lines 0 comments Download
M chrome/browser/ui/panels/panel_browser_window.h View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/ui/panels/panel_browser_window.cc View 1 2 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/browser/ui/views/browser_dialogs.h View 1 2 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/ui/views/extensions/extension_install_dialog_view.cc View 1 2 5 chunks +11 lines, -21 lines 0 comments Download
M chrome/browser/ui/views/frame/browser_view.h View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/frame/browser_view.cc View 1 2 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/ui/webui/extensions/install_extension_handler.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/ntp/app_launcher_handler.cc View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M chrome/chrome_browser_extensions.gypi View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/test/base/test_browser_window.h View 1 2 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Ben Goodger (Google)
8 years, 5 months ago (2012-07-02 21:34:43 UTC) #1
Aaron Boodman
Nice change. http://codereview.chromium.org/10699057/diff/13095/chrome/browser/automation/testing_automation_provider.cc File chrome/browser/automation/testing_automation_provider.cc (right): http://codereview.chromium.org/10699057/diff/13095/chrome/browser/automation/testing_automation_provider.cc#newcode4021 chrome/browser/automation/testing_automation_provider.cc:4021: (with_ui ? chrome::CreateExtensionInstallPromptWithBrowser( I'm no style expert, ...
8 years, 5 months ago (2012-07-03 00:52:14 UTC) #2
Ben Goodger (Google)
Thanks for the review! Updated. http://codereview.chromium.org/10699057/diff/13095/chrome/browser/automation/testing_automation_provider.cc File chrome/browser/automation/testing_automation_provider.cc (right): http://codereview.chromium.org/10699057/diff/13095/chrome/browser/automation/testing_automation_provider.cc#newcode4021 chrome/browser/automation/testing_automation_provider.cc:4021: (with_ui ? chrome::CreateExtensionInstallPromptWithBrowser( On ...
8 years, 5 months ago (2012-07-03 19:17:00 UTC) #3
Aaron Boodman
8 years, 5 months ago (2012-07-03 20:38:29 UTC) #4 
LGTM

Powered by Google App Engine
This is Rietveld 408576698