Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2775)

Unified Diff: chrome/browser/extensions/extension_install_prompt.h

Issue 10699057: Move application creation and extension install prompt showing off Browser and onto ExtensionTabHel… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/extension_install_prompt.h
===================================================================
--- chrome/browser/extensions/extension_install_prompt.h (revision 145357)
+++ chrome/browser/extensions/extension_install_prompt.h (working copy)
@@ -23,13 +23,18 @@
class Browser;
class ExtensionInstallUI;
+class InfoBarDelegate;
class MessageLoop;
-class InfoBarDelegate;
+class Profile;
namespace base {
class DictionaryValue;
} // namespace base
+namespace content {
+class PageNavigator;
+}
+
namespace extensions {
class BundleInstaller;
class Extension;
@@ -160,7 +165,11 @@
const std::string& localized_description,
std::string* error);
- explicit ExtensionInstallPrompt(Browser* browser);
+ // Creates a prompt with a parent window and a navigator that can be used to
+ // load pages.
+ ExtensionInstallPrompt(gfx::NativeWindow parent,
+ content::PageNavigator* navigator,
+ Profile* profile);
virtual ~ExtensionInstallPrompt();
ExtensionInstallUI* install_ui() const { return install_ui_.get(); }
@@ -270,7 +279,8 @@
// Shows the actual UI (the icon should already be loaded).
void ShowConfirmation();
- Browser* browser_;
+ gfx::NativeWindow parent_;
+ content::PageNavigator* navigator_;
MessageLoop* ui_loop_;
// The extensions installation icon.
@@ -304,4 +314,14 @@
ImageLoadingTracker tracker_;
};
+namespace chrome {
+
+// Creates an ExtensionInstallPrompt from |browser|. Caller assumes ownership.
+// TODO(beng): remove this once various extensions types are weaned from
+// Browser.
+ExtensionInstallPrompt* CreateExtensionInstallPromptWithBrowser(
+ Browser* browser);
+
+} // namespace chrome
+
#endif // CHROME_BROWSER_EXTENSIONS_EXTENSION_INSTALL_PROMPT_H_
« no previous file with comments | « chrome/browser/extensions/extension_install_dialog.cc ('k') | chrome/browser/extensions/extension_install_prompt.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698