chrome/browser/ui/extensions/application_launch.cc - Issue 10699057: Move application creation and extension install prompt showing off Browser and onto ExtensionTabHel…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/extensions/application_launch.cc

Issue 10699057: Move application creation and extension install prompt showing off Browser and onto ExtensionTabHel… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/

Patch Set: Created 8 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/cocoa/extensions/extension_install_dialog_controller_unittest.mm ('k') | chrome/browser/ui/gtk/browser_window_gtk.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/extensions/application_launch.cc

===================================================================

--- chrome/browser/ui/extensions/application_launch.cc (revision 145357)

+++ chrome/browser/ui/extensions/application_launch.cc (working copy)

@@ -245,13 +245,15 @@

return NULL;

if (update_shortcut) {

+ TabContents* tab_contents = TabContents::FromWebContents(tab);

// Set UPDATE_SHORTCUT as the pending web app action. This action is picked

// up in LoadingStateChanged to schedule a GetApplicationInfo. And when

// the web app info is available, ExtensionTabHelper notifies Browser via

// OnDidGetApplicationInfo, which calls

// web_app::UpdateShortcutForTabContents when it sees UPDATE_SHORTCUT as

// pending web app action.

- app_browser->set_pending_web_app_action(Browser::UPDATE_SHORTCUT);

+ tab_contents->extension_tab_helper()->set_pending_web_app_action(

+ ExtensionTabHelper::UPDATE_SHORTCUT);

}

return tab;

}