Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Issue 10698168: Part 3 of Move SelectFileDialog implementation to ui/base/dialogs/ (Closed)

Created:
8 years, 5 months ago by Elliot Glaysher
Modified:
8 years, 5 months ago
Reviewers:
sky
CC:
chromium-reviews, Aaron Boodman, mihaip-chromium-reviews_chromium.org, sadrul, ben+watch_chromium.org
Visibility:
Public.

Description

Part 3 of Move SelectFileDialog implementation to ui/base/dialogs/ - Actually move the SelectFileDialog class to ui::, leaving a compatibility header in the interim. - Because of linking reasons, create a factory interface for the SelectFileDialogExtension to use to inject itself from chrome/browser/views/ui/ - Because of linking reasons, move SelectFileDialogWin in this patch. - wstring code moved to win only files. BUG=134529 TEST=none First Review URL: https://chromiumcodereview.appspot.com/10695066 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=147263

Patch Set 1 #

Patch Set 2 : With some windows fix #

Patch Set 3 : Maybe fix full win build. #

Patch Set 4 : More win fix. #

Patch Set 5 : More win #

Patch Set 6 : More fix #

Patch Set 7 : More fix for aura #

Patch Set 8 : 8th time a charm? #

Patch Set 9 : Maybe needs to be in this file list? #

Patch Set 10 : More export. #

Patch Set 11 : More namespace to force rebuild. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+311 lines, -1527 lines) Patch
M chrome/browser/file_select_helper.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/certificate_dialogs.h View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/ui/select_file_dialog.h View 1 chunk +3 lines, -186 lines 0 comments Download
D chrome/browser/ui/select_file_dialog.cc View 1 chunk +0 lines, -88 lines 0 comments Download
M chrome/browser/ui/views/ash/chrome_browser_main_extra_parts_ash.cc View 2 chunks +9 lines, -0 lines 0 comments Download
D chrome/browser/ui/views/base_shell_dialog_win.h View 1 chunk +0 lines, -92 lines 0 comments Download
D chrome/browser/ui/views/base_shell_dialog_win.cc View 1 chunk +0 lines, -104 lines 0 comments Download
M chrome/browser/ui/views/color_chooser_dialog.h View 1 2 3 4 5 6 7 8 9 10 2 chunks +2 lines, -2 lines 0 comments Download
D chrome/browser/ui/views/select_file_dialog_aura.cc View 1 chunk +0 lines, -22 lines 0 comments Download
M chrome/browser/ui/views/select_file_dialog_extension.cc View 1 chunk +2 lines, -11 lines 0 comments Download
A chrome/browser/ui/views/select_file_dialog_extension_factory.h View 1 chunk +25 lines, -0 lines 0 comments Download
A chrome/browser/ui/views/select_file_dialog_extension_factory.cc View 1 chunk +19 lines, -0 lines 0 comments Download
D chrome/browser/ui/views/select_file_dialog_win.cc View 1 chunk +0 lines, -858 lines 0 comments Download
D chrome/browser/ui/views/select_file_dialog_win_unittest.cc View 1 chunk +0 lines, -44 lines 0 comments Download
M chrome/browser/ui/webui/print_preview/print_preview_handler.h View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 6 chunks +6 lines, -7 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 2 chunks +0 lines, -2 lines 0 comments Download
A + ui/base/dialogs/base_shell_dialog_win.h View 1 2 3 4 5 6 7 8 9 10 2 chunks +10 lines, -5 lines 0 comments Download
A + ui/base/dialogs/base_shell_dialog_win.cc View 1 2 3 4 5 6 7 8 9 10 3 chunks +9 lines, -2 lines 0 comments Download
A + ui/base/dialogs/select_file_dialog.h View 6 chunks +18 lines, -20 lines 0 comments Download
A + ui/base/dialogs/select_file_dialog.cc View 1 2 3 4 5 6 7 3 chunks +53 lines, -15 lines 0 comments Download
A ui/base/dialogs/select_file_dialog_factory.h View 1 chunk +29 lines, -0 lines 0 comments Download
A ui/base/dialogs/select_file_dialog_factory.cc View 1 chunk +11 lines, -0 lines 0 comments Download
A ui/base/dialogs/select_file_dialog_win.h View 1 2 3 4 1 chunk +29 lines, -0 lines 0 comments Download
A + ui/base/dialogs/select_file_dialog_win.cc View 1 2 3 4 5 6 7 8 9 10 8 chunks +59 lines, -64 lines 0 comments Download
A + ui/base/dialogs/select_file_dialog_win_unittest.cc View 1 2 3 4 5 6 2 chunks +6 lines, -5 lines 0 comments Download
M ui/base/ui_base_exports.cc View 1 2 3 4 5 6 7 8 1 chunk +1 line, -0 lines 0 comments Download
M ui/ui.gyp View 1 2 3 4 5 6 7 2 chunks +9 lines, -0 lines 0 comments Download
M ui/ui_unittests.gypi View 1 2 3 4 5 6 7 8 9 10 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Elliot Glaysher
A part of this patch was previously committed and then reverted. Due to how windows ...
8 years, 5 months ago (2012-07-17 22:53:12 UTC) #1
sky
LGTM
8 years, 5 months ago (2012-07-17 23:30:28 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/erg@chromium.org/10698168/14004
8 years, 5 months ago (2012-07-17 23:31:26 UTC) #3
commit-bot: I haz the power
8 years, 5 months ago (2012-07-17 23:31:41 UTC) #4
Presubmit check for 10698168-14004 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit Warnings **
New code should not use wstrings.  If you are calling an API that accepts a
wstring, fix the API.
    ui/base/dialogs/select_file_dialog_win.cc:816
    ui/base/dialogs/select_file_dialog_win.cc:817
    ui/base/dialogs/select_file_dialog_win.cc:818
    ui/base/dialogs/select_file_dialog_win.cc:819
    ui/base/dialogs/select_file_dialog_win.cc:821
    ui/base/dialogs/select_file_dialog_win.cc:828
    ui/base/dialogs/select_file_dialog_win.cc:830
    ui/base/dialogs/select_file_dialog_win.h:16
    ui/base/dialogs/select_file_dialog_win.h:17
    ui/base/dialogs/select_file_dialog_win.h:18
    ui/base/dialogs/select_file_dialog_win.h:19

Presubmit checks took 1.9s to calculate.

Powered by Google App Engine
This is Rietveld 408576698