|
|
Part 3 of Move SelectFileDialog implementation to ui/base/dialogs/
- Actually move the SelectFileDialog class to ui::, leaving a compatibility header in the interim.
- Because of linking reasons, create a factory interface for the SelectFileDialogExtension to use to inject itself from chrome/browser/views/ui/
- Because of linking reasons, move SelectFileDialogWin in this patch.
- wstring code moved to win only files.
BUG= 134529
TEST=none
First Review URL: https://chromiumcodereview.appspot.com/10695066
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=147263
|
Unified diffs |
Side-by-side diffs |
Delta from patch set |
Stats (+311 lines, -1527 lines) |
Patch |
 |
M |
chrome/browser/file_select_helper.h
|
View
|
|
1 chunk |
+1 line, -0 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/ui/certificate_dialogs.h
|
View
|
|
1 chunk |
+4 lines, -0 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/ui/select_file_dialog.h
|
View
|
|
1 chunk |
+3 lines, -186 lines |
0 comments
|
Download
|
 |
D |
chrome/browser/ui/select_file_dialog.cc
|
View
|
|
1 chunk |
+0 lines, -88 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/ui/views/ash/chrome_browser_main_extra_parts_ash.cc
|
View
|
|
2 chunks |
+9 lines, -0 lines |
0 comments
|
Download
|
 |
D |
chrome/browser/ui/views/base_shell_dialog_win.h
|
View
|
|
1 chunk |
+0 lines, -92 lines |
0 comments
|
Download
|
 |
D |
chrome/browser/ui/views/base_shell_dialog_win.cc
|
View
|
|
1 chunk |
+0 lines, -104 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/ui/views/color_chooser_dialog.h
|
View
|
1
2
3
4
5
6
7
8
9
10
|
2 chunks |
+2 lines, -2 lines |
0 comments
|
Download
|
 |
D |
chrome/browser/ui/views/select_file_dialog_aura.cc
|
View
|
|
1 chunk |
+0 lines, -22 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/ui/views/select_file_dialog_extension.cc
|
View
|
|
1 chunk |
+2 lines, -11 lines |
0 comments
|
Download
|
 |
A |
chrome/browser/ui/views/select_file_dialog_extension_factory.h
|
View
|
|
1 chunk |
+25 lines, -0 lines |
0 comments
|
Download
|
 |
A |
chrome/browser/ui/views/select_file_dialog_extension_factory.cc
|
View
|
|
1 chunk |
+19 lines, -0 lines |
0 comments
|
Download
|
 |
D |
chrome/browser/ui/views/select_file_dialog_win.cc
|
View
|
|
1 chunk |
+0 lines, -858 lines |
0 comments
|
Download
|
 |
D |
chrome/browser/ui/views/select_file_dialog_win_unittest.cc
|
View
|
|
1 chunk |
+0 lines, -44 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/ui/webui/print_preview/print_preview_handler.h
|
View
|
|
1 chunk |
+4 lines, -0 lines |
0 comments
|
Download
|
 |
M |
chrome/chrome_browser.gypi
|
View
|
1
|
6 chunks |
+6 lines, -7 lines |
0 comments
|
Download
|
 |
M |
chrome/chrome_tests.gypi
|
View
|
1
|
2 chunks |
+0 lines, -2 lines |
0 comments
|
Download
|
 |
A + |
ui/base/dialogs/base_shell_dialog_win.h
|
View
|
1
2
3
4
5
6
7
8
9
10
|
2 chunks |
+10 lines, -5 lines |
0 comments
|
Download
|
 |
A + |
ui/base/dialogs/base_shell_dialog_win.cc
|
View
|
1
2
3
4
5
6
7
8
9
10
|
3 chunks |
+9 lines, -2 lines |
0 comments
|
Download
|
 |
A + |
ui/base/dialogs/select_file_dialog.h
|
View
|
|
6 chunks |
+18 lines, -20 lines |
0 comments
|
Download
|
 |
A + |
ui/base/dialogs/select_file_dialog.cc
|
View
|
1
2
3
4
5
6
7
|
3 chunks |
+53 lines, -15 lines |
0 comments
|
Download
|
 |
A |
ui/base/dialogs/select_file_dialog_factory.h
|
View
|
|
1 chunk |
+29 lines, -0 lines |
0 comments
|
Download
|
 |
A |
ui/base/dialogs/select_file_dialog_factory.cc
|
View
|
|
1 chunk |
+11 lines, -0 lines |
0 comments
|
Download
|
 |
A |
ui/base/dialogs/select_file_dialog_win.h
|
View
|
1
2
3
4
|
1 chunk |
+29 lines, -0 lines |
0 comments
|
Download
|
 |
A + |
ui/base/dialogs/select_file_dialog_win.cc
|
View
|
1
2
3
4
5
6
7
8
9
10
|
8 chunks |
+59 lines, -64 lines |
0 comments
|
Download
|
 |
A + |
ui/base/dialogs/select_file_dialog_win_unittest.cc
|
View
|
1
2
3
4
5
6
|
2 chunks |
+6 lines, -5 lines |
0 comments
|
Download
|
 |
M |
ui/base/ui_base_exports.cc
|
View
|
1
2
3
4
5
6
7
8
|
1 chunk |
+1 line, -0 lines |
0 comments
|
Download
|
 |
M |
ui/ui.gyp
|
View
|
1
2
3
4
5
6
7
|
2 chunks |
+9 lines, -0 lines |
0 comments
|
Download
|
 |
M |
ui/ui_unittests.gypi
|
View
|
1
2
3
4
5
6
7
8
9
10
|
2 chunks |
+2 lines, -0 lines |
0 comments
|
Download
|
Total messages: 4 (0 generated)
|