Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1019)

Unified Diff: chrome/browser/ui/views/select_file_dialog_extension.cc

Issue 10698168: Part 3 of Move SelectFileDialog implementation to ui/base/dialogs/ (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: More namespace to force rebuild. Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/select_file_dialog_extension.cc
diff --git a/chrome/browser/ui/views/select_file_dialog_extension.cc b/chrome/browser/ui/views/select_file_dialog_extension.cc
index 0f9cbfbcc634d3180de859d45d09337eed3f5e8b..69fc0b215ee902e65792d24dda0607cfe913404a 100644
--- a/chrome/browser/ui/views/select_file_dialog_extension.cc
+++ b/chrome/browser/ui/views/select_file_dialog_extension.cc
@@ -80,21 +80,12 @@ scoped_refptr<SelectFileDialogExtension> PendingDialog::Find(int32 tab_id) {
} // namespace
-// Linking this implementation of SelectFileDialog::Create into the target
-// selects FileManagerDialog as the dialog of choice.
+/////////////////////////////////////////////////////////////////////////////
+
// TODO(jamescook): Move this into a new file shell_dialogs_chromeos.cc
// TODO(jamescook): Change all instances of SelectFileDialog::Create to return
// scoped_refptr<SelectFileDialog> as object is ref-counted.
// static
-SelectFileDialog* SelectFileDialog::Create(Listener* listener,
- ui::SelectFilePolicy* policy) {
- DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
- return SelectFileDialogExtension::Create(listener, policy);
-}
-
-/////////////////////////////////////////////////////////////////////////////
-
-// static
SelectFileDialogExtension* SelectFileDialogExtension::Create(
Listener* listener,
ui::SelectFilePolicy* policy) {
« no previous file with comments | « chrome/browser/ui/views/select_file_dialog_aura.cc ('k') | chrome/browser/ui/views/select_file_dialog_extension_factory.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698