Move SelectFileDialog implementation to ui/base/dialogs/

Part 3 of Move SelectFileDialog implementation to ui/base/dialogs/

-Actually move the SelectFileDialog class to ui::, leaving a
compatibility header in the interim.
- Because of linking reasons, create a factory interface for the SelectFileDialogExtension to use to inject itself from chrome/browser/views/ui/
- wstring code moved to win only files.

BUG=134529
TEST=none

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=146382

[James Cook, 2012-07-11 22:15:56]

Most files say "error: old chunk mismatch", maybe it needs a re-upload?

The factory approach overall seems good to me (I can see a few of the factory
files).  I'll have more to say when I can see the diffs.

[Elliot Glaysher, 2012-07-11 22:24:09]

ptal. I don't know what happened with rietveld.

[James Cook, 2012-07-11 22:34:14]

LGTM with two optional comments. I like the overall factory approach.

http://codereview.chromium.org/10695066/diff/5006/chrome/browser/ui/views/sel...
File chrome/browser/ui/views/select_file_dialog_extension.cc (right):

http://codereview.chromium.org/10695066/diff/5006/chrome/browser/ui/views/sel...
chrome/browser/ui/views/select_file_dialog_extension.cc:83: /*
Did you mean to leave this in?

http://codereview.chromium.org/10695066/diff/5006/ui/base/dialogs/select_file...
File ui/base/dialogs/select_file_dialog.h (right):

http://codereview.chromium.org/10695066/diff/5006/ui/base/dialogs/select_file...
ui/base/dialogs/select_file_dialog.h:42: class UI_EXPORT Listener {
Optional suggestion: Perhaps this should be in a separate file and at ui:: scope
so it can be forward declared and includes of this file can be avoided?  I saw
an include elsewhere that seemed to exist solely to declare a pointer of
SelectFileDialog::Listener*.

[Elliot Glaysher, 2012-07-11 22:40:16]

http://codereview.chromium.org/10695066/diff/5006/ui/base/dialogs/select_file...
File ui/base/dialogs/select_file_dialog.h (right):

http://codereview.chromium.org/10695066/diff/5006/ui/base/dialogs/select_file...
ui/base/dialogs/select_file_dialog.h:42: class UI_EXPORT Listener {
On 2012/07/11 22:34:14, James Cook (Chromium) wrote:
> Optional suggestion: Perhaps this should be in a separate file and at ui::
scope
> so it can be forward declared and includes of this file can be avoided?  I saw
> an include elsewhere that seemed to exist solely to declare a pointer of
> SelectFileDialog::Listener*.

That's a good idea. I've filed
https://code.google.com/p/chromium/issues/detail?id=136909 because this
interface is used all over the place and this patch is already getting pretty
big.

[Ben Goodger (Google), 2012-07-12 02:56:23]

lgtm

http://codereview.chromium.org/10695066/diff/5006/chrome/browser/ui/views/sel...
File chrome/browser/ui/views/select_file_dialog_extension_factory.h (right):

http://codereview.chromium.org/10695066/diff/5006/chrome/browser/ui/views/sel...
chrome/browser/ui/views/select_file_dialog_extension_factory.h:16: // Override
from ui::SelectFileDialogFactory:
private?