Move the callback out of the Read method and into Initialize to make Read loops simpler.

Move the callback out of the Read method and into Initialize to make Read loops simpler.
TEST=Run media_unittests --gtest_filter=*AsyncSocketIoHandlerTest*

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=145453

[no longer working on chromium, 2012-07-04 09:54:55]

Nice work, lgtm with one nit.

https://chromiumcodereview.appspot.com/10697069/diff/6001/media/audio/async_s...
File media/audio/async_socket_io_handler_win.cc (right):

https://chromiumcodereview.appspot.com/10697069/diff/6001/media/audio/async_s...
media/audio/async_socket_io_handler_win.cc:53: is_pending_ = !ok &&
(GetLastError() == ERROR_IO_PENDING);
From the code, it seems that we run the callback only in OnIOCompleted().
But the comment above is a bit confusing, does it mean that we need to run the
callback explicitly when is_pending == false?

[tommi (sloooow) - chröme, 2012-07-04 12:12:40]

https://chromiumcodereview.appspot.com/10697069/diff/6001/media/audio/async_s...
File media/audio/async_socket_io_handler_win.cc (right):

https://chromiumcodereview.appspot.com/10697069/diff/6001/media/audio/async_s...
media/audio/async_socket_io_handler_win.cc:53: is_pending_ = !ok &&
(GetLastError() == ERROR_IO_PENDING);
On 2012/07/04 09:54:55, xians1 wrote:
> From the code, it seems that we run the callback only in OnIOCompleted().

That's correct.

> But the comment above is a bit confusing, does it mean that we need to run the
> callback explicitly when is_pending == false?

"OnIOCompleted() will be called regardless and we don't need to explicitly run
the callback" is really the key.  Can you tell me which part it is that's
confusing you?