Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(299)

Issue 10695120: Ensure that all descriptors have a valid enumeration index, and replace NextEnumIndex with LastAdde… (Closed)

Created:
8 years, 5 months ago by Toon Verwaest
Modified:
8 years, 5 months ago
Reviewers:
danno
CC:
v8-dev
Visibility:
Public.

Description

Ensure that all descriptors have a valid enumeration index, and replace NextEnumIndex with LastAdded. The LastAdded points to the descriptor that was last added to the array. From the descriptor we can deduce the NextEnumerationIndex. This allows us to quickly find the property that we are transitioning to, which is necessary for transition-intensive code, eg JSON parsing. Committed: https://code.google.com/p/v8/source/detail?r=12042

Patch Set 1 : Merge with bleeding edge #

Total comments: 1

Patch Set 2 : Addressed comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+180 lines, -126 lines) Patch
M src/arm/full-codegen-arm.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/arm/lithium-codegen-arm.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/arm/macro-assembler-arm.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/bootstrapper.cc View 8 chunks +75 lines, -45 lines 0 comments Download
M src/factory.cc View 4 chunks +18 lines, -8 lines 0 comments Download
M src/heap.cc View 1 chunk +1 line, -3 lines 0 comments Download
M src/ia32/full-codegen-ia32.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/ia32/lithium-codegen-ia32.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/ia32/macro-assembler-ia32.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/ic.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M src/objects.h View 3 chunks +26 lines, -18 lines 0 comments Download
M src/objects.cc View 1 21 chunks +43 lines, -33 lines 0 comments Download
M src/objects-inl.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/property.h View 4 chunks +4 lines, -4 lines 0 comments Download
M src/transitions-inl.h View 1 chunk +1 line, -2 lines 0 comments Download
M src/x64/full-codegen-x64.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/x64/lithium-codegen-x64.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/x64/macro-assembler-x64.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Toon Verwaest
PTAL.
8 years, 5 months ago (2012-07-09 12:24:35 UTC) #1
danno
LGTM with comment http://codereview.chromium.org/10695120/diff/3001/src/objects.cc File src/objects.cc (right): http://codereview.chromium.org/10695120/diff/3001/src/objects.cc#newcode6030 src/objects.cc:6030: break; Verify that none of the ...
8 years, 5 months ago (2012-07-11 14:02:10 UTC) #2
Toon Verwaest
8 years, 5 months ago (2012-07-11 14:23:41 UTC) #3
Addressed comment. Apparently the last value in the descriptor array isn't
always the last added, so now I linearly scan through it.

Powered by Google App Engine
This is Rietveld 408576698