Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Side by Side Diff: src/x64/macro-assembler-x64.cc

Issue 10695120: Ensure that all descriptors have a valid enumeration index, and replace NextEnumIndex with LastAdde… (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Addressed comment. Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/x64/lithium-codegen-x64.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 4455 matching lines...) Expand 10 before | Expand all | Expand 10 after
4466 movq(rdx, FieldOperand(rbx, Map::kInstanceDescriptorsOrBackPointerOffset)); 4466 movq(rdx, FieldOperand(rbx, Map::kInstanceDescriptorsOrBackPointerOffset));
4467 4467
4468 CheckMap(rdx, 4468 CheckMap(rdx,
4469 isolate()->factory()->fixed_array_map(), 4469 isolate()->factory()->fixed_array_map(),
4470 call_runtime, 4470 call_runtime,
4471 DONT_DO_SMI_CHECK); 4471 DONT_DO_SMI_CHECK);
4472 4472
4473 // Check that there is an enum cache in the non-empty instance 4473 // Check that there is an enum cache in the non-empty instance
4474 // descriptors (rdx). This is the case if the next enumeration 4474 // descriptors (rdx). This is the case if the next enumeration
4475 // index field does not contain a smi. 4475 // index field does not contain a smi.
4476 movq(rdx, FieldOperand(rdx, DescriptorArray::kEnumerationIndexOffset)); 4476 movq(rdx, FieldOperand(rdx, DescriptorArray::kLastAddedOffset));
4477 JumpIfSmi(rdx, call_runtime); 4477 JumpIfSmi(rdx, call_runtime);
4478 4478
4479 // For all objects but the receiver, check that the cache is empty. 4479 // For all objects but the receiver, check that the cache is empty.
4480 Label check_prototype; 4480 Label check_prototype;
4481 cmpq(rcx, rax); 4481 cmpq(rcx, rax);
4482 j(equal, &check_prototype, Label::kNear); 4482 j(equal, &check_prototype, Label::kNear);
4483 movq(rdx, FieldOperand(rdx, DescriptorArray::kEnumCacheBridgeCacheOffset)); 4483 movq(rdx, FieldOperand(rdx, DescriptorArray::kEnumCacheBridgeCacheOffset));
4484 cmpq(rdx, empty_fixed_array_value); 4484 cmpq(rdx, empty_fixed_array_value);
4485 j(not_equal, call_runtime); 4485 j(not_equal, call_runtime);
4486 4486
4487 // Load the prototype from the map and loop if non-null. 4487 // Load the prototype from the map and loop if non-null.
4488 bind(&check_prototype); 4488 bind(&check_prototype);
4489 movq(rcx, FieldOperand(rbx, Map::kPrototypeOffset)); 4489 movq(rcx, FieldOperand(rbx, Map::kPrototypeOffset));
4490 cmpq(rcx, null_value); 4490 cmpq(rcx, null_value);
4491 j(not_equal, &next); 4491 j(not_equal, &next);
4492 } 4492 }
4493 4493
4494 4494
4495 } } // namespace v8::internal 4495 } } // namespace v8::internal
4496 4496
4497 #endif // V8_TARGET_ARCH_X64 4497 #endif // V8_TARGET_ARCH_X64
OLDNEW
« no previous file with comments | « src/x64/lithium-codegen-x64.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698