Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(493)

Side by Side Diff: src/ia32/full-codegen-ia32.cc

Issue 10695120: Ensure that all descriptors have a valid enumeration index, and replace NextEnumIndex with LastAdde… (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Addressed comment. Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/heap.cc ('k') | src/ia32/lithium-codegen-ia32.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 1074 matching lines...) Expand 10 before | Expand all | Expand 10 after
1085 __ push(eax); 1085 __ push(eax);
1086 __ CallRuntime(Runtime::kGetPropertyNamesFast, 1); 1086 __ CallRuntime(Runtime::kGetPropertyNamesFast, 1);
1087 __ cmp(FieldOperand(eax, HeapObject::kMapOffset), 1087 __ cmp(FieldOperand(eax, HeapObject::kMapOffset),
1088 isolate()->factory()->meta_map()); 1088 isolate()->factory()->meta_map());
1089 __ j(not_equal, &fixed_array); 1089 __ j(not_equal, &fixed_array);
1090 1090
1091 1091
1092 // We got a map in register eax. Get the enumeration cache from it. 1092 // We got a map in register eax. Get the enumeration cache from it.
1093 __ bind(&use_cache); 1093 __ bind(&use_cache);
1094 __ LoadInstanceDescriptors(eax, ecx); 1094 __ LoadInstanceDescriptors(eax, ecx);
1095 __ mov(ecx, FieldOperand(ecx, DescriptorArray::kEnumerationIndexOffset)); 1095 __ mov(ecx, FieldOperand(ecx, DescriptorArray::kLastAddedOffset));
1096 __ mov(edx, FieldOperand(ecx, DescriptorArray::kEnumCacheBridgeCacheOffset)); 1096 __ mov(edx, FieldOperand(ecx, DescriptorArray::kEnumCacheBridgeCacheOffset));
1097 1097
1098 // Set up the four remaining stack slots. 1098 // Set up the four remaining stack slots.
1099 __ push(eax); // Map. 1099 __ push(eax); // Map.
1100 __ push(edx); // Enumeration cache. 1100 __ push(edx); // Enumeration cache.
1101 __ mov(eax, FieldOperand(edx, FixedArray::kLengthOffset)); 1101 __ mov(eax, FieldOperand(edx, FixedArray::kLengthOffset));
1102 __ push(eax); // Enumeration cache length (as smi). 1102 __ push(eax); // Enumeration cache length (as smi).
1103 __ push(Immediate(Smi::FromInt(0))); // Initial index. 1103 __ push(Immediate(Smi::FromInt(0))); // Initial index.
1104 __ jmp(&loop); 1104 __ jmp(&loop);
1105 1105
(...skipping 3443 matching lines...) Expand 10 before | Expand all | Expand 10 after
4549 *context_length = 0; 4549 *context_length = 0;
4550 return previous_; 4550 return previous_;
4551 } 4551 }
4552 4552
4553 4553
4554 #undef __ 4554 #undef __
4555 4555
4556 } } // namespace v8::internal 4556 } } // namespace v8::internal
4557 4557
4558 #endif // V8_TARGET_ARCH_IA32 4558 #endif // V8_TARGET_ARCH_IA32
OLDNEW
« no previous file with comments | « src/heap.cc ('k') | src/ia32/lithium-codegen-ia32.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698