Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Unified Diff: chrome/browser/extensions/api/extension_action/extension_actions_api.h

Issue 10695070: Implement scriptBadge.requestToAct. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/extension_action/extension_actions_api.h
diff --git a/chrome/browser/extensions/api/extension_action/extension_actions_api.h b/chrome/browser/extensions/api/extension_action/extension_actions_api.h
index 4924051c9f5cd21814c15367a21ed6344d5b8de0..bc08b3cc9bf34a52d8d2bc034f7557e97aad99b5 100644
--- a/chrome/browser/extensions/api/extension_action/extension_actions_api.h
+++ b/chrome/browser/extensions/api/extension_action/extension_actions_api.h
@@ -12,6 +12,7 @@
namespace base {
class DictionaryValue;
}
+class ExtensionTabHelper;
class TabContents;
// Implementation of the browserAction, pageAction, and scriptBadge APIs.
@@ -35,6 +36,10 @@ class ExtensionActionFunction : public SyncExtensionFunction {
void NotifyLocationBarChange();
bool SetVisible(bool visible);
+ // Extension-related information for |tab_id_|.
+ // CHECK-fails if there is no tab.
+ ExtensionTabHelper& tab_helper() const;
Aaron Boodman 2012/07/03 01:29:31 These are supposed to be const-ref in Chrome.
Jeffrey Yasskin 2012/07/10 21:52:33 I don't see that in the style guide. http://googl
Aaron Boodman 2012/07/10 22:50:46 Hm, ok.
+
// All the extension action APIs take a single argument called details that
// is a dictionary.
base::DictionaryValue* details_;

Powered by Google App Engine
This is Rietveld 408576698