Implement scriptBadge.requestToAct.

chrome/browser/extensions/api/extension_action/extension_actions_api.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_EXTENSIONS_API_EXTENSION_ACTION_EXTENSION_ACTIONS_API_H_
 #define CHROME_BROWSER_EXTENSIONS_API_EXTENSION_ACTION_EXTENSION_ACTIONS_API_H_
 #pragma once
 
 #include "chrome/browser/extensions/extension_function.h"
 #include "chrome/common/extensions/extension_action.h"
 
 namespace base {
 class DictionaryValue;
 }
+class ExtensionTabHelper;
 class TabContents;
 
 // Implementation of the browserAction, pageAction, and scriptBadge APIs.
 //
 // Divergent behaviour between the three is minimal (pageAction and scriptBadge
 // have required tabIds while browserAction's are optional, they have different
 // internal browser notification requirements, and not all functions are defined
 // for all APIs).
 class ExtensionActionFunction : public SyncExtensionFunction {
  public:
   static bool ParseCSSColorString(const std::string& color_string,
                                   SkColor* result);
 
  protected:
   ExtensionActionFunction();
   virtual ~ExtensionActionFunction();
   virtual bool RunImpl() OVERRIDE;
   virtual bool RunExtensionAction() = 0;
   void NotifyChange();
   void NotifyBrowserActionChange();
   void NotifyLocationBarChange();
   bool SetVisible(bool visible);
 
+  // Extension-related information for |tab_id_|.
+  // CHECK-fails if there is no tab.
+  ExtensionTabHelper& tab_helper() const;

[Aaron Boodman, 2012/07/03 01:29:31]

These are supposed to be const-ref in Chrome.

[Jeffrey Yasskin, 2012/07/10 21:52:33]

I don't see that in the style guide. 
http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml?showone=Refere...
certainly covers it for arguments, but this isn't an argument. 

One could argue that const methods shouldn't return non-const references or
pointers, in which case I'd need to make this method non-const since I call the
non-const ExtensionTabHelper::location_bar_controller() method. Alternately I
can make this return a pointer, but that doesn't communicate that we've ensured
the result won't be NULL.

[Aaron Boodman, 2012/07/10 22:50:46]

Hm, ok.

+
   // All the extension action APIs take a single argument called details that
   // is a dictionary.
   base::DictionaryValue* details_;
 
   // The tab id the extension action function should apply to, if any, or
   // kDefaultTabId if none was specified.
   int tab_id_;
 
   // Tab content for |tab_id_| if one exists.
   TabContents* contents_;
@@ skipping 82 matching lines @@
 
 // getBadgeBackgroundColor
 class ExtensionActionGetBadgeBackgroundColorFunction
     : public ExtensionActionFunction {
  protected:
   virtual ~ExtensionActionGetBadgeBackgroundColorFunction() {}
   virtual bool RunExtensionAction() OVERRIDE;
 };
 
 #endif  // CHROME_BROWSER_EXTENSIONS_API_EXTENSION_ACTION_EXTENSION_ACTIONS_API_H_