Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4961)

Unified Diff: chrome/browser/extensions/page_action_controller.h

Issue 10695070: Implement scriptBadge.requestToAct. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/page_action_controller.h
diff --git a/chrome/browser/extensions/page_action_controller.h b/chrome/browser/extensions/page_action_controller.h
index 8c9941d503ec1d7eec04812ee496961a272d663c..e3365e69b43f37a4398ba654662df9a5878c5cc1 100644
--- a/chrome/browser/extensions/page_action_controller.h
+++ b/chrome/browser/extensions/page_action_controller.h
@@ -28,6 +28,9 @@ class PageActionController : public LocationBarController,
// LocationBarController implementation.
virtual std::vector<ExtensionAction*> GetCurrentActions() const OVERRIDE;
+ // As if the user never grants permission.
Aaron Boodman 2012/07/03 01:29:31 Weird comment is weird.
Jeffrey Yasskin 2012/07/10 21:52:33 My idea was that doing nothing in the PageActionCo
+ virtual void RequestScriptPermission(
+ const std::string& extension_id) OVERRIDE {}
virtual Action OnClicked(const std::string& extension_id,
int mouse_button) OVERRIDE;
virtual void NotifyChange() OVERRIDE;

Powered by Google App Engine
This is Rietveld 408576698