DescriptionFix RenderTextWin base direction; remove test exceptions; etc.
Use the first strong character's direction to set SCRIPT_STATE.uBidiLevel.
RenderTextWin::GetTextDirection returns this calculated base direction.
Fix RenderTextWin::AdjacentCharSelectionModel:
Handle all out-of-bounds run indicies as invalid runs.
Use the visual ordering of runs (implicit on Linux) to determine edges.
Add new RenderTextTest.GetTextDirection unit test.
Add SetRTL test utility function which works with GTK.
Fix RenderTextTest.DisplayRectShowsCursorRTL on linux with SetRTL.
Remove relevant Windows-specific unit test exceptions.
TODO(msw): Cleanup canvas_skia.cc in a followup CL.
TODO(msw): Use UI dir by default in GetFirstStrongCharacterDirection.
BUG=134746, 134009
TEST=Updated unit tests; no RTL/LTR regressions.
TBR=sky@chromium.org
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=145476
Patch Set 1 : Sync and rebase. #
Total comments: 4
Patch Set 2 : Address comments; add unit test. #
Total comments: 4
Patch Set 3 : Use the application text direction by default; update unit test; add TODO. #Patch Set 4 : Revert base/i18n/rtl.cc; use LTR by default for now; update test. #Patch Set 5 : Fix RenderTextTest.DisplayRectShowsCursorRTL on linux with SetRTL(). #Patch Set 6 : Revert gypi change to keep Mac working. #
Total comments: 6
Patch Set 7 : Address comments. #
Messages
Total messages: 14 (0 generated)
|