Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8212)

Unified Diff: chrome/browser/ui/toolbar/back_forward_menu_model_unittest.cc

Issue 10692195: Consolidate Browser Creation. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/toolbar/back_forward_menu_model_unittest.cc
===================================================================
--- chrome/browser/ui/toolbar/back_forward_menu_model_unittest.cc (revision 148382)
+++ chrome/browser/ui/toolbar/back_forward_menu_model_unittest.cc (working copy)
@@ -15,6 +15,7 @@
#include "chrome/browser/ui/browser_tabstrip.h"
#include "chrome/common/url_constants.h"
#include "chrome/test/base/chrome_render_view_host_test_harness.h"
+#include "chrome/test/base/test_browser_window.h"
#include "chrome/test/base/testing_profile.h"
#include "content/public/browser/navigation_controller.h"
#include "content/public/browser/navigation_entry.h"
@@ -503,11 +504,12 @@
TEST_F(BackFwdMenuModelTest, FaviconLoadTest) {
profile()->CreateHistoryService(true, false);
profile()->CreateFaviconService();
- Browser browser(Browser::TYPE_TABBED, profile());
+ scoped_ptr<Browser> browser(
+ chrome::CreateBrowserWithTestWindowForProfile(profile()));
FaviconDelegate favicon_delegate;
BackForwardMenuModel back_model(
- &browser, BackForwardMenuModel::BACKWARD_MENU);
+ browser.get(), BackForwardMenuModel::BACKWARD_MENU);
back_model.set_test_web_contents(controller().GetWebContents());
back_model.SetMenuModelDelegate(&favicon_delegate);
@@ -563,7 +565,7 @@
new_icon_bitmap.getSize()));
// Make sure the browser deconstructor doesn't have problems.
- chrome::CloseAllTabs(&browser);
+ chrome::CloseAllTabs(browser.get());
// This is required to prevent the message loop from hanging.
profile()->DestroyHistoryService();
}
« no previous file with comments | « chrome/browser/ui/tabs/pinned_tab_service_unittest.cc ('k') | chrome/browser/ui/views/ash/app_list/extension_app_item.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698