Do not link non-executables with -pie for tsan=1

Do not link non-executables with -pie for tsan=1
(-pie is incompatible with -shared and -static)

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=148393

[Alexander Potapenko, 2012-07-08 16:57:37]

PTAL

[Alexander Potapenko, 2012-07-13 11:04:06]

Nico, will you have time to look at this?

[Nico, 2012-07-20 18:06:11]

https://chromiumcodereview.appspot.com/10690103/diff/1/build/common.gypi
File build/common.gypi (right):

https://chromiumcodereview.appspot.com/10690103/diff/1/build/common.gypi#newc...
build/common.gypi:2318: '-fPIE',
But you do want -fPIE for non-executables?

https://chromiumcodereview.appspot.com/10690103/diff/1/build/common.gypi#newc...
build/common.gypi:2331: ],
nit: we use 2 spaces indent in gyp files, not 4. maybe reindent everything in
the ~30 lines above this)

[Alexander Potapenko, 2012-07-25 08:36:43]

PTAL

https://chromiumcodereview.appspot.com/10690103/diff/1/build/common.gypi
File build/common.gypi (right):

https://chromiumcodereview.appspot.com/10690103/diff/1/build/common.gypi#newc...
build/common.gypi:2318: '-fPIE',
On 2012/07/20 18:06:11, Nico wrote:
> But you do want -fPIE for non-executables?
Yes. Non-executables can share object files with executables, can't they?

https://chromiumcodereview.appspot.com/10690103/diff/1/build/common.gypi#newc...
build/common.gypi:2331: ],
On 2012/07/20 18:06:11, Nico wrote:
> nit: we use 2 spaces indent in gyp files, not 4. maybe reindent everything in
> the ~30 lines above this)

Done.

[Nico, 2012-07-25 13:50:02]

lgtm

[commit-bot: I haz the power, 2012-07-25 18:22:33]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/glider@chromium.org/10690103/6001

[commit-bot: I haz the power, 2012-07-25 20:06:46]

Change committed as 148393