Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(168)

Side by Side Diff: build/common.gypi

Issue 10690103: Do not link non-executables with -pie for tsan=1 (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 # IMPORTANT: 5 # IMPORTANT:
6 # Please don't directly include this file if you are building via gyp_chromium, 6 # Please don't directly include this file if you are building via gyp_chromium,
7 # since gyp_chromium is automatically forcing its inclusion. 7 # since gyp_chromium is automatically forcing its inclusion.
8 { 8 {
9 # Variables expected to be overriden on the GYP command line (-D) or by 9 # Variables expected to be overriden on the GYP command line (-D) or by
10 # ~/.gyp/include.gypi. 10 # ~/.gyp/include.gypi.
(...skipping 2278 matching lines...) Expand 10 before | Expand all | Expand 10 after
2289 }], 2289 }],
2290 ['clang==1 and "<(GENERATOR)"=="ninja"', { 2290 ['clang==1 and "<(GENERATOR)"=="ninja"', {
2291 'cflags': [ 2291 'cflags': [
2292 # See http://crbug.com/110262 2292 # See http://crbug.com/110262
2293 '-fcolor-diagnostics', 2293 '-fcolor-diagnostics',
2294 ], 2294 ],
2295 }], 2295 }],
2296 ['asan==1', { 2296 ['asan==1', {
2297 'target_conditions': [ 2297 'target_conditions': [
2298 ['_toolset=="target"', { 2298 ['_toolset=="target"', {
2299 'cflags': [ 2299 'cflags': [
2300 '-faddress-sanitizer', 2300 '-faddress-sanitizer',
2301 '-fno-omit-frame-pointer', 2301 '-fno-omit-frame-pointer',
2302 ], 2302 ],
2303 'ldflags': [ 2303 'ldflags': [
2304 '-faddress-sanitizer', 2304 '-faddress-sanitizer',
2305 ], 2305 ],
2306 'defines': [ 2306 'defines': [
2307 'ADDRESS_SANITIZER', 2307 'ADDRESS_SANITIZER',
2308 ], 2308 ],
2309 }], 2309 }],
2310 ], 2310 ],
2311 }], 2311 }],
2312 ['tsan==1', { 2312 ['tsan==1', {
2313 'target_conditions': [ 2313 'target_conditions': [
2314 ['_toolset=="target"', { 2314 ['_toolset=="target"', {
2315 'cflags': [ 2315 'cflags': [
2316 '-fthread-sanitizer', 2316 '-fthread-sanitizer',
2317 '-fno-omit-frame-pointer', 2317 '-fno-omit-frame-pointer',
2318 '-fPIE', 2318 '-fPIE',
2319 ], 2319 ],
2320 'ldflags': [ 2320 'ldflags': [
2321 '-fthread-sanitizer', 2321 '-fthread-sanitizer',
2322 ],
2323 'defines': [
2324 'THREAD_SANITIZER',
2325 'DYNAMIC_ANNOTATIONS_EXTERNAL_IMPL=1',
2326 ],
2327 'target_conditions': [
2328 ['_type=="executable"', {
2329 'ldflags': [
2322 '-pie', 2330 '-pie',
2323 ], 2331 ],
2324 'defines': [ 2332 }],
2325 'THREAD_SANITIZER', 2333 ],
2326 'DYNAMIC_ANNOTATIONS_EXTERNAL_IMPL=1',
2327 ],
2328 }], 2334 }],
2329 ], 2335 ],
2330 }], 2336 }],
2331 ['order_profiling!=0 and (chromeos==1 or OS=="linux")', { 2337 ['order_profiling!=0 and (chromeos==1 or OS=="linux")', {
2332 'target_conditions' : [ 2338 'target_conditions' : [
2333 ['_toolset=="target"', { 2339 ['_toolset=="target"', {
2334 'cflags': [ 2340 'cflags': [
2335 '-finstrument-functions', 2341 '-finstrument-functions',
2336 ], 2342 ],
2337 }], 2343 }],
(...skipping 950 matching lines...) Expand 10 before | Expand all | Expand 10 after
3288 # settings in target dicts. SYMROOT is a special case, because many other 3294 # settings in target dicts. SYMROOT is a special case, because many other
3289 # Xcode variables depend on it, including variables such as 3295 # Xcode variables depend on it, including variables such as
3290 # PROJECT_DERIVED_FILE_DIR. When a source group corresponding to something 3296 # PROJECT_DERIVED_FILE_DIR. When a source group corresponding to something
3291 # like PROJECT_DERIVED_FILE_DIR is added to a project, in order for the 3297 # like PROJECT_DERIVED_FILE_DIR is added to a project, in order for the
3292 # files to appear (when present) in the UI as actual files and not red 3298 # files to appear (when present) in the UI as actual files and not red
3293 # red "missing file" proxies, the correct path to PROJECT_DERIVED_FILE_DIR, 3299 # red "missing file" proxies, the correct path to PROJECT_DERIVED_FILE_DIR,
3294 # and therefore SYMROOT, needs to be set at the project level. 3300 # and therefore SYMROOT, needs to be set at the project level.
3295 'SYMROOT': '<(DEPTH)/xcodebuild', 3301 'SYMROOT': '<(DEPTH)/xcodebuild',
3296 }, 3302 },
3297 } 3303 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698