Do not link non-executables with -pie for tsan=1

build/common.gypi

 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 # IMPORTANT:
 # Please don't directly include this file if you are building via gyp_chromium,
 # since gyp_chromium is automatically forcing its inclusion.
 {
   # Variables expected to be overriden on the GYP command line (-D) or by
   # ~/.gyp/include.gypi.
@@ skipping 2297 matching lines @@
                   ],
               }],
             ],
           }],
           ['tsan==1', {
             'target_conditions': [
               ['_toolset=="target"', {
                   'cflags': [
                       '-fthread-sanitizer',
                       '-fno-omit-frame-pointer',
                       '-fPIE',

[Nico, 2012/07/20 18:06:11]

But you do want -fPIE for non-executables?

[Alexander Potapenko, 2012/07/25 08:36:44]

Yes. Non-executables can share object files with executables, can't they?

                   ],
                   'ldflags': [
                       '-fthread-sanitizer',
-                      '-pie',
                   ],
                   'defines': [
                       'THREAD_SANITIZER',
                       'DYNAMIC_ANNOTATIONS_EXTERNAL_IMPL=1',
                   ],
+                  'target_conditions': [
+                    ['_type=="executable"', {
+                        'ldflags': [
+                            '-pie',
+                        ],

[Nico, 2012/07/20 18:06:11]

nit: we use 2 spaces indent in gyp files, not 4. maybe reindent everything in
the ~30 lines above this)

[Alexander Potapenko, 2012/07/25 08:36:44]

Done.

+                    }],
+                  ],
               }],
             ],
           }],
           ['order_profiling!=0 and (chromeos==1 or OS=="linux")', {
             'target_conditions' : [
               ['_toolset=="target"', {
                 'cflags': [
                   '-finstrument-functions',
                 ],
               }],
@@ skipping 944 matching lines @@
     # settings in target dicts.  SYMROOT is a special case, because many other
     # Xcode variables depend on it, including variables such as
     # PROJECT_DERIVED_FILE_DIR.  When a source group corresponding to something
     # like PROJECT_DERIVED_FILE_DIR is added to a project, in order for the
     # files to appear (when present) in the UI as actual files and not red
     # red "missing file" proxies, the correct path to PROJECT_DERIVED_FILE_DIR,
     # and therefore SYMROOT, needs to be set at the project level.
     'SYMROOT': '<(DEPTH)/xcodebuild',
   },
 }