Issue 10684003: Make SplitString() and variants clear their outparam vector. (Note that SplitStringIntoKeyValues()…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10684003: Make SplitString() and variants clear their outparam vector. (Note that SplitStringIntoKeyValues()… (Closed)

Created:
8 years, 6 months ago by Peter Kasting

Modified:
8 years, 5 months ago

Reviewers:
brettw, Paweł Hajdan Jr.

CC:
chromium-reviews, cbentzel+watch_chromium.org, erikwright (departed), brettw-cc_chromium.org, darin-cc_chromium.org, Paweł Hajdan Jr., jshin+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Make SplitString() and variants clear their outparam vector. (Note that SplitStringIntoKeyValues() and SplitStringIntoKeyValuePairs() already did this.) This is more in line with what other APIs that take outparams do. I audited all callers, and the only ones affected by this are the buggy ones in bug 134695 that already wanted this behavior, as well as the couple of places in this CL that were manually calling clear() and now don't have to. BUG=134695 TEST=none TBR=brettw,phajdan.jr Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=144323

Patch Set 1 #

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+6 lines, -9 lines)			Patch
M	base/string_split.h	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	base/string_split.cc	View	3 chunks	+3 lines, -0 lines	0 comments	Download
M	base/string_split_unittest.cc	View	2 chunks	+0 lines, -3 lines	0 comments	Download
M	net/ftp/ftp_directory_listing_parser_vms.cc	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	webkit/plugins/npapi/plugin_list_win.cc	View	1 chunk	+0 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages