net/ftp/ftp_directory_listing_parser_vms.cc - Issue 10684003: Make SplitString() and variants clear their outparam vector. (Note that SplitStringIntoKeyValues()…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/ftp/ftp_directory_listing_parser_vms.cc

Issue 10684003: Make SplitString() and variants clear their outparam vector. (Note that SplitStringIntoKeyValues()… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/

Patch Set: Created 8 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/ftp/ftp_directory_listing_parser_vms.cc

===================================================================

--- net/ftp/ftp_directory_listing_parser_vms.cc (revision 144240)

+++ net/ftp/ftp_directory_listing_parser_vms.cc (working copy)

@@ -217,7 +217,6 @@

return false;

// Join the current and next line and split them into columns.

- columns.clear();

base::SplitString(

CollapseWhitespace(lines[i] + ASCIIToUTF16(" ") + lines[i + 1],

false),

« no previous file with comments | « base/string_split_unittest.cc ('k') | webkit/plugins/npapi/plugin_list_win.cc » ('j') | no next file with comments »