Make SplitString() and variants clear their outparam vector. (Note that SplitStringIntoKeyValues()…

net/ftp/ftp_directory_listing_parser_vms.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/ftp/ftp_directory_listing_parser_vms.h"
 
 #include <vector>
 
 #include "base/string_number_conversions.h"
 #include "base/string_split.h"
@@ skipping 199 matching lines @@
 
     std::vector<string16> columns;
     base::SplitString(CollapseWhitespace(lines[i], false), ' ', &columns);
 
     if (columns.size() == 1) {
       // There can be no continuation if the current line is the last one.
       if (i == lines.size() - 1)
         return false;
 
       // Join the current and next line and split them into columns.
-      columns.clear();
       base::SplitString(
           CollapseWhitespace(lines[i] + ASCIIToUTF16(" ") + lines[i + 1],
                              false),
           ' ',
           &columns);
       i++;
     }
 
     FtpDirectoryListingEntry entry;
     if (!ParseVmsFilename(columns[0], &entry.name, &entry.type))
@@ skipping 26 matching lines @@
 
     entries->push_back(entry);
   }
 
   // The only place where we return true is after receiving the "Total" line,
   // that should be present in every VMS listing.
   return false;
 }
 
 }  // namespace net