webkit/plugins/npapi/plugin_group_unittest.cc - Issue 10683005: Remove two deprecated methods from base::Version

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webkit/plugins/npapi/plugin_group_unittest.cc

Issue 10683005: Remove two deprecated methods from base::Version (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: ... Created 8 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: webkit/plugins/npapi/plugin_group_unittest.cc

diff --git a/webkit/plugins/npapi/plugin_group_unittest.cc b/webkit/plugins/npapi/plugin_group_unittest.cc

index a4f55473d1704171aebf2c9788726c32744a8482..b9820be0c6aa61cddbc91b1b29b422d53f7a670d 100644

--- a/webkit/plugins/npapi/plugin_group_unittest.cc

+++ b/webkit/plugins/npapi/plugin_group_unittest.cc

@@ -30,9 +30,10 @@ TEST(PluginGroupTest, VersionExtraction) {

};

for (size_t i = 0; i < arraysize(versions); i++) {

- scoped_ptr<Version> version(PluginGroup::CreateVersionFromString(

- ASCIIToUTF16(versions[i][0])));

- EXPECT_EQ(versions[i][1], version->GetString());

+ Version version;

+ PluginGroup::CreateVersionFromString(ASCIIToUTF16(versions[i][0]),

+ &version);

+ EXPECT_EQ(versions[i][1], version.GetString());

}