Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Unified Diff: webkit/plugins/npapi/plugin_group.cc

Issue 10683005: Remove two deprecated methods from base::Version (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: ... Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webkit/plugins/npapi/plugin_group.h ('k') | webkit/plugins/npapi/plugin_group_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webkit/plugins/npapi/plugin_group.cc
diff --git a/webkit/plugins/npapi/plugin_group.cc b/webkit/plugins/npapi/plugin_group.cc
index 6f3c6074204eba7eefb3d4ab5ac8585e85542ec4..8f8aa40ff3397fcba666eb057033c813860ce56e 100644
--- a/webkit/plugins/npapi/plugin_group.cc
+++ b/webkit/plugins/npapi/plugin_group.cc
@@ -100,7 +100,8 @@ bool PluginGroup::Match(const WebPluginInfo& plugin) const {
}
/* static */
-Version* PluginGroup::CreateVersionFromString(const string16& version_string) {
+void PluginGroup::CreateVersionFromString(const string16& version_string,
+ Version* parsed_version) {
// Remove spaces and ')' from the version string,
// Replace any instances of 'r', ',' or '(' with a dot.
std::string version = UTF16ToASCII(version_string);
@@ -111,7 +112,7 @@ Version* PluginGroup::CreateVersionFromString(const string16& version_string) {
std::replace(version.begin(), version.end(), '(', '.');
std::replace(version.begin(), version.end(), '_', '.');
- return Version::GetVersionFromString(version);
+ *parsed_version = Version(version);
}
void PluginGroup::AddPlugin(const WebPluginInfo& plugin) {
« no previous file with comments | « webkit/plugins/npapi/plugin_group.h ('k') | webkit/plugins/npapi/plugin_group_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698