Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1332)

Unified Diff: webkit/plugins/npapi/webplugin_delegate_impl_win.cc

Issue 10683005: Remove two deprecated methods from base::Version (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: ... Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webkit/plugins/npapi/plugin_group_unittest.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webkit/plugins/npapi/webplugin_delegate_impl_win.cc
diff --git a/webkit/plugins/npapi/webplugin_delegate_impl_win.cc b/webkit/plugins/npapi/webplugin_delegate_impl_win.cc
index cb6a2e8fe3ed39869602cb11c9779f1fd0ee3d97..a0a4f188ab560a7a3487fce3f22346c3a34487a4 100644
--- a/webkit/plugins/npapi/webplugin_delegate_impl_win.cc
+++ b/webkit/plugins/npapi/webplugin_delegate_impl_win.cc
@@ -255,12 +255,13 @@ std::wstring GetKeyPath(HKEY key) {
}
int GetPluginMajorVersion(const WebPluginInfo& plugin_info) {
- scoped_ptr<Version> plugin_version(PluginGroup::CreateVersionFromString(
- plugin_info.version));
+ Version plugin_version;
+ PluginGroup::CreateVersionFromString(plugin_info.version, &plugin_version);
+
int major_version = 0;
- if (plugin_version.get()) {
- major_version = plugin_version->components()[0];
- }
+ if (plugin_version.IsValid())
+ major_version = plugin_version.components()[0];
+
return major_version;
}
« no previous file with comments | « webkit/plugins/npapi/plugin_group_unittest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698