Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1039)

Issue 10661038: Revert 143896 - Filtered events. (Closed)

Created:
8 years, 6 months ago by benwells
Modified:
8 years, 6 months ago
CC:
chromium-reviews, mihaip-chromium-reviews_chromium.org, hashimoto+watch_chromium.org, aboxhall+watch_chromium.org, yoshiki+watch_chromium.org, yuzo+watch_chromium.org, davidbarr+watch_chromium.org, Aaron Boodman, darin-cc_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, brettw-cc_chromium.org, ctguil+watch_chromium.org, zork+watch_chromium.org
Visibility:
Public.

Description

Revert 143896 - Filtered events. (Reverting as it breaks platform app's onLaunched event dispatch). Makes web_navigation events support filters, eg: chrome.webNavigation.onBeforeCommitted.addListener(callback, {url: [{hostSuffix: 'google.com'}]}); Now callback will only be called when the event has a URL with a host suffix of google.com. BUG=121479 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=143872 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=143874 Review URL: https://chromiumcodereview.appspot.com/10514013 TBR=koz@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=144013

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+339 lines, -2099 lines) Patch
MM chrome/browser/accessibility/accessibility_extension_api.cc View 1 chunk +1 line, -1 line 0 comments Download
MM chrome/browser/bookmarks/bookmark_extension_api.cc View 1 chunk +1 line, -1 line 0 comments Download
MM chrome/browser/bookmarks/bookmark_manager_extension_api.cc View 1 chunk +1 line, -1 line 0 comments Download
MM chrome/browser/extensions/api/cookies/cookies_api.cc View 1 chunk +1 line, -1 line 0 comments Download
MM chrome/browser/extensions/api/downloads/downloads_api.cc View 1 chunk +1 line, -2 lines 0 comments Download
MM chrome/browser/extensions/api/offscreen_tabs/offscreen_tabs_api.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/extensions/api/web_navigation/web_navigation_api.cc View 8 chunks +24 lines, -21 lines 0 comments Download
M chrome/browser/extensions/api/web_navigation/web_navigation_apitest.cc View 3 chunks +0 lines, -12 lines 0 comments Download
M chrome/browser/extensions/api/web_request/web_request_api.cc View 1 chunk +1 line, -2 lines 0 comments Download
D chrome/browser/extensions/event_listener_map.h View 1 chunk +0 lines, -158 lines 0 comments Download
D chrome/browser/extensions/event_listener_map.cc View 1 chunk +0 lines, -240 lines 0 comments Download
D chrome/browser/extensions/event_listener_map_unittest.cc View 1 chunk +0 lines, -300 lines 0 comments Download
MM chrome/browser/extensions/extension_browser_event_router.cc View 1 chunk +1 line, -1 line 0 comments Download
MM chrome/browser/extensions/extension_devtools_bridge.cc View 2 chunks +2 lines, -4 lines 0 comments Download
MM chrome/browser/extensions/extension_event_router.h View 10 chunks +29 lines, -93 lines 0 comments Download
MM chrome/browser/extensions/extension_event_router.cc View 16 chunks +183 lines, -240 lines 0 comments Download
MM chrome/browser/extensions/extension_event_router_forwarder.cc View 2 chunks +2 lines, -3 lines 0 comments Download
MM chrome/browser/extensions/extension_idle_api.cc View 1 chunk +1 line, -1 line 0 comments Download
MM chrome/browser/extensions/extension_managed_mode_api.cc View 1 chunk +2 lines, -3 lines 0 comments Download
MM chrome/browser/extensions/extension_management_api.cc View 1 chunk +1 line, -1 line 0 comments Download
MM chrome/browser/extensions/extension_messages_apitest.cc View 1 chunk +4 lines, -8 lines 0 comments Download
MM chrome/browser/extensions/extension_prefs.h View 1 chunk +0 lines, -15 lines 0 comments Download
MM chrome/browser/extensions/extension_prefs.cc View 2 chunks +0 lines, -57 lines 0 comments Download
MM chrome/browser/extensions/extension_processes_api.cc View 1 chunk +1 line, -1 line 0 comments Download
MM chrome/browser/extensions/lazy_background_page_apitest.cc View 1 chunk +0 lines, -16 lines 0 comments Download
M chrome/browser/extensions/system/system_api.cc View 1 chunk +1 line, -1 line 0 comments Download
MM chrome/browser/history/history_extension_api.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/renderer_host/chrome_render_message_filter.h View 1 chunk +0 lines, -8 lines 0 comments Download
M chrome/browser/renderer_host/chrome_render_message_filter.cc View 3 chunks +0 lines, -34 lines 0 comments Download
M chrome/browser/ui/cocoa/menu_controller_unittest.mm View 2 chunks +0 lines, -4 lines 0 comments Download
MM chrome/chrome_browser_extensions.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
MM chrome/chrome_common.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
MM chrome/chrome_tests.gypi View 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/common/extensions/api/web_navigation.json View 7 chunks +0 lines, -35 lines 0 comments Download
M chrome/common/extensions/event_filtering_info.h View 2 chunks +0 lines, -8 lines 0 comments Download
M chrome/common/extensions/event_filtering_info.cc View 1 chunk +0 lines, -14 lines 0 comments Download
M chrome/common/extensions/extension_messages.h View 1 chunk +0 lines, -16 lines 0 comments Download
D chrome/common/extensions/value_counter.h View 1 chunk +0 lines, -72 lines 0 comments Download
D chrome/common/extensions/value_counter.cc View 1 chunk +0 lines, -67 lines 0 comments Download
D chrome/common/extensions/value_counter_unittest.cc View 1 chunk +0 lines, -42 lines 0 comments Download
M chrome/renderer/extensions/event_bindings.h View 2 chunks +1 line, -6 lines 0 comments Download
M chrome/renderer/extensions/event_bindings.cc View 7 chunks +21 lines, -204 lines 0 comments Download
M chrome/renderer/extensions/event_unittest.cc View 3 chunks +0 lines, -154 lines 0 comments Download
M chrome/renderer/extensions/extension_dispatcher.h View 3 chunks +0 lines, -9 lines 0 comments Download
M chrome/renderer/extensions/extension_dispatcher.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M chrome/renderer/resources/extensions/event.js View 12 chunks +56 lines, -164 lines 0 comments Download
D chrome/test/data/extensions/api_test/filtered_events/manifest.json View 1 chunk +0 lines, -11 lines 0 comments Download
D chrome/test/data/extensions/api_test/lazy_background_page/filters/background.js View 1 chunk +0 lines, -9 lines 0 comments Download
D chrome/test/data/extensions/api_test/lazy_background_page/filters/manifest.json View 1 chunk +0 lines, -11 lines 0 comments Download
D chrome/test/data/extensions/api_test/webnavigation/filtered/a.html View 1 chunk +0 lines, -1 line 0 comments Download
D chrome/test/data/extensions/api_test/webnavigation/filtered/b.html View 1 chunk +0 lines, -1 line 0 comments Download
D chrome/test/data/extensions/api_test/webnavigation/test_filtered.html View 1 chunk +0 lines, -5 lines 0 comments Download
D chrome/test/data/extensions/api_test/webnavigation/test_filtered.js View 1 chunk +0 lines, -28 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
benwells
8 years, 6 months ago (2012-06-25 21:12:58 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698