Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(882)

Unified Diff: chrome/browser/extensions/api/web_navigation/web_navigation_api.cc

Issue 10661038: Revert 143896 - Filtered events. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/web_navigation/web_navigation_api.cc
===================================================================
--- chrome/browser/extensions/api/web_navigation/web_navigation_api.cc (revision 144007)
+++ chrome/browser/extensions/api/web_navigation/web_navigation_api.cc (working copy)
@@ -20,7 +20,6 @@
#include "chrome/browser/view_type_utils.h"
#include "chrome/common/chrome_notification_types.h"
#include "chrome/common/extensions/api/web_navigation.h"
-#include "chrome/common/extensions/event_filtering_info.h"
#include "chrome/common/url_constants.h"
#include "content/public/browser/resource_request_details.h"
#include "content/public/browser/navigation_details.h"
@@ -75,18 +74,11 @@
// Dispatches events to the extension message service.
void DispatchEvent(BrowserContext* browser_context,
const char* event_name,
- const ListValue& args,
- const GURL& url) {
- std::string json_args;
- base::JSONWriter::Write(&args, &json_args);
-
- extensions::EventFilteringInfo info;
- info.SetURL(url);
-
+ const std::string& json_args) {
Profile* profile = Profile::FromBrowserContext(browser_context);
if (profile && profile->GetExtensionEventRouter()) {
profile->GetExtensionEventRouter()->DispatchEventToRenderers(
- event_name, json_args, profile, GURL(), info);
+ event_name, json_args, profile, GURL());
}
}
@@ -103,10 +95,11 @@
dict->SetDouble(keys::kTimeStampKey, MilliSecondsFromTime(base::Time::Now()));
args.Append(dict);
+ std::string json_args;
+ base::JSONWriter::Write(&args, &json_args);
DispatchEvent(web_contents->GetBrowserContext(),
keys::kOnBeforeNavigate,
- args,
- validated_url);
+ json_args);
}
// Constructs and dispatches an onCommitted or onReferenceFragmentUpdated
@@ -138,7 +131,9 @@
dict->SetDouble(keys::kTimeStampKey, MilliSecondsFromTime(base::Time::Now()));
args.Append(dict);
- DispatchEvent(web_contents->GetBrowserContext(), event_name, args, url);
+ std::string json_args;
+ base::JSONWriter::Write(&args, &json_args);
+ DispatchEvent(web_contents->GetBrowserContext(), event_name, json_args);
}
// Constructs and dispatches an onDOMContentLoaded event.
@@ -155,10 +150,11 @@
dict->SetDouble(keys::kTimeStampKey, MilliSecondsFromTime(base::Time::Now()));
args.Append(dict);
+ std::string json_args;
+ base::JSONWriter::Write(&args, &json_args);
DispatchEvent(web_contents->GetBrowserContext(),
keys::kOnDOMContentLoaded,
- args,
- url);
+ json_args);
}
// Constructs and dispatches an onCompleted event.
@@ -175,8 +171,10 @@
dict->SetDouble(keys::kTimeStampKey, MilliSecondsFromTime(base::Time::Now()));
args.Append(dict);
- DispatchEvent(web_contents->GetBrowserContext(), keys::kOnCompleted, args,
- url);
+ std::string json_args;
+ base::JSONWriter::Write(&args, &json_args);
+ DispatchEvent(web_contents->GetBrowserContext(),
+ keys::kOnCompleted, json_args);
}
// Constructs and dispatches an onCreatedNavigationTarget event.
@@ -206,8 +204,10 @@
dict->SetDouble(keys::kTimeStampKey, MilliSecondsFromTime(base::Time::Now()));
args.Append(dict);
- DispatchEvent(browser_context, keys::kOnCreatedNavigationTarget, args,
- target_url);
+ std::string json_args;
+ base::JSONWriter::Write(&args, &json_args);
+ DispatchEvent(
+ browser_context, keys::kOnCreatedNavigationTarget, json_args);
}
// Constructs and dispatches an onErrorOccurred event.
@@ -225,8 +225,11 @@
dict->SetDouble(keys::kTimeStampKey, MilliSecondsFromTime(base::Time::Now()));
args.Append(dict);
- DispatchEvent(web_contents->GetBrowserContext(), keys::kOnErrorOccurred,
- args, url);
+ std::string json_args;
+ base::JSONWriter::Write(&args, &json_args);
+ DispatchEvent(web_contents->GetBrowserContext(),
+ keys::kOnErrorOccurred,
+ json_args);
}
} // namespace

Powered by Google App Engine
This is Rietveld 408576698