Issue 10660025: Cleanup dart to string conversions.

Issue 10660025: Cleanup dart to string conversions. (Closed)

Created:
8 years, 6 months ago by podivilov

Modified:
8 years, 5 months ago

Reviewers:
Anton Muhin

CC:
reviews+dom_dartlang.org

Base URL:
svn://svn.chromium.org/multivm/trunk/webkit

Visibility:
Public.

More Reviews

Description

Cleanup dart to string conversions. R=antonm@google.com Committed: https://src.chromium.org/viewvc/multivm?view=rev&revision=646

Patch Set 3 : . #

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+152 lines, -317 lines)			Patch
M	Source/WebCore/bindings/dart/DartApplicationLoader.cpp	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	Source/WebCore/bindings/dart/DartDOMWrapper.h	View		1 chunk	+0 lines, -84 lines	0 comments	Download
M	Source/WebCore/bindings/dart/DartDebugServer.cpp	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/WebCore/bindings/dart/DartEventListener.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download
M	Source/WebCore/bindings/dart/DartNativeUtilities.cpp	View	1	4 chunks	+7 lines, -13 lines	0 comments	Download
M	Source/WebCore/bindings/dart/DartUtilities.h	View		5 chunks	+28 lines, -11 lines	0 comments	Download
M	Source/WebCore/bindings/dart/DartUtilities.cpp	View		5 chunks	+12 lines, -7 lines	0 comments	Download
M	Source/WebCore/bindings/dart/custom/DartCanvasRenderingContext2DCustom.cpp	View	1	2 chunks	+4 lines, -8 lines	0 comments	Download
M	Source/WebCore/bindings/dart/custom/DartDOMStringListCustom.cpp	View	1	1 chunk	+2 lines, -3 lines	0 comments	Download
M	Source/WebCore/bindings/dart/custom/DartDOMStringMapCustom.cpp	View	1	5 chunks	+11 lines, -21 lines	0 comments	Download
M	Source/WebCore/bindings/dart/custom/DartDOMWindowCustom.cpp	View	1	5 chunks	+14 lines, -28 lines	0 comments	Download
M	Source/WebCore/bindings/dart/custom/DartDirectoryEntryCustom.cpp	View	1	2 chunks	+4 lines, -8 lines	0 comments	Download
M	Source/WebCore/bindings/dart/custom/DartDirectoryEntrySyncCustom.cpp	View	1	2 chunks	+4 lines, -8 lines	0 comments	Download
M	Source/WebCore/bindings/dart/custom/DartHTMLCanvasElementCustom.cpp	View	1	2 chunks	+4 lines, -8 lines	0 comments	Download
M	Source/WebCore/bindings/dart/custom/DartHTMLInputElementCustom.cpp	View	1	2 chunks	+4 lines, -8 lines	0 comments	Download
M	Source/WebCore/bindings/dart/custom/DartHistoryCustom.cpp	View	1	1 chunk	+4 lines, -8 lines	0 comments	Download
M	Source/WebCore/bindings/dart/custom/DartIDBKeyCustom.cpp	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
M	Source/WebCore/bindings/dart/custom/DartIntentCustom.cpp	View	1	1 chunk	+4 lines, -8 lines	0 comments	Download
M	Source/WebCore/bindings/dart/custom/DartLocationCustom.cpp	View	1	10 chunks	+20 lines, -40 lines	0 comments	Download
M	Source/WebCore/bindings/dart/custom/DartMessageEventCustom.cpp	View	1	2 chunks	+6 lines, -12 lines	0 comments	Download
M	Source/WebCore/bindings/dart/custom/DartWebGLRenderingContextCustom.cpp	View	1	1 chunk	+2 lines, -4 lines	0 comments	Download
M	Source/WebCore/bindings/dart/custom/DartWebKitCSSMatrixCustom.cpp	View	1	1 chunk	+2 lines, -4 lines	0 comments	Download
M	Source/WebCore/bindings/dart/custom/DartWebSocketCustom.cpp	View	1	2 chunks	+4 lines, -8 lines	0 comments	Download
M	Source/WebCore/bindings/dart/custom/DartXMLHttpRequestCustom.cpp	View	1	3 chunks	+10 lines, -20 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Anton Muhin

lgtm w/ comments https://chromiumcodereview.appspot.com/10660025/diff/3001/Source/WebCore/bindings/dart/DartNativeUtilities.cpp File Source/WebCore/bindings/dart/DartNativeUtilities.cpp (right): https://chromiumcodereview.appspot.com/10660025/diff/3001/Source/WebCore/bindings/dart/DartNativeUtilities.cpp#newcode83 Source/WebCore/bindings/dart/DartNativeUtilities.cpp:83: printf("[print]: %s\n", String(message).utf8().data()); do you still ...

8 years, 6 months ago (2012-06-26 16:52:28 UTC) #2

podivilov

8 years, 6 months ago (2012-06-26 18:07:38 UTC) #3

https://chromiumcodereview.appspot.com/10660025/diff/3001/Source/WebCore/bind...
File Source/WebCore/bindings/dart/DartNativeUtilities.cpp (right):

https://chromiumcodereview.appspot.com/10660025/diff/3001/Source/WebCore/bind...
Source/WebCore/bindings/dart/DartNativeUtilities.cpp:83: printf("[print]: %s\n",
String(message).utf8().data());
On 2012/06/26 16:52:28, antonmuhin wrote:
> do you still need this conversion?

Sure, DartStringAdapter has no utf8 method.

https://chromiumcodereview.appspot.com/10660025/diff/3001/Source/WebCore/bind...
File Source/WebCore/bindings/dart/DartUtilities.h (right):

https://chromiumcodereview.appspot.com/10660025/diff/3001/Source/WebCore/bind...
Source/WebCore/bindings/dart/DartUtilities.h:157: static DartStringAdapter
dartToStringWithNullCheck(Dart_Handle object, Dart_Handle& exception)
On 2012/06/26 16:52:28, antonmuhin wrote:
> wdyt, do we need to distinguish those?  maybe we should just accept nulls?  my
> main concern would be v8 may convert nulls to "null" string :)

Passing nulls to c++ methods is a bit scary... Also we do want to throw
exceptions where real string should be provided.

https://chromiumcodereview.appspot.com/10660025/diff/3001/Source/WebCore/bind...
File Source/WebCore/bindings/dart/gyp/scripts/generate_dart_bindings.py (right):

https://chromiumcodereview.appspot.com/10660025/diff/3001/Source/WebCore/bind...
Source/WebCore/bindings/dart/gyp/scripts/generate_dart_bindings.py:60:
#fremontcutbuilder.build_database(idlFiles, databaseDir, featureDefines)
On 2012/06/26 16:52:28, antonmuhin wrote:
> probably should be reverted before commit

Done.

Expand Messages | Collapse Messages