Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Side by Side Diff: Source/WebCore/bindings/dart/DartDebugServer.cpp

Issue 10660025: Cleanup dart to string conversions. (Closed) Base URL: svn://svn.chromium.org/multivm/trunk/webkit
Patch Set: . Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2012 Google Inc. All rights reserved. 2 * Copyright (C) 2012 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 455 matching lines...) Expand 10 before | Expand all | Expand 10 after
466 ASSERT(!Dart_IsError(libraryIdHandle)); 466 ASSERT(!Dart_IsError(libraryIdHandle));
467 Dart_Handle exception = 0; 467 Dart_Handle exception = 0;
468 int64_t int64LibraryId = DartUtilities::toInteger(libraryIdHandle, excep tion); 468 int64_t int64LibraryId = DartUtilities::toInteger(libraryIdHandle, excep tion);
469 ASSERT(!exception); 469 ASSERT(!exception);
470 intptr_t libraryId = static_cast<intptr_t>(int64LibraryId); 470 intptr_t libraryId = static_cast<intptr_t>(int64LibraryId);
471 ASSERT(libraryId == int64LibraryId); 471 ASSERT(libraryId == int64LibraryId);
472 472
473 Dart_Handle libraryURL = Dart_GetLibraryURL(libraryId); 473 Dart_Handle libraryURL = Dart_GetLibraryURL(libraryId);
474 ASSERT(Dart_IsString(libraryURL)); 474 ASSERT(Dart_IsString(libraryURL));
475 475
476 if (ignoreStandardLibraries && DartUtilities::dartStringToString(library URL).startsWith("dart:")) 476 if (ignoreStandardLibraries && DartUtilities::toString(libraryURL).start sWith("dart:"))
477 continue; 477 continue;
478 478
479 Dart_Handle scripts = Dart_GetScriptURLs(libraryURL); 479 Dart_Handle scripts = Dart_GetScriptURLs(libraryURL);
480 ASSERT(Dart_IsList(scripts)); 480 ASSERT(Dart_IsList(scripts));
481 481
482 intptr_t scriptsLength = 0; 482 intptr_t scriptsLength = 0;
483 result = Dart_ListLength(scripts, &scriptsLength); 483 result = Dart_ListLength(scripts, &scriptsLength);
484 ASSERT(!Dart_IsError(result)); 484 ASSERT(!Dart_IsError(result));
485 for (intptr_t j = 0; j < scriptsLength; ++j) { 485 for (intptr_t j = 0; j < scriptsLength; ++j) {
486 Dart_Handle scriptURL = Dart_ListGetAt(scripts, j); 486 Dart_Handle scriptURL = Dart_ListGetAt(scripts, j);
(...skipping 107 matching lines...) Expand 10 before | Expand all | Expand 10 after
594 nativeCallbacks->Set(v8::String::New("setBreakpoint"), v8::FunctionTemplate: :New(&setBreakpoint)->GetFunction()); 594 nativeCallbacks->Set(v8::String::New("setBreakpoint"), v8::FunctionTemplate: :New(&setBreakpoint)->GetFunction());
595 nativeCallbacks->Set(v8::String::New("removeBreakpoint"), v8::FunctionTempla te::New(&removeBreakpoint)->GetFunction()); 595 nativeCallbacks->Set(v8::String::New("removeBreakpoint"), v8::FunctionTempla te::New(&removeBreakpoint)->GetFunction());
596 nativeCallbacks->Set(v8::String::New("getBreakpointLine"), v8::FunctionTempl ate::New(&getBreakpointLine)->GetFunction()); 596 nativeCallbacks->Set(v8::String::New("getBreakpointLine"), v8::FunctionTempl ate::New(&getBreakpointLine)->GetFunction());
597 nativeCallbacks->Set(v8::String::New("setExceptionPauseInfo"), v8::FunctionT emplate::New(&setExceptionPauseInfo)->GetFunction()); 597 nativeCallbacks->Set(v8::String::New("setExceptionPauseInfo"), v8::FunctionT emplate::New(&setExceptionPauseInfo)->GetFunction());
598 nativeCallbacks->Set(v8::String::New("stepInto"), v8::FunctionTemplate::New( &stepInto)->GetFunction()); 598 nativeCallbacks->Set(v8::String::New("stepInto"), v8::FunctionTemplate::New( &stepInto)->GetFunction());
599 nativeCallbacks->Set(v8::String::New("stepOver"), v8::FunctionTemplate::New( &stepOver)->GetFunction()); 599 nativeCallbacks->Set(v8::String::New("stepOver"), v8::FunctionTemplate::New( &stepOver)->GetFunction());
600 nativeCallbacks->Set(v8::String::New("stepOut"), v8::FunctionTemplate::New(& stepOut)->GetFunction()); 600 nativeCallbacks->Set(v8::String::New("stepOut"), v8::FunctionTemplate::New(& stepOut)->GetFunction());
601 } 601 }
602 602
603 } 603 }
OLDNEW
« no previous file with comments | « Source/WebCore/bindings/dart/DartDOMWrapper.h ('k') | Source/WebCore/bindings/dart/DartEventListener.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698